195817 2019-03-15 13:34:33 -0700 Total not showing in JetStream2 2019-03-15 15:10:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P1 Normal --- 1 jond jond cdumez commit-queue ews-feeder ews-watchlist rniwa saam webkit-bug-importer oldest_to_newest 1517097 0 jond 2019-03-15 13:34:33 -0700 There is a bug in setting the browser elements for changing the status and summary of the test. 1517100 1 364832 jond 2019-03-15 13:41:37 -0700 Created attachment 364832 Patch 1517105 2 364832 rniwa 2019-03-15 13:50:19 -0700 Comment on attachment 364832 Patch Use let instead of var? 1517119 3 364839 jond 2019-03-15 14:07:11 -0700 Created attachment 364839 Patch 1517123 4 364841 jond 2019-03-15 14:13:14 -0700 Created attachment 364841 Patch 1517126 5 364841 ews-feeder 2019-03-15 14:17:22 -0700 Comment on attachment 364841 Patch Rejecting attachment 364841 from review queue. jond@apple.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 1517148 6 364841 commit-queue 2019-03-15 14:45:47 -0700 Comment on attachment 364841 Patch Clearing flags on attachment: 364841 Committed r243013: <https://trac.webkit.org/changeset/243013> 1517149 7 commit-queue 2019-03-15 14:45:49 -0700 All reviewed patches have been landed. Closing bug. 1517171 8 webkit-bug-importer 2019-03-15 15:10:32 -0700 <rdar://problem/48940241> 364832 2019-03-15 13:41:37 -0700 2019-03-15 14:07:10 -0700 Patch bug-195817-20190315134135.patch text/plain 1133 jond U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMDA3CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0pldFN0cmVhbTIvSmV0U3RyZWFtRHJpdmVyLmpzIGIvUGVyZm9ybWFuY2VUZXN0cy9KZXRTdHJl YW0yL0pldFN0cmVhbURyaXZlci5qcwppbmRleCA4NDJlZmY5M2NmOWRjNzY5YTFiODg2MjZiMzRk MGMyMDIwZDk0OTk0Li5lN2JhOWYxMWNmOWFlN2FmNTExODM0YTEwNWQ3NThhYzFjNzNjZDI3IDEw MDY0NAotLS0gYS9QZXJmb3JtYW5jZVRlc3RzL0pldFN0cmVhbTIvSmV0U3RyZWFtRHJpdmVyLmpz CisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvSmV0U3RyZWFtMi9KZXRTdHJlYW1Ecml2ZXIuanMKQEAg LTE1MSw5ICsxNTEsMTEgQEAgY2xhc3MgRHJpdmVyIHsKICAgICB9CiAKICAgICBhc3luYyBzdGFy dCgpIHsKKyAgICAgICAgdmFyIHN0YXR1c0VsZW1lbnQgPSBmYWxzZTsKKyAgICAgICAgdmFyIHN1 bW1hcnlFbGVtZW50ID0gZmFsc2U7CiAgICAgICAgIGlmIChpc0luQnJvd3NlcikgewotICAgICAg ICAgICAgbGV0IHN0YXR1c0VsZW1lbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic3RhdHVz Iik7Ci0gICAgICAgICAgICBsZXQgc3VtbWFyeUVsZW1lbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgicmVzdWx0LXN1bW1hcnkiKTsKKyAgICAgICAgICAgIHN0YXR1c0VsZW1lbnQgPSBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgic3RhdHVzIik7CisgICAgICAgICAgICBzdW1tYXJ5RWxlbWVu dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQtc3VtbWFyeSIpOwogICAgICAgICAg ICAgc3RhdHVzRWxlbWVudC5pbm5lckhUTUwgPSBgPGxhYmVsPlJ1bm5pbmcuLi48L2xhYmVsPmA7 CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBjb25zb2xlLmxvZygiU3RhcnRpbmcgSmV0 U3RyZWFtMiIpOwpAQCAtMTc3LDYgKzE3OSw3IEBAIGNsYXNzIERyaXZlciB7CiAKICAgICAgICAg ICAgIGJlbmNobWFyay51cGRhdGVVSUFmdGVyUnVuKCk7CiAgICAgICAgIH0KKwogICAgICAgICBs ZXQgdG90YWxUaW1lID0gRGF0ZS5ub3coKSAtIHN0YXJ0OwogICAgICAgICBpZiAobWVhc3VyZVRv dGFsVGltZUFzU3VidGVzdCkgewogICAgICAgICAgICAgaWYgKGlzSW5Ccm93c2VyKQo= 364839 2019-03-15 14:07:11 -0700 2019-03-15 14:13:12 -0700 Patch bug-195817-20190315140710.patch text/plain 1133 jond U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMDA3CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0pldFN0cmVhbTIvSmV0U3RyZWFtRHJpdmVyLmpzIGIvUGVyZm9ybWFuY2VUZXN0cy9KZXRTdHJl YW0yL0pldFN0cmVhbURyaXZlci5qcwppbmRleCA4NDJlZmY5M2NmOWRjNzY5YTFiODg2MjZiMzRk MGMyMDIwZDk0OTk0Li42OTEwMGMyODhhOGQ4MWY0MmJkZDMwNjdjNWFlNThiM2E3NTY2NDNkIDEw MDY0NAotLS0gYS9QZXJmb3JtYW5jZVRlc3RzL0pldFN0cmVhbTIvSmV0U3RyZWFtRHJpdmVyLmpz CisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvSmV0U3RyZWFtMi9KZXRTdHJlYW1Ecml2ZXIuanMKQEAg LTE1MSw5ICsxNTEsMTEgQEAgY2xhc3MgRHJpdmVyIHsKICAgICB9CiAKICAgICBhc3luYyBzdGFy dCgpIHsKKyAgICAgICAgbGV0IHN0YXR1c0VsZW1lbnQgPSBmYWxzZTsKKyAgICAgICAgbGV0IHN1 bW1hcnlFbGVtZW50ID0gZmFsc2U7CiAgICAgICAgIGlmIChpc0luQnJvd3NlcikgewotICAgICAg ICAgICAgbGV0IHN0YXR1c0VsZW1lbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic3RhdHVz Iik7Ci0gICAgICAgICAgICBsZXQgc3VtbWFyeUVsZW1lbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgicmVzdWx0LXN1bW1hcnkiKTsKKyAgICAgICAgICAgIHN0YXR1c0VsZW1lbnQgPSBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgic3RhdHVzIik7CisgICAgICAgICAgICBzdW1tYXJ5RWxlbWVu dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQtc3VtbWFyeSIpOwogICAgICAgICAg ICAgc3RhdHVzRWxlbWVudC5pbm5lckhUTUwgPSBgPGxhYmVsPlJ1bm5pbmcuLi48L2xhYmVsPmA7 CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBjb25zb2xlLmxvZygiU3RhcnRpbmcgSmV0 U3RyZWFtMiIpOwpAQCAtMTc3LDYgKzE3OSw3IEBAIGNsYXNzIERyaXZlciB7CiAKICAgICAgICAg ICAgIGJlbmNobWFyay51cGRhdGVVSUFmdGVyUnVuKCk7CiAgICAgICAgIH0KKwogICAgICAgICBs ZXQgdG90YWxUaW1lID0gRGF0ZS5ub3coKSAtIHN0YXJ0OwogICAgICAgICBpZiAobWVhc3VyZVRv dGFsVGltZUFzU3VidGVzdCkgewogICAgICAgICAgICAgaWYgKGlzSW5Ccm93c2VyKQo= 364841 2019-03-15 14:13:14 -0700 2019-03-15 14:45:47 -0700 Patch bug-195817-20190315141313.patch text/plain 1778 jond U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMDA3CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDJmMzI0ZGYzYTE0 ZDZiMDg0OTVmMDliMmJiNjRjYWI2NTFhM2RlOGQuLjVjYTFkZGFjMjA4YjI2MGRkOGY3OGI2Nzgy Njc2NmM2MzBiZGVjYjcgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDMt MTUgIEpvbiBEYXZpcyAgPGpvbmRAYXBwbGUuY29tPgorCisgICAgICAgIEZpeGVkIGEgYnVnIHBy ZXZlbnRpbmcgdGhlIG92ZXJhbGwgc29yZSB0byBiZSBkaXNwbGF5ZWQgb24gSmV0U3RyZWFtMgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1ODE3CisK KyAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgU2FhbSBCYXJhdGkuCisKKyAgICAgICAgKiBKZXRT dHJlYW0yL0pldFN0cmVhbURyaXZlci5qczoKKyAgICAgICAgKERyaXZlci5wcm90b3R5cGUuYXN5 bmMuc3RhcnQpOgorCiAyMDE5LTAzLTE0ICBKb24gRGF2aXMgIDxqb25kQGFwcGxlLmNvbT4KIAog ICAgICAgICBJbXBsZW1lbnQgYSBuZXcgZGVzaWduIGZvciBKZXRTdHJlYW0yCmRpZmYgLS1naXQg YS9QZXJmb3JtYW5jZVRlc3RzL0pldFN0cmVhbTIvSmV0U3RyZWFtRHJpdmVyLmpzIGIvUGVyZm9y bWFuY2VUZXN0cy9KZXRTdHJlYW0yL0pldFN0cmVhbURyaXZlci5qcwppbmRleCA4NDJlZmY5M2Nm OWRjNzY5YTFiODg2MjZiMzRkMGMyMDIwZDk0OTk0Li42OTEwMGMyODhhOGQ4MWY0MmJkZDMwNjdj NWFlNThiM2E3NTY2NDNkIDEwMDY0NAotLS0gYS9QZXJmb3JtYW5jZVRlc3RzL0pldFN0cmVhbTIv SmV0U3RyZWFtRHJpdmVyLmpzCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvSmV0U3RyZWFtMi9KZXRT dHJlYW1Ecml2ZXIuanMKQEAgLTE1MSw5ICsxNTEsMTEgQEAgY2xhc3MgRHJpdmVyIHsKICAgICB9 CiAKICAgICBhc3luYyBzdGFydCgpIHsKKyAgICAgICAgbGV0IHN0YXR1c0VsZW1lbnQgPSBmYWxz ZTsKKyAgICAgICAgbGV0IHN1bW1hcnlFbGVtZW50ID0gZmFsc2U7CiAgICAgICAgIGlmIChpc0lu QnJvd3NlcikgewotICAgICAgICAgICAgbGV0IHN0YXR1c0VsZW1lbnQgPSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgic3RhdHVzIik7Ci0gICAgICAgICAgICBsZXQgc3VtbWFyeUVsZW1lbnQgPSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0LXN1bW1hcnkiKTsKKyAgICAgICAgICAgIHN0 YXR1c0VsZW1lbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic3RhdHVzIik7CisgICAgICAg ICAgICBzdW1tYXJ5RWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQtc3Vt bWFyeSIpOwogICAgICAgICAgICAgc3RhdHVzRWxlbWVudC5pbm5lckhUTUwgPSBgPGxhYmVsPlJ1 bm5pbmcuLi48L2xhYmVsPmA7CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBjb25zb2xl LmxvZygiU3RhcnRpbmcgSmV0U3RyZWFtMiIpOwpAQCAtMTc3LDYgKzE3OSw3IEBAIGNsYXNzIERy aXZlciB7CiAKICAgICAgICAgICAgIGJlbmNobWFyay51cGRhdGVVSUFmdGVyUnVuKCk7CiAgICAg ICAgIH0KKwogICAgICAgICBsZXQgdG90YWxUaW1lID0gRGF0ZS5ub3coKSAtIHN0YXJ0OwogICAg ICAgICBpZiAobWVhc3VyZVRvdGFsVGltZUFzU3VidGVzdCkgewogICAgICAgICAgICAgaWYgKGlz SW5Ccm93c2VyKQo=