195798 2019-03-15 03:29:01 -0700 [WTF] Remove redundant std::move in StringConcatenate 2019-03-18 16:52:16 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 xan.lopez webkit-unassigned benjamin cdumez cmarcelo commit-queue darin dbates ews-watchlist webkit-bug-importer xan.lopez oldest_to_newest 1516946 0 xan.lopez 2019-03-15 03:29:01 -0700 GCC (since 9.x when -Wredundant-move is enabled by default) warns of two redundant move operations in StringConcatenate. AFAICT the issue is that C++ will already do an implicit move when a local value is returned and copy (or move) elision is not applicable, as in here. 1516947 1 364786 xan.lopez 2019-03-15 03:34:23 -0700 Created attachment 364786 Remove redundant WTFMove calls 1518010 2 364786 commit-queue 2019-03-18 16:51:48 -0700 Comment on attachment 364786 Remove redundant WTFMove calls Clearing flags on attachment: 364786 Committed r243115: <https://trac.webkit.org/changeset/243115> 1518011 3 commit-queue 2019-03-18 16:51:50 -0700 All reviewed patches have been landed. Closing bug. 1518012 4 webkit-bug-importer 2019-03-18 16:52:16 -0700 <rdar://problem/49000128> 364786 2019-03-15 03:34:23 -0700 2019-03-18 16:51:48 -0700 Remove redundant WTFMove calls stringconcatenate-redundant-move.diff text/plain 2300 xan.lopez RnJvbSA1YmE0MzdlMTI5NjMwMzVhMDZhMmRkMWYwNTRkZTkxMjJlNTExODRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/WGFuPTIwTD1DMz1CM3Blej89IDx4YW5AaWdh bGlhLmNvbT4KRGF0ZTogRnJpLCAxNSBNYXIgMjAxOSAxMTozMTowMiArMDEwMApTdWJqZWN0OiBb UEFUQ0hdIFtXVEZdIFJlbW92ZSByZWR1bmRhbnQgc3RkOjptb3ZlIGluIFN0cmluZ0NvbmNhdGVu YXRlCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1Nzk4CgpSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KClJlbW92ZSByZWR1bmRhbnQgY2FsbHMgdG8gV1RGTW92 ZSBpbiByZXR1cm4gdmFsdWVzIGZvciB0aGlzCm1ldGhvZC4gQysrIHdpbGwgYWxyZWFkeSBkbyBh biBpbXBsaWNpdCBtb3ZlIGhlcmUgc2luY2Ugd2UgYXJlCnJldHVybmluZyBhIGxvY2FsIHZhbHVl IHdoZXJlIGNvcHkvbW92ZSBlbGlzaW9uIGlzIG5vdCBhcHBsaWNhYmxlLgoKKiB3dGYvdGV4dC9T dHJpbmdDb25jYXRlbmF0ZS5oOgooV1RGOjp0cnlNYWtlU3RyaW5nRnJvbUFkYXB0ZXJzKToKLS0t CiBTb3VyY2UvV1RGL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgfCAxNCArKysrKysrKysr KysrKwogU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdDb25jYXRlbmF0ZS5oIHwgIDQgKystLQog MiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXgg OTliZjc1NzYwZmYuLjMwZmUyZDJhNjRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTAzLTE1 ICBYYW4gTG9wZXogIDx4YW5AaWdhbGlhLmNvbT4KKworICAgICAgICBbV1RGXSBSZW1vdmUgcmVk dW5kYW50IHN0ZDo6bW92ZSBpbiBTdHJpbmdDb25jYXRlbmF0ZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1Nzk4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHJlZHVuZGFudCBjYWxscyB0byBX VEZNb3ZlIGluIHJldHVybiB2YWx1ZXMgZm9yIHRoaXMKKyAgICAgICAgbWV0aG9kLiBDKysgd2ls bCBhbHJlYWR5IGRvIGFuIGltcGxpY2l0IG1vdmUgaGVyZSBzaW5jZSB3ZSBhcmUKKyAgICAgICAg cmV0dXJuaW5nIGEgbG9jYWwgdmFsdWUgd2hlcmUgY29weS9tb3ZlIGVsaXNpb24gaXMgbm90IGFw cGxpY2FibGUuCisKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdDb25jYXRlbmF0ZS5oOgorICAg ICAgICAoV1RGOjp0cnlNYWtlU3RyaW5nRnJvbUFkYXB0ZXJzKToKKwogMjAxOS0wMy0xMyAgU2Ft IFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCB1dGlsaXR5IGZ1bmN0aW9u IHRvIGFsbG93IGVhc3kgcmV2ZXJzZSByYW5nZS1iYXNlZCBpdGVyYXRpb24gb2YgYSBjb250YWlu ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQ29uY2F0ZW5hdGUuaCBi L1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQ29uY2F0ZW5hdGUuaAppbmRleCAxYzUwMWVkNTA1 Yy4uYzVkMDIwMTgxODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQ29u Y2F0ZW5hdGUuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0NvbmNhdGVuYXRlLmgK QEAgLTI3OCw3ICsyNzgsNyBAQCBTdHJpbmcgdHJ5TWFrZVN0cmluZ0Zyb21BZGFwdGVycyhTdHJp bmdUeXBlQWRhcHRlciBhZGFwdGVyLCBTdHJpbmdUeXBlQWRhcHRlcnMgLgogCiAgICAgICAgIG1h a2VTdHJpbmdBY2N1bXVsYXRvcihidWZmZXIsIGFkYXB0ZXIsIGFkYXB0ZXJzLi4uKTsKIAotICAg ICAgICByZXR1cm4gV1RGTW92ZShyZXN1bHRJbXBsKTsKKyAgICAgICAgcmV0dXJuIHJlc3VsdElt cGw7CiAgICAgfQogCiAgICAgVUNoYXIqIGJ1ZmZlcjsKQEAgLTI4OCw3ICsyODgsNyBAQCBTdHJp bmcgdHJ5TWFrZVN0cmluZ0Zyb21BZGFwdGVycyhTdHJpbmdUeXBlQWRhcHRlciBhZGFwdGVyLCBT dHJpbmdUeXBlQWRhcHRlcnMgLgogCiAgICAgbWFrZVN0cmluZ0FjY3VtdWxhdG9yKGJ1ZmZlciwg YWRhcHRlciwgYWRhcHRlcnMuLi4pOwogCi0gICAgcmV0dXJuIFdURk1vdmUocmVzdWx0SW1wbCk7 CisgICAgcmV0dXJuIHJlc3VsdEltcGw7CiB9CiAKIHRlbXBsYXRlPHR5cGVuYW1lLi4uIFN0cmlu Z1R5cGVzPgotLSAKMi4yMC4xCgo=