195779 2019-03-14 16:13:01 -0700 REGRESSION: Layout Test http/tests/security/cross-origin-indexeddb.html is crashing 2019-03-21 11:52:13 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196024 InRadar P2 Normal --- 1 tsavell youennf achristensen alecflett beidson cdumez commit-queue ews-watchlist jlewis3 jsbell lforschler ryanhaddad sihui_liu webkit-bug-importer youennf oldest_to_newest 1516731 0 tsavell 2019-03-14 16:13:01 -0700 The following layout test is crashing on iOS and Mac Debug WK2 http/tests/security/cross-origin-indexeddb.html Probable cause: This test recently began crashing around r242911. It is fairly consistent failure and crashes around 90% of the time on the bots. I am unable to reproduce locally right now. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fcross-origin-indexeddb.html Crash: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r242946%20(1942)/http/tests/security/cross-origin-indexeddb-crash-log.txt VM Regions Near 0xbbadbeef: --> __TEXT 0000000104c3c000-0000000104c3d000 [ 4K] r-x/rwx SM=COW /Volumes/VOLUME/*/*.Development Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x000000011dc8ff40 WTFCrash + 16 (Assertions.cpp:305) 1 com.apple.WebCore 0x000000010b8e154b WTFCrashWithInfo(int, char const*, char const*, int) + 27 2 com.apple.WebCore 0x000000010d178aaa WTF::CrossThreadQueue<WTF::CrossThreadTask>::append(WTF::CrossThreadTask&&) + 138 (CrossThreadQueue.h:64) 1516760 1 364722 youennf 2019-03-14 17:07:22 -0700 Created attachment 364722 Patch 1516761 2 youennf 2019-03-14 17:12:24 -0700 Tried to reproduce locally as well but failed. The current model is that we only potentially delay tasks that might increase quota. Read operations or delete operations can carry on without waiting for the space request. Patch should fix the crash. I wonder whether the IDB implementation would behave better with waiting for the space request to complete to carry on with other tasks, be they read, write or delete. 1516763 3 364724 youennf 2019-03-14 17:13:27 -0700 Created attachment 364724 Patch 1518394 4 364724 cdumez 2019-03-19 11:28:20 -0700 Comment on attachment 364724 Patch r=me 1518424 5 364724 commit-queue 2019-03-19 11:55:03 -0700 Comment on attachment 364724 Patch Clearing flags on attachment: 364724 Committed r243157: <https://trac.webkit.org/changeset/243157> 1518425 6 commit-queue 2019-03-19 11:55:05 -0700 All reviewed patches have been landed. Closing bug. 1518427 7 webkit-bug-importer 2019-03-19 11:56:18 -0700 <rdar://problem/49028748> 364722 2019-03-14 17:07:22 -0700 2019-03-14 17:13:26 -0700 Patch bug-195779-20190314170715.patch text/plain 2030 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyOTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjAzMmJkYzYxMjRhYjBm ZGRkZmVmNDZjZmNiZjNiMTE4OTQ4OGRkOC4uMzc0OWJjOTdjMjAyMmQwMzVmOTA3M2ZkZjhmOWY4 MmQ1NjMxYTQzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAzLTE0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBMYXlv dXQgVGVzdCBodHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLW9yaWdpbi1pbmRleGVkZGIuaHRtbCBp cyBjcmFzaGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk1Nzc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2hlbiByZXF1ZXN0aW5nIHNwYWNlLCB3ZSBtaWdodCBkZWxheSBleGVjdXRpb24gb2YgdGhl IHRhc2suCisgICAgICAgIEluIHN1Y2ggYSBjYXNlLCBhIHRhc2sgdG8gY2xvc2UgdGhlIGRhdGFi YXNlIG1pZ2h0IGJlIGRvbmUgYmVmb3JlIHRoZSB0YXNrIGNvbnRpbnVlcy4KKyAgICAgICAgQ2hl Y2sgdGhhdCB0aGUgZGF0YWJhc2UgaXMgbm90IGNsb3NpbmcgdG8gY29udGludWUgdGhlIHRhc2su CisgICAgICAgIFRoaXMgc2hvdWxkIGVuc3VyZSB0aGF0IHRoZSBjcm9zcyB0aHJlYWQgcXVldWUg aXMgbm90IGFscmVhZHkga2lsbGVkLgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvc2Vy dmVyL1VuaXF1ZUlEQkRhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQlNlcnZlcjo6 VW5pcXVlSURCRGF0YWJhc2U6OnJlcXVlc3RTcGFjZSk6CisKIDIwMTktMDMtMTQgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEluY2x1ZGUgV0FMIGFuZCBTSE0g ZmlsZSBzaXplIGluIElEQiBkYXRhYmFzZSBzaXplIGNvbXB1dGF0aW9uCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvVW5pcXVlSURCRGF0YWJhc2Uu Y3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1VuaXF1ZUlEQkRh dGFiYXNlLmNwcAppbmRleCBkNWI5NmIwMzg3M2QyNGZjODk0MGMyOTQzZDY2NGZiY2UyYTcwYTFi Li5hY2Y2YWE5MjE2ZmYwYzM1MzExMTkwZjExMTA2ZmVjZTQ0YzVjZjA2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvVW5pcXVlSURCRGF0YWJhc2Uu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9VbmlxdWVJ REJEYXRhYmFzZS5jcHAKQEAgLTE4Miw2ICsxODIsMTMgQEAgdm9pZCBVbmlxdWVJREJEYXRhYmFz ZTo6cmVxdWVzdFNwYWNlKHVpbnQ2NF90IHRhc2tTaXplLCBjb25zdCBjaGFyKiB0YXNrTmFtZSwg Q28KICAgICAgICAgICAgIGNhbGxiYWNrKElEQkVycm9yIHsgVW5rbm93bkVycm9yIH0pOwogICAg ICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CisKKyAgICAgICAgaWYgKG1fb3duaW5nUG9pbnRl ckZvckNsb3NlKSB7CisgICAgICAgICAgICAvLyBXZSBhcmUgY2xvc2luZyB0aGUgZGF0YWJhc2Us IHRoZXJlIGlzIG5vIHBvaW50IGluIHRyeWluZyB0byBtb2RpZnkgdGhlIGRhdGFiYXNlIGF0IHRo YXQgcG9pbnQuCisgICAgICAgICAgICBjYWxsYmFjayhJREJFcnJvciB7IFVua25vd25FcnJvciB9 KTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorCiAgICAgICAgIHN3aXRjaCAoZGVj aXNpb24pIHsKICAgICAgICAgY2FzZSBTdG9yYWdlUXVvdGFNYW5hZ2VyOjpEZWNpc2lvbjo6RGVu eToKICAgICAgICAgICAgIGNhbGxiYWNrKElEQkVycm9yIHsgUXVvdGFFeGNlZWRlZEVycm9yLCBx dW90YUVycm9yTWVzc2FnZU5hbWUodGFza05hbWUpIH0pOwo= 364724 2019-03-14 17:13:27 -0700 2019-03-19 11:55:03 -0700 Patch bug-195779-20190314171320.patch text/plain 2503 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyOTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjAzMmJkYzYxMjRhYjBm ZGRkZmVmNDZjZmNiZjNiMTE4OTQ4OGRkOC4uMzc0OWJjOTdjMjAyMmQwMzVmOTA3M2ZkZjhmOWY4 MmQ1NjMxYTQzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAzLTE0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBMYXlv dXQgVGVzdCBodHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLW9yaWdpbi1pbmRleGVkZGIuaHRtbCBp cyBjcmFzaGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk1Nzc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2hlbiByZXF1ZXN0aW5nIHNwYWNlLCB3ZSBtaWdodCBkZWxheSBleGVjdXRpb24gb2YgdGhl IHRhc2suCisgICAgICAgIEluIHN1Y2ggYSBjYXNlLCBhIHRhc2sgdG8gY2xvc2UgdGhlIGRhdGFi YXNlIG1pZ2h0IGJlIGRvbmUgYmVmb3JlIHRoZSB0YXNrIGNvbnRpbnVlcy4KKyAgICAgICAgQ2hl Y2sgdGhhdCB0aGUgZGF0YWJhc2UgaXMgbm90IGNsb3NpbmcgdG8gY29udGludWUgdGhlIHRhc2su CisgICAgICAgIFRoaXMgc2hvdWxkIGVuc3VyZSB0aGF0IHRoZSBjcm9zcyB0aHJlYWQgcXVldWUg aXMgbm90IGFscmVhZHkga2lsbGVkLgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvc2Vy dmVyL1VuaXF1ZUlEQkRhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQlNlcnZlcjo6 VW5pcXVlSURCRGF0YWJhc2U6OnJlcXVlc3RTcGFjZSk6CisKIDIwMTktMDMtMTQgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEluY2x1ZGUgV0FMIGFuZCBTSE0g ZmlsZSBzaXplIGluIElEQiBkYXRhYmFzZSBzaXplIGNvbXB1dGF0aW9uCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvVW5pcXVlSURCRGF0YWJhc2Uu Y3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1VuaXF1ZUlEQkRh dGFiYXNlLmNwcAppbmRleCBkNWI5NmIwMzg3M2QyNGZjODk0MGMyOTQzZDY2NGZiY2UyYTcwYTFi Li44ZjBmNzk2NDQ3NGIwYWExYzFjMzQwNmY5NDVmMmRlM2RhNDlkZmUzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvVW5pcXVlSURCRGF0YWJhc2Uu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9VbmlxdWVJ REJEYXRhYmFzZS5jcHAKQEAgLTE3NywxMSArMTc3LDE4IEBAIHN0YXRpYyBpbmxpbmUgU3RyaW5n IHF1b3RhRXJyb3JNZXNzYWdlTmFtZShjb25zdCBjaGFyKiB0YXNrTmFtZSkKIAogdm9pZCBVbmlx dWVJREJEYXRhYmFzZTo6cmVxdWVzdFNwYWNlKHVpbnQ2NF90IHRhc2tTaXplLCBjb25zdCBjaGFy KiB0YXNrTmFtZSwgQ29tcGxldGlvbkhhbmRsZXI8dm9pZChPcHRpb25hbDxJREJFcnJvcj4mJik+ JiYgY2FsbGJhY2spCiB7Ci0gICAgbV9zZXJ2ZXItPnJlcXVlc3RTcGFjZShtX2lkZW50aWZpZXIu b3JpZ2luKCksIHRhc2tTaXplLCBbd2Vha1RoaXMgPSBtYWtlV2Vha1B0cih0aGlzKSwgdGFza05h bWUsIGNhbGxiYWNrID0gV1RGTW92ZShjYWxsYmFjayldKGF1dG8gZGVjaXNpb24pIG11dGFibGUg eworICAgIG1fc2VydmVyLT5yZXF1ZXN0U3BhY2UobV9pZGVudGlmaWVyLm9yaWdpbigpLCB0YXNr U2l6ZSwgW3dlYWtUaGlzID0gbWFrZVdlYWtQdHIodGhpcyksIHRoaXMsIHRhc2tOYW1lLCBjYWxs YmFjayA9IFdURk1vdmUoY2FsbGJhY2spXShhdXRvIGRlY2lzaW9uKSBtdXRhYmxlIHsKICAgICAg ICAgaWYgKCF3ZWFrVGhpcykgewogICAgICAgICAgICAgY2FsbGJhY2soSURCRXJyb3IgeyBVbmtu b3duRXJyb3IgfSk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KKworICAgICAgICBp ZiAobV9vd25pbmdQb2ludGVyRm9yQ2xvc2UpIHsKKyAgICAgICAgICAgIC8vIFdlIGFyZSBjbG9z aW5nIHRoZSBkYXRhYmFzZSwgdGhlcmUgaXMgbm8gcG9pbnQgaW4gdHJ5aW5nIHRvIG1vZGlmeSB0 aGUgZGF0YWJhc2UgYXQgdGhhdCBwb2ludC4KKyAgICAgICAgICAgIGNhbGxiYWNrKElEQkVycm9y IHsgVW5rbm93bkVycm9yIH0pOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKICAg ICAgICAgc3dpdGNoIChkZWNpc2lvbikgewogICAgICAgICBjYXNlIFN0b3JhZ2VRdW90YU1hbmFn ZXI6OkRlY2lzaW9uOjpEZW55OgogICAgICAgICAgICAgY2FsbGJhY2soSURCRXJyb3IgeyBRdW90 YUV4Y2VlZGVkRXJyb3IsIHF1b3RhRXJyb3JNZXNzYWdlTmFtZSh0YXNrTmFtZSkgfSk7Cg==