195774 2019-03-14 15:44:50 -0700 Web Inspector: changes to CSS resources only take affect once editing stops 2019-03-20 09:28:23 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes nvasilyev timothy webkit-bug-importer oldest_to_newest 1516712 0 hi 2019-03-14 15:44:50 -0700 # STEPS TO REPRODUCE: 1. inspect any page 2. find a CSS resource in the Resources/Sources tab 3. find a CSS color value 4. show the color popover 5. drag your mouse around the color wheel that appears => corresponding usage of the color doesn't change in the page 5. stop moving your mouse => color changes after almost 1s 1516713 1 webkit-bug-importer 2019-03-14 15:45:11 -0700 <rdar://problem/48905413> 1516714 2 364709 hi 2019-03-14 15:52:33 -0700 Created attachment 364709 Patch 1517162 3 364709 nvasilyev 2019-03-15 15:00:52 -0700 Comment on attachment 364709 Patch Nice find! Using throttling instead of debouncing makes sense here. You changed the timeout from 500 to 100ms. Have you tested this on large stylesheets? What happens when you edit colors on https://stackoverflow.com ? 1517189 4 hi 2019-03-15 15:23:40 -0700 (In reply to Nikita Vasilyev from comment #3) > You changed the timeout from 500 to 100ms. Have you tested this on large stylesheets? What happens when you edit colors on https://stackoverflow.com ? I tried editing colors on <https://webkit.org> and <https://apple.com> and both seemed fine. 1518930 5 364709 commit-queue 2019-03-20 09:28:22 -0700 Comment on attachment 364709 Patch Clearing flags on attachment: 364709 Committed r243208: <https://trac.webkit.org/changeset/243208> 1518931 6 commit-queue 2019-03-20 09:28:23 -0700 All reviewed patches have been landed. Closing bug. 364709 2019-03-14 15:52:33 -0700 2019-03-20 09:28:22 -0700 Patch bug-195774-20190314155233.patch text/plain 3498 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDJjMTk3ZjZlZDc3MDY1Y2RhM2U4ODhjOTlhNmE0 NTg5YmRjMDlhY2QuLjAwODIxMjc3MjQxMTIzZTA5MDUwZGNjYTI0MGYyZjBkN2Y3YTBmNzggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAzLTE0ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBj aGFuZ2VzIHRvIENTUyByZXNvdXJjZXMgb25seSB0YWtlIGFmZmVjdCBvbmNlIGVkaXRpbmcgc3Rv cHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTc3 NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDg5MDU0MTM+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJz L0NTU01hbmFnZXIuanM6CisgICAgICAgIChXSS5DU1NNYW5hZ2VyLnByb3RvdHlwZS5fcmVzb3Vy Y2VDb250ZW50RGlkQ2hhbmdlLmFwcGx5U3R5bGVTaGVldENoYW5nZXMuc3R5bGVTaGVldEZvdW5k KToKKyAgICAgICAgKFdJLkNTU01hbmFnZXIucHJvdG90eXBlLl9yZXNvdXJjZUNvbnRlbnREaWRD aGFuZ2UpOgorICAgICAgICAoV0kuQ1NTTWFuYWdlci5wcm90b3R5cGUuX3VwZGF0ZVJlc291cmNl Q29udGVudC5mZXRjaGVkU3R5bGVTaGVldENvbnRlbnQpOgorICAgICAgICAoV0kuQ1NTTWFuYWdl ci5wcm90b3R5cGUuX3VwZGF0ZVJlc291cmNlQ29udGVudCk6CisgICAgICAgIFVzZSBhIGBUaHJv dHRsZXJgIGluc3RlYWQgb2YgYSA1MDBtcyBkZWJvdW5jZS4KKwogMjAxOS0wMy0xNCAgRGV2aW4g Um91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUkVH UkVTU0lPTjogQ2FudmFzOiB0aGUgZmlyc3QgcHJvY2Vzc2VkIGFjdGlvbiBzaG91bGQgYmUgc2Vs ZWN0ZWQgYXMgc29vbiBhcyBpdCdzIGF2YWlsYWJsZSBpZiBubyBwcmV2aW91cyBzZWxlY3RlZCBh Y3Rpb24gZXhpc3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Db250cm9sbGVycy9DU1NNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ1NTTWFuYWdlci5qcwppbmRleCBiOTMyM2E0ZWQ4Nzk2 Y2U3NDczNzY4ODI1MDMyMjk2NDM4NjJlNTFlLi42NTk4YmUwZmU4NTQ5MDczYjY4NzE3ZWYzOTkz ZmNkMDRmOGIyM2NkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Db250cm9sbGVycy9DU1NNYW5hZ2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NTU01hbmFnZXIuanMKQEAgLTY0Niw3ICs2NDYs NyBAQCBXSS5DU1NNYW5hZ2VyID0gY2xhc3MgQ1NTTWFuYWdlciBleHRlbmRzIFdJLk9iamVjdAog ICAgICAgICB7CiAgICAgICAgICAgICBmdW5jdGlvbiBzdHlsZVNoZWV0Rm91bmQoc3R5bGVTaGVl dCkKICAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICByZXNvdXJjZS5fX3BlbmRpbmdDaGFu Z2VUaW1lb3V0ID0gdW5kZWZpbmVkOworICAgICAgICAgICAgICAgIHJlc291cmNlLl9fcGVuZGlu Z0NoYW5nZVRpbWVvdXQuY2FuY2VsKCk7CiAKICAgICAgICAgICAgICAgICBjb25zb2xlLmFzc2Vy dChzdHlsZVNoZWV0KTsKICAgICAgICAgICAgICAgICBpZiAoIXN0eWxlU2hlZXQpCkBAIC02NjIs OSArNjYyLDkgQEAgV0kuQ1NTTWFuYWdlciA9IGNsYXNzIENTU01hbmFnZXIgZXh0ZW5kcyBXSS5P YmplY3QKICAgICAgICAgICAgIHRoaXMuX2xvb2t1cFN0eWxlU2hlZXRGb3JSZXNvdXJjZShyZXNv dXJjZSwgc3R5bGVTaGVldEZvdW5kLmJpbmQodGhpcykpOwogICAgICAgICB9CiAKLSAgICAgICAg aWYgKHJlc291cmNlLl9fcGVuZGluZ0NoYW5nZVRpbWVvdXQpCi0gICAgICAgICAgICBjbGVhclRp bWVvdXQocmVzb3VyY2UuX19wZW5kaW5nQ2hhbmdlVGltZW91dCk7Ci0gICAgICAgIHJlc291cmNl Ll9fcGVuZGluZ0NoYW5nZVRpbWVvdXQgPSBzZXRUaW1lb3V0KGFwcGx5U3R5bGVTaGVldENoYW5n ZXMuYmluZCh0aGlzKSwgNTAwKTsKKyAgICAgICAgaWYgKCFyZXNvdXJjZS5fX3BlbmRpbmdDaGFu Z2VUaW1lb3V0KQorICAgICAgICAgICAgcmVzb3VyY2UuX19wZW5kaW5nQ2hhbmdlVGltZW91dCA9 IG5ldyBUaHJvdHRsZXIoYXBwbHlTdHlsZVNoZWV0Q2hhbmdlcy5iaW5kKHRoaXMpLCAxMDApOwor ICAgICAgICByZXNvdXJjZS5fX3BlbmRpbmdDaGFuZ2VUaW1lb3V0LmZpcmUoKTsKICAgICB9CiAK ICAgICBfdXBkYXRlUmVzb3VyY2VDb250ZW50KHN0eWxlU2hlZXQpCkBAIC02NzMsOCArNjczLDkg QEAgV0kuQ1NTTWFuYWdlciA9IGNsYXNzIENTU01hbmFnZXIgZXh0ZW5kcyBXSS5PYmplY3QKIAog ICAgICAgICBmdW5jdGlvbiBmZXRjaGVkU3R5bGVTaGVldENvbnRlbnQocGFyYW1ldGVycykKICAg ICAgICAgeworICAgICAgICAgICAgc3R5bGVTaGVldC5fX3BlbmRpbmdDaGFuZ2VUaW1lb3V0LmNh bmNlbCgpOworCiAgICAgICAgICAgICBsZXQgcmVwcmVzZW50ZWRPYmplY3QgPSBwYXJhbWV0ZXJz LnNvdXJjZUNvZGU7Ci0gICAgICAgICAgICByZXByZXNlbnRlZE9iamVjdC5fX3BlbmRpbmdDaGFu Z2VUaW1lb3V0ID0gdW5kZWZpbmVkOwogCiAgICAgICAgICAgICBjb25zb2xlLmFzc2VydChyZXBy ZXNlbnRlZE9iamVjdC51cmwpOwogICAgICAgICAgICAgaWYgKCFyZXByZXNlbnRlZE9iamVjdC51 cmwpCkBAIC03MjEsOSArNzIyLDkgQEAgV0kuQ1NTTWFuYWdlciA9IGNsYXNzIENTU01hbmFnZXIg ZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgICAgICAgICB0aGlzLl9mZXRjaEluZm9Gb3JBbGxT dHlsZVNoZWV0cyhzdHlsZVNoZWV0UmVhZHkuYmluZCh0aGlzKSk7CiAgICAgICAgIH0KIAotICAg ICAgICBpZiAoc3R5bGVTaGVldC5fX3BlbmRpbmdDaGFuZ2VUaW1lb3V0KQotICAgICAgICAgICAg Y2xlYXJUaW1lb3V0KHN0eWxlU2hlZXQuX19wZW5kaW5nQ2hhbmdlVGltZW91dCk7Ci0gICAgICAg IHN0eWxlU2hlZXQuX19wZW5kaW5nQ2hhbmdlVGltZW91dCA9IHNldFRpbWVvdXQoYXBwbHlTdHls ZVNoZWV0Q2hhbmdlcy5iaW5kKHRoaXMpLCA1MDApOworICAgICAgICBpZiAoIXN0eWxlU2hlZXQu X19wZW5kaW5nQ2hhbmdlVGltZW91dCkKKyAgICAgICAgICAgIHN0eWxlU2hlZXQuX19wZW5kaW5n Q2hhbmdlVGltZW91dCA9IG5ldyBUaHJvdHRsZXIoYXBwbHlTdHlsZVNoZWV0Q2hhbmdlcy5iaW5k KHRoaXMpLCAxMDApOworICAgICAgICBzdHlsZVNoZWV0Ll9fcGVuZGluZ0NoYW5nZVRpbWVvdXQu ZmlyZSgpOwogICAgIH0KIH07CiAK