19577 2008-06-16 06:34:24 -0700 JSCore does not compile in C++ environments where C99 headers are not present 2008-06-16 14:23:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hausmann webkit-unassigned oldest_to_newest 83451 0 hausmann 2008-06-16 06:34:24 -0700 Some JSCore public header files include stdbool.h. The stdbool.h header is a C99 feature, defining the "_Bool" type as well as the "true" and "false" constants. But it's completely unnecessary in C++ as the language already defines the "bool" type and its two values. 83452 1 21725 hausmann 2008-06-16 06:35:30 -0700 Created attachment 21725 Fix compilation in C++ environments where C99 headers are not present Proposed patch from Thiago Macieira <tjmaciei@trolltech.com> 83454 2 hausmann 2008-06-16 06:39:45 -0700 I think the patch is fine, but since this touches the header files of the public API I'd be great to get a review from someone with experience on handling those :) 83465 3 21725 darin 2008-06-16 08:53:35 -0700 Comment on attachment 21725 Fix compilation in C++ environments where C99 headers are not present Seems OK. r=me 83541 4 hausmann 2008-06-16 14:23:37 -0700 Landed in r34606 21725 2008-06-16 06:35:30 -0700 2008-06-16 08:53:35 -0700 Fix compilation in C++ environments where C99 headers are not present patch.txt text/plain 2583 hausmann ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0FQSS9KU0Jhc2UuaCBiL0phdmFTY3JpcHRDb3Jl L0FQSS9KU0Jhc2UuaAppbmRleCAyYzFlOWUzLi45MGRjNTYxIDEwMDY0NAotLS0gYS9KYXZhU2Ny aXB0Q29yZS9BUEkvSlNCYXNlLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvQVBJL0pTQmFzZS5oCkBA IC0yNyw3ICsyNyw5IEBACiAjaWZuZGVmIEpTQmFzZV9oCiAjZGVmaW5lIEpTQmFzZV9oCiAKKyNp Zm5kZWYgX19jcGx1c3BsdXMKICNpbmNsdWRlIDxzdGRib29sLmg+CisjZW5kaWYKIAogLyogSmF2 YVNjcmlwdCBlbmdpbmUgaW50ZXJmYWNlICovCiAKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3Jl L0FQSS9KU0NvbnRleHRSZWYuaCBiL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NvbnRleHRSZWYuaApp bmRleCBkZjBhMzk3Li5mODExZDIxIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9BUEkvSlND b250ZXh0UmVmLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ29udGV4dFJlZi5oCkBAIC0z MCw3ICszMCw5IEBACiAjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvSlNPYmplY3RSZWYuaD4KICNp bmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9KU1ZhbHVlUmVmLmg+CiAKKyNpZm5kZWYgX19jcGx1c3Bs dXMKICNpbmNsdWRlIDxzdGRib29sLmg+CisjZW5kaWYKIAogI2lmZGVmIF9fY3BsdXNwbHVzCiBl eHRlcm4gIkMiIHsKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0FQSS9KU09iamVjdFJlZi5o IGIvSmF2YVNjcmlwdENvcmUvQVBJL0pTT2JqZWN0UmVmLmgKaW5kZXggYmY0MDQxZi4uZWU4ZmRj YSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQVBJL0pTT2JqZWN0UmVmLmgKKysrIGIvSmF2 YVNjcmlwdENvcmUvQVBJL0pTT2JqZWN0UmVmLmgKQEAgLTMwLDcgKzMwLDkgQEAKICNpbmNsdWRl IDxKYXZhU2NyaXB0Q29yZS9KU0Jhc2UuaD4KICNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9KU1Zh bHVlUmVmLmg+CiAKKyNpZm5kZWYgX19jcGx1c3BsdXMKICNpbmNsdWRlIDxzdGRib29sLmg+Cisj ZW5kaWYKICNpbmNsdWRlIDxzdGRkZWYuaD4gLy8gZm9yIHNpemVfdAogCiAjaWZkZWYgX19jcGx1 c3BsdXMKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0FQSS9KU1N0cmluZ1JlZi5oIGIvSmF2 YVNjcmlwdENvcmUvQVBJL0pTU3RyaW5nUmVmLmgKaW5kZXggZmI1NjQ5Zi4uYzA5NTg4MiAxMDA2 NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQVBJL0pTU3RyaW5nUmVmLmgKKysrIGIvSmF2YVNjcmlw dENvcmUvQVBJL0pTU3RyaW5nUmVmLmgKQEAgLTI5LDcgKzI5LDkgQEAKIAogI2luY2x1ZGUgPEph dmFTY3JpcHRDb3JlL0pTVmFsdWVSZWYuaD4KIAorI2lmbmRlZiBfX2NwbHVzcGx1cwogI2luY2x1 ZGUgPHN0ZGJvb2wuaD4KKyNlbmRpZgogI2luY2x1ZGUgPHN0ZGRlZi5oPiAvLyBmb3Igc2l6ZV90 CiAKICNpZmRlZiBfX2NwbHVzcGx1cwpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvQVBJL0pT VmFsdWVSZWYuaCBiL0phdmFTY3JpcHRDb3JlL0FQSS9KU1ZhbHVlUmVmLmgKaW5kZXggNmYxY2Uw OC4uZGVhZGU3YyAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQVBJL0pTVmFsdWVSZWYuaAor KysgYi9KYXZhU2NyaXB0Q29yZS9BUEkvSlNWYWx1ZVJlZi5oCkBAIC0yOSw3ICsyOSw5IEBACiAK ICNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9KU0Jhc2UuaD4KIAorI2lmbmRlZiBfX2NwbHVzcGx1 cwogI2luY2x1ZGUgPHN0ZGJvb2wuaD4KKyNlbmRpZgogCiAvKiEKIEBlbnVtIEpTVHlwZQpkaWZm IC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCmluZGV4IDk4YTYxZmEuLjZjMjQ4M2YgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZworKysgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAor MjAwOC0wNi0xNiAgVGhpYWdvIE1hY2llaXJhICA8dGptYWNpZWlAdHJvbGx0ZWNoLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKQorCisgICAgICAgIEZpeCBjb21waWxh dGlvbiBpbiBDKysgZW52aXJvbm1lbnRzIHdoZXJlIEM5OSBoZWFkZXJzIGFyZSBub3QgcHJlc2Vu dAorCisgICAgICAgIFRoZSBzdGRib29sLmggaGVhZGVyIGlzIGEgQzk5IGZlYXR1cmUsIGRlZmlu aW5nIHRoZSAiX0Jvb2wiIHR5cGUgYXMgd2VsbCBhcyB0aGUKKyAgICAgICAgInRydWUiIGFuZCAi ZmFsc2UiIGNvbnN0YW50cy4gQnV0IGl0J3MgY29tcGxldGVseSB1bm5lY2Vzc2FyeSBpbiBDKysg YXMgdGhlCisgICAgICAgIGxhbmd1YWdlIGFscmVhZHkgZGVmaW5lcyB0aGUgImJvb2wiIHR5cGUg YW5kIGl0cyB0d28gdmFsdWVzLgorCisgICAgICAgICogQVBJL0pTQmFzZS5oOgorICAgICAgICAq IEFQSS9KU0NvbnRleHRSZWYuaDoKKyAgICAgICAgKiBBUEkvSlNPYmplY3RSZWYuaDoKKyAgICAg ICAgKiBBUEkvSlNTdHJpbmdSZWYuaDoKKyAgICAgICAgKiBBUEkvSlNWYWx1ZVJlZi5oOgorCiAy MDA4LTA2LTE2ICBBZHJpYWFuIGRlIEdyb290ICA8Z3Jvb3RAa2RlLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBTaW1vbi4K