195768 2019-03-14 15:05:43 -0700 Web process is put to suspended when holding locked WebSQL files 2019-03-14 18:55:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu commit-queue ggaren webkit-bug-importer oldest_to_newest 1516669 0 sihui_liu 2019-03-14 15:05:43 -0700 Web process should not get suspended when it's holding locked database file and performing close. 1516704 1 364706 sihui_liu 2019-03-14 15:31:09 -0700 Created attachment 364706 Patch 1516734 2 364706 ggaren 2019-03-14 16:17:53 -0700 Comment on attachment 364706 Patch In file included from ./inspector/CommandLineAPIHost.cpp:34: In file included from /Volumes/Data/EWS/WebKit/Source/WebCore/Modules/webdatabase/Database.h:32: /Volumes/Data/EWS/WebKit/Source/WebCore/platform/sql/SQLiteDatabase.h:159:28: error: expected ';' at end of declaration list bool m_useWAL { false } 1516749 3 364706 ggaren 2019-03-14 16:51:42 -0700 Comment on attachment 364706 Patch r=me if you fix the build (missing semicolon) 1516806 4 364744 sihui_liu 2019-03-14 18:04:58 -0700 Created attachment 364744 Patch for landing 1516830 5 commit-queue 2019-03-14 18:53:39 -0700 The commit-queue encountered the following flaky tests while processing attachment 364744: loader/load-defer-resume-crash.html bug 195438 (authors: max.hong.shen@gmail.com and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1516831 6 364744 commit-queue 2019-03-14 18:54:28 -0700 Comment on attachment 364744 Patch for landing Clearing flags on attachment: 364744 Committed r242983: <https://trac.webkit.org/changeset/242983> 1516832 7 commit-queue 2019-03-14 18:54:30 -0700 All reviewed patches have been landed. Closing bug. 1516833 8 webkit-bug-importer 2019-03-14 18:55:18 -0700 <rdar://problem/48912114> 364706 2019-03-14 15:31:09 -0700 2019-03-14 18:04:57 -0700 Patch bug-195768-20190314153108.patch text/plain 3044 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyOTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTU0YWQ0ZDFjNDk1ZmY3 YzFjMzk0Y2ExNjQzYzQ2NzhiZDhkODBhNi4uZGY2NTEzMjk4Yzc4NDVmNTlmMTBmMGY3MzFhYWIy YTE0ZmQ0MzcxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAzLTE0ICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBwcm9jZXNzIGlzIHB1 dCB0byBzdXNwZW5kZWQgd2hlbiBob2xkaW5nIGxvY2tlZCBXZWJTUUwgZmlsZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTc2OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG5lZWQgdG8ga2VlcCBw cm9jZXNzZXMgYWN0aXZlIGR1cmluZyBkYXRhYmFzZSBjbG9zZSwgYmVjYXVzZSBTUUxpdGUgZGF0 YWJhc2UgbWF5IHJ1biBhIGNoZWNrcG9pbnQgb3BlcmF0aW9uCisgICAgICAgIGFuZCBsb2NrIGRh dGFiYXNlIGZpbGVzLgorCisgICAgICAgICogcGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNlLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNRTGl0ZURhdGFiYXNlOjp1c2VXQUxKb3VybmFsTW9kZSk6 CisgICAgICAgIChXZWJDb3JlOjpTUUxpdGVEYXRhYmFzZTo6Y2xvc2UpOgorICAgICAgICAqIHBs YXRmb3JtL3NxbC9TUUxpdGVEYXRhYmFzZS5oOgorCiAyMDE5LTAzLTE0ICBDaHJpcyBEdW1leiAg PGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgRGV2aWNlIG9yaWVudGF0aW9uJ3MgcGVybWlz c2lvbiBzaG91bGQgb25seSByZXF1aXJlIGEgdXNlciBnZXN0dXJlIHRvIHByb21wdCB0aGUgdXNl cgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVEYXRhYmFzZS5jcHAKaW5k ZXggZGM3ZTgzMjQ3MWQ3YzYzNDk5YmE5YmVkMjE3MTg1N2NlOTQwNWYzYS4uMDcwZDNhZThiNTlm NDgzNTU1ZjIwOTE2NWZkMmM1OGIxOTYxZGY2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9zcWwvU1FMaXRlRGF0YWJhc2UuY3BwCkBAIC0zMCw2ICszMCw3IEBACiAjaW5jbHVkZSAi RGF0YWJhc2VBdXRob3JpemVyLmgiCiAjaW5jbHVkZSAiTG9nZ2luZy5oIgogI2luY2x1ZGUgIk1l bW9yeVJlbGVhc2UuaCIKKyNpbmNsdWRlICJTUUxpdGVEYXRhYmFzZVRyYWNrZXIuaCIKICNpbmNs dWRlICJTUUxpdGVGaWxlU3lzdGVtLmgiCiAjaW5jbHVkZSAiU1FMaXRlU3RhdGVtZW50LmgiCiAj aW5jbHVkZSA8bXV0ZXg+CkBAIC0xMzMsNiArMTM0LDcgQEAgYm9vbCBTUUxpdGVEYXRhYmFzZTo6 b3Blbihjb25zdCBTdHJpbmcmIGZpbGVuYW1lLCBPcGVuTW9kZSBvcGVuTW9kZSkKIAogdm9pZCBT UUxpdGVEYXRhYmFzZTo6dXNlV0FMSm91cm5hbE1vZGUoKQogeworICAgIG1fdXNlV0FMID0gdHJ1 ZTsKICAgICB7CiAgICAgICAgIFNRTGl0ZVN0YXRlbWVudCB3YWxTdGF0ZW1lbnQoKnRoaXMsICJQ UkFHTUEgam91cm5hbF9tb2RlPVdBTDsiX3MpOwogICAgICAgICBpZiAod2FsU3RhdGVtZW50LnBy ZXBhcmVBbmRTdGVwKCkgPT0gU1FMSVRFX1JPVykgewpAQCAtMTQ2LDYgKzE0OCw3IEBAIHZvaWQg U1FMaXRlRGF0YWJhc2U6OnVzZVdBTEpvdXJuYWxNb2RlKCkKICAgICB9CiAKICAgICB7CisgICAg ICAgIFNRTGl0ZVRyYW5zYWN0aW9uSW5Qcm9ncmVzc0F1dG9Db3VudGVyIHRyYW5zYWN0aW9uQ291 bnRlcjsKICAgICAgICAgU1FMaXRlU3RhdGVtZW50IGNoZWNrcG9pbnRTdGF0ZW1lbnQoKnRoaXMs ICJQUkFHTUEgd2FsX2NoZWNrcG9pbnQoVFJVTkNBVEUpIl9zKTsKICAgICAgICAgaWYgKGNoZWNr cG9pbnRTdGF0ZW1lbnQucHJlcGFyZUFuZFN0ZXAoKSA9PSBTUUxJVEVfUk9XKSB7CiAgICAgICAg ICAgICBpZiAoY2hlY2twb2ludFN0YXRlbWVudC5nZXRDb2x1bW5JbnQoMCkpCkBAIC0xNjUsNyAr MTY4LDExIEBAIHZvaWQgU1FMaXRlRGF0YWJhc2U6OmNsb3NlKCkKICAgICAgICAgICAgIExvY2tI b2xkZXIgbG9ja2VyKG1fZGF0YWJhc2VDbG9zaW5nTXV0ZXgpOwogICAgICAgICAgICAgbV9kYiA9 IDA7CiAgICAgICAgIH0KLSAgICAgICAgc3FsaXRlM19jbG9zZShkYik7CisgICAgICAgIGlmICht X3VzZVdBTCkgeworICAgICAgICAgICAgU1FMaXRlVHJhbnNhY3Rpb25JblByb2dyZXNzQXV0b0Nv dW50ZXIgdHJhbnNhY3Rpb25Db3VudGVyOworICAgICAgICAgICAgc3FsaXRlM19jbG9zZShkYik7 CisgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgc3FsaXRlM19jbG9zZShkYik7CiAgICAgfQog CiAgICAgbV9vcGVuaW5nVGhyZWFkID0gbnVsbHB0cjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVEYXRhYmFzZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vc3FsL1NRTGl0ZURhdGFiYXNlLmgKaW5kZXggNjQzZDI0MjY3NjlmZjQwMDQxODlhOGY2Njkw ZWIxZDQzMDZhYjJjMC4uMWFkYTdmMDQ3YTk2MWU4MjA4NGFjMTdmZGJhZWUwZjBlMzBjYWU2MyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNlLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNlLmgKQEAgLTE1 NSw3ICsxNTUsOSBAQCBwcml2YXRlOgogI2lmbmRlZiBOREVCVUcKICAgICBib29sIG1fc2hhcmFi bGUgeyBmYWxzZSB9OwogI2VuZGlmCi0gICAgCisKKyAgICBib29sIG1fdXNlV0FMIHsgZmFsc2Ug fQorCiAgICAgTG9jayBtX2F1dGhvcml6ZXJMb2NrOwogICAgIFJlZlB0cjxEYXRhYmFzZUF1dGhv cml6ZXI+IG1fYXV0aG9yaXplcjsKIAo= 364744 2019-03-14 18:04:58 -0700 2019-03-14 18:54:28 -0700 Patch for landing bug-195768-20190314180457.patch text/plain 3045 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyOTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTU0YWQ0ZDFjNDk1ZmY3 YzFjMzk0Y2ExNjQzYzQ2NzhiZDhkODBhNi4uMjliNDE2NDA0NGRhMmEwZGNmZDgzMmY0ZGRjMzhm ZTA2ZWM5YmJhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAzLTE0ICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBwcm9jZXNzIGlzIHB1 dCB0byBzdXNwZW5kZWQgd2hlbiBob2xkaW5nIGxvY2tlZCBXZWJTUUwgZmlsZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTc2OAorCisgICAgICAg IFJldmlld2VkIGJ5IEdlb2ZmcmV5IEdhcmVuLgorCisgICAgICAgIFdlIG5lZWQgdG8ga2VlcCBw cm9jZXNzZXMgYWN0aXZlIGR1cmluZyBkYXRhYmFzZSBjbG9zZSwgYmVjYXVzZSBTUUxpdGUgZGF0 YWJhc2UgbWF5IHJ1biBhIGNoZWNrcG9pbnQgb3BlcmF0aW9uCisgICAgICAgIGFuZCBsb2NrIGRh dGFiYXNlIGZpbGVzLgorCisgICAgICAgICogcGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNlLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNRTGl0ZURhdGFiYXNlOjp1c2VXQUxKb3VybmFsTW9kZSk6 CisgICAgICAgIChXZWJDb3JlOjpTUUxpdGVEYXRhYmFzZTo6Y2xvc2UpOgorICAgICAgICAqIHBs YXRmb3JtL3NxbC9TUUxpdGVEYXRhYmFzZS5oOgorCiAyMDE5LTAzLTE0ICBDaHJpcyBEdW1leiAg PGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgRGV2aWNlIG9yaWVudGF0aW9uJ3MgcGVybWlz c2lvbiBzaG91bGQgb25seSByZXF1aXJlIGEgdXNlciBnZXN0dXJlIHRvIHByb21wdCB0aGUgdXNl cgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVEYXRhYmFzZS5jcHAKaW5k ZXggZGM3ZTgzMjQ3MWQ3YzYzNDk5YmE5YmVkMjE3MTg1N2NlOTQwNWYzYS4uMDcwZDNhZThiNTlm NDgzNTU1ZjIwOTE2NWZkMmM1OGIxOTYxZGY2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9zcWwvU1FMaXRlRGF0YWJhc2UuY3BwCkBAIC0zMCw2ICszMCw3IEBACiAjaW5jbHVkZSAi RGF0YWJhc2VBdXRob3JpemVyLmgiCiAjaW5jbHVkZSAiTG9nZ2luZy5oIgogI2luY2x1ZGUgIk1l bW9yeVJlbGVhc2UuaCIKKyNpbmNsdWRlICJTUUxpdGVEYXRhYmFzZVRyYWNrZXIuaCIKICNpbmNs dWRlICJTUUxpdGVGaWxlU3lzdGVtLmgiCiAjaW5jbHVkZSAiU1FMaXRlU3RhdGVtZW50LmgiCiAj aW5jbHVkZSA8bXV0ZXg+CkBAIC0xMzMsNiArMTM0LDcgQEAgYm9vbCBTUUxpdGVEYXRhYmFzZTo6 b3Blbihjb25zdCBTdHJpbmcmIGZpbGVuYW1lLCBPcGVuTW9kZSBvcGVuTW9kZSkKIAogdm9pZCBT UUxpdGVEYXRhYmFzZTo6dXNlV0FMSm91cm5hbE1vZGUoKQogeworICAgIG1fdXNlV0FMID0gdHJ1 ZTsKICAgICB7CiAgICAgICAgIFNRTGl0ZVN0YXRlbWVudCB3YWxTdGF0ZW1lbnQoKnRoaXMsICJQ UkFHTUEgam91cm5hbF9tb2RlPVdBTDsiX3MpOwogICAgICAgICBpZiAod2FsU3RhdGVtZW50LnBy ZXBhcmVBbmRTdGVwKCkgPT0gU1FMSVRFX1JPVykgewpAQCAtMTQ2LDYgKzE0OCw3IEBAIHZvaWQg U1FMaXRlRGF0YWJhc2U6OnVzZVdBTEpvdXJuYWxNb2RlKCkKICAgICB9CiAKICAgICB7CisgICAg ICAgIFNRTGl0ZVRyYW5zYWN0aW9uSW5Qcm9ncmVzc0F1dG9Db3VudGVyIHRyYW5zYWN0aW9uQ291 bnRlcjsKICAgICAgICAgU1FMaXRlU3RhdGVtZW50IGNoZWNrcG9pbnRTdGF0ZW1lbnQoKnRoaXMs ICJQUkFHTUEgd2FsX2NoZWNrcG9pbnQoVFJVTkNBVEUpIl9zKTsKICAgICAgICAgaWYgKGNoZWNr cG9pbnRTdGF0ZW1lbnQucHJlcGFyZUFuZFN0ZXAoKSA9PSBTUUxJVEVfUk9XKSB7CiAgICAgICAg ICAgICBpZiAoY2hlY2twb2ludFN0YXRlbWVudC5nZXRDb2x1bW5JbnQoMCkpCkBAIC0xNjUsNyAr MTY4LDExIEBAIHZvaWQgU1FMaXRlRGF0YWJhc2U6OmNsb3NlKCkKICAgICAgICAgICAgIExvY2tI b2xkZXIgbG9ja2VyKG1fZGF0YWJhc2VDbG9zaW5nTXV0ZXgpOwogICAgICAgICAgICAgbV9kYiA9 IDA7CiAgICAgICAgIH0KLSAgICAgICAgc3FsaXRlM19jbG9zZShkYik7CisgICAgICAgIGlmICht X3VzZVdBTCkgeworICAgICAgICAgICAgU1FMaXRlVHJhbnNhY3Rpb25JblByb2dyZXNzQXV0b0Nv dW50ZXIgdHJhbnNhY3Rpb25Db3VudGVyOworICAgICAgICAgICAgc3FsaXRlM19jbG9zZShkYik7 CisgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgc3FsaXRlM19jbG9zZShkYik7CiAgICAgfQog CiAgICAgbV9vcGVuaW5nVGhyZWFkID0gbnVsbHB0cjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVEYXRhYmFzZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vc3FsL1NRTGl0ZURhdGFiYXNlLmgKaW5kZXggNjQzZDI0MjY3NjlmZjQwMDQxODlhOGY2Njkw ZWIxZDQzMDZhYjJjMC4uOWE0YzUyNmExMjFkYjQ4MGQ0NmE2N2UwOTAxY2IyOTkxZGQ3MWIzOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNlLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNlLmgKQEAgLTE1 NSw3ICsxNTUsOSBAQCBwcml2YXRlOgogI2lmbmRlZiBOREVCVUcKICAgICBib29sIG1fc2hhcmFi bGUgeyBmYWxzZSB9OwogI2VuZGlmCi0gICAgCisKKyAgICBib29sIG1fdXNlV0FMIHsgZmFsc2Ug fTsKKwogICAgIExvY2sgbV9hdXRob3JpemVyTG9jazsKICAgICBSZWZQdHI8RGF0YWJhc2VBdXRo b3JpemVyPiBtX2F1dGhvcml6ZXI7CiAK