195753 2019-03-14 11:56:15 -0700 [ews-app] Gracefully handle the case when state_string is None 2019-03-14 14:45:16 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu jbedard lforschler webkit-bug-importer oldest_to_newest 1516561 0 aakash_jain 2019-03-14 11:56:15 -0700 ews-app should gracefully handle the case when 'state_string' sent by buildbot is None. Currently it results in a database exception: IntegrityError: NOT NULL constraint failed: ews_step.state_string 1516565 1 364673 aakash_jain 2019-03-14 11:59:03 -0700 Created attachment 364673 Patch 1516570 2 jbedard 2019-03-14 12:02:36 -0700 Assuming we're ok displaying an empty state string (and I think we are), this looks good to me. Note that this is a response to comments I had in <https://bugs.webkit.org/show_bug.cgi?id=195744>. 1516656 3 364673 commit-queue 2019-03-14 14:44:41 -0700 Comment on attachment 364673 Patch Clearing flags on attachment: 364673 Committed r242966: <https://trac.webkit.org/changeset/242966> 1516657 4 commit-queue 2019-03-14 14:44:42 -0700 All reviewed patches have been landed. Closing bug. 1516658 5 webkit-bug-importer 2019-03-14 14:45:16 -0700 <rdar://problem/48902526> 364673 2019-03-14 11:59:03 -0700 2019-03-14 14:44:41 -0700 Patch bug-195753-20190314145919.patch text/plain 2012 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Mjk1MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTAzLTE0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gR3JhY2VmdWxseSBoYW5kbGUgdGhlIGNhc2Ugd2hlbiBz dGF0ZV9zdHJpbmcgaXMgTm9uZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk1NzUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvYnVpbGQu cHk6CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3N0ZXAu cHk6CisKIDIwMTktMDMtMTMgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+ CiAKICAgICAgICAgTWFrZSAtW19XS0F0dGFjaG1lbnQgc2V0RmlsZVdyYXBwZXI6Y29udGVudFR5 cGU6Y29tcGxldGlvbjpdIHJvYnVzdCB3aGVuIGdpdmVuIGEgbmlsIGNvbXBsZXRpb24gaGFuZGxl cgpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxk LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21v ZGVscy9idWlsZC5weQkocmV2aXNpb24gMjQyOTUwKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxkLnB5CSh3b3JraW5nIGNvcHkpCkBAIC01NSw2ICs1 NSw5IEBAIGNsYXNzIEJ1aWxkKG1vZGVscy5Nb2RlbCk6CiAgICAgICAgIGlmIG5vdCBCdWlsZC5p c192YWxpZF9yZXN1bHQocGF0Y2hfaWQsIGJ1aWxkX2lkLCBidWlsZGVyX2lkLCBudW1iZXIsIHJl c3VsdCwgc3RhdGVfc3RyaW5nLCBzdGFydGVkX2F0LCBjb21wbGV0ZV9hdCk6CiAgICAgICAgICAg ICByZXR1cm4gRVJSX1VORVhQRUNURUQKIAorICAgICAgICBpZiBzdGF0ZV9zdHJpbmcgaXMgTm9u ZToKKyAgICAgICAgICAgIHN0YXRlX3N0cmluZyA9ICcnCisKICAgICAgICAgdWlkID0gQnVpbGRi b3RJbnN0YW5jZS5nZXRfdWlkKGhvc3RuYW1lLCBidWlsZF9pZCkKICAgICAgICAgYnVpbGQgPSBC dWlsZC5nZXRfZXhpc3RpbmdfYnVpbGQodWlkKQogICAgICAgICBpZiBidWlsZDoKSW5kZXg6IFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9zdGVwLnB5Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9zdGVwLnB5 CShyZXZpc2lvbiAyNDI5NTApCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3 cy9tb2RlbHMvc3RlcC5weQkod29ya2luZyBjb3B5KQpAQCAtNTEsNiArNTEsOSBAQCBjbGFzcyBT dGVwKG1vZGVscy5Nb2RlbCk6CiAgICAgICAgIGlmIG5vdCBTdGVwLmlzX3ZhbGlkX3Jlc3VsdChz dGVwX2lkLCBidWlsZF9pZCwgcmVzdWx0LCBzdGF0ZV9zdHJpbmcsIHN0YXJ0ZWRfYXQsIGNvbXBs ZXRlX2F0KToKICAgICAgICAgICAgIHJldHVybiBFUlJfVU5FWFBFQ1RFRAogCisgICAgICAgIGlm IHN0YXRlX3N0cmluZyBpcyBOb25lOgorICAgICAgICAgICAgc3RhdGVfc3RyaW5nID0gJycKKwog ICAgICAgICBzdGVwX3VpZCA9IEJ1aWxkYm90SW5zdGFuY2UuZ2V0X3VpZChob3N0bmFtZSwgc3Rl cF9pZCkKICAgICAgICAgYnVpbGRfdWlkID0gQnVpbGRib3RJbnN0YW5jZS5nZXRfdWlkKGhvc3Ru YW1lLCBidWlsZF9pZCkKIAo=