195751 2019-03-14 11:27:41 -0700 REGRESSION (r242908): TestWebKitAPI.WebKit.AddAndRemoveDataDetectors Crashed 2019-03-14 12:23:19 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy aestes commit-queue webkit-bug-importer wenson_hsieh oldest_to_newest 1516547 0 timothy 2019-03-14 11:27:41 -0700 ASSERTION FAILED: allowedClasses && allowedClasses.count /Volumes/Data/slave/ios-simulator-12-debug/build/Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm(321) : Optional<RetainPtr<id> > IPC::decodeSecureCodingInternal(IPC::Decoder &, NSArray<Class> *) 1 0x10addb779 WTFCrash 2 0x10fc9634b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x11016ff4d IPC::decodeSecureCodingInternal(IPC::Decoder&, NSArray<objc_class*>*) 4 0x11016f4e3 IPC::decodeObject(IPC::Decoder&, NSArray<objc_class*>*) 5 0x11016f701 IPC::decodeArrayInternal(IPC::Decoder&) 6 0x11016f497 IPC::decodeObject(IPC::Decoder&, NSArray<objc_class*>*) 7 0x110171186 WTF::Optional<WTF::RetainPtr<NSArray> > IPC::decode<NSArray, NSArray*>(IPC::Decoder&, NSArray<objc_class*>*) 8 0x11017100b WebKit::DataDetectionResult::decode(IPC::Decoder&) 9 0x110e0460c WTF::Optional<WebKit::DataDetectionResult> IPC::ArgumentCoder<WebKit::DataDetectionResult>::decode<WebKit::DataDetectionResult, (void*)0>(IPC::Decoder&) 10 0x110de2984 IPC::Decoder& IPC::Decoder::operator>><WebKit::DataDetectionResult, (void*)0>(WTF::Optional<WebKit::DataDetectionResult>&) 11 0x110de2889 Messages::WebPage::DetectDataInAllFrames::callReply(IPC::Decoder&, WTF::CompletionHandler<void (WebKit::DataDetectionResult&&)>&&) 12 0x11056b581 void IPC::Connection::sendWithAsyncReply<Messages::WebPage::DetectDataInAllFrames, WebKit::DataDetectionResult const&>(Messages::WebPage::DetectDataInAllFrames&&, WTF::CompletionHandler<void (WebKit::DataDetectionResult const&)>&&, unsigned long long)::'lambda'(IPC::Decoder*)::operator()(IPC::Decoder*) 13 0x11056b492 WTF::Function<void (IPC::Decoder*)>::CallableWrapper<void IPC::Connection::sendWithAsyncReply<Messages::WebPage::DetectDataInAllFrames, WebKit::DataDetectionResult const&>(Messages::WebPage::DetectDataInAllFrames&&, WTF::CompletionHandler<void (WebKit::DataDetectionResult const&)>&&, unsigned long long)::'lambda'(IPC::Decoder*)>::call(IPC::Decoder*) 14 0x10fceecde WTF::Function<void (IPC::Decoder*)>::operator()(IPC::Decoder*) const 15 0x10fcd2253 WTF::CompletionHandler<void (IPC::Decoder*)>::operator()(IPC::Decoder*) 16 0x10fcde3e1 IPC::Connection::dispatchMessage(IPC::Decoder&) 17 0x10fcd0a01 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 18 0x10fcdb931 IPC::Connection::dispatchIncomingMessages() 19 0x10fcffe62 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14::operator()() 20 0x10fcffd89 WTF::Function<void ()>::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14>::call() 21 0x10ae05c1d WTF::Function<void ()>::operator()() const 22 0x10ae65393 WTF::RunLoop::performWork() 23 0x10ae65d24 WTF::RunLoop::performWork(void*) 1516551 1 364668 timothy 2019-03-14 11:35:56 -0700 Created attachment 364668 Patch 1516583 2 364668 commit-queue 2019-03-14 12:22:12 -0700 Comment on attachment 364668 Patch Clearing flags on attachment: 364668 Committed r242953: <https://trac.webkit.org/changeset/242953> 1516584 3 commit-queue 2019-03-14 12:22:13 -0700 All reviewed patches have been landed. Closing bug. 1516585 4 webkit-bug-importer 2019-03-14 12:23:19 -0700 <rdar://problem/48896640> 364668 2019-03-14 11:35:56 -0700 2019-03-14 12:22:12 -0700 Patch bug-195751-20190314113555.patch text/plain 3582 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyOTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk2MGFkMWUzYTY4OWE4YTc1 YzU2ZWUzZmUxYzVhZTQwNGJmYmVkYWQuLjdlOWNhNzNlYmVlM2EzOWZkYWYyNjhlN2U0Y2JmNzhl N2ZlNjkxNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDMtMTQgIFRpbW90aHkg SGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNDI5 MDgpOiBUZXN0V2ViS2l0QVBJLldlYktpdC5BZGRBbmRSZW1vdmVEYXRhRGV0ZWN0b3JzIENyYXNo ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTc1 MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hh cmVkL0NvY29hL0FyZ3VtZW50Q29kZXJzQ29jb2EubW06CisgICAgICAgIChJUEM6OmRlY29kZUFy cmF5SW50ZXJuYWwpOiBBZGRlZCBhbGxvd2VkQ2xhc3NlcywgcGFzcyB0byBpbnRlcm5hbCBkZWNv ZGVPYmplY3QgZm9yIHZhbHVlcy4KKyAgICAgICAgKElQQzo6ZGVjb2RlRGljdGlvbmFyeUludGVy bmFsKTogRGl0dG8gZm9yIGtleXMgYW5kIHZhbHVlcy4KKyAgICAgICAgKElQQzo6ZGVjb2RlT2Jq ZWN0KTogUGFzcyBhbGxvd2VkQ2xhc3NlcyB0byBhcnJheSBhbmQgZGljdGlvbmFyeSBkZWNvZGVy cy4KKwogMjAxOS0wMy0xMyAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFtDb250ZW50Q2hhbmdlT2JzZXJ2ZXJdIFN0b3AgY29udGVudCBvYnNlcnZhdGlvbiB3aGVu IGNvbnRlbnQgY2FsbHMgcHJldmVudERlZmF1bHQoKSBvbiB0b3VjaCBldmVudHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0NvY29hL0FyZ3VtZW50Q29kZXJzQ29jb2EubW0gYi9T b3VyY2UvV2ViS2l0L1NoYXJlZC9Db2NvYS9Bcmd1bWVudENvZGVyc0NvY29hLm1tCmluZGV4IGJl MWJjMDliODhjZTIyMDZkNTYxMmQ1ODQ1NzMxYzBiOTg4ODQxMWMuLjgwZThlNTUxY2UwOTU1MjE3 NjVlNzA3NWU1ODY0N2RkZjE0MTg5ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVk L0NvY29hL0FyZ3VtZW50Q29kZXJzQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQv Q29jb2EvQXJndW1lbnRDb2RlcnNDb2NvYS5tbQpAQCAtMTUzLDcgKzE1Myw3IEBAIHN0YXRpYyB2 b2lkIGVuY29kZUFycmF5SW50ZXJuYWwoRW5jb2RlciYgZW5jb2RlciwgTlNBcnJheSAqYXJyYXkp CiAgICAgfQogfQogCi1zdGF0aWMgT3B0aW9uYWw8UmV0YWluUHRyPGlkPj4gZGVjb2RlQXJyYXlJ bnRlcm5hbChEZWNvZGVyJiBkZWNvZGVyKQorc3RhdGljIE9wdGlvbmFsPFJldGFpblB0cjxpZD4+ IGRlY29kZUFycmF5SW50ZXJuYWwoRGVjb2RlciYgZGVjb2RlciwgTlNBcnJheTxDbGFzcz4gKmFs bG93ZWRDbGFzc2VzKQogewogICAgIHVpbnQ2NF90IHNpemU7CiAgICAgaWYgKCFkZWNvZGVyLmRl Y29kZShzaXplKSkKQEAgLTE2MSw3ICsxNjEsNyBAQCBzdGF0aWMgT3B0aW9uYWw8UmV0YWluUHRy PGlkPj4gZGVjb2RlQXJyYXlJbnRlcm5hbChEZWNvZGVyJiBkZWNvZGVyKQogCiAgICAgUmV0YWlu UHRyPE5TTXV0YWJsZUFycmF5PiBhcnJheSA9IGFkb3B0TlMoW1tOU011dGFibGVBcnJheSBhbGxv Y10gaW5pdFdpdGhDYXBhY2l0eTpzaXplXSk7CiAgICAgZm9yICh1aW50NjRfdCBpID0gMDsgaSA8 IHNpemU7ICsraSkgewotICAgICAgICBhdXRvIHZhbHVlID0gZGVjb2RlT2JqZWN0KGRlY29kZXIs IG5pbCk7CisgICAgICAgIGF1dG8gdmFsdWUgPSBkZWNvZGVPYmplY3QoZGVjb2RlciwgYWxsb3dl ZENsYXNzZXMpOwogICAgICAgICBpZiAoIXZhbHVlKQogICAgICAgICAgICAgcmV0dXJuIFdURjo6 bnVsbG9wdDsKICAgICAgICAgW2FycmF5IGFkZE9iamVjdDp2YWx1ZS52YWx1ZSgpLmdldCgpXTsK QEAgLTI1MSw3ICsyNTEsNyBAQCBzdGF0aWMgdm9pZCBlbmNvZGVEaWN0aW9uYXJ5SW50ZXJuYWwo RW5jb2RlciYgZW5jb2RlciwgTlNEaWN0aW9uYXJ5ICpkaWN0aW9uYXJ5KQogICAgIH0KIH0KIAot c3RhdGljIE9wdGlvbmFsPFJldGFpblB0cjxpZD4+IGRlY29kZURpY3Rpb25hcnlJbnRlcm5hbChE ZWNvZGVyJiBkZWNvZGVyKQorc3RhdGljIE9wdGlvbmFsPFJldGFpblB0cjxpZD4+IGRlY29kZURp Y3Rpb25hcnlJbnRlcm5hbChEZWNvZGVyJiBkZWNvZGVyLCBOU0FycmF5PENsYXNzPiAqYWxsb3dl ZENsYXNzZXMpCiB7CiAgICAgdWludDY0X3Qgc2l6ZTsKICAgICBpZiAoIWRlY29kZXIuZGVjb2Rl KHNpemUpKQpAQCAtMjU5LDExICsyNTksMTEgQEAgc3RhdGljIE9wdGlvbmFsPFJldGFpblB0cjxp ZD4+IGRlY29kZURpY3Rpb25hcnlJbnRlcm5hbChEZWNvZGVyJiBkZWNvZGVyKQogCiAgICAgUmV0 YWluUHRyPE5TTXV0YWJsZURpY3Rpb25hcnk+IGRpY3Rpb25hcnkgPSBhZG9wdE5TKFtbTlNNdXRh YmxlRGljdGlvbmFyeSBhbGxvY10gaW5pdFdpdGhDYXBhY2l0eTpzaXplXSk7CiAgICAgZm9yICh1 aW50NjRfdCBpID0gMDsgaSA8IHNpemU7ICsraSkgewotICAgICAgICBhdXRvIGtleSA9IGRlY29k ZU9iamVjdChkZWNvZGVyLCBuaWwpOworICAgICAgICBhdXRvIGtleSA9IGRlY29kZU9iamVjdChk ZWNvZGVyLCBhbGxvd2VkQ2xhc3Nlcyk7CiAgICAgICAgIGlmICgha2V5KQogICAgICAgICAgICAg cmV0dXJuIFdURjo6bnVsbG9wdDsKIAotICAgICAgICBhdXRvIHZhbHVlID0gZGVjb2RlT2JqZWN0 KGRlY29kZXIsIG5pbCk7CisgICAgICAgIGF1dG8gdmFsdWUgPSBkZWNvZGVPYmplY3QoZGVjb2Rl ciwgYWxsb3dlZENsYXNzZXMpOwogICAgICAgICBpZiAoIXZhbHVlKQogICAgICAgICAgICAgcmV0 dXJuIFdURjo6bnVsbG9wdDsKIApAQCAtNDM0LDEzICs0MzQsMTMgQEAgT3B0aW9uYWw8UmV0YWlu UHRyPGlkPj4gZGVjb2RlT2JqZWN0KERlY29kZXImIGRlY29kZXIsIE5TQXJyYXk8Q2xhc3M+ICph bGxvd2VkQ2wKIAogICAgIHN3aXRjaCAodHlwZSkgewogICAgIGNhc2UgTlNUeXBlOjpBcnJheToK LSAgICAgICAgcmV0dXJuIGRlY29kZUFycmF5SW50ZXJuYWwoZGVjb2Rlcik7CisgICAgICAgIHJl dHVybiBkZWNvZGVBcnJheUludGVybmFsKGRlY29kZXIsIGFsbG93ZWRDbGFzc2VzKTsKICNpZiBV U0UoQVBQS0lUKQogICAgIGNhc2UgTlNUeXBlOjpDb2xvcjoKICAgICAgICAgcmV0dXJuIGRlY29k ZUNvbG9ySW50ZXJuYWwoZGVjb2Rlcik7CiAjZW5kaWYKICAgICBjYXNlIE5TVHlwZTo6RGljdGlv bmFyeToKLSAgICAgICAgcmV0dXJuIGRlY29kZURpY3Rpb25hcnlJbnRlcm5hbChkZWNvZGVyKTsK KyAgICAgICAgcmV0dXJuIGRlY29kZURpY3Rpb25hcnlJbnRlcm5hbChkZWNvZGVyLCBhbGxvd2Vk Q2xhc3Nlcyk7CiAgICAgY2FzZSBOU1R5cGU6OkZvbnQ6CiAgICAgICAgIHJldHVybiBkZWNvZGVG b250SW50ZXJuYWwoZGVjb2Rlcik7CiAgICAgY2FzZSBOU1R5cGU6Ok51bWJlcjoK