195749 2019-03-14 10:16:01 -0700 REGRESSION (r242801): [iOS] preventDefault() on touchstart in a subframe does not prevent focusing the subframe 2019-06-24 12:32:56 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198928 InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue dino megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1516523 0 wenson_hsieh 2019-03-14 10:16:01 -0700 This began after r242801, but it's really due to an existing (long-standing) bug wherein position information requests will change the focused frame: InteractionInformationAtPosition WebPage::positionInformation(const InteractionInformationRequest& request) { … if (!elementIsLinkOrImage) { HitTestResult result = m_page->mainFrame().eventHandler().hitTestResultAtPoint(request.point, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::DisallowUserAgentShadowContent | HitTestRequest::AllowChildFrameContent); hitNode = result.innerNode(); // Hit test could return HTMLHtmlElement that has no renderer, if the body is smaller than the document. if (hitNode && hitNode->renderer()) { RenderObject* renderer = hitNode->renderer(); m_page->focusController().setFocusedFrame(result.innerNodeFrame()); ^^^^^^^^^^^^^^^ This line in particular info.bounds = renderer->absoluteBoundingBoxRect(true); // We don't want to select blocks that are larger than 97% of the visible area of the document. … 1516524 1 wenson_hsieh 2019-03-14 10:17:11 -0700 (In reply to Wenson Hsieh from comment #0) > > m_page->focusController().setFocusedFrame(result.innerNodeFrame()); > ^^^^^^^^^^^^^^^ > This line in particular ...it was added to fix <https://bugs.webkit.org/show_bug.cgi?id=128264>. 1516531 2 webkit-bug-importer 2019-03-14 10:50:28 -0700 <rdar://problem/48892367> 1516595 3 364677 wenson_hsieh 2019-03-14 13:06:13 -0700 Created attachment 364677 Patch 1516596 4 wenson_hsieh 2019-03-14 13:08:13 -0700 This will bring back <rdar://problem/48020610>, but I have a different plan to make that work. 1516673 5 364677 commit-queue 2019-03-14 15:07:13 -0700 Comment on attachment 364677 Patch Clearing flags on attachment: 364677 Committed r242968: <https://trac.webkit.org/changeset/242968> 1516674 6 commit-queue 2019-03-14 15:07:15 -0700 All reviewed patches have been landed. Closing bug. 364677 2019-03-14 13:06:13 -0700 2019-03-14 15:07:13 -0700 Patch bug-195749-20190314130613.patch text/plain 12460 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyOTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM3YjI3MmMxNzk5N2MyODU3 NTI4ZTBkNThlYTZiOGYwYTMyYTM5NGMuLmQ3NThhNDhjNWNmYmM1NWY2NDc0MTJjNGYyZWQ2YzUz NTljNjZlYWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNDYgQEAKKzIwMTktMDMtMTQgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI0 MjgwMSk6IFtpT1NdIHByZXZlbnREZWZhdWx0KCkgb24gdG91Y2hzdGFydCBpbiBhIHN1YmZyYW1l IGRvZXMgbm90IHByZXZlbnQgZm9jdXNpbmcgdGhlIHN1YmZyYW1lCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU3NDkKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzQ4ODkyMzY3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIHIyNDI4MDEgYWRkZWQgbG9naWMgdG8gZmV0Y2ggaW50ZXJhY3Rpb24gaW5mb3Jt YXRpb24gYXQgdGhlIHRvdWNoIGxvY2F0aW9uIHVwb24gdG91Y2ggc3RhcnQuIEhvd2V2ZXIgdGhp cywKKyAgICAgICAgY29tYmluZWQgd2l0aCBhbiBleGlzdGluZyBiZWhhdmlvciB3aGVyZSB0aGUg cHJvY2VzcyBvZiBjb21wdXRpbmcgSW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24gaW4g V2ViUGFnZQorICAgICAgICBtb3ZlcyBmb2N1cyBpbnRvIHRoZSBmcmFtZSBvZiB0aGUgaGl0LXRl c3RlZCBub2RlIGJlbG93IHRoZSB0b3VjaCBsb2NhdGlvbiwgbWVhbnMgdGhhdCB3ZSdsbCBhbHdh eXMgdHJpZ2dlciBhCisgICAgICAgIGJsdXIgZXZlbnQgb24gdGhlIHdpbmRvdyBhbmQgbW92ZSBm b2N1cyBpbnRvIHRoZSBzdWJmcmFtZSB3aGVuIHBlcmZvcm1pbmcgYSB0b3VjaCBpbnNpZGUgYSBz dWJmcmFtZSwgZXZlbiBpZiB0aGUKKyAgICAgICAgcGFnZSBwcmV2ZW50cyBkZWZhdWx0IG9uIHRv dWNoc3RhcnQuCisKKyAgICAgICAgVG8gZml4IHRoaXMsIGFkZCBhICJyZWFkb25seSIgZmxhZyB0 byBJbnRlcmFjdGlvbkluZm9ybWF0aW9uUmVxdWVzdCwgYW5kIG9ubHkgY2hhbmdlIGZvY3VzIHdo ZW4gcmVxdWVzdGluZworICAgICAgICBwb3NpdGlvbiBpbmZvcm1hdGlvbiBpbiB0aGUgY2FzZSB3 aGVyZSB0aGUgcmVxdWVzdCBpcyBub3QgcmVhZG9ubHkuIEZvciBub3csIHRoaXMgcmVhZG9ubHkg ZmxhZyBpcyBmYWxzZSBieQorICAgICAgICBkZWZhdWx0OyBpbiBhIGZ1dHVyZSBwYXRjaCwgd2Ug c2hvdWxkIGlkZW50aWZ5IHRoZSAoaG9wZWZ1bGx5IGZldykgcGxhY2VzIHRoYXQgcmVseSBvbiBw b3NpdGlvbiBpbmZvcm1hdGlvbgorICAgICAgICByZXF1ZXN0cyB0byBtb3ZlIGZvY3VzLCBleHBs aWNpdGx5IHR1cm4gdGhpcyBiaXQgb2ZmIGluIHRob3NlIHBsYWNlcywgYW5kIG90aGVyd2lzZSBz ZW5kIHJlYWRvbmx5IHBvc2l0aW9uCisgICAgICAgIGluZm9ybWF0aW9uIHJlcXVlc3RzIGJ5IGRl ZmF1bHQuCisKKyAgICAgICAgKiBTaGFyZWQvaW9zL0ludGVyYWN0aW9uSW5mb3JtYXRpb25SZXF1 ZXN0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6SW50ZXJhY3Rpb25JbmZvcm1hdGlvblJlcXVlc3Q6 OmVuY29kZSBjb25zdCk6CisgICAgICAgIChXZWJLaXQ6OkludGVyYWN0aW9uSW5mb3JtYXRpb25S ZXF1ZXN0OjpkZWNvZGUpOgorICAgICAgICAoV2ViS2l0OjpJbnRlcmFjdGlvbkluZm9ybWF0aW9u UmVxdWVzdDo6aXNWYWxpZEZvclJlcXVlc3QpOgorICAgICAgICAoV2ViS2l0OjpJbnRlcmFjdGlv bkluZm9ybWF0aW9uUmVxdWVzdDo6aXNBcHByb3hpbWF0ZWx5VmFsaWRGb3JSZXF1ZXN0KToKKwor ICAgICAgICBFbnN1cmUgdGhhdCBhIHJlYWRvbmx5IHJlcXVlc3QgaXMgbm90IHZhbGlkIGZvciBh IG5vbi1yZWFkb25seSByZXF1ZXN0LgorCisgICAgICAgICogU2hhcmVkL2lvcy9JbnRlcmFjdGlv bkluZm9ybWF0aW9uUmVxdWVzdC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tX ZWJWaWV3Lm1tOgorICAgICAgICAoLVtXS1dlYlZpZXcgX3JlcXVlc3RBY3RpdmF0ZWRFbGVtZW50 QXRQb3NpdGlvbjpjb21wbGV0aW9uQmxvY2s6XSk6CisKKyAgICAgICAgU2VuZCBhIHJlYWRvbmx5 IHBvc2l0aW9uIGluZm9ybWF0aW9uIHJlcXVlc3QgaW4gdGhlIGNhc2Ugd2hlcmUgYSBXZWJLaXQg U1BJIGNsaWVudCBpcyBxdWVyeWluZyBmb3IgZWxlbWVudAorICAgICAgICBpbmZvcm1hdGlvbiBh dCB0aGUgZ2l2ZW4gbG9jYXRpb24uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfd2ViVG91Y2hF dmVudHNSZWNvZ25pemVkOl0pOgorCisgICAgICAgIFNlbmQgYSByZWFkb25seSBwb3NpdGlvbiBp bmZvcm1hdGlvbiByZXF1ZXN0IG9uIHRvdWNoc3RhcnQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNz L1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW06CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnBv c2l0aW9uSW5mb3JtYXRpb24pOgorCiAyMDE5LTAzLTE0ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1v dGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjQyOTA4KTogVGVzdFdlYktp dEFQSS5XZWJLaXQuQWRkQW5kUmVtb3ZlRGF0YURldGVjdG9ycyBDcmFzaGVkCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9pb3MvSW50ZXJhY3Rpb25JbmZvcm1hdGlvblJlcXVlc3Qu Y3BwIGIvU291cmNlL1dlYktpdC9TaGFyZWQvaW9zL0ludGVyYWN0aW9uSW5mb3JtYXRpb25SZXF1 ZXN0LmNwcAppbmRleCA1ZmNmYzAzZDAxMmJlOGJjMGUwZTE4Yjk3YTI1ZDEyODdmMjI2NTAyLi43 ZjEwNjNhZmExNmI3Y2RhNDNjYzgyYjQwNjZhMzE2MjJjZjI0MGJlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1NoYXJlZC9pb3MvSW50ZXJhY3Rpb25JbmZvcm1hdGlvblJlcXVlc3QuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL2lvcy9JbnRlcmFjdGlvbkluZm9ybWF0aW9uUmVxdWVz dC5jcHAKQEAgLTM4LDYgKzM4LDcgQEAgdm9pZCBJbnRlcmFjdGlvbkluZm9ybWF0aW9uUmVxdWVz dDo6ZW5jb2RlKElQQzo6RW5jb2RlciYgZW5jb2RlcikgY29uc3QKICAgICBlbmNvZGVyIDw8IHBv aW50OwogICAgIGVuY29kZXIgPDwgaW5jbHVkZVNuYXBzaG90OwogICAgIGVuY29kZXIgPDwgaW5j bHVkZUxpbmtJbmRpY2F0b3I7CisgICAgZW5jb2RlciA8PCByZWFkb25seTsKIH0KIAogYm9vbCBJ bnRlcmFjdGlvbkluZm9ybWF0aW9uUmVxdWVzdDo6ZGVjb2RlKElQQzo6RGVjb2RlciYgZGVjb2Rl ciwgSW50ZXJhY3Rpb25JbmZvcm1hdGlvblJlcXVlc3QmIHJlc3VsdCkKQEAgLTUxLDYgKzUyLDkg QEAgYm9vbCBJbnRlcmFjdGlvbkluZm9ybWF0aW9uUmVxdWVzdDo6ZGVjb2RlKElQQzo6RGVjb2Rl ciYgZGVjb2RlciwgSW50ZXJhY3Rpb25JbmYKICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHJlc3Vs dC5pbmNsdWRlTGlua0luZGljYXRvcikpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAorICAgIGlm ICghZGVjb2Rlci5kZWNvZGUocmVzdWx0LnJlYWRvbmx5KSkKKyAgICAgICAgcmV0dXJuIGZhbHNl OworCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKQEAgLTY1LDYgKzY5LDkgQEAgYm9vbCBJbnRlcmFj dGlvbkluZm9ybWF0aW9uUmVxdWVzdDo6aXNWYWxpZEZvclJlcXVlc3QoY29uc3QgSW50ZXJhY3Rp b25JbmZvcm1hdGkKICAgICBpZiAob3RoZXIuaW5jbHVkZUxpbmtJbmRpY2F0b3IgJiYgIWluY2x1 ZGVMaW5rSW5kaWNhdG9yKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKKyAgICBpZiAoIW90aGVy LnJlYWRvbmx5ICYmIHJlYWRvbmx5KQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICByZXR1 cm4gdHJ1ZTsKIH0KICAgICAKQEAgLTc1LDYgKzgyLDkgQEAgYm9vbCBJbnRlcmFjdGlvbkluZm9y bWF0aW9uUmVxdWVzdDo6aXNBcHByb3hpbWF0ZWx5VmFsaWRGb3JSZXF1ZXN0KGNvbnN0IEludGVy YWMKICAgICAKICAgICBpZiAob3RoZXIuaW5jbHVkZUxpbmtJbmRpY2F0b3IgJiYgIWluY2x1ZGVM aW5rSW5kaWNhdG9yKQogICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAoIW90aGVyLnJl YWRvbmx5ICYmIHJlYWRvbmx5KQorICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgCiAgICAgcmV0 dXJuIChvdGhlci5wb2ludCAtIHBvaW50KS5kaWFnb25hbExlbmd0aFNxdWFyZWQoKSA8PSA0Owog fQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvaW9zL0ludGVyYWN0aW9uSW5mb3Jt YXRpb25SZXF1ZXN0LmggYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9pb3MvSW50ZXJhY3Rpb25JbmZv cm1hdGlvblJlcXVlc3QuaAppbmRleCBkMjc0YmFiZWM3YTEwM2ZjYzhlNmM5ZDE5MjI0NzlmYzAz Zjg1NzkwLi4xNWJiZTA5NDM4NDhlMzFkZjQyOTliM2U5ZWExY2M2MDdhZjIxM2JhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9pb3MvSW50ZXJhY3Rpb25JbmZvcm1hdGlvblJlcXVl c3QuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9pb3MvSW50ZXJhY3Rpb25JbmZvcm1hdGlv blJlcXVlc3QuaApAQCAtNDIsNiArNDIsMTEgQEAgc3RydWN0IEludGVyYWN0aW9uSW5mb3JtYXRp b25SZXF1ZXN0IHsKICAgICBib29sIGluY2x1ZGVTbmFwc2hvdCB7IGZhbHNlIH07CiAgICAgYm9v bCBpbmNsdWRlTGlua0luZGljYXRvciB7IGZhbHNlIH07CiAKKyAgICAvLyBGSVhNRTogVGhpcyBy ZWFkb25seSBmbGFnIG91Z2h0IHRvIGJlIHRydWUgYnkgZGVmYXVsdCwgYnV0IHRoZXJlIGFyZSBh IG51bWJlciBvZiBpbnRlcmFjdGlvbnMgKGUuZy4gc2VsZWN0aW9uKSB0aGF0IGN1cnJlbnRseQor ICAgIC8vIHJlbHkgb24gdGhlIGZhY3QgdGhhdCBpbnRlcmFjdGlvbiBpbmZvcm1hdGlvbiByZXF1 ZXN0cyBhZGRpdGlvbmFsbHkgY2hhbmdlIHRoZSBmb2N1c2VkIGZyYW1lLiBXZSBzaG91bGQgZXhw bGljaXRseSB0dXJuIHRoZQorICAgIC8vIHJlYWRvbmx5IGJpdCBvZmYgaW4gdGhlc2Ugc2NlbmFy aW9zLCBhbmQgbWFrZSBzdXJlIHRoYXQgYWxsIG90aGVyIHBvc2l0aW9uIGluZm9ybWF0aW9uIHJl cXVlc3RzIGRvbid0IG1vdmUgZm9jdXMgYXJvdW5kLgorICAgIGJvb2wgcmVhZG9ubHkgeyBmYWxz ZSB9OworCiAgICAgSW50ZXJhY3Rpb25JbmZvcm1hdGlvblJlcXVlc3QoKSB7IH0KICAgICBleHBs aWNpdCBJbnRlcmFjdGlvbkluZm9ybWF0aW9uUmVxdWVzdChXZWJDb3JlOjpJbnRQb2ludCBwb2lu dCkKICAgICB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll dy5tbQppbmRleCBmOWRhYzRhNGEzZTJhOTViYTQyZWYyZTRiODA5YjhlNGQ1NDJjNzA0Li5kYTAz ODEyOWMzN2Y0ODI0MmM3ZmM2N2Y0NzBlM2FkNWI5NzgwZjUyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KQEAgLTY1NzcsNiArNjU3Nyw3IEBA IC0gKHZvaWQpX3JlcXVlc3RBY3RpdmF0ZWRFbGVtZW50QXRQb3NpdGlvbjooQ0dQb2ludClwb3Np dGlvbiBjb21wbGV0aW9uQmxvY2s6KHZvCiB7CiAgICAgYXV0byBpbmZvUmVxdWVzdCA9IFdlYktp dDo6SW50ZXJhY3Rpb25JbmZvcm1hdGlvblJlcXVlc3QoV2ViQ29yZTo6cm91bmRlZEludFBvaW50 KHBvc2l0aW9uKSk7CiAgICAgaW5mb1JlcXVlc3QuaW5jbHVkZVNuYXBzaG90ID0gdHJ1ZTsKKyAg ICBpbmZvUmVxdWVzdC5yZWFkb25seSA9IHRydWU7CiAKICAgICBbX2NvbnRlbnRWaWV3IGRvQWZ0 ZXJQb3NpdGlvbkluZm9ybWF0aW9uVXBkYXRlOltjYXB0dXJlZEJsb2NrID0gbWFrZUJsb2NrUHRy KGJsb2NrKV0gKFdlYktpdDo6SW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24gaW5mb3Jt YXRpb24pIHsKICAgICAgICAgY2FwdHVyZWRCbG9jayhbX1dLQWN0aXZhdGVkRWxlbWVudEluZm8g YWN0aXZhdGVkRWxlbWVudEluZm9XaXRoSW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb246 aW5mb3JtYXRpb25dKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9X S0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3Mv V0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDdmYzQ2YTZmNDk4ZDViMTQxMTA1MTI0 OGFlMjE3YTdmN2VhNzcxZDEuLmNiZmNjOTJmMzE0ODBiODQ3MzA4ZmI2OGI3NDEzY2RlNjk4OGYz ZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtMTIyMSw5ICsxMjIxLDExIEBAIC0gKHZvaWQpX3dlYlRv dWNoRXZlbnRzUmVjb2duaXplZDooVUlXZWJUb3VjaEV2ZW50c0dlc3R1cmVSZWNvZ25pemVyICop Z2VzdHVyZVJlCiAgICAgICAgIFtzZWxmIF9oYW5kbGVET01QYXN0ZVJlcXVlc3RXaXRoUmVzdWx0 OldlYkNvcmU6OkRPTVBhc3RlQWNjZXNzUmVzcG9uc2U6OkRlbmllZEZvckdlc3R1cmVdOwogICAg ICAgICBfbGF5ZXJUcmVlVHJhbnNhY3Rpb25JZEF0TGFzdFRvdWNoU3RhcnQgPSBkb3duY2FzdDxX ZWJLaXQ6OlJlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhUHJveHk+KCpfcGFnZS0+ZHJhd2luZ0Fy ZWEoKSkubGFzdENvbW1pdHRlZExheWVyVHJlZVRyYW5zYWN0aW9uSUQoKTsKIAorICAgICAgICBX ZWJLaXQ6OkludGVyYWN0aW9uSW5mb3JtYXRpb25SZXF1ZXN0IHBvc2l0aW9uSW5mb3JtYXRpb25S ZXF1ZXN0IHsgV2ViQ29yZTo6SW50UG9pbnQoX2xhc3RJbnRlcmFjdGlvbkxvY2F0aW9uKSB9Owor ICAgICAgICBwb3NpdGlvbkluZm9ybWF0aW9uUmVxdWVzdC5yZWFkb25seSA9IHRydWU7CiAgICAg ICAgIFtzZWxmIGRvQWZ0ZXJQb3NpdGlvbkluZm9ybWF0aW9uVXBkYXRlOlthc3Npc3RhbnQgPSBX ZWFrT2JqQ1B0cjxXS0FjdGlvblNoZWV0QXNzaXN0YW50PihfYWN0aW9uU2hlZXRBc3Npc3RhbnQu Z2V0KCkpXSAoV2ViS2l0OjpJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbiBpbmZvcm1h dGlvbikgewogICAgICAgICAgICAgW2Fzc2lzdGFudCBpbnRlcmFjdGlvbkRpZFN0YXJ0V2l0aFBv c2l0aW9uSW5mb3JtYXRpb246aW5mb3JtYXRpb25dOwotICAgICAgICB9IGZvclJlcXVlc3Q6V2Vi S2l0OjpJbnRlcmFjdGlvbkluZm9ybWF0aW9uUmVxdWVzdChXZWJDb3JlOjpJbnRQb2ludChfbGFz dEludGVyYWN0aW9uTG9jYXRpb24pKV07CisgICAgICAgIH0gZm9yUmVxdWVzdDpwb3NpdGlvbklu Zm9ybWF0aW9uUmVxdWVzdF07CiAgICAgfQogCiAjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9T Lm1tIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0K aW5kZXggODRkZmMzZWJkNTQ5NGE4ODZiYjEyNGFhYzg3MDE5NjA2NThkOTBjNS4uNDY2NWE5NDk3 M2VjYmE4NmZmNzdiM2M2NWE0NDlhMDM1NzYxOWU5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KKysrIGIvU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KQEAgLTIzNzYsNyArMjM3Niw4 IEBAIEludGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uIFdlYlBhZ2U6OnBvc2l0aW9uSW5m b3JtYXRpb24oY29uc3QgSW50ZXJhY3Rpb25JCiAgICAgICAgIC8vIEhpdCB0ZXN0IGNvdWxkIHJl dHVybiBIVE1MSHRtbEVsZW1lbnQgdGhhdCBoYXMgbm8gcmVuZGVyZXIsIGlmIHRoZSBib2R5IGlz IHNtYWxsZXIgdGhhbiB0aGUgZG9jdW1lbnQuCiAgICAgICAgIGlmIChoaXROb2RlICYmIGhpdE5v ZGUtPnJlbmRlcmVyKCkpIHsKICAgICAgICAgICAgIFJlbmRlck9iamVjdCogcmVuZGVyZXIgPSBo aXROb2RlLT5yZW5kZXJlcigpOwotICAgICAgICAgICAgbV9wYWdlLT5mb2N1c0NvbnRyb2xsZXIo KS5zZXRGb2N1c2VkRnJhbWUocmVzdWx0LmlubmVyTm9kZUZyYW1lKCkpOworICAgICAgICAgICAg aWYgKCFyZXF1ZXN0LnJlYWRvbmx5KQorICAgICAgICAgICAgICAgIG1fcGFnZS0+Zm9jdXNDb250 cm9sbGVyKCkuc2V0Rm9jdXNlZEZyYW1lKHJlc3VsdC5pbm5lck5vZGVGcmFtZSgpKTsKICAgICAg ICAgICAgIGluZm8uYm91bmRzID0gcmVuZGVyZXItPmFic29sdXRlQm91bmRpbmdCb3hSZWN0KHRy dWUpOwogICAgICAgICAgICAgLy8gV2UgZG9uJ3Qgd2FudCB0byBzZWxlY3QgYmxvY2tzIHRoYXQg YXJlIGxhcmdlciB0aGFuIDk3JSBvZiB0aGUgdmlzaWJsZSBhcmVhIG9mIHRoZSBkb2N1bWVudC4K ICAgICAgICAgICAgIGlmIChpczxIVE1MQXR0YWNobWVudEVsZW1lbnQ+KCpoaXROb2RlKSkgewpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IGQ3ZGRmYmY2NjllNjM4ZTQ1YWVhZmJhOGI1ZjlkZTRiMGUwOGFiMGQuLjNmNTUzZTRm YjIyZGI0ZWRkYWE4ZGRiMDQyNjZmOGY0ZmRiYzY3OTIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAor MjAxOS0wMy0xNCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KKworICAg ICAgICBSRUdSRVNTSU9OIChyMjQyODAxKTogW2lPU10gcHJldmVudERlZmF1bHQoKSBvbiB0b3Vj aHN0YXJ0IGluIGEgc3ViZnJhbWUgZG9lcyBub3QgcHJldmVudCBmb2N1c2luZyB0aGUgc3ViZnJh bWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTc0 OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDg4OTIzNjc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCB0byB2ZXJpZnkgdGhhdCB0 YXBwaW5nIGEgc3ViZnJhbWUgZG9lc24ndCBtb3ZlIGZvY3VzIGludG8gaXQgc3ViZnJhbWUgaWYg dGhlIHBhZ2UgcHJldmVudHMgZGVmYXVsdAorICAgICAgICBvbiB0b3VjaHN0YXJ0LgorCisgICAg ICAgICogZmFzdC9ldmVudHMvdG91Y2gvaW9zL25vLWZvY3VzLWNoYW5nZS13aGVuLXByZXZlbnRp bmctZGVmYXVsdC1vbi10b3VjaHN0YXJ0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog ZmFzdC9ldmVudHMvdG91Y2gvaW9zL25vLWZvY3VzLWNoYW5nZS13aGVuLXByZXZlbnRpbmctZGVm YXVsdC1vbi10b3VjaHN0YXJ0Lmh0bWw6IEFkZGVkLgorCiAyMDE5LTAzLTE0ICBTaGF3biBSb2Jl cnRzICA8c3JvYmVydHNAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcg b3V0IHIyNDI5MzEuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9p b3Mvbm8tZm9jdXMtY2hhbmdlLXdoZW4tcHJldmVudGluZy1kZWZhdWx0LW9uLXRvdWNoc3RhcnQt ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvaW9zL25vLWZvY3Vz LWNoYW5nZS13aGVuLXByZXZlbnRpbmctZGVmYXVsdC1vbi10b3VjaHN0YXJ0LWV4cGVjdGVkLnR4 dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi4zNTAxOTM3MzFlYmQ1OWFjZDM4MWVkZWUzZjgzMjIzMjI2OTNhMjBhCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvaW9zL25vLWZv Y3VzLWNoYW5nZS13aGVuLXByZXZlbnRpbmctZGVmYXVsdC1vbi10b3VjaHN0YXJ0LWV4cGVjdGVk LnR4dApAQCAtMCwwICsxLDExIEBACitWZXJpZmllcyB0aGF0IGZvY3VzIGRvZXNuJ3QgbW92ZSBp bnRvIHRoZSBzdWJmcmFtZSB3aGVuIHByZXZlbnREZWZhdWx0KCkgaXMgaW52b2tlZCBvbiB0b3Vj aHN0YXJ0LiBUbyB0ZXN0IG1hbnVhbGx5LCB0YXAgdGhlIGJ1dHRvbiBhbmQgY2hlY2sgdGhhdCB0 aGUgdG9wIGxldmVsIGZyYW1lIGRvZXMgbm90IGxvc2UgZm9jdXMuCisKK09uIHN1Y2Nlc3MsIHlv dSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNU IENPTVBMRVRFIi4KKworCitQQVNTIGRvY3VtZW50LmFjdGl2ZUVsZW1lbnQgaXMgZG9jdW1lbnQu Ym9keQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisK KwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvaW9zL25vLWZvY3Vz LWNoYW5nZS13aGVuLXByZXZlbnRpbmctZGVmYXVsdC1vbi10b3VjaHN0YXJ0Lmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9pb3Mvbm8tZm9jdXMtY2hhbmdlLXdoZW4tcHJldmVu dGluZy1kZWZhdWx0LW9uLXRvdWNoc3RhcnQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zZGM1NzljZmEzZGU1 NTlhNzI1MmQyNzY2MTVhNmNiOTdiM2RjMmExCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9ldmVudHMvdG91Y2gvaW9zL25vLWZvY3VzLWNoYW5nZS13aGVuLXByZXZlbnRpbmct ZGVmYXVsdC1vbi10b3VjaHN0YXJ0Lmh0bWwKQEAgLTAsMCArMSw1MyBAQAorPCFET0NUWVBFIGh0 bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uLy4uL3Jlc291cmNlcy9q cy10ZXN0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi8uLi9yZXNvdXJjZXMv dWktaGVscGVyLmpzIj48L3NjcmlwdD4KKzxzdHlsZT4KK2h0bWwsIGJvZHkgeworICAgIHdpZHRo OiAxMDAlOworICAgIGhlaWdodDogMTAwJTsKKyAgICBtYXJnaW46IDA7Cit9CisKK2lmcmFtZSB7 CisgICAgd2lkdGg6IDMyMHB4OworICAgIGhlaWdodDogMzIwcHg7Cit9Cis8L3N0eWxlPgorPHNj cmlwdD4KKyAgICBqc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKKworICAgIGRlc2NyaXB0aW9uKCJWZXJp ZmllcyB0aGF0IGZvY3VzIGRvZXNuJ3QgbW92ZSBpbnRvIHRoZSBzdWJmcmFtZSB3aGVuIHByZXZl bnREZWZhdWx0KCkgaXMgaW52b2tlZCBvbiB0b3VjaHN0YXJ0LiBUbyB0ZXN0IG1hbnVhbGx5LCB0 YXAgdGhlIGJ1dHRvbiBhbmQgY2hlY2sgdGhhdCB0aGUgdG9wIGxldmVsIGZyYW1lIGRvZXMgbm90 IGxvc2UgZm9jdXMuIik7CisKKyAgICBhZGRFdmVudExpc3RlbmVyKCJibHVyIiwgKCkgPT4gdGVz dEZhaWxlZCgiVG9wIGxldmVsIGZyYW1lIGxvc3QgZm9jdXMuIikpOworICAgIGFkZEV2ZW50TGlz dGVuZXIoImxvYWQiLCBhc3luYyAoKSA9PiB7CisgICAgICAgIGRvY3VtZW50LmJvZHkuYWRkRXZl bnRMaXN0ZW5lcigidG91Y2hzdGFydCIsIGUgPT4gZS5wcmV2ZW50RGVmYXVsdCgpLCB7IHBhc3Np dmU6IGZhbHNlIH0pOworICAgICAgICBpZiAoIXdpbmRvdy50ZXN0UnVubmVyIHx8ICF0ZXN0UnVu bmVyLnJ1blVJU2NyaXB0KQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIGF3YWl0IFVJ SGVscGVyLmFjdGl2YXRlRWxlbWVudChkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCJpZnJhbWUiKSk7 CisgICAgICAgIHNob3VsZEJlKCJkb2N1bWVudC5hY3RpdmVFbGVtZW50IiwgImRvY3VtZW50LmJv ZHkiKTsKKyAgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAgfSk7Cis8L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5PgorICAgIDxpZnJhbWUgc3JjZG9jPSIKKyAgICAgICAgPHN0eWxlPgorICAgICAg ICAgICAgYm9keSwgaHRtbCwgYnV0dG9uIHsKKyAgICAgICAgICAgICAgICB3aWR0aDogMTAwJTsK KyAgICAgICAgICAgICAgICBoZWlnaHQ6IDEwMCU7CisgICAgICAgICAgICB9CisgICAgICAgIDwv c3R5bGU+CisgICAgICAgIDxib2R5PgorICAgICAgICAgICAgPGJ1dHRvbj5UYXAgaGVyZTwvYnV0 dG9uPgorICAgICAgICA8L2JvZHk+CisgICAgICAgIDxzY3JpcHQ+CisgICAgICAgICAgICBkb2N1 bWVudC5ib2R5LmFkZEV2ZW50TGlzdGVuZXIoJ3RvdWNoc3RhcnQnLCBlID0+IGUucHJldmVudERl ZmF1bHQoKSwgeyBwYXNzaXZlOiBmYWxzZSB9KTsKKyAgICAgICAgPC9zY3JpcHQ+CisgICAgIj48 L2lmcmFtZT4KKyAgICA8cHJlIGlkPSJkZXNjcmlwdGlvbiI+PC9wcmU+CisgICAgPHByZSBpZD0i Y29uc29sZSI+PC9wcmU+Cis8L2JvZHk+Cis8L2h0bWw+Cg==