195744 2019-03-14 05:48:47 -0700 [ews-app] Status bubble display pending for currently running build step 2019-03-14 14:51:06 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu jbedard lforschler slewis webkit-bug-importer oldest_to_newest 1516488 0 aakash_jain 2019-03-14 05:48:47 -0700 Status bubble display 'pending' for the step which is currently running (on Buildbot). This is because Buildbot send state_string as 'pending' for step-started event. 1516489 1 364655 aakash_jain 2019-03-14 05:53:20 -0700 Created attachment 364655 Patch 1516500 2 364655 jbedard 2019-03-14 08:11:56 -0700 Comment on attachment 364655 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364655&action=review > Tools/BuildSlaveSupport/ews-build/events.py:164 > + state_string = step.get('state_string') Could this be 'None' (that's what using the .get would imply)? Would that mess things up? 1516530 3 364655 aakash_jain 2019-03-14 10:49:05 -0700 Comment on attachment 364655 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364655&action=review >> Tools/BuildSlaveSupport/ews-build/events.py:164 >> + state_string = step.get('state_string') > > Could this be 'None' (that's what using the .get would imply)? Would that mess things up? state_string should always be present in step data and the value should not be None. Looking into buildbot code this step event data comes from database directly (in https://github.com/buildbot/buildbot/blob/master/master/buildbot/data/steps.py#L125) https://github.com/buildbot/buildbot/blob/master/master/buildbot/db/model.py#L177 specifies that state_string is not nullable. However, in an unexpected case when this is None, it shouldn't mess up things. Buildbot will send that data as is, and Django app should handle it appropriately. I will test and handle that case (state_string or other data being None) on the Django app side. 1516567 4 aakash_jain 2019-03-14 12:00:22 -0700 > However, in an unexpected case when this is None, it shouldn't mess up things. Buildbot will send that data as is, and Django app should handle it appropriately. I will test and handle that case (state_string or other data being None) on the Django app side. Handling that in ews-app in https://bugs.webkit.org/show_bug.cgi?id=195753 1516571 5 jbedard 2019-03-14 12:03:09 -0700 (In reply to Aakash Jain from comment #4) > > However, in an unexpected case when this is None, it shouldn't mess up things. Buildbot will send that data as is, and Django app should handle it appropriately. I will test and handle that case (state_string or other data being None) on the Django app side. > Handling that in ews-app in https://bugs.webkit.org/show_bug.cgi?id=195753 This seems a reasonable way to handle this problem. 1516647 6 364655 commit-queue 2019-03-14 14:33:52 -0700 Comment on attachment 364655 Patch Clearing flags on attachment: 364655 Committed r242965: <https://trac.webkit.org/changeset/242965> 1516648 7 commit-queue 2019-03-14 14:33:53 -0700 All reviewed patches have been landed. Closing bug. 1516663 8 webkit-bug-importer 2019-03-14 14:51:06 -0700 <rdar://problem/48902762> 364655 2019-03-14 05:53:20 -0700 2019-03-14 14:33:52 -0700 Patch bug-195744-20190314085335.patch text/plain 1757 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Mjk0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTAzLTE0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gU3RhdHVzIGJ1YmJsZSBkaXNwbGF5IHBlbmRpbmcgZm9y IGN1cnJlbnRseSBydW5uaW5nIGJ1aWxkIHN0ZXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTc0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2V2ZW50 cy5weToKKyAgICAgICAgKEV2ZW50cy5zdGVwU3RhcnRlZCk6IElmIHN0YXRlX3N0cmluZyBpcyBw ZW5kaW5nLCByZXBsYWNlIGl0IHdpdGggc3RlcCBuYW1lLgorCiAyMDE5LTAzLTEzICBXZW5zb24g SHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgLVtfV0tBdHRh Y2htZW50IHNldEZpbGVXcmFwcGVyOmNvbnRlbnRUeXBlOmNvbXBsZXRpb246XSByb2J1c3Qgd2hl biBnaXZlbiBhIG5pbCBjb21wbGV0aW9uIGhhbmRsZXIKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1idWlsZC9ldmVudHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWJ1aWxkL2V2ZW50cy5weQkocmV2aXNpb24gMjQyOTQxKQorKysgVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2V2ZW50cy5weQkod29ya2luZyBjb3B5KQpAQCAt MTYxLDYgKzE2MSwxMCBAQCBjbGFzcyBFdmVudHMoc2VydmljZS5CdWlsZGJvdFNlcnZpY2UpOgog ICAgICAgICBzZWxmLnNlbmREYXRhKGRhdGEpCiAKICAgICBkZWYgc3RlcFN0YXJ0ZWQoc2VsZiwg a2V5LCBzdGVwKToKKyAgICAgICAgc3RhdGVfc3RyaW5nID0gc3RlcC5nZXQoJ3N0YXRlX3N0cmlu ZycpCisgICAgICAgIGlmIHN0YXRlX3N0cmluZyA9PSAncGVuZGluZyc6CisgICAgICAgICAgICBz dGF0ZV9zdHJpbmcgPSAnUnVubmluZyB7fScuZm9ybWF0KHN0ZXAuZ2V0KCduYW1lJykpCisKICAg ICAgICAgZGF0YSA9IHsKICAgICAgICAgICAgICJ0eXBlIjogc2VsZi50eXBlX3ByZWZpeCArICJz dGVwIiwKICAgICAgICAgICAgICJzdGF0dXMiOiAic3RhcnRlZCIsCkBAIC0xNjgsNyArMTcyLDcg QEAgY2xhc3MgRXZlbnRzKHNlcnZpY2UuQnVpbGRib3RTZXJ2aWNlKToKICAgICAgICAgICAgICJz dGVwX2lkIjogc3RlcC5nZXQoJ3N0ZXBpZCcpLAogICAgICAgICAgICAgImJ1aWxkX2lkIjogc3Rl cC5nZXQoJ2J1aWxkaWQnKSwKICAgICAgICAgICAgICJyZXN1bHQiOiBzdGVwLmdldCgncmVzdWx0 cycpLAotICAgICAgICAgICAgInN0YXRlX3N0cmluZyI6IHN0ZXAuZ2V0KCdzdGF0ZV9zdHJpbmcn KSwKKyAgICAgICAgICAgICJzdGF0ZV9zdHJpbmciOiBzdGF0ZV9zdHJpbmcsCiAgICAgICAgICAg ICAic3RhcnRlZF9hdCI6IHN0ZXAuZ2V0KCdzdGFydGVkX2F0JyksCiAgICAgICAgICAgICAiY29t cGxldGVfYXQiOiBzdGVwLmdldCgnY29tcGxldGVfYXQnKSwKICAgICAgICAgfQo=