195742 2019-03-14 05:16:52 -0700 [WPE] Confusing messages in stderr when surfaceless context is not supported 2019-03-21 02:44:28 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned aperez bugs-noreply magomez zan oldest_to_newest 1516485 0 cgarcia 2019-03-14 05:16:52 -0700 Cannot create EGL surfaceless context: missing EGL_KHR_surfaceless_{context,opengl} extension. Cannot create EGL WPE context: EGL_SUCCESS It seems like there's anything wrong, while there isn't. It's also confusing an error message where the error is EGL_SUCCESS. I think we should not show those messages at all, not suporting surfaceless contexts is not an error and it's correctly handled. Failing to get a native window handle from render backend offscreen egl target is not an error either, since most of the backend don't implement the interface (they actually have an empty implementation). 1516486 1 364654 cgarcia 2019-03-14 05:24:13 -0700 Created attachment 364654 Patch 1516730 2 aperez 2019-03-14 16:09:35 -0700 (In reply to Carlos Garcia Campos from comment #0) > Cannot create EGL surfaceless context: missing > EGL_KHR_surfaceless_{context,opengl} extension. > Cannot create EGL WPE context: EGL_SUCCESS > > It seems like there's anything wrong, while there isn't. > [...] I have to admit the first time I noticed these messages they were indeed confusing; it will be good to just go ahead and remove them, IMO. 1516965 3 364654 zan 2019-03-15 07:48:52 -0700 Comment on attachment 364654 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364654&action=review > Source/WebCore/platform/graphics/egl/GLContextEGLLibWPE.cpp:77 > + if (context == EGL_NO_CONTEXT) { > + WTFLogAlways("Cannot create EGL WPE context: %s\n", lastErrorString()); > + return nullptr; > + } This needs to destroy the offscreen target before returning early. 1516974 4 364654 cgarcia 2019-03-15 08:27:39 -0700 Comment on attachment 364654 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364654&action=review >> Source/WebCore/platform/graphics/egl/GLContextEGLLibWPE.cpp:77 >> + } > > This needs to destroy the offscreen target before returning early. Right! I fixed the context leak to introduce a target leak :-P 1518850 5 365341 cgarcia 2019-03-20 05:54:38 -0700 Created attachment 365341 Patch 1519579 6 cgarcia 2019-03-21 02:44:28 -0700 Committed r243284: <https://trac.webkit.org/changeset/243284> 364654 2019-03-14 05:24:13 -0700 2019-03-20 05:54:38 -0700 Patch wpe-no-surfaceless.diff text/plain 4676 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZDQ1YzNhZTM1NS4uMjNjMTkxOWJiZGUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOCBAQAorMjAxOS0wMy0xNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gQ29uZnVzaW5nIG1lc3NhZ2VzIGluIHN0ZGVyciB3 aGVuIHN1cmZhY2VsZXNzIGNvbnRleHQgaXMgbm90IHN1cHBvcnRlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1NzQyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG1lc3NhZ2VzIHNob3duIGFyZToK KworICAgICAgICBDYW5ub3QgY3JlYXRlIEVHTCBzdXJmYWNlbGVzcyBjb250ZXh0OiBtaXNzaW5n IEVHTF9LSFJfc3VyZmFjZWxlc3Nfe2NvbnRleHQsb3BlbmdsfSBleHRlbnNpb24uCisgICAgICAg IENhbm5vdCBjcmVhdGUgRUdMIFdQRSBjb250ZXh0OiBFR0xfU1VDQ0VTUworCisgICAgICAgIEl0 IHNlZW1zIGxpa2UgdGhlcmUncyBhbnl0aGluZyB3cm9uZywgd2hpbGUgdGhlcmUgaXNuJ3QuIEl0 J3MgYWxzbyBjb25mdXNpbmcgYW4gZXJyb3IgbWVzc2FnZSB3aGVyZSB0aGUgZXJyb3IgaXMKKyAg ICAgICAgRUdMX1NVQ0NFU1MuIEkgdGhpbmsgd2Ugc2hvdWxkIG5vdCBzaG93IHRob3NlIG1lc3Nh Z2VzIGF0IGFsbCwgbm90IHN1cG9ydGluZyBzdXJmYWNlbGVzcyBjb250ZXh0cyBpcyBub3QgYW4K KyAgICAgICAgZXJyb3IgYW5kIGl0J3MgY29ycmVjdGx5IGhhbmRsZWQuIEZhaWxpbmcgdG8gZ2V0 IGEgbmF0aXZlIHdpbmRvdyBoYW5kbGUgZnJvbSByZW5kZXIgYmFja2VuZCBvZmZzY3JlZW4gZWds IHRhcmdldAorICAgICAgICBpcyBub3QgYW4gZXJyb3IgZWl0aGVyLCBzaW5jZSBtb3N0IG9mIHRo ZSBiYWNrZW5kcyBkb24ndCBpbXBsZW1lbnQgdGhlIGludGVyZmFjZSAodGhleSBhY3R1YWxseSBo YXZlIGFuIGVtcHR5CisgICAgICAgIGltcGxlbWVudGF0aW9uKS4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R0xD b250ZXh0RUdMOjpjcmVhdGVTdXJmYWNlbGVzc0NvbnRleHQpOiBSZW1vdmUgdGhlIG1lc3NhZ2Ug d2hlbiBleHRlbnNpb25zIGFyZSBub3QgcHJlc2VudAorICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2VnbC9HTENvbnRleHRFR0xMaWJXUEUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R0xDb250 ZXh0RUdMOjpjcmVhdGVXUEVDb250ZXh0KTogSGFuZGxlIHRoZSBjYXNlIG9mIHdwZV9yZW5kZXJl cl9iYWNrZW5kX2VnbF9vZmZzY3JlZW5fdGFyZ2V0X2NyZWF0ZSgpCisgICAgICAgIHJldHVybmlu ZyBudWxscHRyLCB3aGljaCBjYW4gaGFwcGVuIGlmIHRoZSBiYWNrZW5kIGRvZXNuJ3QgaW1wbGVt ZW50IHRoZSBpbnRlcmZhY2UuIE1vdmUgdGhlIGNvbnRleHQgY3JlYXRpb24KKyAgICAgICAgYWZ0 ZXIgdGhlIHRhcmdldCBpbml0aWFsaXphdGlvbiwgdG8gYXZvaWQgbGVha2luZyB0aGUgY29udGV4 dCB3aGVuIHRoZSB0YXJnZXQgZG9lc24ndCBoYXZlIGEgbmF0aXZlIHdpbmRvdy4KKwogMjAxOS0w My0xMyAgTWlndWVsIEdvbWV6ICA8bWFnb21lekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtDb29y ZGluYXRlZEdyYXBoaWNzXSBOdWxsIGRlcmVmZXJlbmNlIGluIENvb3JkaW5hdGVkR3JhcGhpY3NM YXllcjo6c2V0Q29vcmRpbmF0b3JJbmNsdWRpbmdTdWJMYXllcnNJZk5lZWRlZApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xDb250ZXh0RUdMLmNwcApp bmRleCA0MmJhYTY0ZDc3MC4uNzMyMTM3YzZiOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3BwCkBAIC0yMzMsMTAgKzIz Myw4IEBAIHN0ZDo6dW5pcXVlX3B0cjxHTENvbnRleHRFR0w+IEdMQ29udGV4dEVHTDo6Y3JlYXRl U3VyZmFjZWxlc3NDb250ZXh0KFBsYXRmb3JtRGlzCiAgICAgfQogCiAgICAgY29uc3QgY2hhciog ZXh0ZW5zaW9ucyA9IGVnbFF1ZXJ5U3RyaW5nKGRpc3BsYXksIEVHTF9FWFRFTlNJT05TKTsKLSAg ICBpZiAoIUdMQ29udGV4dDo6aXNFeHRlbnNpb25TdXBwb3J0ZWQoZXh0ZW5zaW9ucywgIkVHTF9L SFJfc3VyZmFjZWxlc3NfY29udGV4dCIpICYmICFHTENvbnRleHQ6OmlzRXh0ZW5zaW9uU3VwcG9y dGVkKGV4dGVuc2lvbnMsICJFR0xfS0hSX3N1cmZhY2VsZXNzX29wZW5nbCIpKSB7Ci0gICAgICAg IFdURkxvZ0Fsd2F5cygiQ2Fubm90IGNyZWF0ZSBFR0wgc3VyZmFjZWxlc3MgY29udGV4dDogbWlz c2luZyBFR0xfS0hSX3N1cmZhY2VsZXNzX3tjb250ZXh0LG9wZW5nbH0gZXh0ZW5zaW9uLlxuIik7 CisgICAgaWYgKCFHTENvbnRleHQ6OmlzRXh0ZW5zaW9uU3VwcG9ydGVkKGV4dGVuc2lvbnMsICJF R0xfS0hSX3N1cmZhY2VsZXNzX2NvbnRleHQiKSAmJiAhR0xDb250ZXh0Ojppc0V4dGVuc2lvblN1 cHBvcnRlZChleHRlbnNpb25zLCAiRUdMX0tIUl9zdXJmYWNlbGVzc19vcGVuZ2wiKSkKICAgICAg ICAgcmV0dXJuIG51bGxwdHI7Ci0gICAgfQogCiAgICAgRUdMQ29uZmlnIGNvbmZpZzsKICAgICBp ZiAoIWdldEVHTENvbmZpZyhkaXNwbGF5LCAmY29uZmlnLCBTdXJmYWNlbGVzcykpIHsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0xM aWJXUEUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4 dEVHTExpYldQRS5jcHAKaW5kZXggZDk4ODA5ZmU3YWQuLmQxODZiNDZmZjUzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xDb250ZXh0RUdMTGliV1BF LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xDb250ZXh0 RUdMTGliV1BFLmNwcApAQCAtNTksMjEgKzU5LDIzIEBAIHN0ZDo6dW5pcXVlX3B0cjxHTENvbnRl eHRFR0w+IEdMQ29udGV4dEVHTDo6Y3JlYXRlV1BFQ29udGV4dChQbGF0Zm9ybURpc3BsYXkmIHBs CiAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIH0KIAotICAgIEVHTENvbnRleHQgY29udGV4 dCA9IGNyZWF0ZUNvbnRleHRGb3JFR0xWZXJzaW9uKHBsYXRmb3JtRGlzcGxheSwgY29uZmlnLCBz aGFyaW5nQ29udGV4dCk7Ci0gICAgaWYgKGNvbnRleHQgPT0gRUdMX05PX0NPTlRFWFQpIHsKLSAg ICAgICAgV1RGTG9nQWx3YXlzKCJDYW5ub3QgY3JlYXRlIEVHTCBXUEUgY29udGV4dDogJXNcbiIs IGxhc3RFcnJvclN0cmluZygpKTsKKyAgICBhdXRvKiB0YXJnZXQgPSB3cGVfcmVuZGVyZXJfYmFj a2VuZF9lZ2xfb2Zmc2NyZWVuX3RhcmdldF9jcmVhdGUoKTsKKyAgICBpZiAoIXRhcmdldCkKICAg ICAgICAgcmV0dXJuIG51bGxwdHI7Ci0gICAgfQogCi0gICAgYXV0byogdGFyZ2V0ID0gd3BlX3Jl bmRlcmVyX2JhY2tlbmRfZWdsX29mZnNjcmVlbl90YXJnZXRfY3JlYXRlKCk7CiAgICAgd3BlX3Jl bmRlcmVyX2JhY2tlbmRfZWdsX29mZnNjcmVlbl90YXJnZXRfaW5pdGlhbGl6ZSh0YXJnZXQsIGRv d25jYXN0PFBsYXRmb3JtRGlzcGxheUxpYldQRT4ocGxhdGZvcm1EaXNwbGF5KS5iYWNrZW5kKCkp OwogICAgIEVHTE5hdGl2ZVdpbmRvd1R5cGUgd2luZG93ID0gd3BlX3JlbmRlcmVyX2JhY2tlbmRf ZWdsX29mZnNjcmVlbl90YXJnZXRfZ2V0X25hdGl2ZV93aW5kb3codGFyZ2V0KTsKICAgICBpZiAo IXdpbmRvdykgewotICAgICAgICBXVEZMb2dBbHdheXMoIkNhbm5vdCBjcmVhdGUgRUdMIFdQRSBj b250ZXh0OiAlc1xuIiwgbGFzdEVycm9yU3RyaW5nKCkpOwogICAgICAgICB3cGVfcmVuZGVyZXJf YmFja2VuZF9lZ2xfb2Zmc2NyZWVuX3RhcmdldF9kZXN0cm95KHRhcmdldCk7CiAgICAgICAgIHJl dHVybiBudWxscHRyOwogICAgIH0KIAorICAgIEVHTENvbnRleHQgY29udGV4dCA9IGNyZWF0ZUNv bnRleHRGb3JFR0xWZXJzaW9uKHBsYXRmb3JtRGlzcGxheSwgY29uZmlnLCBzaGFyaW5nQ29udGV4 dCk7CisgICAgaWYgKGNvbnRleHQgPT0gRUdMX05PX0NPTlRFWFQpIHsKKyAgICAgICAgV1RGTG9n QWx3YXlzKCJDYW5ub3QgY3JlYXRlIEVHTCBXUEUgY29udGV4dDogJXNcbiIsIGxhc3RFcnJvclN0 cmluZygpKTsKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CisgICAgfQorCiAgICAgRUdMU3VyZmFj ZSBzdXJmYWNlID0gZWdsQ3JlYXRlV2luZG93U3VyZmFjZShkaXNwbGF5LCBjb25maWcsIHN0YXRp Y19jYXN0PEVHTE5hdGl2ZVdpbmRvd1R5cGU+KHdpbmRvdyksIG51bGxwdHIpOwogICAgIGlmIChz dXJmYWNlID09IEVHTF9OT19TVVJGQUNFKSB7CiAgICAgICAgIFdURkxvZ0Fsd2F5cygiQ2Fubm90 IGNyZWF0ZSBFR0wgV1BFIHdpbmRvdyBzdXJmYWNlOiAlc1xuIiwgbGFzdEVycm9yU3RyaW5nKCkp Owo= 365341 2019-03-20 05:54:38 -0700 2019-03-21 01:21:29 -0700 Patch wpe-error-messages.diff text/plain 4391 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4YTkwMjFhNjJmYy4uMDkyMDYzNDFiNTIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOCBAQAorMjAxOS0wMy0xNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gQ29uZnVzaW5nIG1lc3NhZ2VzIGluIHN0ZGVyciB3 aGVuIHN1cmZhY2VsZXNzIGNvbnRleHQgaXMgbm90IHN1cHBvcnRlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1NzQyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG1lc3NhZ2VzIHNob3duIGFyZToK KworICAgICAgICBDYW5ub3QgY3JlYXRlIEVHTCBzdXJmYWNlbGVzcyBjb250ZXh0OiBtaXNzaW5n IEVHTF9LSFJfc3VyZmFjZWxlc3Nfe2NvbnRleHQsb3BlbmdsfSBleHRlbnNpb24uCisgICAgICAg IENhbm5vdCBjcmVhdGUgRUdMIFdQRSBjb250ZXh0OiBFR0xfU1VDQ0VTUworCisgICAgICAgIEl0 IHNlZW1zIGxpa2UgdGhlcmUncyBhbnl0aGluZyB3cm9uZywgd2hpbGUgdGhlcmUgaXNuJ3QuIEl0 J3MgYWxzbyBjb25mdXNpbmcgYW4gZXJyb3IgbWVzc2FnZSB3aGVyZSB0aGUgZXJyb3IgaXMKKyAg ICAgICAgRUdMX1NVQ0NFU1MuIEkgdGhpbmsgd2Ugc2hvdWxkIG5vdCBzaG93IHRob3NlIG1lc3Nh Z2VzIGF0IGFsbCwgbm90IHN1cG9ydGluZyBzdXJmYWNlbGVzcyBjb250ZXh0cyBpcyBub3QgYW4K KyAgICAgICAgZXJyb3IgYW5kIGl0J3MgY29ycmVjdGx5IGhhbmRsZWQuIEZhaWxpbmcgdG8gZ2V0 IGEgbmF0aXZlIHdpbmRvdyBoYW5kbGUgZnJvbSByZW5kZXIgYmFja2VuZCBvZmZzY3JlZW4gZWds IHRhcmdldAorICAgICAgICBpcyBub3QgYW4gZXJyb3IgZWl0aGVyLCBzaW5jZSBtb3N0IG9mIHRo ZSBiYWNrZW5kcyBkb24ndCBpbXBsZW1lbnQgdGhlIGludGVyZmFjZSAodGhleSBhY3R1YWxseSBo YXZlIGFuIGVtcHR5CisgICAgICAgIGltcGxlbWVudGF0aW9uKS4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R0xD b250ZXh0RUdMOjpjcmVhdGVTdXJmYWNlbGVzc0NvbnRleHQpOiBSZW1vdmUgdGhlIG1lc3NhZ2Ug d2hlbiBleHRlbnNpb25zIGFyZSBub3QgcHJlc2VudAorICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2VnbC9HTENvbnRleHRFR0xMaWJXUEUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R0xDb250 ZXh0RUdMOjpjcmVhdGVXUEVDb250ZXh0KTogSGFuZGxlIHRoZSBjYXNlIG9mIHdwZV9yZW5kZXJl cl9iYWNrZW5kX2VnbF9vZmZzY3JlZW5fdGFyZ2V0X2NyZWF0ZSgpCisgICAgICAgIHJldHVybmlu ZyBudWxscHRyLCB3aGljaCBjYW4gaGFwcGVuIGlmIHRoZSBiYWNrZW5kIGRvZXNuJ3QgaW1wbGVt ZW50IHRoZSBpbnRlcmZhY2UuIE1vdmUgdGhlIGNvbnRleHQgY3JlYXRpb24KKyAgICAgICAgYWZ0 ZXIgdGhlIHRhcmdldCBpbml0aWFsaXphdGlvbiwgdG8gYXZvaWQgbGVha2luZyB0aGUgY29udGV4 dCB3aGVuIHRoZSB0YXJnZXQgZG9lc24ndCBoYXZlIGEgbmF0aXZlIHdpbmRvdy4KKwogMjAxOS0w My0yMCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0dTdHJlYW1lcl0gU3dpdGNoIGJhY2sgdG8gd2Via2l0d2Vic3JjIGZvciBhZGFwdGl2ZSBzdHJl YW1pbmcgZnJhZ21lbnRzIGRvd25sb2FkaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xDb250ZXh0RUdMLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3BwCmluZGV4IDQyYmFhNjRkNzcwLi43 MzIxMzdjNmI5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv ZWdsL0dMQ29udGV4dEVHTC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZWdsL0dMQ29udGV4dEVHTC5jcHAKQEAgLTIzMywxMCArMjMzLDggQEAgc3RkOjp1bmlxdWVf cHRyPEdMQ29udGV4dEVHTD4gR0xDb250ZXh0RUdMOjpjcmVhdGVTdXJmYWNlbGVzc0NvbnRleHQo UGxhdGZvcm1EaXMKICAgICB9CiAKICAgICBjb25zdCBjaGFyKiBleHRlbnNpb25zID0gZWdsUXVl cnlTdHJpbmcoZGlzcGxheSwgRUdMX0VYVEVOU0lPTlMpOwotICAgIGlmICghR0xDb250ZXh0Ojpp c0V4dGVuc2lvblN1cHBvcnRlZChleHRlbnNpb25zLCAiRUdMX0tIUl9zdXJmYWNlbGVzc19jb250 ZXh0IikgJiYgIUdMQ29udGV4dDo6aXNFeHRlbnNpb25TdXBwb3J0ZWQoZXh0ZW5zaW9ucywgIkVH TF9LSFJfc3VyZmFjZWxlc3Nfb3BlbmdsIikpIHsKLSAgICAgICAgV1RGTG9nQWx3YXlzKCJDYW5u b3QgY3JlYXRlIEVHTCBzdXJmYWNlbGVzcyBjb250ZXh0OiBtaXNzaW5nIEVHTF9LSFJfc3VyZmFj ZWxlc3Nfe2NvbnRleHQsb3BlbmdsfSBleHRlbnNpb24uXG4iKTsKKyAgICBpZiAoIUdMQ29udGV4 dDo6aXNFeHRlbnNpb25TdXBwb3J0ZWQoZXh0ZW5zaW9ucywgIkVHTF9LSFJfc3VyZmFjZWxlc3Nf Y29udGV4dCIpICYmICFHTENvbnRleHQ6OmlzRXh0ZW5zaW9uU3VwcG9ydGVkKGV4dGVuc2lvbnMs ICJFR0xfS0hSX3N1cmZhY2VsZXNzX29wZW5nbCIpKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsK LSAgICB9CiAKICAgICBFR0xDb25maWcgY29uZmlnOwogICAgIGlmICghZ2V0RUdMQ29uZmlnKGRp c3BsYXksICZjb25maWcsIFN1cmZhY2VsZXNzKSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTExpYldQRS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xDb250ZXh0RUdMTGliV1BFLmNwcAppbmRl eCBkOTg4MDlmZTdhZC4uMWVkYjVmYWRkNzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0xMaWJXUEUuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0xMaWJXUEUuY3BwCkBAIC01 OSwxNiArNTksMTkgQEAgc3RkOjp1bmlxdWVfcHRyPEdMQ29udGV4dEVHTD4gR0xDb250ZXh0RUdM OjpjcmVhdGVXUEVDb250ZXh0KFBsYXRmb3JtRGlzcGxheSYgcGwKICAgICAgICAgcmV0dXJuIG51 bGxwdHI7CiAgICAgfQogCi0gICAgRUdMQ29udGV4dCBjb250ZXh0ID0gY3JlYXRlQ29udGV4dEZv ckVHTFZlcnNpb24ocGxhdGZvcm1EaXNwbGF5LCBjb25maWcsIHNoYXJpbmdDb250ZXh0KTsKLSAg ICBpZiAoY29udGV4dCA9PSBFR0xfTk9fQ09OVEVYVCkgewotICAgICAgICBXVEZMb2dBbHdheXMo IkNhbm5vdCBjcmVhdGUgRUdMIFdQRSBjb250ZXh0OiAlc1xuIiwgbGFzdEVycm9yU3RyaW5nKCkp OworICAgIGF1dG8qIHRhcmdldCA9IHdwZV9yZW5kZXJlcl9iYWNrZW5kX2VnbF9vZmZzY3JlZW5f dGFyZ2V0X2NyZWF0ZSgpOworICAgIGlmICghdGFyZ2V0KQogICAgICAgICByZXR1cm4gbnVsbHB0 cjsKLSAgICB9CiAKLSAgICBhdXRvKiB0YXJnZXQgPSB3cGVfcmVuZGVyZXJfYmFja2VuZF9lZ2xf b2Zmc2NyZWVuX3RhcmdldF9jcmVhdGUoKTsKICAgICB3cGVfcmVuZGVyZXJfYmFja2VuZF9lZ2xf b2Zmc2NyZWVuX3RhcmdldF9pbml0aWFsaXplKHRhcmdldCwgZG93bmNhc3Q8UGxhdGZvcm1EaXNw bGF5TGliV1BFPihwbGF0Zm9ybURpc3BsYXkpLmJhY2tlbmQoKSk7CiAgICAgRUdMTmF0aXZlV2lu ZG93VHlwZSB3aW5kb3cgPSB3cGVfcmVuZGVyZXJfYmFja2VuZF9lZ2xfb2Zmc2NyZWVuX3Rhcmdl dF9nZXRfbmF0aXZlX3dpbmRvdyh0YXJnZXQpOwogICAgIGlmICghd2luZG93KSB7CisgICAgICAg IHdwZV9yZW5kZXJlcl9iYWNrZW5kX2VnbF9vZmZzY3JlZW5fdGFyZ2V0X2Rlc3Ryb3kodGFyZ2V0 KTsKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CisgICAgfQorCisgICAgRUdMQ29udGV4dCBjb250 ZXh0ID0gY3JlYXRlQ29udGV4dEZvckVHTFZlcnNpb24ocGxhdGZvcm1EaXNwbGF5LCBjb25maWcs IHNoYXJpbmdDb250ZXh0KTsKKyAgICBpZiAoY29udGV4dCA9PSBFR0xfTk9fQ09OVEVYVCkgewog ICAgICAgICBXVEZMb2dBbHdheXMoIkNhbm5vdCBjcmVhdGUgRUdMIFdQRSBjb250ZXh0OiAlc1xu IiwgbGFzdEVycm9yU3RyaW5nKCkpOwogICAgICAgICB3cGVfcmVuZGVyZXJfYmFja2VuZF9lZ2xf b2Zmc2NyZWVuX3RhcmdldF9kZXN0cm95KHRhcmdldCk7CiAgICAgICAgIHJldHVybiBudWxscHRy Owo=