195725 2019-03-13 19:04:49 -0700 Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler 2019-03-13 20:59:29 -0700 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aestes bdakin commit-queue thorton webkit-bug-importer oldest_to_newest 1516334 0 wenson_hsieh 2019-03-13 19:04:49 -0700 <rdar://problem/48545062> 1516358 1 364615 wenson_hsieh 2019-03-13 20:05:38 -0700 Created attachment 364615 Patch 1516376 2 364615 commit-queue 2019-03-13 20:59:27 -0700 Comment on attachment 364615 Patch Clearing flags on attachment: 364615 Committed r242934: <https://trac.webkit.org/changeset/242934> 1516377 3 commit-queue 2019-03-13 20:59:29 -0700 All reviewed patches have been landed. Closing bug. 364615 2019-03-13 20:05:38 -0700 2019-03-13 20:59:27 -0700 Patch bug-195725-20190313200537.patch text/plain 5038 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyOTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU0OGNjODlhZmZhNjMwNTNi YmM2OGQ3OTRiYzJmYzliZWNkYWE3NGIuLjAwYWE1MmIxNzViMzdjODczNDYzOTlkNTkwODNiOWE2 N2UwY2I1ODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTktMDMtMTMgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSAtW19XS0F0dGFj aG1lbnQgc2V0RmlsZVdyYXBwZXI6Y29udGVudFR5cGU6Y29tcGxldGlvbjpdIHJvYnVzdCB3aGVu IGdpdmVuIGEgbmlsIGNvbXBsZXRpb24gaGFuZGxlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1NzI1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80 ODU0NTA2Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgYSBtaXNzaW5nIG5pbCBjaGVjayBiZWZvcmUgaW52b2tpbmcgdGhlIGdpdmVuIGNvbXBs ZXRpb25IYW5kbGVyIGluIHRoZSBjYXNlIHdoZXJlIHRoZSBhdHRhY2htZW50IGlzIGludmFsaWQu CisgICAgICAgIFRlc3RlZCBieSBhdWdtZW50aW5nIFdLQXR0YWNobWVudFRlc3RzLlNldEZpbGVX cmFwcGVyRm9yUERGSW1hZ2VBdHRhY2htZW50IHRvIGV4ZXJjaXNlIHRoaXMgc2NlbmFyaW8uCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0FQSUF0dGFjaG1lbnQuY3BwOgorICAgICAgICAoQVBJ OjpBdHRhY2htZW50OjppbnZhbGlkYXRlKToKKworICAgICAgICBBZGRpdGlvbmFsbHkgbWFrZSBz dXJlIHRoYXQgYW4gaW52YWxpZGF0ZWQgX1dLQXR0YWNobWVudCBpcyBhbHNvIGNvbnNpZGVyZWQg dG8gYmUgZGlzY29ubmVjdGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tB dHRhY2htZW50Lm1tOgorICAgICAgICAoLVtfV0tBdHRhY2htZW50IHNldEZpbGVXcmFwcGVyOmNv bnRlbnRUeXBlOmNvbXBsZXRpb246XSk6CisKIDIwMTktMDMtMTMgIFRpbW90aHkgSGF0Y2hlciAg PHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgc3BlY3VsYXRpdmUgYnVp bGQgZml4IGZvciB3YXRjaE9TIGFmdGVyIHIyNDI5MDguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvQVBJQXR0YWNobWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvQVBJQXR0YWNobWVudC5jcHAKaW5kZXggYTBiMmVmN2U4NWZhNjZlNDg2MzIxODQ3 NmUwZDY0YTM2Y2I2MjlkMy4uZjlhNGNhZGZhZTE0YjgwYzQwYjA4Y2M4NzhmZmQ1ZTQxMDFjMWNm ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0FQSUF0dGFjaG1lbnQu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9BUElBdHRhY2htZW50LmNwcApA QCAtNzIsNiArNzIsNyBAQCB2b2lkIEF0dGFjaG1lbnQ6OmludmFsaWRhdGUoKQogI2lmIFBMQVRG T1JNKENPQ09BKQogICAgIG1fZmlsZVdyYXBwZXIuY2xlYXIoKTsKICNlbmRpZgorICAgIG1faW5z ZXJ0aW9uU3RhdGUgPSBJbnNlcnRpb25TdGF0ZTo6Tm90SW5zZXJ0ZWQ7CiB9CiAKICNpZiAhUExB VEZPUk0oQ09DT0EpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29j b2EvX1dLQXR0YWNobWVudC5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9f V0tBdHRhY2htZW50Lm1tCmluZGV4IDAxMmQ2M2FmNzQyYTFiZWJkODQzOWFhMzUyZDBmMWEyODNh ZDJjZDQuLjQ1NDk2MDU1NzZhYWEyMzVmMTNkZTZkYjg2M2Q0MDA2M2RkZDNiMmUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tBdHRhY2htZW50Lm1tCisr KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tBdHRhY2htZW50Lm1tCkBA IC0xMjMsNyArMTIzLDggQEAgLSAodm9pZClyZXF1ZXN0SW5mbzoodm9pZCheKShfV0tBdHRhY2ht ZW50SW5mbyAqLCBOU0Vycm9yICopKWNvbXBsZXRpb25IYW5kbGVyCiAtICh2b2lkKXNldEZpbGVX cmFwcGVyOihOU0ZpbGVXcmFwcGVyICopZmlsZVdyYXBwZXIgY29udGVudFR5cGU6KE5TU3RyaW5n ICopY29udGVudFR5cGUgY29tcGxldGlvbjoodm9pZCAoXikoTlNFcnJvciAqKSljb21wbGV0aW9u SGFuZGxlcgogewogICAgIGlmICghX2F0dGFjaG1lbnQtPmlzVmFsaWQoKSkgewotICAgICAgICBj b21wbGV0aW9uSGFuZGxlcihbTlNFcnJvciBlcnJvcldpdGhEb21haW46V0tFcnJvckRvbWFpbiBj b2RlOkludmFsaWRBdHRhY2htZW50RXJyb3JDb2RlIHVzZXJJbmZvOm5pbF0pOworICAgICAgICBp ZiAoY29tcGxldGlvbkhhbmRsZXIpCisgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihbTlNF cnJvciBlcnJvcldpdGhEb21haW46V0tFcnJvckRvbWFpbiBjb2RlOkludmFsaWRBdHRhY2htZW50 RXJyb3JDb2RlIHVzZXJJbmZvOm5pbF0pOwogICAgICAgICByZXR1cm47CiAgICAgfQogCmRpZmYg LS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmFjZmZkYmIx ODlhZTVmMzE2NDg5MDcxODYyNGE2MTE2ZmI4NDQwNS4uZjgyNTk3MGI5OTYzMmY4NWE4NTRiYjdm NjZhNzc2YzA5YzIyNDk3MCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTAzLTEzICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgLVtfV0tBdHRhY2htZW50IHNl dEZpbGVXcmFwcGVyOmNvbnRlbnRUeXBlOmNvbXBsZXRpb246XSByb2J1c3Qgd2hlbiBnaXZlbiBh IG5pbCBjb21wbGV0aW9uIGhhbmRsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NTcyNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDg1NDUwNjI+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdCB0 aGF0IHdlIGRvbid0IGNyYXNoIHdoZW4gY2hhbmdpbmcgdGhlIGZpbGUgd3JhcHBlciBvZiBhbiBp bnZhbGlkIGF0dGFjaG1lbnQsIGlmIHRoZSBnaXZlbiBjb21wbGV0aW9uCisgICAgICAgIGhhbmRs ZXIgaXMgbmlsLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9X S0F0dGFjaG1lbnRUZXN0cy5tbToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAy MDE5LTAzLTEzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVXNl IGEgU2VydmljZVdvcmtlciBwcm9jZXNzIHBlciByZWdpc3RyYWJsZSBkb21haW4KZGlmZiAtLWdp dCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tBdHRhY2htZW50VGVz dHMubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dLQXR0YWNobWVu dFRlc3RzLm1tCmluZGV4IGZlNTVhNjAzZTQ2M2Y4NjliYTAxNTM2N2M3MzBkN2E3ZGY5MGIzMjMu LjU4N2M1MzlmMjZlMWNhMGJhODgzYTkxZGY1YzEwNzNjNzdjMWFhZjAgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tBdHRhY2htZW50VGVzdHMubW0K KysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XS0F0dGFjaG1lbnRU ZXN0cy5tbQpAQCAtMTQ3OCwxMSArMTQ3OCwxNyBAQCBURVNUKFdLQXR0YWNobWVudFRlc3RzLCBT ZXRGaWxlV3JhcHBlckZvclBERkltYWdlQXR0YWNobWVudCkKICAgICBhdXRvIHdlYlZpZXcgPSB3 ZWJWaWV3Rm9yVGVzdGluZ0F0dGFjaG1lbnRzKCk7CiAgICAgW3dlYlZpZXcgZXZhbHVhdGVKYXZh U2NyaXB0OkAiZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZCgpIiBjb21wbGV0aW9uSGFuZGxlcjpu aWxdOwogICAgIE5TU3RyaW5nICppZGVudGlmaWVyID0gW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0 aW5nSmF2YVNjcmlwdDpAImNvbnN0IGkgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdpbWcnKTsg ZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChpKTsgSFRNTEF0dGFjaG1lbnRFbGVtZW50LmdldEF0 dGFjaG1lbnRJZGVudGlmaWVyKGkpIl07Ci0gICAgX1dLQXR0YWNobWVudCAqYXR0YWNobWVudCA9 IFt3ZWJWaWV3IF9hdHRhY2htZW50Rm9ySWRlbnRpZmllcjppZGVudGlmaWVyXTsKKyAgICBhdXRv IGF0dGFjaG1lbnQgPSByZXRhaW5QdHIoW3dlYlZpZXcgX2F0dGFjaG1lbnRGb3JJZGVudGlmaWVy OmlkZW50aWZpZXJdKTsKIAogICAgIGF1dG8gcGRmRmlsZSA9IGFkb3B0TlMoW1tOU0ZpbGVXcmFw cGVyIGFsbG9jXSBpbml0UmVndWxhckZpbGVXaXRoQ29udGVudHM6dGVzdFBERkRhdGEoKV0pOwog ICAgIFthdHRhY2htZW50IHNldEZpbGVXcmFwcGVyOnBkZkZpbGUuZ2V0KCkgY29udGVudFR5cGU6 KF9fYnJpZGdlIE5TU3RyaW5nICopa1VUVHlwZVBERiBjb21wbGV0aW9uOm5pbF07CiAgICAgW3dl YlZpZXcgd2FpdEZvckltYWdlRWxlbWVudFNpemVUb0JlY29tZTpDR1NpemVNYWtlKDEzMCwgMjkp XTsKKworICAgIFt3ZWJWaWV3IHN5bmNocm9ub3VzbHlMb2FkVGVzdFBhZ2VOYW1lZDpAInNpbXBs ZSJdOworCisgICAgYXV0byB6aXBGaWxlID0gYWRvcHROUyhbW05TRmlsZVdyYXBwZXIgYWxsb2Nd IGluaXRSZWd1bGFyRmlsZVdpdGhDb250ZW50czp0ZXN0WklQRGF0YSgpXSk7CisgICAgW2F0dGFj aG1lbnQgc2V0RmlsZVdyYXBwZXI6emlwRmlsZS5nZXQoKSBjb250ZW50VHlwZTooX19icmlkZ2Ug TlNTdHJpbmcgKilrVVRUeXBlWmlwQXJjaGl2ZSBjb21wbGV0aW9uOm5pbF07CisgICAgRVhQRUNU X0ZBTFNFKFthdHRhY2htZW50IGlzQ29ubmVjdGVkXSk7CiB9CiAKICNwcmFnbWEgbWFyayAtIFBs YXRmb3JtLXNwZWNpZmljIHRlc3RzCg==