195724 2019-03-13 18:54:15 -0700 [ContentChangeObserver] Stop content observation when content calls preventDefault() on touch events 2019-03-13 21:49:23 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1516328 0 zalan 2019-03-13 18:54:15 -0700 ssia 1516329 1 webkit-bug-importer 2019-03-13 18:54:45 -0700 <rdar://problem/48873456> 1516332 2 364606 zalan 2019-03-13 18:59:38 -0700 Created attachment 364606 Patch 1516333 3 364606 simon.fraser 2019-03-13 19:02:49 -0700 Comment on attachment 364606 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364606&action=review > Source/WebCore/ChangeLog:9 > + Call willNotProceedWithClick on preventDefault. This is very similar to the long press case. Testable? 1516387 4 zalan 2019-03-13 21:23:39 -0700 (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 364606 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364606&action=review > > > Source/WebCore/ChangeLog:9 > > + Call willNotProceedWithClick on preventDefault. This is very similar to the long press case. > > Testable? Unfortunately not (This is about stop observing) 1516392 5 364606 commit-queue 2019-03-13 21:49:21 -0700 Comment on attachment 364606 Patch Clearing flags on attachment: 364606 Committed r242935: <https://trac.webkit.org/changeset/242935> 1516393 6 commit-queue 2019-03-13 21:49:23 -0700 All reviewed patches have been landed. Closing bug. 364606 2019-03-13 18:59:38 -0700 2019-03-13 21:49:21 -0700 Patch bug-195724-20190313185938.patch text/plain 5058 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyOTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjg2MmY4ZGM4MWVmNWQz NjhjNzY0ZWJkNDdkYmI4M2MxYzZmYmUwMC4uODg2NTljY2NjMjk2YjRjNjNiMjgyOGJlNDUyMTA1 NDViOWIyZmQyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAzLTEzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvbnRlbnRDaGFuZ2VPYnNl cnZlcl0gU3RvcCBjb250ZW50IG9ic2VydmF0aW9uIHdoZW4gY29udGVudCBjYWxscyBwcmV2ZW50 RGVmYXVsdCgpIG9uIHRvdWNoIGV2ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk1NzI0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80ODg3MzQ1 Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYWxs IHdpbGxOb3RQcm9jZWVkV2l0aENsaWNrIG9uIHByZXZlbnREZWZhdWx0LiBUaGlzIGlzIHZlcnkg c2ltaWxhciB0byB0aGUgbG9uZyBwcmVzcyBjYXNlLgorCisgICAgICAgICogcGFnZS9pb3MvQ29u dGVudENoYW5nZU9ic2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OndpbGxOb3RQcm9jZWVk V2l0aENsaWNrKToKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRlbnRDaGFuZ2VPYnNlcnZlcjo6ZGlk UmVjb2duaXplTG9uZ1ByZXNzKToKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRlbnRDaGFuZ2VPYnNl cnZlcjo6ZGlkUHJldmVudERlZmF1bHRGb3JFdmVudCk6CisgICAgICAgICogcGFnZS9pb3MvQ29u dGVudENoYW5nZU9ic2VydmVyLmg6CisKIDIwMTktMDMtMTMgIFphbGFuIEJ1anRhcyAgPHphbGFu QGFwcGxlLmNvbT4KIAogICAgICAgICBbV2Vha1B0cl0gUmVuZGVyTGlzdE1hcmtlcjo6bV9saXN0 SXRlbSBzaG91bGQgYmUgYSBXZWFrUHRyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMyMTJkYjgzNDIwMjA5Mzg0MjU0 MWJkMjY4OTdiZjg1MjdiOTdkN2QuLjgzYzJjNjg0YWFiNjA1ZTg5NTFiMzczMGZjMzdkZTZiODRl ZDcxZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDMtMTMgIFphbGFuIEJ1anRh cyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29udGVudENoYW5nZU9ic2VydmVyXSBT dG9wIGNvbnRlbnQgb2JzZXJ2YXRpb24gd2hlbiBjb250ZW50IGNhbGxzIHByZXZlbnREZWZhdWx0 KCkgb24gdG91Y2ggZXZlbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTU3MjQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ4ODczNDU2PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vz cy9XZWJDb3JlU3VwcG9ydC9pb3MvV2ViQ2hyb21lQ2xpZW50SU9TLm1tOgorICAgICAgICAoV2Vi S2l0OjpXZWJDaHJvbWVDbGllbnQ6OmRpZFByZXZlbnREZWZhdWx0Rm9yRXZlbnQpOgorCiAyMDE5 LTAzLTEzICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAg IFN0b3AgdXNpbmcgc29tZSBkZXByZWNhdGVkIFNQSSBpbiBXS0RyYXdpbmdWaWV3CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvcGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLmNwcAppbmRleCBm YzI1NmNlZTkwMWRjNDU0YjhjNmMyYTE3OTk1NTMyYTNlYjg4NDg5Li5jNDhkOGFjZWMyNTM5NDQ1 YzAzY2UwOTU3N2Q1ZjhhMjNkOTkwZDZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv aW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5jcHAKQEAgLTQ0LDE1ICs0NCwyNiBAQCBDb250ZW50 Q2hhbmdlT2JzZXJ2ZXI6OkNvbnRlbnRDaGFuZ2VPYnNlcnZlcihEb2N1bWVudCYgZG9jdW1lbnQp CiB7CiB9CiAKLXZvaWQgQ29udGVudENoYW5nZU9ic2VydmVyOjpkaWRSZWNvZ25pemVMb25nUHJl c3MoRnJhbWUmIG1haW5mcmFtZSkKK3N0YXRpYyB2b2lkIHdpbGxOb3RQcm9jZWVkV2l0aENsaWNr KEZyYW1lJiBtYWluRnJhbWUpCiB7Ci0gICAgTE9HKENvbnRlbnRPYnNlcnZhdGlvbiwgImRpZFJl Y29nbml6ZUxvbmdQcmVzczogY2FuY2VsIG9uZ29pbmcgY29udGVudCBjaGFuZ2Ugb2JzZXJ2aW5n LiIpOwotICAgIGZvciAoYXV0byogZnJhbWUgPSAmbWFpbmZyYW1lOyBmcmFtZTsgZnJhbWUgPSBm cmFtZS0+dHJlZSgpLnRyYXZlcnNlTmV4dCgpKSB7CisgICAgZm9yIChhdXRvKiBmcmFtZSA9ICZt YWluRnJhbWU7IGZyYW1lOyBmcmFtZSA9IGZyYW1lLT50cmVlKCkudHJhdmVyc2VOZXh0KCkpIHsK ICAgICAgICAgaWYgKGF1dG8qIGRvY3VtZW50ID0gZnJhbWUtPmRvY3VtZW50KCkpCiAgICAgICAg ICAgICBkb2N1bWVudC0+Y29udGVudENoYW5nZU9ic2VydmVyKCkud2lsbE5vdFByb2NlZWRXaXRo Q2xpY2soKTsKICAgICB9CiB9CiAKK3ZvaWQgQ29udGVudENoYW5nZU9ic2VydmVyOjpkaWRSZWNv Z25pemVMb25nUHJlc3MoRnJhbWUmIG1haW5GcmFtZSkKK3sKKyAgICBMT0coQ29udGVudE9ic2Vy dmF0aW9uLCAiZGlkUmVjb2duaXplTG9uZ1ByZXNzOiBjYW5jZWwgb25nb2luZyBjb250ZW50IGNo YW5nZSBvYnNlcnZpbmcuIik7CisgICAgV2ViQ29yZTo6d2lsbE5vdFByb2NlZWRXaXRoQ2xpY2so bWFpbkZyYW1lKTsKK30KKwordm9pZCBDb250ZW50Q2hhbmdlT2JzZXJ2ZXI6OmRpZFByZXZlbnRE ZWZhdWx0Rm9yRXZlbnQoRnJhbWUmIG1haW5GcmFtZSkKK3sKKyAgICBMT0coQ29udGVudE9ic2Vy dmF0aW9uLCAiZGlkUHJldmVudERlZmF1bHRGb3JFdmVudDogY2FuY2VsIG9uZ29pbmcgY29udGVu dCBjaGFuZ2Ugb2JzZXJ2aW5nLiIpOworICAgIFdlYkNvcmU6OndpbGxOb3RQcm9jZWVkV2l0aENs aWNrKG1haW5GcmFtZSk7Cit9CisKIHZvaWQgQ29udGVudENoYW5nZU9ic2VydmVyOjpzdGFydENv bnRlbnRPYnNlcnZhdGlvbkZvckR1cmF0aW9uKFNlY29uZHMgZHVyYXRpb24pCiB7CiAgICAgaWYg KCFtX2RvY3VtZW50LnNldHRpbmdzKCkuY29udGVudENoYW5nZU9ic2VydmVyRW5hYmxlZCgpKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVy LmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuaAppbmRl eCAzYTI0MDhlZGU2Y2QzMGQxODhkZTFjNGZiMDQzMWM4ZWMyYzQ3OGJhLi42YWUxODAyNjIxZjgy NDY4NTRjNGUxY2Q5Yjk2ZmExNTkyZjllMWZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuaApAQCAtNDYsNyArNDYsOSBAQCBwdWJsaWM6CiAg ICAgdm9pZCBkaWRJbnN0YWxsRE9NVGltZXIoY29uc3QgRE9NVGltZXImLCBTZWNvbmRzIHRpbWVv dXQsIGJvb2wgc2luZ2xlU2hvdCk7CiAgICAgdm9pZCBkaWRSZW1vdmVET01UaW1lcihjb25zdCBE T01UaW1lciYpOwogICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgd2lsbE5vdFByb2NlZWRXaXRoQ2xp Y2soKTsKLSAgICBXRUJDT1JFX0VYUE9SVCBzdGF0aWMgdm9pZCBkaWRSZWNvZ25pemVMb25nUHJl c3MoRnJhbWUmIG1haW5mcmFtZSk7CisgICAgV0VCQ09SRV9FWFBPUlQgc3RhdGljIHZvaWQgZGlk UmVjb2duaXplTG9uZ1ByZXNzKEZyYW1lJiBtYWluRnJhbWUpOworICAgIFdFQkNPUkVfRVhQT1JU IHN0YXRpYyB2b2lkIGRpZFByZXZlbnREZWZhdWx0Rm9yRXZlbnQoRnJhbWUmIG1haW5GcmFtZSk7 CisKICAgICB2b2lkIGRpZFN1c3BlbmRBY3RpdmVET01PYmplY3RzKCk7CiAgICAgdm9pZCB3aWxs RGV0YWNoUGFnZSgpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi Q29yZVN1cHBvcnQvaW9zL1dlYkNocm9tZUNsaWVudElPUy5tbSBiL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9pb3MvV2ViQ2hyb21lQ2xpZW50SU9TLm1tCmluZGV4IDkw MzI3Y2NmM2EwYTkyOWQ4YmJkNjEzM2Q2YTYxZTJiODE2M2IxMmQuLjI5NDQwOTFlM2FhMTNkNGVh OWUzYzUyOTBmMjIxMWIyZTJmYzhiN2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9XZWJDb3JlU3VwcG9ydC9pb3MvV2ViQ2hyb21lQ2xpZW50SU9TLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9pb3MvV2ViQ2hyb21lQ2xpZW50SU9T Lm1tCkBAIC0zNyw2ICszNyw3IEBACiAjaW1wb3J0ICJXZWJQYWdlLmgiCiAjaW1wb3J0ICJXZWJQ YWdlUHJveHlNZXNzYWdlcy5oIgogI2ltcG9ydCA8V2ViQ29yZS9BdWRpb1Nlc3Npb24uaD4KKyNp bXBvcnQgPFdlYkNvcmUvQ29udGVudENoYW5nZU9ic2VydmVyLmg+CiAjaW1wb3J0IDxXZWJDb3Jl L0ljb24uaD4KICNpbXBvcnQgPFdlYkNvcmUvTm90SW1wbGVtZW50ZWQuaD4KICNpbXBvcnQgPHd0 Zi9SZWZQdHIuaD4KQEAgLTQ4LDcgKzQ5LDkgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAK IHZvaWQgV2ViQ2hyb21lQ2xpZW50OjpkaWRQcmV2ZW50RGVmYXVsdEZvckV2ZW50KCkKIHsKLSAg ICBub3RJbXBsZW1lbnRlZCgpOworICAgIGlmICghbV9wYWdlLm1haW5GcmFtZSgpKQorICAgICAg ICByZXR1cm47CisgICAgQ29udGVudENoYW5nZU9ic2VydmVyOjpkaWRQcmV2ZW50RGVmYXVsdEZv ckV2ZW50KCptX3BhZ2UubWFpbkZyYW1lKCkpOwogfQogCiAjZW5kaWYK