<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>195708</bug_id>
          
          <creation_ts>2019-03-13 15:28:13 -0700</creation_ts>
          <short_desc>HTMLInputElement::setEditingValue should not fail if renderer doesn&apos;t exist</short_desc>
          <delta_ts>2019-03-29 12:04:35 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Forms</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=196402</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Michael Catanzaro">mcatanzaro</assigned_to>
          <cc>cdumez</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1516212</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-03-13 15:28:13 -0700</bug_when>
    <thetext>HTMLInputElement::setEditingValue currently returns early if the element&apos;s renderer() is null. This is causing the Epiphany password manager to fail to remember passwords on https://www.geico.com/ except for navigations through page cache.

I traced this back to https://bugs.webkit.org/show_bug.cgi?id=85353#c15 trying to figure out why it was added in the first place and discovered it was to avoid some assertion, but I don&apos;t know which one, and there&apos;s definitely not any assertion hit nowadays in this case. Probably there are more guards checking if renderer() is null elsewhere in the code nowadays, closer to where it&apos;s really needed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1516214</commentid>
    <comment_count>1</comment_count>
      <attachid>364584</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-03-13 15:31:23 -0700</bug_when>
    <thetext>Created attachment 364584
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1516224</commentid>
    <comment_count>2</comment_count>
      <attachid>364584</attachid>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2019-03-13 16:00:57 -0700</bug_when>
    <thetext>Comment on attachment 364584
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364584&amp;action=review

&gt; Source/WebCore/ChangeLog:18
&gt; +        No new test because I have no clue how this could possibly be tested. The change should be
&gt; +        good as long as it doesn&apos;t break existing tests.

Could you use Internals.setEditingValue?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1516254</commentid>
    <comment_count>3</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-03-13 16:53:52 -0700</bug_when>
    <thetext>(In reply to Wenson Hsieh from comment #2)
&gt; Could you use Internals.setEditingValue?

That, or the GTK DOM API.

The bigger problem is I don&apos;t know how rendering works: we&apos;d have to somehow figure out how to trigger this NULL renderer() case.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1516390</commentid>
    <comment_count>4</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2019-03-13 21:42:11 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #3)
&gt; (In reply to Wenson Hsieh from comment #2)
&gt; &gt; Could you use Internals.setEditingValue?
&gt; 
&gt; That, or the GTK DOM API.
&gt; 
&gt; The bigger problem is I don&apos;t know how rendering works: we&apos;d have to somehow
&gt; figure out how to trigger this NULL renderer() case.

&lt;input type=“text” style=“display: none”&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1516391</commentid>
    <comment_count>5</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2019-03-13 21:43:00 -0700</bug_when>
    <thetext>(In reply to Daniel Bates from comment #4)
&gt; (In reply to Michael Catanzaro from comment #3)
&gt; &gt; (In reply to Wenson Hsieh from comment #2)
&gt; &gt; &gt; Could you use Internals.setEditingValue?
&gt; &gt; 
&gt; &gt; That, or the GTK DOM API.
&gt; &gt; 
&gt; &gt; The bigger problem is I don&apos;t know how rendering works: we&apos;d have to somehow
&gt; &gt; figure out how to trigger this NULL renderer() case.
&gt; 
&gt; &lt;input type=“text” style=“display: none”&gt;

Except without the fancy quotes😄</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1516501</commentid>
    <comment_count>6</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-03-14 08:12:17 -0700</bug_when>
    <thetext>Oh wow, I&apos;ll try that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1519940</commentid>
    <comment_count>7</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-03-21 14:28:28 -0700</bug_when>
    <thetext>(In reply to Daniel Bates from comment #4)
&gt; &lt;input type=“text” style=“display: none”&gt;

Good tip! This worked.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1519942</commentid>
    <comment_count>8</comment_count>
      <attachid>365618</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-03-21 14:30:37 -0700</bug_when>
    <thetext>Created attachment 365618
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1520616</commentid>
    <comment_count>9</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-03-23 08:25:01 -0700</bug_when>
    <thetext>Wenson, Daniel, does this look OK?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1522438</commentid>
    <comment_count>10</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-03-29 05:56:04 -0700</bug_when>
    <thetext>Any reviewer, please?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1522447</commentid>
    <comment_count>11</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2019-03-29 08:09:33 -0700</bug_when>
    <thetext>As Zalan pointed out to me, it seems a bit strange to use setEditingValue. On Cocoa platforms, autofill uses setValueForUser which turns around and calls setValue.

AFAICT, setEditingValue is only used in GTK code and internal testing helpers, so the impact of this change is pretty limited. But now I&apos;m also wondering if we could just use setValueForUser or setValue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1522458</commentid>
    <comment_count>12</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-03-29 08:42:55 -0700</bug_when>
    <thetext>I think it would probably work.

I think the reason we use setEditingValue is to dispatch the change event. When called from JS, JSHTMLInputElement::setJSHTMLInputElementValueAsNumberSetter calls HTMLInputElement::setValue with DispatchNoEvent, and there&apos;s no way around that, so we have to use a native API. But using setValueForUser would also dispatch the change event. webkit_dom_element_html_input_element_set_editing_value() is public API, but we could deprecate it and reimplement it using setValueForUser if that works better, and then get rid of setEditingValue entirely (since keeping it is pointless if nothing except the tests uses it).

I&apos;ll need to do more testing, so I&apos;m going to land this as-is for now, but I&apos;ll have a follow-up soon.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1522462</commentid>
    <comment_count>13</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-03-29 08:50:50 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #12)
&gt; webkit_dom_element_html_input_element_set_editing_value() is public API

Surprise, it was added by me, in bug #163082. Shame I didn&apos;t leave more detail in the bug itself. I just wrote &quot;these are needed to make autofill work properly with Angular forms.&quot; Wish I remembered what page was causing problems there.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1522471</commentid>
    <comment_count>14</comment_count>
      <attachid>365618</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-03-29 09:11:08 -0700</bug_when>
    <thetext>Comment on attachment 365618
Patch

Clearing flags on attachment: 365618

Committed r243647: &lt;https://trac.webkit.org/changeset/243647&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1522472</commentid>
    <comment_count>15</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-03-29 09:11:10 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1522473</commentid>
    <comment_count>16</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-03-29 09:12:19 -0700</bug_when>
    <thetext>&lt;rdar://problem/49422616&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1522508</commentid>
    <comment_count>17</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-03-29 11:25:43 -0700</bug_when>
    <thetext>I found in https://gitlab.gnome.org/GNOME/epiphany/commit/e34c87c316ca16dfe608def225523d2fe5872fbb the justification for using setEditingValue:

&quot;&quot;&quot;
Honestly, I have no clue what I&apos;ve done here, but it&apos;s what Chromium
does when it autofills a form, and it makes an Angular password form
work on one of our internal sites, so it&apos;s probably good right?
&quot;&quot;&quot;

So that&apos;s not great.

It jogged my memory as to which site to test this setValueForUser with, at least.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1522519</commentid>
    <comment_count>18</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-03-29 11:54:43 -0700</bug_when>
    <thetext>Using setValueForUser works on the handful of sites I just tested, and fixes ting.com, so great tip, thanks. Bug #196402</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>364584</attachid>
            <date>2019-03-13 15:31:23 -0700</date>
            <delta_ts>2019-03-21 14:30:35 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-195708-20190313173123.patch</filename>
            <type>text/plain</type>
            <size>2049</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyNzA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDQzYzlkNjE3YmZiMDE5
YjNkNTFkNGJlZmFkNDRlMGYwZDEzODk0Mi4uNGFhYmZlNjZlZjFjMTNhNjBiM2NkNjZkODQwMGIw
OWIxZjZkZDQxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE5LTAzLTEzICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBIVE1MSW5w
dXRFbGVtZW50OjpzZXRFZGl0aW5nVmFsdWUgc2hvdWxkIG5vdCBmYWlsIGlmIHJlbmRlcmVyIGRv
ZXNuJ3QgZXhpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTE5NTcwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgIEhUTUxJbnB1dEVsZW1lbnQ6OnNldEVkaXRpbmdWYWx1ZSBjdXJyZW50bHkgcmV0dXJucyBl
YXJseSBpZiB0aGUgZWxlbWVudCdzIHJlbmRlcmVyKCkgaXMKKyAgICAgICAgbnVsbC4gVGhpcyBp
cyBjYXVzaW5nIHRoZSBFcGlwaGFueSBwYXNzd29yZCBtYW5hZ2VyIHRvIGZhaWwgdG8gcmVtZW1i
ZXIgcGFzc3dvcmRzIG9uCisgICAgICAgIGh0dHBzOi8vd3d3LmdlaWNvLmNvbS8gZXhjZXB0IGZv
ciBuYXZpZ2F0aW9ucyB0aHJvdWdoIHBhZ2UgY2FjaGUuCisKKyAgICAgICAgVGhpcyBjaGVjayB3
YXMgb3JpZ2luYWxseSBhZGRlZCB0byBhdm9pZCBzb21lIGFzc2VydGlvbiwgYnV0IEkgZG9uJ3Qg
a25vdyB3aGljaCBvbmUsIGFuZAorICAgICAgICB0aGVyZSdzIGRlZmluaXRlbHkgbm90IGFueSBh
c3NlcnRpb24gaGl0IG5vd2FkYXlzIGluIHRoaXMgY2FzZS4gUHJvYmFibHkgdGhlcmUgYXJlIG1v
cmUKKyAgICAgICAgZ3VhcmRzIGNoZWNraW5nIGlmIHJlbmRlcmVyKCkgaXMgbnVsbCBlbHNld2hl
cmUgaW4gdGhlIGNvZGUgbm93YWRheXMsIGNsb3NlciB0byB3aGVyZSBpdCdzCisgICAgICAgIHJl
YWxseSBuZWVkZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3QgYmVjYXVzZSBJIGhhdmUgbm8gY2x1
ZSBob3cgdGhpcyBjb3VsZCBwb3NzaWJseSBiZSB0ZXN0ZWQuIFRoZSBjaGFuZ2Ugc2hvdWxkIGJl
CisgICAgICAgIGdvb2QgYXMgbG9uZyBhcyBpdCBkb2Vzbid0IGJyZWFrIGV4aXN0aW5nIHRlc3Rz
LgorCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv
cmU6OkhUTUxJbnB1dEVsZW1lbnQ6OnNldEVkaXRpbmdWYWx1ZSk6CisKIDIwMTktMDMtMTEgIFBo
aWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3
ZWQsIE5vbi1HU3RyZWFtZXItR0wgYnVpbGQgZml4IGFmdGVyIHIyNDI3MDEuCmRpZmYgLS1naXQg
YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNv
cmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAppbmRleCBlMjA5NGYzZjQ0NmQwMDE4OTM5ODYy
NjVjNjRmNmM2NDBmMzllZTFkLi5mY2UxMjM1ZDc1YWVjNTdkNGNiM2E3NDAzOWY1MzYwNjZmY2Vm
YzA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3Bw
CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKQEAgLTEwMzYs
OCArMTAzNiw5IEBAIHZvaWQgSFRNTElucHV0RWxlbWVudDo6c2V0VmFsdWVGb3JVc2VyKGNvbnN0
IFN0cmluZyYgdmFsdWUpCiAKIHZvaWQgSFRNTElucHV0RWxlbWVudDo6c2V0RWRpdGluZ1ZhbHVl
KGNvbnN0IFN0cmluZyYgdmFsdWUpCiB7Ci0gICAgaWYgKCFyZW5kZXJlcigpIHx8ICFpc1RleHRG
aWVsZCgpKQorICAgIGlmICghaXNUZXh0RmllbGQoKSkKICAgICAgICAgcmV0dXJuOworCiAgICAg
c2V0SW5uZXJUZXh0VmFsdWUodmFsdWUpOwogICAgIHN1YnRyZWVIYXNDaGFuZ2VkKCk7CiAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>365618</attachid>
            <date>2019-03-21 14:30:37 -0700</date>
            <delta_ts>2019-03-29 09:11:08 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-195708-20190321163036.patch</filename>
            <type>text/plain</type>
            <size>4759</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTFlYTM4OTc0ZGYwOTUy
NTFhODE3YzBmNTJkY2E5N2E2OTY4OTIzMi4uM2MxMDA5MjRmNWVjZWYyZTFhOTMxOGY0MzExYjlm
OTY4ZGFmYjgzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE5LTAzLTIxICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBIVE1MSW5w
dXRFbGVtZW50OjpzZXRFZGl0aW5nVmFsdWUgc2hvdWxkIG5vdCBmYWlsIGlmIHJlbmRlcmVyIGRv
ZXNuJ3QgZXhpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTE5NTcwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgIEhUTUxJbnB1dEVsZW1lbnQ6OnNldEVkaXRpbmdWYWx1ZSBjdXJyZW50bHkgcmV0dXJucyBl
YXJseSBpZiB0aGUgZWxlbWVudCdzIHJlbmRlcmVyKCkgaXMKKyAgICAgICAgbnVsbC4gVGhpcyBp
cyBjYXVzaW5nIHRoZSBFcGlwaGFueSBwYXNzd29yZCBtYW5hZ2VyIHRvIGZhaWwgdG8gcmVtZW1i
ZXIgcGFzc3dvcmRzIG9uCisgICAgICAgIGh0dHBzOi8vd3d3LmdlaWNvLmNvbS8gZXhjZXB0IGZv
ciBuYXZpZ2F0aW9ucyB0aHJvdWdoIHBhZ2UgY2FjaGUuCisKKyAgICAgICAgVGhpcyBjaGVjayB3
YXMgb3JpZ2luYWxseSBhZGRlZCB0byBhdm9pZCBzb21lIGFzc2VydGlvbiwgYnV0IEkgZG9uJ3Qg
a25vdyB3aGljaCBvbmUsIGFuZAorICAgICAgICB0aGVyZSdzIGRlZmluaXRlbHkgbm90IGFueSBh
c3NlcnRpb24gaGl0IG5vd2FkYXlzIGluIHRoaXMgY2FzZS4gUHJvYmFibHkgdGhlcmUgYXJlIG1v
cmUKKyAgICAgICAgZ3VhcmRzIGNoZWNraW5nIGlmIHJlbmRlcmVyKCkgaXMgbnVsbCBlbHNld2hl
cmUgaW4gdGhlIGNvZGUgbm93YWRheXMsIGNsb3NlciB0byB3aGVyZSBpdCdzCisgICAgICAgIHJl
YWxseSBuZWVkZWQuCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9lZGl0aW5nLXZhbHVlLW51
bGwtcmVuZGVyZXIuaHRtbAorCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDoK
KyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OnNldEVkaXRpbmdWYWx1ZSk6CisK
IDIwMTktMDMtMjEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4K
IAogICAgICAgICBBZGQgU1BJIHRvIGluZm9ybSBhcHBsaWNhdGlvbnMgb2YgV0tDb250ZW50UnVs
ZUxpc3QgYWN0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRF
bGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKaW5k
ZXggZTIwOTRmM2Y0NDZkMDAxODkzOTg2MjY1YzY0ZjZjNjQwZjM5ZWUxZC4uZmNlMTIzNWQ3NWFl
YzU3ZDRjYjNhNzQwMzlmNTM2MDY2ZmNlZmMwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv
aHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJ
bnB1dEVsZW1lbnQuY3BwCkBAIC0xMDM2LDggKzEwMzYsOSBAQCB2b2lkIEhUTUxJbnB1dEVsZW1l
bnQ6OnNldFZhbHVlRm9yVXNlcihjb25zdCBTdHJpbmcmIHZhbHVlKQogCiB2b2lkIEhUTUxJbnB1
dEVsZW1lbnQ6OnNldEVkaXRpbmdWYWx1ZShjb25zdCBTdHJpbmcmIHZhbHVlKQogewotICAgIGlm
ICghcmVuZGVyZXIoKSB8fCAhaXNUZXh0RmllbGQoKSkKKyAgICBpZiAoIWlzVGV4dEZpZWxkKCkp
CiAgICAgICAgIHJldHVybjsKKwogICAgIHNldElubmVyVGV4dFZhbHVlKHZhbHVlKTsKICAgICBz
dWJ0cmVlSGFzQ2hhbmdlZCgpOwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg
Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjE4OGZkZDM0MGI0MmMwZWM2Y2RiOWYzZjc3
NmI4MzRhYTJlMjBkZC4uZDUxYjlkOGY4YjkzODc1ZjA1OGVhZmRkM2U1YmEzNzAwNmIyMjliMCAx
MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n
ZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAzLTIxICBNaWNoYWVsIENhdGFuemFybyAgPG1j
YXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBIVE1MSW5wdXRFbGVtZW50OjpzZXRFZGl0
aW5nVmFsdWUgc2hvdWxkIG5vdCBmYWlsIGlmIHJlbmRlcmVyIGRvZXNuJ3QgZXhpc3QKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTcwOAorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgYSBjb3B5
IG9mIGZhc3QvZm9ybXMvZWRpdGluZy12YWx1ZS5odG1sLCBleGNlcHQgdGhlIGZvcm0gaXMgbm90
IGRpc3BsYXllZC4gVGhlIGlucHV0CisgICAgICAgIHZhbHVlIHNob3VsZCBzdGlsbCBjaGFuZ2Uu
CisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2VkaXRpbmctdmFsdWUtbnVsbC1yZW5kZXJlci1leHBl
Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvZWRpdGluZy12YWx1ZS1udWxs
LXJlbmRlcmVyLmh0bWw6IEFkZGVkLgorCiAyMDE5LTAzLTIxICBBbGV4IENocmlzdGVuc2VuICA8
YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIFNQSSB0byBpbmZvcm0gYXBw
bGljYXRpb25zIG9mIFdLQ29udGVudFJ1bGVMaXN0IGFjdGlvbnMKZGlmZiAtLWdpdCBhL0xheW91
dFRlc3RzL2Zhc3QvZm9ybXMvZWRpdGluZy12YWx1ZS1udWxsLXJlbmRlcmVyLWV4cGVjdGVkLnR4
dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvZWRpdGluZy12YWx1ZS1udWxsLXJlbmRlcmVyLWV4
cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yOGM5NjBhNDFiMzgwOTU4NTNkZjBmMjgxMzAzZGJmOTY3
NmMyODA0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9lZGl0aW5n
LXZhbHVlLW51bGwtcmVuZGVyZXItZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTIgQEAKK1RoaXMg
dGVzdHMgc2V0dGluZyB0aGUgZWRpdGluZyB2YWx1ZSBvZiBhbiBpbnB1dC4KKworT24gc3VjY2Vz
cywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkg
IlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1Mgb25pbnB1dCBldmVudCB3YXMgZmlyZWQuCitQQVNT
IGlucHV0LnZhbHVlIGlzICJmb28iCitQQVNTIGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoIjppbnZh
bGlkIikgaXMgaW5wdXQKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBD
T01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2VkaXRpbmctdmFs
dWUtbnVsbC1yZW5kZXJlci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9lZGl0aW5nLXZh
bHVlLW51bGwtcmVuZGVyZXIuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40MjA2OTMzYTdlNWQ1OTJkYzYwYTYw
YjM5MWIzMTU0YjA1OWQ3ZTgzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9m
b3Jtcy9lZGl0aW5nLXZhbHVlLW51bGwtcmVuZGVyZXIuaHRtbApAQCAtMCwwICsxLDM3IEBACis8
IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxo
ZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3Jp
cHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0i
Y29uc29sZSI+PC9kaXY+CisKKzxpbnB1dCB0eXBlPSJlbWFpbCIgaWQ9InRlc3QiIHBsYWNlaG9s
ZGVyPSJGQUlMOiBwbGFjZWhvbGRlciBzaG91bGQgZGlzYXBwZWFyIiBzdHlsZT0iZGlzcGxheTog
bm9uZSI+CisKKzxzY3JpcHQ+CitkZXNjcmlwdGlvbignVGhpcyB0ZXN0cyBzZXR0aW5nIHRoZSBl
ZGl0aW5nIHZhbHVlIG9mIGFuIGlucHV0LicpOworCit2YXIgaW5wdXQgPSBkb2N1bWVudC5nZXRF
bGVtZW50QnlJZCgndGVzdCcpOworaW5wdXQub25jaGFuZ2UgPSBmdW5jdGlvbigpIHsKKyAgICB0
ZXN0RmFpbGVkKCJvbmNoYW5nZSBldmVudCB3YXMgZmlyZWQuIik7Cit9OworaW5wdXQub25pbnB1
dCA9IGZ1bmN0aW9uKCkgeworICAgIHRlc3RQYXNzZWQoIm9uaW5wdXQgZXZlbnQgd2FzIGZpcmVk
LiIpOworfTsKKworaW5wdXQuZm9jdXMoKTsKK2lmICh3aW5kb3cuaW50ZXJuYWxzKSB7CisgICAg
aW50ZXJuYWxzLnNldEVkaXRpbmdWYWx1ZShpbnB1dCwgIiBmb28gIik7Cit9IGVsc2UgeworICAg
IGRlYnVnKCdUaGlzIHRlc3QgcmVxdWlyZXMgd2luZG93LmludGVybmFscyBvYmplY3QuJyk7Cit9
CitzaG91bGRCZSgnaW5wdXQudmFsdWUnLCAnImZvbyInKTsKK3Nob3VsZEJlKCdkb2N1bWVudC5x
dWVyeVNlbGVjdG9yKCI6aW52YWxpZCIpJywgJ2lucHV0Jyk7CitpbnB1dC5ibHVyKCk7CisKKzwv
c2NyaXB0PgorCis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+
PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>