195705 2019-03-13 15:14:45 -0700 Web Inspector: Debugger: pausing in an inline script on a page with a URL query creates an Extra Script 2019-03-13 18:35:41 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue graouts hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1516198 0 hi 2019-03-13 15:14:45 -0700 # STEPS TO REPRODUCE: 1. inspect <https://peoplesoakland.mysalononline.com/Booking/?sid=0&guid=fe74f67f-6863-4671-bbb9-704ef70e163e> 2. tap on the date to show the calendar 3. select the <div.k-calendar> node 4. set a breakpoint in the "mousedown" event listener registered on this node 5. Tap anywhere in the calendar 1516199 1 hi 2019-03-13 15:14:54 -0700 <rdar://problem/48853820> 1516203 2 364581 hi 2019-03-13 15:20:33 -0700 Created attachment 364581 Patch 1516206 3 364581 graouts 2019-03-13 15:24:51 -0700 Comment on attachment 364581 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364581&action=review > Source/WebInspectorUI/UserInterface/Models/Script.js:280 > + let mainResource = this._target === WI.mainTarget ? WI.networkManager.mainFrame.mainResource : this._target.mainResource; Not sure if there's a coding style I don't know about, but technically `const` here would work since mainResource is not re-assigned. 1516210 4 364581 hi 2019-03-13 15:26:58 -0700 Comment on attachment 364581 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364581&action=review >> Source/WebInspectorUI/UserInterface/Models/Script.js:280 >> + let mainResource = this._target === WI.mainTarget ? WI.networkManager.mainFrame.mainResource : this._target.mainResource; > > Not sure if there's a coding style I don't know about, but technically `const` here would work since mainResource is not re-assigned. The style that I've known for Web Inspector is that we only use `const` for things that won't change across executions. We use `const` almost like one would expect `static`. FWIW, `let` is also less characters than `const` :P 1516217 5 364581 joepeck 2019-03-13 15:38:02 -0700 Comment on attachment 364581 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364581&action=review > Source/WebInspectorUI/UserInterface/Models/Script.js:283 > + if (this._target && !this.isMainResource()) { > + let mainResource = this._target === WI.mainTarget ? WI.networkManager.mainFrame.mainResource : this._target.mainResource; > + if (mainResource && mainResource.url.startsWith(this._url)) > + return mainResource; > + } Shouldn't this check each Frame's document resource URLs? What if this was a <script> in a sub-frame's document? 1516297 6 364598 hi 2019-03-13 17:56:17 -0700 Created attachment 364598 Patch 1516319 7 364598 commit-queue 2019-03-13 18:35:40 -0700 Comment on attachment 364598 Patch Clearing flags on attachment: 364598 Committed r242929: <https://trac.webkit.org/changeset/242929> 1516320 8 commit-queue 2019-03-13 18:35:41 -0700 All reviewed patches have been landed. Closing bug. 364581 2019-03-13 15:20:33 -0700 2019-03-13 17:56:16 -0700 Patch bug-195705-20190313152032.patch text/plain 2076 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQwMTE0OGVhNmVkMDBkNjIxZWI3ZGNjZWZlYzgy ZjhjNTIwMGUzM2IuLmYzODI3ZjdiMGE3OWEzMjhkNjkxYjQ0NjFhNzQyZmM0MzI1YzJiMWMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAzLTEzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBE ZWJ1Z2dlcjogcGF1c2luZyBpbiBhbiBpbmxpbmUgc2NyaXB0IG9uIGEgcGFnZSB3aXRoIGEgVVJM IHF1ZXJ5IGNyZWF0ZXMgYW4gRXh0cmEgU2NyaXB0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU3MDUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ4 ODUzODIwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9Nb2RlbHMvU2NyaXB0LmpzOgorICAgICAgICAoV0kuU2NyaXB0LnBy b3RvdHlwZS5fcmVzb2x2ZVJlc291cmNlKToKKyAgICAgICAgSWYgdGhlIHBhZ2UncyBVUkwgaGFz IGEgcXVlcnkgcGFyYW1ldGVyLCB0aGUgcGF5bG9hZCB3ZSByZWNlaXZlIGZvciBhbnkgaW5saW5l IDxzY3JpcHQ+cworICAgICAgICBkb2Vzbid0IGluY2x1ZGUgdGhlIHF1ZXJ5IHBhcmFtZXRlciBh cyBwYXJ0IG9mIGl0cyBVUkwuIEFzIHN1Y2gsIGlmIHRoZXJlIGlzbid0IGFuIGV4aXN0aW5nCisg ICAgICAgIHJlc291cmNlIHdpdGggYSBVUkwgdGhhdCBleGFjdGx5IG1hdGNoZXMgdGhlIFVSTCBv ZiB0aGUgc2NyaXB0IGFuZCBpZiB0aGUgVVJMIG9mIHRoZSBtYWluCisgICAgICAgIHJlc291cmNl IGZvciB0aGUgc2NyaXB0J3MgdGFyZ2V0IHN0YXJ0cyB3aXRoIHRoZSBVUkwgb2YgdGhlIHNjcmlw dCwgd2UgYXNzdW1lIHRoYXQgdGhlCisgICAgICAgIHNjcmlwdCAiYmVsb25ncyIgdG8gdGhlIHRh cmdldCdzIG1haW4gcmVzb3VyY2UgYW5kIGFzc29jaWF0ZSB0aGUgc2NyaXB0IHdpdGggaXQgYXMg c3VjaC4KKwogMjAxOS0wMy0xMyAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogUHJvdG9jb2wgTG9nZ2luZzogbG9nIG1lc3NhZ2VzIHdp dGggYmFja3RyYWNlIGlmIGluc3BlY3Rvcl4yIGlzIG9wZW4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHQuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvU2NyaXB0LmpzCmluZGV4IGZiNDI3Njk4 YmEzY2QyNzg1YTkyNGM4MDdmODcyYzQ4OWY0ODFhYzUuLmZkNTljNzAxMTE5ZGVmOTE3ZTViZDY0 NDgzZWVlMWI1ZmRhZWExOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL01vZGVscy9TY3JpcHQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvTW9kZWxzL1NjcmlwdC5qcwpAQCAtMjc2LDYgKzI3NiwxMiBAQCBXSS5TY3Jp cHQgPSBjbGFzcyBTY3JpcHQgZXh0ZW5kcyBXSS5Tb3VyY2VDb2RlCiAgICAgICAgICAgICB9CiAg ICAgICAgIH0gY2F0Y2ggeyB9CiAKKyAgICAgICAgaWYgKHRoaXMuX3RhcmdldCAmJiAhdGhpcy5p c01haW5SZXNvdXJjZSgpKSB7CisgICAgICAgICAgICBsZXQgbWFpblJlc291cmNlID0gdGhpcy5f dGFyZ2V0ID09PSBXSS5tYWluVGFyZ2V0ID8gV0kubmV0d29ya01hbmFnZXIubWFpbkZyYW1lLm1h aW5SZXNvdXJjZSA6IHRoaXMuX3RhcmdldC5tYWluUmVzb3VyY2U7CisgICAgICAgICAgICBpZiAo bWFpblJlc291cmNlICYmIG1haW5SZXNvdXJjZS51cmwuc3RhcnRzV2l0aCh0aGlzLl91cmwpKQor ICAgICAgICAgICAgICAgIHJldHVybiBtYWluUmVzb3VyY2U7CisgICAgICAgIH0KKwogICAgICAg ICByZXR1cm4gbnVsbDsKICAgICB9CiAK 364598 2019-03-13 17:56:17 -0700 2019-03-13 18:35:40 -0700 Patch bug-195705-20190313175617.patch text/plain 2059 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQwMTE0OGVhNmVkMDBkNjIxZWI3ZGNjZWZlYzgy ZjhjNTIwMGUzM2IuLmE2Y2IzMjk4ODE3MGE1YjRhYzEwM2RkMWYyYzJlMjhjYzBjMTFkYWEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAzLTEzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBE ZWJ1Z2dlcjogcGF1c2luZyBpbiBhbiBpbmxpbmUgc2NyaXB0IG9uIGEgcGFnZSB3aXRoIGEgVVJM IHF1ZXJ5IGNyZWF0ZXMgYW4gRXh0cmEgU2NyaXB0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU3MDUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ4 ODUzODIwPgorCisgICAgICAgIFJldmlld2VkIGJ5IEFudG9pbmUgUXVpbnQuCisKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHQuanM6CisgICAgICAgIChXSS5TY3JpcHQucHJv dG90eXBlLl9yZXNvbHZlUmVzb3VyY2UpOgorICAgICAgICBJZiB0aGUgcGFnZSdzIFVSTCBoYXMg YSBxdWVyeSBwYXJhbWV0ZXIsIHRoZSBwYXlsb2FkIHdlIHJlY2VpdmUgZm9yIGFueSBpbmxpbmUg PHNjcmlwdD5zCisgICAgICAgIGRvZXNuJ3QgaW5jbHVkZSB0aGUgcXVlcnkgcGFyYW1ldGVyIGFz IHBhcnQgb2YgaXRzIFVSTC4gQXMgc3VjaCwgaWYgdGhlcmUgaXNuJ3QgYW4gZXhpc3RpbmcKKyAg ICAgICAgcmVzb3VyY2Ugd2l0aCBhIFVSTCB0aGF0IGV4YWN0bHkgbWF0Y2hlcyB0aGUgVVJMIG9m IHRoZSBzY3JpcHQgYW5kIGlmIHRoZSBVUkwgb2YgdGhlIG1haW4KKyAgICAgICAgcmVzb3VyY2Ug Zm9yIHRoZSBzY3JpcHQncyB0YXJnZXQgc3RhcnRzIHdpdGggdGhlIFVSTCBvZiB0aGUgc2NyaXB0 LCB3ZSBhc3N1bWUgdGhhdCB0aGUKKyAgICAgICAgc2NyaXB0ICJiZWxvbmdzIiB0byB0aGUgdGFy Z2V0J3MgbWFpbiByZXNvdXJjZSBhbmQgYXNzb2NpYXRlIHRoZSBzY3JpcHQgd2l0aCBpdCBhcyBz dWNoLgorCiAyMDE5LTAzLTEzICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBQcm90b2NvbCBMb2dnaW5nOiBsb2cgbWVzc2FnZXMgd2l0 aCBiYWNrdHJhY2UgaWYgaW5zcGVjdG9yXjIgaXMgb3BlbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NjcmlwdC5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHQuanMKaW5kZXggZmI0Mjc2OThi YTNjZDI3ODVhOTI0YzgwN2Y4NzJjNDg5ZjQ4MWFjNS4uOWZiNmQzNjI3ZmExNjhmN2FkMzFjNTA2 YjM3MjFiMDllOGE2OTFhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvTW9kZWxzL1NjcmlwdC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Nb2RlbHMvU2NyaXB0LmpzCkBAIC0yNzYsNiArMjc2LDEzIEBAIFdJLlNjcmlw dCA9IGNsYXNzIFNjcmlwdCBleHRlbmRzIFdJLlNvdXJjZUNvZGUKICAgICAgICAgICAgIH0KICAg ICAgICAgfSBjYXRjaCB7IH0KIAorICAgICAgICBpZiAoIXRoaXMuaXNNYWluUmVzb3VyY2UoKSkg eworICAgICAgICAgICAgZm9yIChsZXQgZnJhbWUgb2YgV0kubmV0d29ya01hbmFnZXIuZnJhbWVz KSB7CisgICAgICAgICAgICAgICAgaWYgKGZyYW1lLm1haW5SZXNvdXJjZS50eXBlID09PSBXSS5S ZXNvdXJjZS5UeXBlLkRvY3VtZW50ICYmIGZyYW1lLm1haW5SZXNvdXJjZS51cmwuc3RhcnRzV2l0 aCh0aGlzLl91cmwpKQorICAgICAgICAgICAgICAgICAgICByZXR1cm4gZnJhbWUubWFpblJlc291 cmNlOworICAgICAgICAgICAgfQorICAgICAgICB9CisKICAgICAgICAgcmV0dXJuIG51bGw7CiAg ICAgfQogCg==