195703 2019-03-13 14:45:02 -0700 Remove some unnecessary !USE(UIKIT_KEYBOARD_ADDITIONS) guards 2019-03-13 15:27:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1516173 0 dbates 2019-03-13 14:45:02 -0700 Following the fix for bug #193452 we now make use of windowsKeyCodeForCharCode() even for hardware key events when USE(UIKIT_KEYBOARD_ADDITIONS) is enabled. Update a comment and remove some unnecessary USE(UIKIT_KEYBOARD_ADDITIONS) guards. 1516180 1 364577 dbates 2019-03-13 14:48:48 -0700 Created attachment 364577 Patch 1516182 2 dbates 2019-03-13 14:51:07 -0700 No behavior change despite the removing of the guards even when building with USE(UIKIT_KEYBOARD_ADDITIONS) enabled because though windowsKeyCodeForCharCode() returned 0 (because the char is not known) we fall back to using the event's key code, which worked out for those char that we're only recognized when building with !USE(UIKIT_KEYBOARD_ADDITIONS). 1516208 3 364577 dbates 2019-03-13 15:26:12 -0700 Comment on attachment 364577 Patch Clearing flags on attachment: 364577 Committed r242915: <https://trac.webkit.org/changeset/242915> 1516209 4 dbates 2019-03-13 15:26:13 -0700 All reviewed patches have been landed. Closing bug. 1516211 5 webkit-bug-importer 2019-03-13 15:27:14 -0700 <rdar://problem/48866045> 364577 2019-03-13 14:48:48 -0700 2019-03-13 15:26:12 -0700 Patch bug-195703-20190313144848.patch text/plain 4002 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyNzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzBkNzg0NDUyYzhlZWY5 MDk1MTYxMTFmNjg3YWRiNWM5YjdkYmZkNy4uYmRiNmQ2ODBjMjVhZGNjYjQ4ZjFjNjE4OWRlMTQ3 OTE5ZTNhMWQ0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTAzLTEzICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgc29tZSB1bm5l Y2Vzc2FyeSAhVVNFKFVJS0lUX0tFWUJPQVJEX0FERElUSU9OUykgZ3VhcmRzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU3MDMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgb3V0LW9mLWRhdGUg Y29tbWVudCBhbmQgdW5uY2Vzc2FyeSAhVVNFKFVJS0lUX0tFWUJPQVJEX0FERElUSU9OUykgZ3Vh cmRzLiBGb2xsb3dpbmcKKyAgICAgICAgcjI0MDYwNCB3ZSBub3cgbWFrZSB1c2Ugb2YgV2ViQ29y ZTo6d2luZG93c0tleUNvZGVGb3JDaGFyQ29kZSgpIGV2ZW4gZm9yIGhhcmR3YXJlIGtleSBldmVu dHMKKyAgICAgICAgd2hlbiBVU0UoVUlLSVRfS0VZQk9BUkRfQURESVRJT05TKSBpcyBlbmFibGVk LgorCisgICAgICAgIE5vIGZ1bmN0aW9uYWxpdHkgY2hhbmdlZC4gU28sIG5vIG5ldyB0ZXN0cy4K KworICAgICAgICAqIHBsYXRmb3JtL2lvcy9LZXlFdmVudElPUy5tbToKKyAgICAgICAgKFdlYkNv cmU6OndpbmRvd3NLZXlDb2RlRm9yQ2hhckNvZGUpOgorICAgICAgICAqIHBsYXRmb3JtL2lvcy9X ZWJFdmVudC5tbToKKyAgICAgICAgKG5vcm1hbGl6ZWRTdHJpbmdXaXRoQXBwS2l0Q29tcGF0aWJp bGl0eU1hcHBpbmcpOgorCiAyMDE5LTAzLTExICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUu Y29tPgogCiAgICAgICAgIFVzZSBBVkNvbnRlbnRLZXlTZXNzaW9uIGZvciAiY29tLmFwcGxlLmZw cy4yXzAiIENETSB2ZXJzaW9uIHdoZW4gQVZTdHJlYW1TZXNzaW9uIGlzIGFic2VudApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL0tleUV2ZW50SU9TLm1tIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vaW9zL0tleUV2ZW50SU9TLm1tCmluZGV4IDliZjNhODliOGIyZTRj YTc2NTdjNmVjZGZhYWEwZTdiYTQ1Mjc0ODQuLjdjY2M5NjdhZTc3ODUxMGU5MzM0NjU4MDYzNGU5 MjNiMDJhODQwNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9LZXlF dmVudElPUy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvS2V5RXZlbnRJT1Mu bW0KQEAgLTE5Nyw5ICsxOTcsNiBAQCBpbnQgd2luZG93c0tleUNvZGVGb3JLZXlDb2RlKHVpbnQx Nl90IGtleUNvZGUpCiAgICAgcmV0dXJuIDA7IC8vIFVua25vd24ga2V5CiB9CiAKLS8vIFRoaXMg ZnVuY3Rpb24gaXMgb25seSB1c2VkIHRvIG1hcCBzb2Z0d2FyZSBrZXlib2FyZCBldmVudHMgYmVj YXVzZSB0aGV5IGxhY2sgYSBrZXkgY29kZS4KLS8vIFdoZW4gIVVTRShVSUtJVF9LRVlCT0FSRF9B RERJVElPTlMpLCB0aGlzIGZ1bmN0aW9uIGlzIGFsc28gdXNlZCB0byBtYXAgaGFyZHdhcmUga2V5 Ym9hcmQKLS8vIGtleXVwIGV2ZW50cyBiZWNhdXNlIHRoZXkgbGFjayBhIGtleSBjb2RlLgogaW50 IHdpbmRvd3NLZXlDb2RlRm9yQ2hhckNvZGUodW5pY2hhciBjaGFyQ29kZSkKIHsKICAgICBzd2l0 Y2ggKGNoYXJDb2RlKSB7CkBAIC0yNDUsNyArMjQyLDYgQEAgaW50IHdpbmRvd3NLZXlDb2RlRm9y Q2hhckNvZGUodW5pY2hhciBjaGFyQ29kZSkKICAgICBjYXNlICd5JzogY2FzZSAnWSc6IHJldHVy biBWS19ZOwogICAgIGNhc2UgJ3onOiBjYXNlICdaJzogcmV0dXJuIFZLX1o7CiAKLSNpZiAhVVNF KFVJS0lUX0tFWUJPQVJEX0FERElUSU9OUykKICAgICBjYXNlIDB4MUI6IHJldHVybiBWS19FU0NB UEU7IC8vIFdlYktpdCBnZW5lcmF0ZWQgY29kZSBmb3IgRXNjYXBlLgogCiAgICAgLy8gV2ViS2l0 IHVzZXMgVW5pY29kZSBQVUEgY29kZXMgaW4gdGhlIE9wZW5TdGVwIHJlc2VydmUgcmFuZ2UgZm9y IHNvbWUgc3BlY2lhbCBrZXlzLgpAQCAtMjU1LDcgKzI1MSw2IEBAIGludCB3aW5kb3dzS2V5Q29k ZUZvckNoYXJDb2RlKHVuaWNoYXIgY2hhckNvZGUpCiAgICAgY2FzZSBOU1JpZ2h0QXJyb3dGdW5j dGlvbktleTogcmV0dXJuIFZLX1JJR0hUOwogICAgIGNhc2UgTlNQYWdlVXBGdW5jdGlvbktleTog cmV0dXJuIFZLX1BSSU9SOwogICAgIGNhc2UgTlNQYWdlRG93bkZ1bmN0aW9uS2V5OiByZXR1cm4g VktfTkVYVDsKLSNlbmRpZgogCiAgICAgLy8gVGhpcyBpcyBmb3IgVS5TLiBrZXlib2FyZCBtYXBw aW5nLCBhbmQgZG9lc24ndCBuZWNlc3NhcmlseSBtYWtlIHNlbnNlIGZvciBkaWZmZXJlbnQga2V5 Ym9hcmQgbGF5b3V0cy4KICAgICAvLyBGb3IgZXhhbXBsZSwgJyInIG9uIFdpbmRvd3MgUnVzc2lh biBsYXlvdXQgaXMgVktfMiwgbm90IFZLX09FTV83LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vaW9zL1dlYkV2ZW50Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9z L1dlYkV2ZW50Lm1tCmluZGV4IDI2NmI2MTEwZDVjODZhY2UzMDdjZjIyYWViMTAyMGY5Y2EyNTMz ZTcuLmY1MzJhODQxZGY0MTllYzgwYzk4MGFhZWZlNjk3YmNkYjdiMWI3MzMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJFdmVudC5tbQorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9pb3MvV2ViRXZlbnQubW0KQEAgLTE0OSw3ICsxNDksNiBAQCBzdGF0aWMg TlNTdHJpbmcgKm5vcm1hbGl6ZWRTdHJpbmdXaXRoQXBwS2l0Q29tcGF0aWJpbGl0eU1hcHBpbmco TlNTdHJpbmcgKmNoYXJhYwogICAgICAgICByZXR1cm4gQCJceDFCIjsKICAgICBjYXNlIGtISURV c2FnZV9LZXlwYWROdW1Mb2NrOiAvLyBOdW0gTG9jayAvIENsZWFyCiAgICAgICAgIHJldHVybiBt YWtlTlNTdHJpbmdXaXRoQ2hhcmFjdGVyKE5TQ2xlYXJMaW5lRnVuY3Rpb25LZXkpOwotI2lmIFVT RShVSUtJVF9LRVlCT0FSRF9BRERJVElPTlMpCiAgICAgY2FzZSBrSElEVXNhZ2VfS2V5Ym9hcmRE ZWxldGVGb3J3YXJkOgogICAgICAgICByZXR1cm4gbWFrZU5TU3RyaW5nV2l0aENoYXJhY3RlcihO U0RlbGV0ZUZ1bmN0aW9uS2V5KTsKICAgICBjYXNlIGtISURVc2FnZV9LZXlib2FyZEVuZDoKQEAg LTE1OCwxNCArMTU3LDExIEBAIHN0YXRpYyBOU1N0cmluZyAqbm9ybWFsaXplZFN0cmluZ1dpdGhB cHBLaXRDb21wYXRpYmlsaXR5TWFwcGluZyhOU1N0cmluZyAqY2hhcmFjCiAgICAgICAgIHJldHVy biBtYWtlTlNTdHJpbmdXaXRoQ2hhcmFjdGVyKE5TSW5zZXJ0RnVuY3Rpb25LZXkpOwogICAgIGNh c2Uga0hJRFVzYWdlX0tleWJvYXJkSG9tZToKICAgICAgICAgcmV0dXJuIG1ha2VOU1N0cmluZ1dp dGhDaGFyYWN0ZXIoTlNIb21lRnVuY3Rpb25LZXkpOwotI2VuZGlmCiAgICAgfQotI2lmIFVTRShV SUtJVF9LRVlCT0FSRF9BRERJVElPTlMpCiAgICAgaWYgKGtleUNvZGUgPj0ga0hJRFVzYWdlX0tl eWJvYXJkRjEgJiYga2V5Q29kZSA8PSBrSElEVXNhZ2VfS2V5Ym9hcmRGMTIpCiAgICAgICAgIHJl dHVybiBtYWtlTlNTdHJpbmdXaXRoQ2hhcmFjdGVyKE5TRjFGdW5jdGlvbktleSArIChrZXlDb2Rl IC0ga0hJRFVzYWdlX0tleWJvYXJkRjEpKTsKICAgICBpZiAoa2V5Q29kZSA+PSBrSElEVXNhZ2Vf S2V5Ym9hcmRGMTMgJiYga2V5Q29kZSA8PSBrSElEVXNhZ2VfS2V5Ym9hcmRGMjQpCiAgICAgICAg IHJldHVybiBtYWtlTlNTdHJpbmdXaXRoQ2hhcmFjdGVyKE5TRjEzRnVuY3Rpb25LZXkgKyAoa2V5 Q29kZSAtIGtISURVc2FnZV9LZXlib2FyZEYxMykpOwotI2VuZGlmCiAgICAgcmV0dXJuIGNoYXJh Y3RlcnM7CiB9CiAK