195690 2019-03-13 11:59:40 -0700 Web Inspector: Console: add a setting for controlling auto-expansion of Trace messages 2019-03-20 11:58:11 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck timothy webkit-bug-importer oldest_to_newest 1516083 0 hi 2019-03-13 11:59:40 -0700 If a lot of `console.trace` calls are being made rapidly, it can "spam" the log with a lot of information that the developer would have to sift through, especially if all the traces auto-expand. 1516085 1 364558 hi 2019-03-13 12:04:22 -0700 Created attachment 364558 Patch 1516919 2 webkit-bug-importer 2019-03-15 00:02:20 -0700 <rdar://problem/48917329> 1518138 3 364558 joepeck 2019-03-18 21:46:56 -0700 Comment on attachment 364558 Patch Hmm, I'm not sure this deserves a setting. Do we have a good reason for it (other then our Inspector protocol traffic logging?) 1518685 4 hi 2019-03-19 18:16:53 -0700 (In reply to Joseph Pecoraro from comment #3) > Comment on attachment 364558 [details] > Patch > > Hmm, I'm not sure this deserves a setting. Do we have a good reason for it > (other then our Inspector protocol traffic logging?) I don't have a "good" reason, but I have run into situations before where when running `console.trace(a, b)` a LOT of times, I'll only really care about ones with a particular value for `a` or `b`, and having to scroll/filter is a bit annoying. This solves the issue quite nicely :) I would also prefer it to not be expanded by default. Rather than making that choice for everyone, a setting lets each person choose for themself. 1518896 5 timothy 2019-03-20 09:01:32 -0700 I could see this being useful. Would be good to know how often many of these settings get used in the wild, so we can cull the unused ones or ones always enabled. 1519057 6 364558 commit-queue 2019-03-20 11:58:10 -0700 Comment on attachment 364558 Patch Clearing flags on attachment: 364558 Committed r243220: <https://trac.webkit.org/changeset/243220> 1519058 7 commit-queue 2019-03-20 11:58:11 -0700 All reviewed patches have been landed. Closing bug. 364558 2019-03-13 12:04:22 -0700 2019-03-20 11:58:10 -0700 Patch bug-195690-20190313120420.patch text/plain 5204 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM3OGRmNjk4YjAxZmJlYzY2ZGI5Y2VlZmIwODUz NTMxNjU3ZmVhNTAuLjI0MmRlZTlhZGM5ZGI4MDFjY2FhNjZhMDljYjdmNGQyMDEzZjczN2MgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAzLTEzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD b25zb2xlOiBhZGQgYSBzZXR0aW5nIGZvciBjb250cm9sbGluZyBhdXRvLWV4cGFuc2lvbiBvZiBU cmFjZSBtZXNzYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTk1NjkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVNZXNzYWdlVmlldy5qczoKKyAgICAg ICAgKFdJLkNvbnNvbGVNZXNzYWdlVmlldy5wcm90b3R5cGUuX2FwcGVuZFN0YWNrVHJhY2UpOgor CisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL1NldHRpbmcuanM6CisgICAgICAgICogVXNl ckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV0ku U2V0dGluZ3NUYWJDb250ZW50Vmlldy5wcm90b3R5cGUuX2NyZWF0ZUdlbmVyYWxTZXR0aW5nc1Zp ZXcpOgorCisgICAgICAgICogTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdz LmpzOgorCiAyMDE5LTAzLTEyICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBTb3VyY2VzOiBhbGxvdyBpbWFnZSBjb2xsZWN0aW9ucyB0 byBiZSBmaWx0ZXJlZCBieSB0eXBlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv TG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwppbmRl eCA2MDQ1NDk2MWM2NGZlNTlmOWMwM2NiZjlmMTExM2JhMmI3OGNkODgxLi5jOTlmMWVjMjRkNDhl ZjVkY2IyMzlhYjkzNTM1ZGFkODdmYzZmNjAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmlu Z3MuanMKQEAgLTE0Myw2ICsxNDMsNyBAQCBsb2NhbGl6ZWRTdHJpbmdzWyJBdWRpdCB2ZXJzaW9u OiAlcyJdID0gIkF1ZGl0IHZlcnNpb246ICVzIjsKIGxvY2FsaXplZFN0cmluZ3NbIkF1ZGl0cyJd ID0gIkF1ZGl0cyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJBdXRob3IgU3R5bGVzaGVldCJdID0gIkF1 dGhvciBTdHlsZXNoZWV0IjsKIGxvY2FsaXplZFN0cmluZ3NbIkF1dG8gSW5jcmVtZW50Il0gPSAi QXV0byBJbmNyZW1lbnQiOworbG9jYWxpemVkU3RyaW5nc1siQXV0by1leHBhbmQgVHJhY2VzIl0g PSAiQXV0by1leHBhbmQgVHJhY2VzIjsKIGxvY2FsaXplZFN0cmluZ3NbIkF1dG9tYXRpY2FsbHkg Y29udGludWUgYWZ0ZXIgZXZhbHVhdGluZyJdID0gIkF1dG9tYXRpY2FsbHkgY29udGludWUgYWZ0 ZXIgZXZhbHVhdGluZyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJBdmFpbGFibGUgU3R5bGUgU2hlZXRz Il0gPSAiQXZhaWxhYmxlIFN0eWxlIFNoZWV0cyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJBdmVyYWdl IENQVTogJXMiXSA9ICJBdmVyYWdlIENQVTogJXMiOwpAQCAtMjYxLDYgKzI2Miw3IEBAIGxvY2Fs aXplZFN0cmluZ3NbIkNvbnNvbGUgRXZhbHVhdGlvbiAlZCJdID0gIkNvbnNvbGUgRXZhbHVhdGlv biAlZCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJDb25zb2xlIFByb2ZpbGUgUmVjb3JkZWQiXSA9ICJD b25zb2xlIFByb2ZpbGUgUmVjb3JkZWQiOwogbG9jYWxpemVkU3RyaW5nc1siQ29uc29sZSBjbGVh cmVkIGF0ICVzIl0gPSAiQ29uc29sZSBjbGVhcmVkIGF0ICVzIjsKIGxvY2FsaXplZFN0cmluZ3Nb IkNvbnNvbGUgb3BlbmVkIGF0ICVzIl0gPSAiQ29uc29sZSBvcGVuZWQgYXQgJXMiOworbG9jYWxp emVkU3RyaW5nc1siQ29uc29sZToiXSA9ICJDb25zb2xlOiI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJD b250YWluaW5nIl0gPSAiQ29udGFpbmluZyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJDb250ZW50Il0g PSAiQ29udGVudCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJDb250ZW50IFNlY3VyaXR5IFBvbGljeSB2 aW9sYXRpb24gb2YgZGlyZWN0aXZlOiAlcyJdID0gIkNvbnRlbnQgU2VjdXJpdHkgUG9saWN5IHZp b2xhdGlvbiBvZiBkaXJlY3RpdmU6ICVzIjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvU2V0dGluZy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0Jhc2UvU2V0dGluZy5qcwppbmRleCAwOWQ3NzUwNjc3NDExOWUxN2Fi YzFmNGE2YzM0NDljOTYzMDk4NTI1Li44OTQ3MmU0N2I1NDQxZmMwYzJiNjFhNjkzYjFjOTM5NTBl Y2RjNDA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9C YXNlL1NldHRpbmcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv QmFzZS9TZXR0aW5nLmpzCkBAIC0xMjcsNiArMTI3LDcgQEAgV0kuU2V0dGluZy5FdmVudCA9IHsK IFdJLnNldHRpbmdzID0gewogICAgIGNhbnZhc1JlY29yZGluZ0F1dG9DYXB0dXJlRW5hYmxlZDog bmV3IFdJLlNldHRpbmcoImNhbnZhcy1yZWNvcmRpbmctYXV0by1jYXB0dXJlLWVuYWJsZWQiLCBm YWxzZSksCiAgICAgY2FudmFzUmVjb3JkaW5nQXV0b0NhcHR1cmVGcmFtZUNvdW50OiBuZXcgV0ku U2V0dGluZygiY2FudmFzLXJlY29yZGluZy1hdXRvLWNhcHR1cmUtZnJhbWUtY291bnQiLCAxKSwK KyAgICBjb25zb2xlQXV0b0V4cGFuZFRyYWNlOiBuZXcgV0kuU2V0dGluZygiY29uc29sZS1hdXRv LWV4cGFuZC10cmFjZSIsIHRydWUpLAogICAgIGNzc0NoYW5nZXNQZXJOb2RlOiBuZXcgV0kuU2V0 dGluZygiY3NzLWNoYW5nZXMtcGVyLW5vZGUiLCBmYWxzZSksCiAgICAgY2xlYXJMb2dPbk5hdmln YXRlOiBuZXcgV0kuU2V0dGluZygiY2xlYXItbG9nLW9uLW5hdmlnYXRlIiwgdHJ1ZSksCiAgICAg Y2xlYXJOZXR3b3JrT25OYXZpZ2F0ZTogbmV3IFdJLlNldHRpbmcoImNsZWFyLW5ldHdvcmstb24t bmF2aWdhdGUiLCB0cnVlKSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVNZXNzYWdlVmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVNZXNzYWdlVmlldy5qcwppbmRleCA0Y2Y1 OGZkM2ZmZGJhYjE2MTU4NTk0OGEyYzE5ZDAzMTYwYmJmZGUxLi5iNmVhMTBkOGJhN2YwYWQ1Y2U0 OGJhODYxMWYyZTdiMjg0YWVkYWI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlTWVzc2FnZVZpZXcuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZU1lc3NhZ2VWaWV3LmpzCkBA IC0zOTgsOCArMzk4LDcgQEAgV0kuQ29uc29sZU1lc3NhZ2VWaWV3ID0gY2xhc3MgQ29uc29sZU1l c3NhZ2VWaWV3IGV4dGVuZHMgV0kuT2JqZWN0CiAKICAgICAgICAgdGhpcy5fbWFrZUV4cGFuZGFi bGUoKTsKIAotICAgICAgICAvLyBBdXRvLWV4cGFuZCBmb3IgY29uc29sZS50cmFjZS4KLSAgICAg ICAgaWYgKHRoaXMuX21lc3NhZ2UudHlwZSA9PT0gV0kuQ29uc29sZU1lc3NhZ2UuTWVzc2FnZVR5 cGUuVHJhY2UpCisgICAgICAgIGlmICh0aGlzLl9tZXNzYWdlLnR5cGUgPT09IFdJLkNvbnNvbGVN ZXNzYWdlLk1lc3NhZ2VUeXBlLlRyYWNlICYmIFdJLnNldHRpbmdzLmNvbnNvbGVBdXRvRXhwYW5k VHJhY2UudmFsdWUpCiAgICAgICAgICAgICB0aGlzLmV4cGFuZCgpOwogCiAgICAgICAgIHRoaXMu X3N0YWNrVHJhY2VFbGVtZW50ID0gdGhpcy5fZWxlbWVudC5hcHBlbmRDaGlsZChkb2N1bWVudC5j cmVhdGVFbGVtZW50KCJkaXYiKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5q cwppbmRleCA4MDMyYjYyNDVkMzAxZGZiZTkwYTU3M2NmNDNmMjNiNGIyMGNiMmNiLi4wODA2NmNk NDc2NjQwYzY4Y2NhOTczMDdhNjBmOWNhM2MxNDIxM2Q5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRlbnRWaWV3Lmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdz VGFiQ29udGVudFZpZXcuanMKQEAgLTIwOCw2ICsyMDgsNyBAQCBXSS5TZXR0aW5nc1RhYkNvbnRl bnRWaWV3ID0gY2xhc3MgU2V0dGluZ3NUYWJDb250ZW50VmlldyBleHRlbmRzIFdJLlRhYkNvbnRl bnRWaQogCiAgICAgICAgIGdlbmVyYWxTZXR0aW5nc1ZpZXcuYWRkU2V0dGluZyhXSS5VSVN0cmlu ZygiRGVidWdnZXI6IiksIFdJLnNldHRpbmdzLnNob3dTY29wZUNoYWluT25QYXVzZSwgV0kuVUlT dHJpbmcoIlNob3cgU2NvcGUgQ2hhaW4gb24gcGF1c2UiKSk7CiAgICAgICAgIGdlbmVyYWxTZXR0 aW5nc1ZpZXcuYWRkU2V0dGluZyhXSS5VSVN0cmluZygiU291cmNlIG1hcHM6IiksIFdJLnNldHRp bmdzLnNvdXJjZU1hcHNFbmFibGVkLCBXSS5VSVN0cmluZygiRW5hYmxlIHNvdXJjZSBtYXBzIikp OworICAgICAgICBnZW5lcmFsU2V0dGluZ3NWaWV3LmFkZFNldHRpbmcoV0kuVUlTdHJpbmcoIkNv bnNvbGU6IiksIFdJLnNldHRpbmdzLmNvbnNvbGVBdXRvRXhwYW5kVHJhY2UsIFdJLlVJU3RyaW5n KCJBdXRvLWV4cGFuZCBUcmFjZXMiKSk7CiAKICAgICAgICAgZ2VuZXJhbFNldHRpbmdzVmlldy5h ZGRTZXBhcmF0b3IoKTsKIAo=