195687 2019-03-13 11:30:10 -0700 Web Inspector: Protocol Logging: log messages with backtrace if inspector^2 is open 2019-03-13 12:59:11 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1516068 0 hi 2019-03-13 11:30:10 -0700 This would make debugging with inspector2 open SO much nicer, as I could see the trace of each command. 1516070 1 364552 hi 2019-03-13 11:33:05 -0700 Created attachment 364552 Patch 1516071 2 364552 joepeck 2019-03-13 11:35:28 -0700 Comment on attachment 364552 Patch rs=me. Should we have a trace that doesn't auto-expand? 1516084 3 364552 hi 2019-03-13 11:59:48 -0700 Comment on attachment 364552 Patch (In reply to Joseph Pecoraro from comment #2) > Should we have a trace that doesn't auto-expand? Eh, if anything I'd make that a global setting. Creating a specialized path for a non-expanding `console.trace` seems like a detail that developers shouldn't be concerned with (e.g. thats a setting/"preference" of the developer and/or the tools). <https://webkit.org/b/195690> 1516096 4 364552 commit-queue 2019-03-13 12:28:32 -0700 Comment on attachment 364552 Patch Clearing flags on attachment: 364552 Committed r242898: <https://trac.webkit.org/changeset/242898> 1516097 5 commit-queue 2019-03-13 12:28:34 -0700 All reviewed patches have been landed. Closing bug. 1516113 6 webkit-bug-importer 2019-03-13 12:59:11 -0700 <rdar://problem/48859330> 364552 2019-03-13 11:33:05 -0700 2019-03-13 12:28:32 -0700 Patch bug-195687-20190313113304.patch text/plain 1960 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM3OGRmNjk4YjAxZmJlYzY2ZGI5Y2VlZmIwODUz NTMxNjU3ZmVhNTAuLmRlYTUwMDU1MzVlOGRiMDc5ZjAwOGNkMGVmNGQ5OTYwMDEyNzA5NWUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAzLTEzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBQ cm90b2NvbCBMb2dnaW5nOiBsb2cgbWVzc2FnZXMgd2l0aCBiYWNrdHJhY2UgaWYgaW5zcGVjdG9y XjIgaXMgb3BlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk1Njg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBVc2VySW50ZXJmYWNlL1Byb3RvY29sL0xvZ2dpbmdQcm90b2NvbFRyYWNlci5qczoKKyAg ICAgICAgKFdJLkxvZ2dpbmdQcm90b2NvbFRyYWNlci5wcm90b3R5cGUuX3Byb2Nlc3NFbnRyeSk6 CisKIDIwMTktMDMtMTIgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IFNvdXJjZXM6IGFsbG93IGltYWdlIGNvbGxlY3Rpb25zIHRvIGJl IGZpbHRlcmVkIGJ5IHR5cGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1Byb3RvY29sL0xvZ2dpbmdQcm90b2NvbFRyYWNlci5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0xvZ2dpbmdQcm90b2NvbFRyYWNlci5q cwppbmRleCA1MDA5YTMwYjUxMjAxMDg4YzdmMzFhOGU2NjYzNTJmYjYxYWQzNGE0Li5lODRjYTRj YjkzNzI4NmM5ZWRiZTAwMDM1Zjk5MjBiZDU4NDgyMDE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9Mb2dnaW5nUHJvdG9jb2xUcmFjZXIu anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvTG9n Z2luZ1Byb3RvY29sVHJhY2VyLmpzCkBAIC0xMjEsOSArMTIxLDEyIEBAIFdJLkxvZ2dpbmdQcm90 b2NvbFRyYWNlciA9IGNsYXNzIExvZ2dpbmdQcm90b2NvbFRyYWNlciBleHRlbmRzIFdJLlByb3Rv Y29sVHJhY2VyCiAgICAgICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgICAgICBsZXQgcHJl Zml4ID0gYCR7ZW50cnkudHlwZX0gKCR7dGFyZ2V0SWR9KWA7Ci0gICAgICAgICAgICBpZiAoIXdp bmRvdy5JbnNwZWN0b3JUZXN0ICYmIEluc3BlY3RvckZyb250ZW5kSG9zdC5pc0JlaW5nSW5zcGVj dGVkKCkpCi0gICAgICAgICAgICAgICAgdGhpcy5fbG9nVG9Db25zb2xlKHByZWZpeCwgZW50cnku bWVzc2FnZSk7Ci0gICAgICAgICAgICBlbHNlCisgICAgICAgICAgICBpZiAoIXdpbmRvdy5JbnNw ZWN0b3JUZXN0ICYmIEluc3BlY3RvckZyb250ZW5kSG9zdC5pc0JlaW5nSW5zcGVjdGVkKCkpIHsK KyAgICAgICAgICAgICAgICBpZiAoZW50cnkudHlwZSA9PT0gInJlcXVlc3QiIHx8IGVudHJ5LnR5 cGUgPT09ICJleGNlcHRpb24iKQorICAgICAgICAgICAgICAgICAgICBjb25zb2xlLnRyYWNlKHBy ZWZpeCwgZW50cnkubWVzc2FnZSk7CisgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAg ICAgICAgICB0aGlzLl9sb2dUb0NvbnNvbGUocHJlZml4LCBlbnRyeS5tZXNzYWdlKTsKKyAgICAg ICAgICAgIH0gZWxzZQogICAgICAgICAgICAgICAgIHRoaXMuX2xvZ1RvQ29uc29sZShgJHtwcmVm aXh9OiAke0pTT04uc3RyaW5naWZ5KGVudHJ5Lm1lc3NhZ2UpfWApOwogCiAgICAgICAgICAgICBp ZiAoZW50cnkuZXhjZXB0aW9uKSB7Cg==