195683 2019-03-13 10:26:00 -0700 REGRESSION(r240634): Element::hasPointerCapture() passes a JS-controlled value directly into a HashMap as a key 2019-03-20 13:35:30 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts achristensen mmaxfield webkit-bug-importer oldest_to_newest 1516021 0 graouts 2019-03-13 10:26:00 -0700 We need to allow 0 as a valid pointer ID passed through the Element methods. 1516022 1 graouts 2019-03-13 10:26:11 -0700 <rdar://problem/48659950> 1516026 2 364545 graouts 2019-03-13 10:29:57 -0700 Created attachment 364545 Patch 1516055 3 364545 achristensen 2019-03-13 11:00:29 -0700 Comment on attachment 364545 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364545&action=review code looks good, needs better test. rs=me > LayoutTests/pointerevents/zero-pointer-id-crash-expected.txt:2 > +PASS Checking 0 can be used as a Pointer ID. You should also check INT_MAX, INT_MIN, INT_MAX + 1, INT_MIN - 1 1516059 4 graouts 2019-03-13 11:12:24 -0700 (In reply to Alex Christensen from comment #3) > Comment on attachment 364545 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364545&action=review > > code looks good, needs better test. rs=me > > > LayoutTests/pointerevents/zero-pointer-id-crash-expected.txt:2 > > +PASS Checking 0 can be used as a Pointer ID. > > You should also check INT_MAX, INT_MIN, INT_MAX + 1, INT_MIN - 1 Will fix in commit. 1516061 5 graouts 2019-03-13 11:14:25 -0700 Committed r242893: <https://trac.webkit.org/changeset/242893> 1519144 6 graouts 2019-03-20 13:35:30 -0700 Committed r243235: <https://trac.webkit.org/changeset/243235> 364545 2019-03-13 10:29:57 -0700 2019-03-13 11:00:29 -0700 Patch bug-195683-20190313102956.patch text/plain 4346 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyNzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTcwYTA5MjQxOTU3N2M4 NDQ2Y2Q3NjcxNDYxMzE0YmI1NzIxNGMxMC4uMTUxYmRjYmI3YzgyNmNlMGY5YjFiZjdhOGJkYjA0 NGZjNzNjZGE3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAzLTEzICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjQw NjM0KTogRWxlbWVudDo6aGFzUG9pbnRlckNhcHR1cmUoKSBwYXNzZXMgYSBKUy1jb250cm9sbGVk IHZhbHVlIGRpcmVjdGx5IGludG8gYSBIYXNoTWFwIGFzIGEga2V5CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU2ODMKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzQ4NjU5OTUwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdoaWxlIFBvaW50ZXJJRCBpcyBkZWZpbmVkIGFzIGludDMyX3QsIHdlIG5vdyB1 c2UgaW50NjRfdCBhcyB0aGUga2V5IG9mIHRoZSBIYXNoTWFwIG1hcHBpbmcgUG9pbnRlcklEIHRv IENhcHR1cmluZ0RhdGEgc28gdGhhdCB3ZSB1c2UKKyAgICAgICAgYSB2YWx1ZSBvdXRzaWRlIG9m IHRoZSBpbnQzMl90IHJhbmdlIGFzIGEgc2FmZSBlbXB0eSBhbmQgcmVtb3ZlZCB2YWx1ZXMsIGFs bG93aW5nIGFueSBpbnQzMl90IHRvIGJlIHByb3ZpZGVkIHRocm91Z2ggdGhlIEFQSSBmb3IKKyAg ICAgICAgbG9va3VwIGluIHRoaXMgSGFzaE1hcC4KKworICAgICAgICBUZXN0OiBwb2ludGVyZXZl bnRzL3plcm8tcG9pbnRlci1pZC1jcmFzaC5odG1sCisKKyAgICAgICAgKiBwYWdlL1BvaW50ZXJD YXB0dXJlQ29udHJvbGxlci5oOgorCiAyMDE5LTAzLTEyICBSeW9zdWtlIE5pd2EgIDxybml3YUB3 ZWJraXQub3JnPgogCiAgICAgICAgIEluIENhY2hlZEZyYW1lJ3MgY29uc3RydWN0b3IsIHJlbGVh c2UtYXNzZXJ0IHRoYXQgRE9NV2luZG93IHN0aWxsIGhhcyBhIGZyYW1lIGFmdGVyIHBhZ2UtY2Fj aGluZyBzdWJmcmFtZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUG9pbnRlckNh cHR1cmVDb250cm9sbGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BvaW50ZXJDYXB0dXJlQ29u dHJvbGxlci5oCmluZGV4IGI2MTg0Y2IwMTQyZmU1MDM3ZTU1MGY5Y2NmODFkOGRlYmJiMjk2MTMu LjE3MzM0MWRhNDM5YmI1NTY3OWNlMGI0NzlhY2QyNWE1YjdmZjdlM2EgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvUG9pbnRlckNhcHR1cmVDb250cm9sbGVyLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGFnZS9Qb2ludGVyQ2FwdHVyZUNvbnRyb2xsZXIuaApAQCAtNjksNyArNjksMTAg QEAgcHJpdmF0ZToKICAgICB2b2lkIHByb2Nlc3NQZW5kaW5nUG9pbnRlckNhcHR1cmUoY29uc3Qg UG9pbnRlckV2ZW50Jik7CiAKICAgICBQYWdlJiBtX3BhZ2U7Ci0gICAgSGFzaE1hcDxQb2ludGVy SUQsIENhcHR1cmluZ0RhdGE+IG1fYWN0aXZlUG9pbnRlcklkc1RvQ2FwdHVyaW5nRGF0YTsKKyAg ICAvLyBXaGlsZSBQb2ludGVySUQgaXMgZGVmaW5lZCBhcyBpbnQzMl90LCB3ZSB1c2UgaW50NjRf dCBoZXJlIHNvIHRoYXQgd2UgbWF5IHVzZSBhIHZhbHVlIG91dHNpZGUgb2YgdGhlIGludDMyX3Qg cmFuZ2UgdG8gaGF2ZSBzYWZlCisgICAgLy8gZW1wdHkgYW5kIHJlbW92ZWQgdmFsdWVzLCBhbGxv d2luZyBhbnkgaW50MzJfdCB0byBiZSBwcm92aWRlZCB0aHJvdWdoIHRoZSBBUEkgZm9yIGxvb2t1 cCBpbiB0aGlzIGhhc2htYXAuCisgICAgdXNpbmcgUG9pbnRlcklkVG9DYXB0dXJpbmdEYXRhTWFw ID0gSGFzaE1hcDxpbnQ2NF90LCBDYXB0dXJpbmdEYXRhLCBXVEY6OkludEhhc2g8aW50NjRfdD4s IFdURjo6U2lnbmVkV2l0aFplcm9LZXlIYXNoVHJhaXRzPGludDY0X3Q+PjsKKyAgICBQb2ludGVy SWRUb0NhcHR1cmluZ0RhdGFNYXAgbV9hY3RpdmVQb2ludGVySWRzVG9DYXB0dXJpbmdEYXRhOwog fTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDBjOGU1OWUyODUzMzkxYzJmNjc1 YzE3ZmFlMTg5ZGJlNTAyMjE2ZDkuLmIxZGU2Yjk1ZTg2ZDQ2YWY3ZGUzMzExZmFhMmNkZDIwY2Vi OTAwYzUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOS0wMy0xMyAgQW50b2luZSBRdWludCAg PGdyYW91dHNAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI0MDYzNCk6IEVsZW1l bnQ6Omhhc1BvaW50ZXJDYXB0dXJlKCkgcGFzc2VzIGEgSlMtY29udHJvbGxlZCB2YWx1ZSBkaXJl Y3RseSBpbnRvIGEgSGFzaE1hcCBhcyBhIGtleQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1NjgzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80ODY1 OTk1MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgYSBuZXcgdGVzdCB3aGljaCB3b3VsZCBjcmFzaCBpbiBkZWJ1ZyBidWlsZHMgcHJpb3IgdG8g dGhpcyBmaXguCisKKyAgICAgICAgKiBwb2ludGVyZXZlbnRzL3plcm8tcG9pbnRlci1pZC1jcmFz aC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHBvaW50ZXJldmVudHMvemVyby1wb2lu dGVyLWlkLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDE5LTAzLTEyICBBbnR0aSBLb2l2aXN0byAg PGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBDb21wb3NpdGluZyBsYXllciB0aGF0IHJlbmRl cnMgdHdvIHBvc2l0aW9uZWQgZWxlbWVudHMgc2hvdWxkIG5vdCBoaXQgdGVzdApkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcG9pbnRlcmV2ZW50cy96ZXJvLXBvaW50ZXItaWQtY3Jhc2gtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvcG9pbnRlcmV2ZW50cy96ZXJvLXBvaW50ZXItaWQtY3Jhc2gt ZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjNiYTJiNmNkOTI4MmMwZGQ4ZjZlNTBlNGJkZTViZWQz OTYwMmE4ODcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wb2ludGVyZXZlbnRzL3pl cm8tcG9pbnRlci1pZC1jcmFzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBACisKK1BBU1Mg Q2hlY2tpbmcgMCBjYW4gYmUgdXNlZCBhcyBhIFBvaW50ZXIgSUQuIAorCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wb2ludGVyZXZlbnRzL3plcm8tcG9pbnRlci1pZC1jcmFzaC5odG1sIGIvTGF5 b3V0VGVzdHMvcG9pbnRlcmV2ZW50cy96ZXJvLXBvaW50ZXItaWQtY3Jhc2guaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi4wZGVhYTMzNjFlNGMwN2M2NDgyZTE1M2E0MzAzNzE0ZDFhZjk0MWZiCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvcG9pbnRlcmV2ZW50cy96ZXJvLXBvaW50ZXItaWQtY3Jhc2gu aHRtbApAQCAtMCwwICsxLDIzIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8 bWV0YSBjaGFyc2V0PXV0Zi04PgorPC9oZWFkPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0iLi4vcmVz b3VyY2VzL3Rlc3RoYXJuZXNzLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJj ZXMvdGVzdGhhcm5lc3NyZXBvcnQuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KKworJ3VzZSBzdHJp Y3QnOworCit0ZXN0KCgpID0+IHsKKyAgICBjb25zdCBlbGVtZW50ID0gZG9jdW1lbnQuYm9keS5h cHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKSk7CisgICAgZWxlbWVudC5o YXNQb2ludGVyQ2FwdHVyZSgwKTsKKyAgICBhc3NlcnRfdGhyb3dzKCJOb3RGb3VuZEVycm9yIiwg KCkgPT4gZWxlbWVudC5zZXRQb2ludGVyQ2FwdHVyZSgwKSkKKyAgICBhc3NlcnRfdGhyb3dzKCJO b3RGb3VuZEVycm9yIiwgKCkgPT4gZWxlbWVudC5yZWxlYXNlUG9pbnRlckNhcHR1cmUoMCkpCisg ICAgZWxlbWVudC5yZW1vdmUoKTsKK30sICJDaGVja2luZyAwIGNhbiBiZSB1c2VkIGFzIGEgUG9p bnRlciBJRC4iKTsKKworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBh dCBlbmQgb2YgZmlsZQo=