195673 2019-03-13 07:14:54 -0700 [GStreamer][WebRTC] Do not sync encoder on the clock 2019-03-13 09:31:06 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsaunier tsaunier commit-queue pnormand webkit-bug-importer oldest_to_newest 1515950 0 tsaunier 2019-03-13 07:14:54 -0700 [GStreamer][WebRTC] Do not sync encoder on the clock 1515951 1 364527 tsaunier 2019-03-13 07:15:18 -0700 Created attachment 364527 Patch 1515964 2 364527 pnormand 2019-03-13 07:41:48 -0700 Comment on attachment 364527 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364527&action=review > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:145 > + g_object_set(sink, "sync", FALSE, NULL); Please at least remain consistent with the code below and use nullptr :) 1515971 3 364535 tsaunier 2019-03-13 08:06:21 -0700 Created attachment 364535 Patch for landing 1515972 4 364535 commit-queue 2019-03-13 08:08:10 -0700 Comment on attachment 364535 Patch for landing Rejecting attachment 364535 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 364535, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/11489929 1515976 5 364536 tsaunier 2019-03-13 08:30:11 -0700 Created attachment 364536 Patch for landing 1515985 6 364536 commit-queue 2019-03-13 09:08:20 -0700 Comment on attachment 364536 Patch for landing Clearing flags on attachment: 364536 Committed r242883: <https://trac.webkit.org/changeset/242883> 1515986 7 commit-queue 2019-03-13 09:08:22 -0700 All reviewed patches have been landed. Closing bug. 1515993 8 webkit-bug-importer 2019-03-13 09:31:06 -0700 <rdar://problem/48849834> 364527 2019-03-13 07:15:18 -0700 2019-03-13 08:06:17 -0700 Patch bug-195673-20190313111517.patch text/plain 1794 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Q0NWMzYWUzNTU5ZmE2 ZmM5Yjk2ODY5ZjkxNjJkOGFhNDIyNDE4Ni4uZmVkOGE5ZDRlZjgzOTE5MWUwOTU0ZmFlNDFiNDYy MjJhZTg1NTcwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAzLTEzICBUaGli YXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XVtXZWJSVENdIERvIG5vdCBzeW5jIGVuY29kZXIgb24gdGhlIGNsb2NrCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU2NzMKKworICAgICAgICB3ZSBz aG91bGQgZW5jb2RlIGFzIGZhc3QgYXMgcG9zc2libGUgYW5kIHRvdGFsbHkgaWdub3JlIHRpbWVz dGFtcCB3aGlsZQorICAgICAgICBkb2luZyBzby4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9H U3RyZWFtZXJWaWRlb0VuY29kZXJGYWN0b3J5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdTdHJl YW1lclZpZGVvRW5jb2Rlcjo6SW5pdEVuY29kZSk6CisKIDIwMTktMDMtMTMgIE1pZ3VlbCBHb21l eiAgPG1hZ29tZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ29vcmRpbmF0ZWRHcmFwaGljc10g TnVsbCBkZXJlZmVyZW5jZSBpbiBDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXI6OnNldENvb3JkaW5h dG9ySW5jbHVkaW5nU3ViTGF5ZXJzSWZOZWVkZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9HU3RyZWFtZXJWaWRlb0VuY29kZXJGYWN0 b3J5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9H U3RyZWFtZXJWaWRlb0VuY29kZXJGYWN0b3J5LmNwcAppbmRleCA3ZjBkNDgyMjFmNDRjNThkMzU4 ZTU3MjQ5NjNhMzA4NTJlMTMzMTA0Li4xMDZhN2RjOTI3NDQwNjhjYjg0NjA3NzhkMzhjZGZlNTBi NDAzMjc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9s aWJ3ZWJydGMvR1N0cmVhbWVyVmlkZW9FbmNvZGVyRmFjdG9yeS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0dTdHJlYW1lclZpZGVvRW5jb2Rl ckZhY3RvcnkuY3BwCkBAIC0xNDIsNiArMTQyLDcgQEAgcHVibGljOgogICAgICAgICBhdXRvIHNp bmsgPSBtYWtlRWxlbWVudCgiYXBwc2luayIpOwogICAgICAgICBnc3RfYXBwX3Npbmtfc2V0X2Vt aXRfc2lnbmFscyhHU1RfQVBQX1NJTksoc2luayksIFRSVUUpOwogICAgICAgICBnX3NpZ25hbF9j b25uZWN0KHNpbmssICJuZXctc2FtcGxlIiwgR19DQUxMQkFDSyhuZXdTYW1wbGVDYWxsYmFja1Ry YW1wKSwgdGhpcyk7CisgICAgICAgIGdfb2JqZWN0X3NldChzaW5rLCAic3luYyIsIEZBTFNFLCBO VUxMKTsKIAogICAgICAgICBhdXRvIG5hbWUgPSBtYWtlU3RyaW5nKE5hbWUoKSwgIl9lbmNfcmF3 Y2Fwc2ZpbHRlcl8weCIsIGhleChyZWludGVycHJldF9jYXN0PHVpbnRwdHJfdD4odGhpcykpKTsK ICAgICAgICAgbV9jYXBzRmlsdGVyID0gZ3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJjYXBzZmls dGVyIiwgbmFtZS51dGY4KCkuZGF0YSgpKTsK 364535 2019-03-13 08:06:21 -0700 2019-03-13 08:30:07 -0700 Patch for landing bug-195673-20190313120620.patch text/plain 1797 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Q0NWMzYWUzNTU5ZmE2 ZmM5Yjk2ODY5ZjkxNjJkOGFhNDIyNDE4Ni4uZmVkOGE5ZDRlZjgzOTE5MWUwOTU0ZmFlNDFiNDYy MjJhZTg1NTcwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAzLTEzICBUaGli YXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XVtXZWJSVENdIERvIG5vdCBzeW5jIGVuY29kZXIgb24gdGhlIGNsb2NrCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU2NzMKKworICAgICAgICB3ZSBz aG91bGQgZW5jb2RlIGFzIGZhc3QgYXMgcG9zc2libGUgYW5kIHRvdGFsbHkgaWdub3JlIHRpbWVz dGFtcCB3aGlsZQorICAgICAgICBkb2luZyBzby4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9H U3RyZWFtZXJWaWRlb0VuY29kZXJGYWN0b3J5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdTdHJl YW1lclZpZGVvRW5jb2Rlcjo6SW5pdEVuY29kZSk6CisKIDIwMTktMDMtMTMgIE1pZ3VlbCBHb21l eiAgPG1hZ29tZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ29vcmRpbmF0ZWRHcmFwaGljc10g TnVsbCBkZXJlZmVyZW5jZSBpbiBDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXI6OnNldENvb3JkaW5h dG9ySW5jbHVkaW5nU3ViTGF5ZXJzSWZOZWVkZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9HU3RyZWFtZXJWaWRlb0VuY29kZXJGYWN0 b3J5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9H U3RyZWFtZXJWaWRlb0VuY29kZXJGYWN0b3J5LmNwcAppbmRleCA3ZjBkNDgyMjFmNDRjNThkMzU4 ZTU3MjQ5NjNhMzA4NTJlMTMzMTA0Li44YjBlMTA5NzM0NTk5ZTM5YWFhMjk1MzRmZWY4NDg3YTFj ZGFmN2IyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9s aWJ3ZWJydGMvR1N0cmVhbWVyVmlkZW9FbmNvZGVyRmFjdG9yeS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0dTdHJlYW1lclZpZGVvRW5jb2Rl ckZhY3RvcnkuY3BwCkBAIC0xNDIsNiArMTQyLDcgQEAgcHVibGljOgogICAgICAgICBhdXRvIHNp bmsgPSBtYWtlRWxlbWVudCgiYXBwc2luayIpOwogICAgICAgICBnc3RfYXBwX3Npbmtfc2V0X2Vt aXRfc2lnbmFscyhHU1RfQVBQX1NJTksoc2luayksIFRSVUUpOwogICAgICAgICBnX3NpZ25hbF9j b25uZWN0KHNpbmssICJuZXctc2FtcGxlIiwgR19DQUxMQkFDSyhuZXdTYW1wbGVDYWxsYmFja1Ry YW1wKSwgdGhpcyk7CisgICAgICAgIGdfb2JqZWN0X3NldChzaW5rLCAic3luYyIsIEZBTFNFLCBu dWxscHRyKTsKIAogICAgICAgICBhdXRvIG5hbWUgPSBtYWtlU3RyaW5nKE5hbWUoKSwgIl9lbmNf cmF3Y2Fwc2ZpbHRlcl8weCIsIGhleChyZWludGVycHJldF9jYXN0PHVpbnRwdHJfdD4odGhpcykp KTsKICAgICAgICAgbV9jYXBzRmlsdGVyID0gZ3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJjYXBz ZmlsdGVyIiwgbmFtZS51dGY4KCkuZGF0YSgpKTsK 364536 2019-03-13 08:30:11 -0700 2019-03-13 09:08:20 -0700 Patch for landing bug-195673-20190313123010.patch text/plain 1799 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Q0NWMzYWUzNTU5ZmE2 ZmM5Yjk2ODY5ZjkxNjJkOGFhNDIyNDE4Ni4uZTIyNjRkNTczZmFiZTJkNGEzYzZkOWJiOTE3MGY3 ZWQ2ODlmYzc3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAzLTEzICBUaGli YXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XVtXZWJSVENdIERvIG5vdCBzeW5jIGVuY29kZXIgb24gdGhlIGNsb2NrCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU2NzMKKworICAgICAgICB3ZSBz aG91bGQgZW5jb2RlIGFzIGZhc3QgYXMgcG9zc2libGUgYW5kIHRvdGFsbHkgaWdub3JlIHRpbWVz dGFtcCB3aGlsZQorICAgICAgICBkb2luZyBzby4KKworICAgICAgICBSZXZpZXdlZCBieSBQaGls aXBwZSBOb3JtYW5kLgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRj L0dTdHJlYW1lclZpZGVvRW5jb2RlckZhY3RvcnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R1N0 cmVhbWVyVmlkZW9FbmNvZGVyOjpJbml0RW5jb2RlKToKKwogMjAxOS0wMy0xMyAgTWlndWVsIEdv bWV6ICA8bWFnb21lekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtDb29yZGluYXRlZEdyYXBoaWNz XSBOdWxsIGRlcmVmZXJlbmNlIGluIENvb3JkaW5hdGVkR3JhcGhpY3NMYXllcjo6c2V0Q29vcmRp bmF0b3JJbmNsdWRpbmdTdWJMYXllcnNJZk5lZWRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0dTdHJlYW1lclZpZGVvRW5jb2RlckZh Y3RvcnkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRj L0dTdHJlYW1lclZpZGVvRW5jb2RlckZhY3RvcnkuY3BwCmluZGV4IDdmMGQ0ODIyMWY0NGM1OGQz NThlNTcyNDk2M2EzMDg1MmUxMzMxMDQuLjhiMGUxMDk3MzQ1OTllMzlhYWEyOTUzNGZlZjg0ODdh MWNkYWY3YjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFt L2xpYndlYnJ0Yy9HU3RyZWFtZXJWaWRlb0VuY29kZXJGYWN0b3J5LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvR1N0cmVhbWVyVmlkZW9FbmNv ZGVyRmFjdG9yeS5jcHAKQEAgLTE0Miw2ICsxNDIsNyBAQCBwdWJsaWM6CiAgICAgICAgIGF1dG8g c2luayA9IG1ha2VFbGVtZW50KCJhcHBzaW5rIik7CiAgICAgICAgIGdzdF9hcHBfc2lua19zZXRf ZW1pdF9zaWduYWxzKEdTVF9BUFBfU0lOSyhzaW5rKSwgVFJVRSk7CiAgICAgICAgIGdfc2lnbmFs X2Nvbm5lY3Qoc2luaywgIm5ldy1zYW1wbGUiLCBHX0NBTExCQUNLKG5ld1NhbXBsZUNhbGxiYWNr VHJhbXApLCB0aGlzKTsKKyAgICAgICAgZ19vYmplY3Rfc2V0KHNpbmssICJzeW5jIiwgRkFMU0Us IG51bGxwdHIpOwogCiAgICAgICAgIGF1dG8gbmFtZSA9IG1ha2VTdHJpbmcoTmFtZSgpLCAiX2Vu Y19yYXdjYXBzZmlsdGVyXzB4IiwgaGV4KHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90Pih0aGlz KSkpOwogICAgICAgICBtX2NhcHNGaWx0ZXIgPSBnc3RfZWxlbWVudF9mYWN0b3J5X21ha2UoImNh cHNmaWx0ZXIiLCBuYW1lLnV0ZjgoKS5kYXRhKCkpOwo=