195669 2019-03-13 05:26:55 -0700 [ews-app] Remove unused patch view 2019-03-13 10:13:45 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu lforschler slewis webkit-bug-importer oldest_to_newest 1515939 0 aakash_jain 2019-03-13 05:26:55 -0700 We recently added (in https://bugs.webkit.org/show_bug.cgi?id=195477) submit-to-ews url which add capability to submit a patch id to ews. We should remove the unused patch view from ews-app. 1515940 1 364524 aakash_jain 2019-03-13 05:29:10 -0700 Created attachment 364524 Proposed patch 1516006 2 364524 commit-queue 2019-03-13 10:11:33 -0700 Comment on attachment 364524 Proposed patch Clearing flags on attachment: 364524 Committed r242885: <https://trac.webkit.org/changeset/242885> 1516007 3 commit-queue 2019-03-13 10:11:34 -0700 All reviewed patches have been landed. Closing bug. 1516011 4 webkit-bug-importer 2019-03-13 10:13:45 -0700 <rdar://problem/48851529> 364524 2019-03-13 05:29:10 -0700 2019-03-13 10:11:33 -0700 Proposed patch remove-unused-patch-view.patch text/plain 3506 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Mjg4MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTAzLTEzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gUmVtb3ZlIHVudXNlZCBwYXRjaCB2aWV3CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU2NjkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBw b3J0L2V3cy1hcHAvZXdzL3VybHMucHk6CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWFwcC9ld3Mvdmlld3MvcGF0Y2gucHk6IFJlbW92ZWQuCisKIDIwMTktMDMtMTMgIEFha2FzaCBK YWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtld3MtYXBwXSBzdGF0dXMg YnViYmxlIHNob3VsZCBiZSBoaWRkZW4gZm9yIGNlcnRhaW4gYnVpbGRzCkluZGV4OiBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy91cmxzLnB5Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3VybHMucHkJKHJldmlzaW9uIDI0Mjg4MCkK KysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3VybHMucHkJKHdvcmtpbmcg Y29weSkKQEAgLTIzLDcgKzIzLDYgQEAKIGZyb20gZGphbmdvLmNvbmYudXJscyBpbXBvcnQgdXJs CiAKIGZyb20gZXdzLnZpZXdzLmluZGV4IGltcG9ydCBJbmRleAotZnJvbSBld3Mudmlld3MucGF0 Y2ggaW1wb3J0IFBhdGNoCiBmcm9tIGV3cy52aWV3cy5yZXN1bHRzIGltcG9ydCBSZXN1bHRzCiBm cm9tIGV3cy52aWV3cy5zdGF0dXNidWJibGUgaW1wb3J0IFN0YXR1c0J1YmJsZQogZnJvbSBld3Mu dmlld3Muc3VibWl0dG9ld3MgaW1wb3J0IFN1Ym1pdFRvRVdTCkBAIC0zMiw4ICszMSw2IEBAIGFw cF9uYW1lID0gJ2V3cycKIHVybHBhdHRlcm5zID0gWwogICAgICMgZXg6IC8KICAgICB1cmwocide JCcsIEluZGV4LmFzX3ZpZXcoKSwgbmFtZT0naW5kZXgnKSwKLSAgICAjIGV4OiAvcGF0Y2gvNQot ICAgIHVybChyJ15wYXRjaC8oP1A8cGF0Y2hfaWQ+WzAtOV0rKS8kJywgUGF0Y2guYXNfdmlldygp LCBuYW1lPSdwYXRjaCcpLAogICAgICMgZXg6IC9yZXN1bHRzLwogICAgIHVybChyJ15yZXN1bHRz LyQnLCBSZXN1bHRzLmFzX3ZpZXcoKSwgbmFtZT0ncmVzdWx0cycpLAogICAgICMgZXg6IC9zdGF0 dXMtYnViYmxlLzUKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3Zp ZXdzL3BhdGNoLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1h cHAvZXdzL3ZpZXdzL3BhdGNoLnB5CShyZXZpc2lvbiAyNDI4ODApCisrKyBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9wYXRjaC5weQkobm9uZXhpc3RlbnQpCkBAIC0x LDM1ICswLDAgQEAKLSMgQ29weXJpZ2h0IChDKSAyMDE4LTIwMTkgQXBwbGUgSW5jLiBBbGwgcmln aHRzIHJlc2VydmVkLgotIwotIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQg YmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKLSMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0 dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCi0jIGFyZSBtZXQ6Ci0j IDEuICBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3Zl IGNvcHlyaWdodAotIyAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhl IGZvbGxvd2luZyBkaXNjbGFpbWVyLgotIyAyLiAgUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBm b3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKLSMgICAgIG5vdGljZSwgdGhp cyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUK LSMgICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRo IHRoZSBkaXN0cmlidXRpb24uCi0jCi0jIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQ TEUgSU5DLiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFTIElTJycgQU5ECi0jIEFOWSBFWFBSRVNT IE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRI RSBJTVBMSUVECi0jIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZP UiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUKLSMgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hB TEwgQVBQTEUgSU5DLiBPUiBJVFMgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IKLSMgQU5ZIERJ UkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VR VUVOVElBTAotIyBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgUFJPQ1VS RU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUgotIyBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERB VEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUgotIyBDQVVT RUQgQU5EIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBT VFJJQ1QgTElBQklMSVRZLAotIyBPUiBUT1JUIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhF UldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQotIyBPRiBUSElTIFNPRlRX QVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgot Ci1mcm9tIF9fZnV0dXJlX18gaW1wb3J0IHVuaWNvZGVfbGl0ZXJhbHMKLQotZnJvbSBkamFuZ28u aHR0cCBpbXBvcnQgSHR0cFJlc3BvbnNlCi1mcm9tIGRqYW5nby5zaG9ydGN1dHMgaW1wb3J0IHJl bmRlcgotZnJvbSBkamFuZ28udmlld3MgaW1wb3J0IFZpZXcKLQotCi1jbGFzcyBQYXRjaChWaWV3 KToKLSAgICBkZWYgZ2V0KHNlbGYsIHJlcXVlc3QsIHBhdGNoX2lkKToKLSAgICAgICAgcmV0dXJu IEh0dHBSZXNwb25zZSgiUGxhY2Vob2xkZXIgZm9yIHBhdGNoIHt9LiIuZm9ybWF0KHBhdGNoX2lk KSkKLQotICAgIGRlZiBwb3N0KHNlbGYsIHJlcXVlc3QsIHBhdGNoX2lkKToKLSAgICAgICAgcmV0 dXJuIEh0dHBSZXNwb25zZSgiUGxhY2Vob2xkZXIgdG8gaGFuZGxlIHBvc3QgcmVxdWVzdCBmb3Ig cGF0Y2gge30uIi5mb3JtYXQocGF0Y2hfaWQpKQo=