195668 2019-03-13 04:24:53 -0700 [ews-app] Use Buildbot result code variables 2019-03-13 10:04:20 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu jbedard kocsen_chung lforschler slewis webkit-bug-importer oldest_to_newest 1515928 0 aakash_jain 2019-03-13 04:24:53 -0700 Buildbot result codes are integers (e.g.: 0 for SUCCESS, 1 for WARNINGS etc.). Instead of referring these integers in ews-app code, we should save these values in corresponding variables and refer them by name. It would make the code more readable. These result codes are defined in https://github.com/buildbot/buildbot/blob/master/master/buildbot/process/results.py 1515932 1 364521 aakash_jain 2019-03-13 04:43:57 -0700 Created attachment 364521 Proposed patch 1515991 2 jbedard 2019-03-13 09:26:47 -0700 Unofficial r=me. 1516002 3 364521 commit-queue 2019-03-13 10:03:48 -0700 Comment on attachment 364521 Proposed patch Clearing flags on attachment: 364521 Committed r242884: <https://trac.webkit.org/changeset/242884> 1516003 4 commit-queue 2019-03-13 10:03:49 -0700 All reviewed patches have been landed. Closing bug. 1516004 5 webkit-bug-importer 2019-03-13 10:04:20 -0700 <rdar://problem/48851133> 364521 2019-03-13 04:43:57 -0700 2019-03-13 10:03:48 -0700 Proposed patch buildbot-result-codes.patch text/plain 3891 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Mjg4MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTAzLTEzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gVXNlIEJ1aWxkYm90IHJlc3VsdCBjb2RlIHZhcmlhYmxl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1NjY4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWls ZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb21tb24vYnVpbGRib3QucHk6CisgICAgICAgIChC dWlsZGJvdCk6IEFkZGVkIEJ1aWxkYm90IHJlc3VsdCBjb2RlIHZhcmlhYmxlcy4KKyAgICAgICAg KiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJibGUucHk6Cisg ICAgICAgIChTdGF0dXNCdWJibGUuX2J1aWxkX2J1YmJsZSk6IFVzZWQgQnVpbGRib3QgcmVzdWx0 IGNvZGUgdmFyaWFibGVzLgorCiAyMDE5LTAzLTEzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWlu QGFwcGxlLmNvbT4KIAogICAgICAgICBbZXdzLWFwcF0gc3RhdHVzIGJ1YmJsZSBzaG91bGQgYmUg aGlkZGVuIGZvciBjZXJ0YWluIGJ1aWxkcwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv ZXdzLWFwcC9ld3MvY29tbW9uL2J1aWxkYm90LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbW1vbi9idWlsZGJvdC5weQkocmV2aXNpb24gMjQy ODgwKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvY29tbW9uL2J1aWxk Ym90LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yMCw2ICsyMCw4IEBACiAjIE9SIFRPUlQgKElOQ0xV RElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBU SEUgVVNFCiAjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lC SUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKK2Zyb20gZnV0dXJlLnV0aWxzIGltcG9ydCBscmFuZ2UK KwogaW1wb3J0IGxvZ2dpbmcKIGltcG9ydCBvcwogaW1wb3J0IHJlCkBAIC0zMiw2ICszNCwxMCBA QCBfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1lX18pCiAKIAogY2xhc3MgQnVpbGRib3Qo KToKKyAgICAjIEJ1aWxkYm90IHN0YXR1cyBjb2RlcyByZWZlcmVuY2VkIGZyb20gaHR0cHM6Ly9n aXRodWIuY29tL2J1aWxkYm90L2J1aWxkYm90L2Jsb2IvbWFzdGVyL21hc3Rlci9idWlsZGJvdC9w cm9jZXNzL3Jlc3VsdHMucHkKKyAgICBBTExfUkVTVUxUUyA9IGxyYW5nZSg3KQorICAgIFNVQ0NF U1MsIFdBUk5JTkdTLCBGQUlMVVJFLCBTS0lQUEVELCBFWENFUFRJT04sIFJFVFJZLCBDQU5DRUxM RUQgPSBBTExfUkVTVUxUUworCiAgICAgQGNsYXNzbWV0aG9kCiAgICAgZGVmIHNlbmRfcGF0Y2hf dG9fYnVpbGRib3QoY2xzLCBwYXRjaF9wYXRoLCBwcm9wZXJ0aWVzPVtdKToKICAgICAgICAgY29t bWFuZCA9IFsnYnVpbGRib3QnLCAndHJ5JywKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1hcHAvZXdzL3ZpZXdzL3N0YXR1c2J1YmJsZS5weQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJibGUucHkJKHJldmlz aW9uIDI0Mjg4MCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3ZpZXdz L3N0YXR1c2J1YmJsZS5weQkod29ya2luZyBjb3B5KQpAQCAtMjgsNiArMjgsNyBAQCBmcm9tIGRq YW5nby5odHRwIGltcG9ydCBIdHRwUmVzcG9uc2UKIGZyb20gZGphbmdvLnNob3J0Y3V0cyBpbXBv cnQgcmVuZGVyCiBmcm9tIGRqYW5nby52aWV3cyBpbXBvcnQgVmlldwogZnJvbSBkamFuZ28udmll d3MuZGVjb3JhdG9ycy5jbGlja2phY2tpbmcgaW1wb3J0IHhmcmFtZV9vcHRpb25zX2V4ZW1wdAor ZnJvbSBld3MuY29tbW9uLmJ1aWxkYm90IGltcG9ydCBCdWlsZGJvdAogZnJvbSBld3MubW9kZWxz LnBhdGNoIGltcG9ydCBQYXRjaAogaW1wb3J0IGV3cy5jb25maWcgYXMgY29uZmlnCiAKQEAgLTU3 LDE3ICs1OCwxNyBAQCBjbGFzcyBTdGF0dXNCdWJibGUoVmlldyk6CiAgICAgICAgIGJ1YmJsZVsi ZGV0YWlsc19tZXNzYWdlIl0gPSAne31cbnt9Jy5mb3JtYXQoYnVpbGRlcl9mdWxsX25hbWUsIGJ1 aWxkLnN0YXRlX3N0cmluZykKICAgICAgICAgaWYgYnVpbGQucmVzdWx0IGlzIE5vbmU6CiAgICAg ICAgICAgICBidWJibGVbInN0YXRlIl0gPSAic3RhcnRlZCIKLSAgICAgICAgZWxpZiBidWlsZC5y ZXN1bHQgPT0gMDogICMgU1VDQ0VTUworICAgICAgICBlbGlmIGJ1aWxkLnJlc3VsdCA9PSBCdWls ZGJvdC5TVUNDRVNTOgogICAgICAgICAgICAgYnViYmxlWyJzdGF0ZSJdID0gInBhc3MiCi0gICAg ICAgIGVsaWYgYnVpbGQucmVzdWx0ID09IDE6ICAjIFdBUk5JTkdTCisgICAgICAgIGVsaWYgYnVp bGQucmVzdWx0ID09IEJ1aWxkYm90LldBUk5JTkdTOgogICAgICAgICAgICAgYnViYmxlWyJzdGF0 ZSJdID0gInBhc3MiCi0gICAgICAgIGVsaWYgYnVpbGQucmVzdWx0ID09IDI6ICAjIEZBSUxVUkUK KyAgICAgICAgZWxpZiBidWlsZC5yZXN1bHQgPT0gQnVpbGRib3QuRkFJTFVSRToKICAgICAgICAg ICAgIGJ1YmJsZVsic3RhdGUiXSA9ICJmYWlsIgotICAgICAgICBlbGlmIGJ1aWxkLnJlc3VsdCA9 PSAzOiAgIyBTS0lQUEVECisgICAgICAgIGVsaWYgYnVpbGQucmVzdWx0ID09IEJ1aWxkYm90LlNL SVBQRUQ6CiAgICAgICAgICAgICBidWJibGVbInN0YXRlIl0gPSAibm9uZSIKLSAgICAgICAgZWxp ZiBidWlsZC5yZXN1bHQgPT0gNDogICMgRVhDRVBUSU9OCisgICAgICAgIGVsaWYgYnVpbGQucmVz dWx0ID09IEJ1aWxkYm90LkVYQ0VQVElPTjoKICAgICAgICAgICAgIGJ1YmJsZVsic3RhdGUiXSA9 ICJlcnJvciIKLSAgICAgICAgZWxpZiBidWlsZC5yZXN1bHQgPT0gNTogICMgUkVUUlkKKyAgICAg ICAgZWxpZiBidWlsZC5yZXN1bHQgPT0gQnVpbGRib3QuUkVUUlk6CiAgICAgICAgICAgICBidWJi bGVbInN0YXRlIl0gPSAicHJvdmlzaW9uYWwtZmFpbCIKICAgICAgICAgZWxzZToKICAgICAgICAg ICAgIGJ1YmJsZVsic3RhdGUiXSA9ICJmYWlsIgpAQCAtODUsNyArODYsNyBAQCBjbGFzcyBTdGF0 dXNCdWJibGUoVmlldyk6CiAgICAgICAgIHJldHVybiBbYnVpbGQgZm9yIGJ1aWxkIGluIHBhdGNo LmJ1aWxkX3NldC5hbGwoKSBpZiBidWlsZC5idWlsZGVyX2Rpc3BsYXlfbmFtZSA9PSBxdWV1ZV0K IAogICAgIGRlZiBfc2hvdWxkX3Nob3dfYnViYmxlX2Zvcl9idWlsZChzZWxmLCBidWlsZCk6Ci0g ICAgICAgIGlmIGJ1aWxkIGFuZCBidWlsZC5yZXN1bHQgPT0gMyBhbmQgcmUuc2VhcmNoKHInUGF0 Y2ggLiogZG9lc25cJ3QgaGF2ZSByZWxldmFudCBjaGFuZ2VzJywgYnVpbGQuc3RhdGVfc3RyaW5n KToKKyAgICAgICAgaWYgYnVpbGQgYW5kIGJ1aWxkLnJlc3VsdCA9PSBCdWlsZGJvdC5TS0lQUEVE IGFuZCByZS5zZWFyY2gocidQYXRjaCAuKiBkb2VzblwndCBoYXZlIHJlbGV2YW50IGNoYW5nZXMn LCBidWlsZC5zdGF0ZV9zdHJpbmcpOgogICAgICAgICAgICAgcmV0dXJuIEZhbHNlCiAgICAgICAg IHJldHVybiBUcnVlCiAK