195665 2019-03-13 00:07:52 -0700 [bmalloc] Use MADV_FREE on FreeBSD 2019-03-13 16:11:05 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yoshiaki.jitsukawa webkit-unassigned commit-queue don.olmstead ggaren webkit-bug-importer yoshiaki.jitsukawa oldest_to_newest 1515906 0 yoshiaki.jitsukawa 2019-03-13 00:07:52 -0700 [bmalloc] Use MADV_FREE for non Darwin/Linux OS if available 1515908 1 364517 yoshiaki.jitsukawa 2019-03-13 00:17:39 -0700 Created attachment 364517 Patch 1516041 2 364517 ggaren 2019-03-13 10:44:49 -0700 Comment on attachment 364517 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364517&action=review > Source/bmalloc/bmalloc/VMAllocate.h:204 > +#else Can this be #elif? > Source/bmalloc/bmalloc/VMAllocate.h:205 > +#if !BOS(LINUX) && defined(MADV_FREE) We do have a platform macro for FreeBSD. Can you use that? 1516195 3 yoshiaki.jitsukawa 2019-03-13 15:12:02 -0700 (In reply to Geoffrey Garen from comment #2) > Comment on attachment 364517 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364517&action=review > > > Source/bmalloc/bmalloc/VMAllocate.h:204 > > +#else > > Can this be #elif? > > > Source/bmalloc/bmalloc/VMAllocate.h:205 > > +#if !BOS(LINUX) && defined(MADV_FREE) > > We do have a platform macro for FreeBSD. Can you use that? Thanks. I'll introduce BOS_FREEBSD like WTF's WTF_OS_FREEBSD. 1516205 4 364583 yoshiaki.jitsukawa 2019-03-13 15:22:52 -0700 Created attachment 364583 Patch 1516213 5 364583 ggaren 2019-03-13 15:29:21 -0700 Comment on attachment 364583 Patch r=me 1516228 6 364583 commit-queue 2019-03-13 16:07:11 -0700 Comment on attachment 364583 Patch Clearing flags on attachment: 364583 Committed r242916: <https://trac.webkit.org/changeset/242916> 1516229 7 commit-queue 2019-03-13 16:07:13 -0700 All reviewed patches have been landed. Closing bug. 1516234 8 webkit-bug-importer 2019-03-13 16:11:05 -0700 <rdar://problem/48868091> 364517 2019-03-13 00:17:39 -0700 2019-03-13 15:22:49 -0700 Patch bug-195665-20190313163553.patch text/plain 1638 yoshiaki.jitsukawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggNTUwZmJmOTdlYTFlNzYx YmZjOWM5YzE5OWFjYzE3NTc4YTYxNGZiNi4uOGU4ZGViYjdiZjVlZGQ2ZDZhZTQzZWU0MjE3ZjQ2 MmQ3YzU3OTRkNiAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTAzLTEzICBZb3No aWFraSBKaXRzdWthd2EgIDx5b3NoaWFraS5qaXRzdWthd2FAc29ueS5jb20+CisKKyAgICAgICAg W2JtYWxsb2NdIFVzZSBNQURWX0ZSRUUgZm9yIG5vbiBEYXJ3aW4vTGludXggT1MgaWYgYXZhaWxh YmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU2 NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbiBG cmVlQlNEIGFuZCBpdHMgdmFyaWFudHMsIHVubGlrZSByZWNlbnQgTGludXgsIE1BRFZfRE9OVE5F RUQgZG9lc24ndAorICAgICAgICBsZXQgdGhlIE9TIGRpc2NhcmQgdGhlIGNvbnRlbnRzIG9mIHRo ZSBwYWdlcy4gSW5zdGVhZCwgTUFEVl9GUkVFIHNob3VsZAorICAgICAgICBiZSB1c2VkIG9uIHRo b3NlIE9TJ3MgZm9yIGJldHRlciB1c2Ugb2YgcGh5c2ljYWwgbWVtb3J5LgorCisgICAgICAgICog Ym1hbGxvYy9WTUFsbG9jYXRlLmg6CisgICAgICAgIChibWFsbG9jOjp2bURlYWxsb2NhdGVQaHlz aWNhbFBhZ2VzKToKKwogMjAxOS0wMy0xMiAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBw bGUuY29tPgogCiAgICAgICAgIEEgbG90IG1vcmUgY2xhc3NlcyBoYXZlIHBhZGRpbmcgdGhhdCBj YW4gYmUgcmVkdWNlZCBieSByZW9yZGVyaW5nIHRoZWlyIGZpZWxkcwpkaWZmIC0tZ2l0IGEvU291 cmNlL2JtYWxsb2MvYm1hbGxvYy9WTUFsbG9jYXRlLmggYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9j L1ZNQWxsb2NhdGUuaAppbmRleCA1MzcwMjMzYjc4NDU5MTUwNWU4YjdlZmU3MmQ3YTFkODgwMTg1 NjRjLi44NTc3MGM4ZTZhMGJiMWIxZjAzODY1MzM4YWExZGFlMDhlNWM0MzE3IDEwMDY0NAotLS0g YS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL1ZNQWxsb2NhdGUuaAorKysgYi9Tb3VyY2UvYm1hbGxv Yy9ibWFsbG9jL1ZNQWxsb2NhdGUuaApAQCAtMjAxLDggKzIwMSwxMiBAQCBpbmxpbmUgdm9pZCB2 bURlYWxsb2NhdGVQaHlzaWNhbFBhZ2VzKHZvaWQqIHAsIHNpemVfdCB2bVNpemUpCiAgICAgdm1W YWxpZGF0ZVBoeXNpY2FsKHAsIHZtU2l6ZSk7CiAjaWYgQk9TKERBUldJTikKICAgICBTWVNDQUxM KG1hZHZpc2UocCwgdm1TaXplLCBNQURWX0ZSRUVfUkVVU0FCTEUpKTsKKyNlbHNlCisjaWYgIUJP UyhMSU5VWCkgJiYgZGVmaW5lZChNQURWX0ZSRUUpCisgICAgU1lTQ0FMTChtYWR2aXNlKHAsIHZt U2l6ZSwgTUFEVl9GUkVFKSk7CiAjZWxzZQogICAgIFNZU0NBTEwobWFkdmlzZShwLCB2bVNpemUs IE1BRFZfRE9OVE5FRUQpKTsKKyNlbmRpZgogI2lmIEJPUyhMSU5VWCkKICAgICBTWVNDQUxMKG1h ZHZpc2UocCwgdm1TaXplLCBNQURWX0RPTlREVU1QKSk7CiAjZW5kaWYK 364583 2019-03-13 15:22:52 -0700 2019-03-13 16:07:11 -0700 Patch bug-195665-20190314075220.patch text/plain 2083 yoshiaki.jitsukawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggNTUwZmJmOTdlYTFlNzYx YmZjOWM5YzE5OWFjYzE3NTc4YTYxNGZiNi4uNjUyYTYyYzUyYTc5NmQ2YTQ4YjEzNzc4YTU2OWE1 MGViYzNlYjBmZiAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTAzLTEzICBZb3No aWFraSBKaXRzdWthd2EgIDx5b3NoaWFraS5qaXRzdWthd2FAc29ueS5jb20+CisKKyAgICAgICAg W2JtYWxsb2NdIFVzZSBNQURWX0ZSRUUgb24gRnJlZUJTRAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1NjY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBibWFsbG9jL0JQbGF0Zm9ybS5oOgorCisgICAg ICAgIEludHJvZHVjZSBCT1NfRlJFRUJTRCwgd2hpY2ggaXMgZXF1aXZhbGVudCB0byBXVEZfT1Nf RlJFRUJTRAorCisgICAgICAgICogYm1hbGxvYy9WTUFsbG9jYXRlLmg6CisgICAgICAgIChibWFs bG9jOjp2bURlYWxsb2NhdGVQaHlzaWNhbFBhZ2VzKToKKworICAgICAgICBVc2UgTUFEVl9GUkVF IGluc3RlYWQgb2YgTUFEVl9ET05UTkVFRCBpZiBCT1MoRlJFRUJTRCksIHNpbmNlIG9uIEZyZWVC U0QsCisgICAgICAgIHVubGlrZSBvbiBMaW51eCwgTUFEVl9ET05UTkVFRCBkb2Vzbid0IGxldCB0 aGUgT1MgZGlzY2FyZCB0aGUgY29udGVudHMgb2YKKyAgICAgICAgdGhlIHBhZ2VzLgorCiAyMDE5 LTAzLTEyICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CiAKICAgICAgICAg QSBsb3QgbW9yZSBjbGFzc2VzIGhhdmUgcGFkZGluZyB0aGF0IGNhbiBiZSByZWR1Y2VkIGJ5IHJl b3JkZXJpbmcgdGhlaXIgZmllbGRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9j L0JQbGF0Zm9ybS5oIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9CUGxhdGZvcm0uaAppbmRleCAy MzY4YTNhMGJkOTRhZTAyYjcwZGZlZDY2YTJhY2E5ZjIzMDQyMmRjLi5mN2E0YWY0M2QzZWI4Mjkx Zjk0ODJmNTA1OTRmMTQyOTI2Y2UzMDNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9ibWFs bG9jL0JQbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQlBsYXRmb3JtLmgK QEAgLTQ4LDYgKzQ4LDEwIEBACiAjZGVmaW5lIEJPU19MSU5VWCAxCiAjZW5kaWYKIAorI2lmIGRl ZmluZWQoX19GcmVlQlNEX18pIHx8IGRlZmluZWQoX19EcmFnb25GbHlfXykgfHwgZGVmaW5lZChf X0ZyZWVCU0Rfa2VybmVsX18pCisjZGVmaW5lIEJPU19GUkVFQlNEIDEKKyNlbmRpZgorCiAjaWYg ZGVmaW5lZChXSU4zMikgfHwgZGVmaW5lZChfV0lOMzIpCiAjZGVmaW5lIEJPU19XSU5ET1dTIDEK ICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9WTUFsbG9jYXRlLmgg Yi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL1ZNQWxsb2NhdGUuaAppbmRleCA1MzcwMjMzYjc4NDU5 MTUwNWU4YjdlZmU3MmQ3YTFkODgwMTg1NjRjLi5lMzk3NmNhMmQ0MzYyMmNmZmQ0N2MxM2Q5MDRl YTYzZjU4Y2I3NmU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL1ZNQWxsb2Nh dGUuaAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL1ZNQWxsb2NhdGUuaApAQCAtMjAxLDYg KzIwMSw4IEBAIGlubGluZSB2b2lkIHZtRGVhbGxvY2F0ZVBoeXNpY2FsUGFnZXModm9pZCogcCwg c2l6ZV90IHZtU2l6ZSkKICAgICB2bVZhbGlkYXRlUGh5c2ljYWwocCwgdm1TaXplKTsKICNpZiBC T1MoREFSV0lOKQogICAgIFNZU0NBTEwobWFkdmlzZShwLCB2bVNpemUsIE1BRFZfRlJFRV9SRVVT QUJMRSkpOworI2VsaWYgQk9TKEZSRUVCU0QpCisgICAgU1lTQ0FMTChtYWR2aXNlKHAsIHZtU2l6 ZSwgTUFEVl9GUkVFKSk7CiAjZWxzZQogICAgIFNZU0NBTEwobWFkdmlzZShwLCB2bVNpemUsIE1B RFZfRE9OVE5FRUQpKTsKICNpZiBCT1MoTElOVVgpCg==