195662 2019-03-12 21:13:11 -0700 [Win][PlayStation] Remove WebCore::standardUserAgentForURL 2019-03-13 00:49:30 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii don.olmstead rniwa ross.kirsling webkit-bug-importer oldest_to_newest 1515877 0 fujii 2019-03-12 21:13:11 -0700 [Win] Remove WebCore::standardUserAgentForURL Requested by: [webkit-dev] PSA: WebCore::Quirks should define the logic to determine if a particular site specific quirk is needed or not https://lists.webkit.org/pipermail/webkit-dev/2019-March/030530.html 1515886 1 364511 fujii 2019-03-12 21:46:19 -0700 Created attachment 364511 Patch 1515901 2 ross.kirsling 2019-03-12 22:45:41 -0700 LGTM assuming it suffices to remove it. Do you want to remove it from UserAgentPlayStation right away too? 1515904 3 364516 fujii 2019-03-12 23:17:21 -0700 Created attachment 364516 Patch 1515911 4 364516 fujii 2019-03-13 00:48:41 -0700 Comment on attachment 364516 Patch Clearing flags on attachment: 364516 Committed r242847: <https://trac.webkit.org/changeset/242847> 1515912 5 fujii 2019-03-13 00:48:44 -0700 All reviewed patches have been landed. Closing bug. 1515913 6 webkit-bug-importer 2019-03-13 00:49:30 -0700 <rdar://problem/48839947> 364511 2019-03-12 21:46:19 -0700 2019-03-12 23:17:02 -0700 Patch bug-195662-20190313134618.patch text/plain 2963 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzc1OWRlNGViOTUxMTUx ODlkYjU4YjNjOGRmOTk5OWZhYTBiODdhMS4uYmViNjAzNzgzYTRkNDI4NWEzZTJhZmEyNTZmZjc1 OTcyZDZkM2FkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTAzLTEyICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dIFJl bW92ZSBXZWJDb3JlOjpzdGFuZGFyZFVzZXJBZ2VudEZvclVSTAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1NjYyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViQ29yZTo6c3RhbmRhcmRVc2VyQWdlbnRG b3JVUkwgaXMganVzdCBhIHN0dWIgaW4gV2luZG93cyBwb3J0LgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyBiZWNhdXNlIHRoZXJlIGlzIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHBs YXRmb3JtL3dpbi9Vc2VyQWdlbnRXaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6c3RhbmRhcmRV c2VyQWdlbnRGb3JVUkwpOiBEZWxldGVkLgorCiAyMDE5LTAzLTEyICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIE1vdmUgdGhlIGNvZGUgZm9yIGRldGVybWluaW5n IHRoZSBuZWVkIGZvciB0b3VjaCBiYXIgcXVpcmtzIHRvIFF1aXJrcyBjbGFzcwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRl eCBkMWI2ODMyNTUwNDBjN2FhY2FkZGRjOGUwZDA4YmUyYWY3OWM2Mjc1Li42MjBmZDY0MmEwYjky ZjhmYjlkNzRhNGUyZmRmOGYxMDI1ZmE1YTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisy MDE5LTAzLTEyICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisg ICAgICAgIFtXaW5dIFJlbW92ZSBXZWJDb3JlOjpzdGFuZGFyZFVzZXJBZ2VudEZvclVSTAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1NjYyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNz L1dlYlBhZ2Uvd2luL1dlYlBhZ2VXaW4uY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpw bGF0Zm9ybVVzZXJBZ2VudCBjb25zdCk6IFJldHVybiBhbiBlbXB0eSBzdHJpbmcgYXMgd2VsbCBh cyBtYWMvaW9zIHBvcnRzLgorCiAyMDE5LTAzLTEyICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJr aXQub3JnPgogCiAgICAgICAgIE1vdmUgdGhlIGNvZGUgZm9yIGRldGVybWluaW5nIHRoZSBuZWVk IGZvciB0b3VjaCBiYXIgcXVpcmtzIHRvIFF1aXJrcyBjbGFzcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vd2luL1VzZXJBZ2VudFdpbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS93aW4vVXNlckFnZW50V2luLmNwcAppbmRleCA4MjAxZjRlM2ViYzk2MTlhNmRkMWI2 OGY0NzAxYjY2OTlkODVlODY3Li5mYzQ1ZmYwMmJhMWNkZGJlYmVlNGViYzNmYmQyNjMzNGEzM2Ji MjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vVXNlckFnZW50V2lu LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vVXNlckFnZW50V2luLmNwcApA QCAtNDksMTAgKzQ5LDQgQEAgU3RyaW5nIHN0YW5kYXJkVXNlckFnZW50KGNvbnN0IFN0cmluZyYg YXBwbGljYXRpb25OYW1lLCBjb25zdCBTdHJpbmcmIGFwcGxpY2F0aW8KICAgICByZXR1cm4gdWFT dHJpbmcudG9TdHJpbmcoKTsKIH0KIAotU3RyaW5nIHN0YW5kYXJkVXNlckFnZW50Rm9yVVJMKGNv bnN0IFVSTCYgdXJsKQotewotICAgIC8vIFRoZSBudWxsIHN0cmluZyBtZWFucyB3ZSBkb24ndCBu ZWVkIGEgc3BlY2lmaWMgVUEgZm9yIHRoZSBnaXZlbiBVUkwuCi0gICAgcmV0dXJuIHsgfTsKLX0K LQogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL1dlYlBhZ2Uvd2luL1dlYlBhZ2VXaW4uY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL1dlYlBhZ2Uvd2luL1dlYlBhZ2VXaW4uY3BwCmluZGV4IDEyZDZkZTczNGJkMTdiNDRhNzU2 YjE0NTc1MGM1MmFkMTY4MTE3NGQuLjdjNjJjYzBjNTgyMzMxOTFmMDRlYzY3Zjc3OTgxZjI5NzE3 MDJkZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL3dpbi9X ZWJQYWdlV2luLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS93aW4v V2ViUGFnZVdpbi5jcHAKQEAgLTExMywxMiArMTEzLDkgQEAgYm9vbCBXZWJQYWdlOjpwbGF0Zm9y bUNhbkhhbmRsZVJlcXVlc3QoY29uc3QgUmVzb3VyY2VSZXF1ZXN0JikKICAgICByZXR1cm4gZmFs c2U7CiB9CiAKLVN0cmluZyBXZWJQYWdlOjpwbGF0Zm9ybVVzZXJBZ2VudChjb25zdCBVUkwmIHVy bCkgY29uc3QKK1N0cmluZyBXZWJQYWdlOjpwbGF0Zm9ybVVzZXJBZ2VudChjb25zdCBVUkwmKSBj b25zdAogewotICAgIGlmICh1cmwuaXNOdWxsKCkgfHwgIW1fcGFnZS0+c2V0dGluZ3MoKS5uZWVk c1NpdGVTcGVjaWZpY1F1aXJrcygpKQotICAgICAgICByZXR1cm4gU3RyaW5nKCk7Ci0KLSAgICBy ZXR1cm4gV2ViQ29yZTo6c3RhbmRhcmRVc2VyQWdlbnRGb3JVUkwodXJsKTsKKyAgICByZXR1cm4g U3RyaW5nKCk7CiB9CiAKIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBDdHJsS2V5ID0gMSA8PCAwOwo= 364516 2019-03-12 23:17:21 -0700 2019-03-13 00:48:41 -0700 Patch bug-195662-20190313151720.patch text/plain 3749 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzc1OWRlNGViOTUxMTUx ODlkYjU4YjNjOGRmOTk5OWZhYTBiODdhMS4uYTI0MDMxYmE1ZTU0ODM0NGM1OGEyNGVjY2MwZDVj NGNmMThiMWI5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAzLTEyICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dW1Bs YXlTdGF0aW9uXSBSZW1vdmUgV2ViQ29yZTo6c3RhbmRhcmRVc2VyQWdlbnRGb3JVUkwKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTY2MgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYkNvcmU6OnN0YW5k YXJkVXNlckFnZW50Rm9yVVJMIGlzIGp1c3QgYSBzdHViIGluIFdpbmRvd3MgcG9ydC4KKworICAg ICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSB0aGVyZSBpcyBubyBiZWhhdmlvciBjaGFuZ2UuCisK KyAgICAgICAgKiBwbGF0Zm9ybS93aW4vVXNlckFnZW50V2luLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OnN0YW5kYXJkVXNlckFnZW50Rm9yVVJMKTogRGVsZXRlZC4KKyAgICAgICAgKiBwbGF0Zm9y bS9wbGF5c3RhdGlvbi9Vc2VyQWdlbnRQbGF5U3RhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpzdGFuZGFyZFVzZXJBZ2VudEZvclVSTCk6IERlbGV0ZWQuCisKIDIwMTktMDMtMTIgIFJ5b3N1 a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTW92ZSB0aGUgY29kZSBmb3Ig ZGV0ZXJtaW5pbmcgdGhlIG5lZWQgZm9yIHRvdWNoIGJhciBxdWlya3MgdG8gUXVpcmtzIGNsYXNz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hh bmdlTG9nCmluZGV4IGQxYjY4MzI1NTA0MGM3YWFjYWRkZGM4ZTBkMDhiZTJhZjc5YzYyNzUuLjI2 Y2FkMGE4Y2QzN2VjNjY3NzlkMmU5M2EzM2JkMTRjMmMwZDc2MzIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTktMDMtMTIgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29u eS5jb20+CisKKyAgICAgICAgW1dpbl1bUGxheVN0YXRpb25dIFJlbW92ZSBXZWJDb3JlOjpzdGFu ZGFyZFVzZXJBZ2VudEZvclVSTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk1NjYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uvd2luL1dlYlBhZ2VXaW4uY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJQYWdlOjpwbGF0Zm9ybVVzZXJBZ2VudCBjb25zdCk6IFJldHVybiBh biBlbXB0eSBzdHJpbmcgYXMgd2VsbCBhcyBtYWMvaW9zIHBvcnRzLgorCiAyMDE5LTAzLTEyICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIE1vdmUgdGhlIGNvZGUg Zm9yIGRldGVybWluaW5nIHRoZSBuZWVkIGZvciB0b3VjaCBiYXIgcXVpcmtzIHRvIFF1aXJrcyBj bGFzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcGxheXN0YXRpb24vVXNl ckFnZW50UGxheVN0YXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcGxheXN0YXRp b24vVXNlckFnZW50UGxheVN0YXRpb24uY3BwCmluZGV4IGE1NmU1NTFhNjYwM2YzOGExY2FhOTJh ZTZhYzVlMzVlODU4YjIyNTEuLjg0ZmYzNTgzNjA4NTY1YjQ5YzA2ZWY1MWE2ZDFhZTk3ZDk3NDAz ZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3BsYXlzdGF0aW9uL1VzZXJB Z2VudFBsYXlTdGF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9wbGF5c3Rh dGlvbi9Vc2VyQWdlbnRQbGF5U3RhdGlvbi5jcHAKQEAgLTMzLDEwICszMyw0IEBAIFN0cmluZyBz dGFuZGFyZFVzZXJBZ2VudChjb25zdCBTdHJpbmcmLCBjb25zdCBTdHJpbmcmKQogICAgIHJldHVy biBlbXB0eVN0cmluZygpOwogfQogCi1TdHJpbmcgc3RhbmRhcmRVc2VyQWdlbnRGb3JVUkwoY29u c3QgVVJMJikKLXsKLSAgICAvLyBUaGUgbnVsbCBzdHJpbmcgbWVhbnMgd2UgZG9uJ3QgbmVlZCBh IHNwZWNpZmljIFVBIGZvciB0aGUgZ2l2ZW4gVVJMLgotICAgIHJldHVybiBlbXB0eVN0cmluZygp OwotfQotCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS93aW4vVXNlckFnZW50V2luLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3dpbi9Vc2VyQWdlbnRXaW4uY3BwCmluZGV4IDgyMDFmNGUzZWJjOTYxOWE2ZGQxYjY4ZjQ3MDFi NjY5OWQ4NWU4NjcuLmZjNDVmZjAyYmExY2RkYmViZWU0ZWJjM2ZiZDI2MzM0YTMzYmIyODMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9Vc2VyQWdlbnRXaW4uY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9Vc2VyQWdlbnRXaW4uY3BwCkBAIC00OSwx MCArNDksNCBAQCBTdHJpbmcgc3RhbmRhcmRVc2VyQWdlbnQoY29uc3QgU3RyaW5nJiBhcHBsaWNh dGlvbk5hbWUsIGNvbnN0IFN0cmluZyYgYXBwbGljYXRpbwogICAgIHJldHVybiB1YVN0cmluZy50 b1N0cmluZygpOwogfQogCi1TdHJpbmcgc3RhbmRhcmRVc2VyQWdlbnRGb3JVUkwoY29uc3QgVVJM JiB1cmwpCi17Ci0gICAgLy8gVGhlIG51bGwgc3RyaW5nIG1lYW5zIHdlIGRvbid0IG5lZWQgYSBz cGVjaWZpYyBVQSBmb3IgdGhlIGdpdmVuIFVSTC4KLSAgICByZXR1cm4geyB9OwotfQotCiB9IC8v IG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv V2ViUGFnZS93aW4vV2ViUGFnZVdpbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi UGFnZS93aW4vV2ViUGFnZVdpbi5jcHAKaW5kZXggMTJkNmRlNzM0YmQxN2I0NGE3NTZiMTQ1NzUw YzUyYWQxNjgxMTc0ZC4uMzFkZjQyZDI0MDhiNjM4ZDA0NmNiNWRiNDlkZDI5ZGQ2ZWQ1OWE3YiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2Uvd2luL1dlYlBhZ2VX aW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL3dpbi9XZWJQYWdl V2luLmNwcApAQCAtMTEzLDEyICsxMTMsOSBAQCBib29sIFdlYlBhZ2U6OnBsYXRmb3JtQ2FuSGFu ZGxlUmVxdWVzdChjb25zdCBSZXNvdXJjZVJlcXVlc3QmKQogICAgIHJldHVybiBmYWxzZTsKIH0K IAotU3RyaW5nIFdlYlBhZ2U6OnBsYXRmb3JtVXNlckFnZW50KGNvbnN0IFVSTCYgdXJsKSBjb25z dAorU3RyaW5nIFdlYlBhZ2U6OnBsYXRmb3JtVXNlckFnZW50KGNvbnN0IFVSTCYpIGNvbnN0CiB7 Ci0gICAgaWYgKHVybC5pc051bGwoKSB8fCAhbV9wYWdlLT5zZXR0aW5ncygpLm5lZWRzU2l0ZVNw ZWNpZmljUXVpcmtzKCkpCi0gICAgICAgIHJldHVybiBTdHJpbmcoKTsKLQotICAgIHJldHVybiBX ZWJDb3JlOjpzdGFuZGFyZFVzZXJBZ2VudEZvclVSTCh1cmwpOworICAgIHJldHVybiB7IH07CiB9 CiAKIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBDdHJsS2V5ID0gMSA8PCAwOwo=