195648 2019-03-12 15:45:33 -0700 REGRESSION(r242825): "Broke webkitpy tests with my change to lldb_dump_class_layout.py" (Requested by rmorisset on #webkit). 2019-03-12 15:50:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 195573 1 commit-queue commit-queue rmorisset simon.fraser webkit-bug-importer oldest_to_newest 1515726 0 commit-queue 2019-03-12 15:45:33 -0700 https://trac.webkit.org/changeset/242825 broke the build: "Broke webkitpy tests with my change to lldb_dump_class_layout.py" (Requested by rmorisset on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1515728 1 364462 commit-queue 2019-03-12 15:45:38 -0700 Created attachment 364462 ROLLOUT of r242825 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1515730 2 364462 rmorisset 2019-03-12 15:47:52 -0700 Comment on attachment 364462 ROLLOUT of r242825 I had forgotten that there were already tests for this code, and broke them when changing the interface of lldb_dump_class_layout.py. The fix is fairly simple, but I want to first roll-out, then take the time to fix it properly. 1515731 3 364462 commit-queue 2019-03-12 15:49:39 -0700 Comment on attachment 364462 ROLLOUT of r242825 Clearing flags on attachment: 364462 Committed r242832: <https://trac.webkit.org/changeset/242832> 1515732 4 commit-queue 2019-03-12 15:49:41 -0700 All reviewed patches have been landed. Closing bug. 1515733 5 webkit-bug-importer 2019-03-12 15:50:17 -0700 <rdar://problem/48827374> 364462 2019-03-12 15:45:38 -0700 2019-03-12 15:49:39 -0700 ROLLOUT of r242825 bug-195648-20190312154537.patch text/plain 5538 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyODMxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODUxZjRkOGUxZGQ3NjQwMjc3NmVhOWY1NzZlZDBhYjU1 ZDhhODFiNC4uNjMzNDBlOTc4YjYzYzY0MGQ3ZWQ0ZDM0YjI4YWVmZmMzOGM2ODA0ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE5LTAzLTEyICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4K KworICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjQyODI1LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1NjQ4CisKKyAgICAgICAgIkJy b2tlIHdlYmtpdHB5IHRlc3RzIHdpdGggbXkgY2hhbmdlIHRvCisgICAgICAgIGxsZGJfZHVtcF9j bGFzc19sYXlvdXQucHkiIChSZXF1ZXN0ZWQgYnkgcm1vcmlzc2V0IG9uCisgICAgICAgICN3ZWJr aXQpLgorCisgICAgICAgIFJldmVydGVkIGNoYW5nZXNldDoKKworICAgICAgICAiQWx0ZXIgVG9v bHMvU2NyaXB0cy9kdW1wLWNsYXNzLWxheW91dCB0byBiZSBhYmxlIHRvIGR1bXAgYWxsCisgICAg ICAgIGNsYXNzZXMgd2l0aCBzdXNwaWNpb3VzIHBhZGRpbmciCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU1NzMKKyAgICAgICAgaHR0cHM6Ly90cmFj LndlYmtpdC5vcmcvY2hhbmdlc2V0LzI0MjgyNQorCiAyMDE5LTAzLTEyICBBYWthc2ggSmFpbiAg PGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbZXdzLWJ1aWxkXSBTaG93IHN0YXR1 cyBidWJibGVzIHdoaWxlIHRoZSBwYXRjaCBpcyB3YWl0aW5nIGluIHF1ZXVlCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL2R1bXAtY2xhc3MtbGF5b3V0IGIvVG9vbHMvU2NyaXB0cy9kdW1wLWNs YXNzLWxheW91dAppbmRleCBkZjk0M2NjYzI4OTU5YjAwYjUxMjFiZTc3ZWEwNTAxZWZhYWIwMTZh Li5hNTQ3ZTIwNWQ2M2QwODkxOTM4M2IyZGJiZDM3MDU4YzI1ZjVjZGMyIDEwMDc1NQotLS0gYS9U b29scy9TY3JpcHRzL2R1bXAtY2xhc3MtbGF5b3V0CisrKyBiL1Rvb2xzL1NjcmlwdHMvZHVtcC1j bGFzcy1sYXlvdXQKQEAgLTUxLDcgKzUxLDcgQEAgZGVmIG1haW4oKToKICAgICBwYXJzZXIgPSBh cmdwYXJzZS5Bcmd1bWVudFBhcnNlcihkZXNjcmlwdGlvbj0nRHVtcHMgdGhlIGluLW1lbW9yeSBs YXlvdXQgb2YgdGhlIGdpdmVuIGNsYXNzIG9yIGNsYXNzZXMsIHNob3dpbmcgcGFkZGluZyBob2xl cy4nKQogICAgIHBhcnNlci5hZGRfYXJndW1lbnQoJ2ZyYW1ld29yaycsIG1ldGF2YXI9J2ZyYW1l d29yaycsCiAgICAgICAgIGhlbHA9J25hbWUgb2YgdGhlIGZyYW1ld29yayBjb250YWluaW5nIHRo ZSBjbGFzcyAoZS5nLiAiV2ViQ29yZSIpJykKLSAgICBwYXJzZXIuYWRkX2FyZ3VtZW50KCdjbGFz c25hbWUnLCBtZXRhdmFyPSdjbGFzc25hbWUnLCBuYXJncz0nPycsCisgICAgcGFyc2VyLmFkZF9h cmd1bWVudCgnY2xhc3NuYW1lJywgbWV0YXZhcj0nY2xhc3NuYW1lJywKICAgICAgICAgaGVscD0n bmFtZSBvZiB0aGUgY2xhc3Mgb3Igc3RydWN0IHRvIGR1bXAnKQogCiAgICAgcGFyc2VyLmFkZF9h cmd1bWVudCgnLWInLCAnLS1idWlsZC1kaXJlY3RvcnknLCBkZXN0PSdidWlsZF9kaXJlY3Rvcnkn LCBhY3Rpb249J3N0b3JlJywKQEAgLTY2LDkgKzY2LDYgQEAgZGVmIG1haW4oKToKICAgICBwYXJz ZXIuYWRkX2FyZ3VtZW50KCctdCcsICctLXRhcmdldC1wYXRoJywgZGVzdD0ndGFyZ2V0X3BhdGgn LCBhY3Rpb249J3N0b3JlJywKICAgICAgICAgaGVscD0nUGF0aCB0byB0aGUgdGFyZ2V0JykKIAot ICAgIHBhcnNlci5hZGRfYXJndW1lbnQoJy13JywgJy0tYWxsLXdhc3RlZnVsJywgZGVzdD0nYWxs X3dhc3RlZnVsJywgYWN0aW9uPSdzdG9yZV90cnVlJywKLSAgICAgICAgaGVscD0nRXhjbHVzaXZl IHdpdGggY2xhc3NuYW1lLCBkdW1wcyB0aGUgbGF5b3V0IG9mIGFsbCBjbGFzc2VzIHdpdGggYXQg bGVhc3QgOCBieXRlcyBvZiBwYWRkaW5nIGF0IHRoZSB0b3AtbGV2ZWwnKQotCiAgICAgYXJncyA9 IHBhcnNlci5wYXJzZV9hcmdzKCkKICAgICBidWlsZF9kaXIgPSB3ZWJraXRfYnVpbGRfZGlyKCkK IApAQCAtODQsMTQgKzgxLDkgQEAgZGVmIG1haW4oKToKICAgICAgICAgdGFyZ2V0X3BhdGggPSBv cy5wYXRoLmpvaW4oYnVpbGRfZGlyLCBhcmdzLmNvbmZpZywgYXJncy5mcmFtZXdvcmsgKyAiLmZy YW1ld29yayIsIGFyZ3MuZnJhbWV3b3JrKTsKICAgICAKICAgICBsbGRiX2luc3RhbmNlID0gTExE QkRlYnVnZ2VySW5zdGFuY2UodGFyZ2V0X3BhdGgsIGFyZ3MuYXJjaCkKLSAgICBpZiBhcmdzLmFs bF93YXN0ZWZ1bCBhbmQgKGFyZ3MuY2xhc3NuYW1lIGlzIG5vdCBOb25lKToKLSAgICAgICAgcHJp bnQgIlRoZSAtdy8tLWFsbC13YXN0ZWZ1bCBvcHRpb24gaXMgaW5jb21wYXRpYmxlIHdpdGggcHJv dmlkaW5nIGEgY2xhc3MgbmFtZSIKLSAgICBlbGlmIGFyZ3MuYWxsX3dhc3RlZnVsOgotICAgICAg ICBsbGRiX2luc3RhbmNlLmR1bXBfYWxsX3dhc3RlZnVsX2xheW91dHMoKQotICAgIGVsaWYgYXJn cy5jbGFzc25hbWUgaXMgbm90IE5vbmU6Ci0gICAgICAgIGxsZGJfaW5zdGFuY2UuZHVtcF9sYXlv dXRfZm9yX2NsYXNzbmFtZShhcmdzLmNsYXNzbmFtZSkKLSAgICBlbHNlOgotICAgICAgICBwcmlu dCAiWW91IG11c3QgZWl0aGVyIHByb3ZpZGUgYSBjbGFzcyBuYW1lIG9yIHRoZSAtdy8tLWFsbC13 YXN0ZWZ1bCBvcHRpb24iCisgICAgY2xhc3NfbGF5b3V0ID0gbGxkYl9pbnN0YW5jZS5sYXlvdXRf Zm9yX2NsYXNzbmFtZShhcmdzLmNsYXNzbmFtZSkKKyAgICBjbGFzc19sYXlvdXQuZHVtcCgpCisK IAogaWYgX19uYW1lX18gPT0gIl9fbWFpbl9fIjoKICAgICBtYWluKCkKZGlmZiAtLWdpdCBhL1Rv b2xzL2xsZGIvbGxkYl9kdW1wX2NsYXNzX2xheW91dC5weSBiL1Rvb2xzL2xsZGIvbGxkYl9kdW1w X2NsYXNzX2xheW91dC5weQppbmRleCAzNjBhMTg0ZmU4MDM4MmFhZmI0NDE1MGJlMjlkZmIyNWZj MDEzYzNlLi4zYmViZjhmZWQ0MzljOTZhNTA0YzNkZDE4ZmJiYmQxZjkzNzc5MWEwIDEwMDc1NQot LS0gYS9Ub29scy9sbGRiL2xsZGJfZHVtcF9jbGFzc19sYXlvdXQucHkKKysrIGIvVG9vbHMvbGxk Yi9sbGRiX2R1bXBfY2xhc3NfbGF5b3V0LnB5CkBAIC0xNDUsNyArMTQ1LDYgQEAgY2xhc3MgQ2xh c3NMYXlvdXQoQ2xhc3NMYXlvdXRCYXNlKToKICAgICAgICAgc2VsZi50b3RhbF9ieXRlX3NpemUg PSBzZWxmLnR5cGUuR2V0Qnl0ZVNpemUoKQogICAgICAgICBzZWxmLnBvaW50ZXJfc2l6ZSA9IHNl bGYudGFyZ2V0LkdldEFkZHJlc3NCeXRlU2l6ZSgpCiAgICAgICAgIHNlbGYudG90YWxfcGFkX2J5 dGVzID0gMAotICAgICAgICBzZWxmLnRvcF9sZXZlbF9wYWRfYnl0ZXMgPSAwCiAgICAgICAgIHNl bGYuZGF0YV9tZW1iZXJzID0gW10KICAgICAgICAgc2VsZi52aXJ0dWFsX2Jhc2VfY2xhc3NlcyA9 IHNlbGYuX3ZpcnR1YWxfYmFzZV9jbGFzc2VzX2RpY3Rpb25hcnkoKQogICAgICAgICBzZWxmLl9w YXJzZShjb250YWluZXJDbGFzcywgZGVyaXZlZENsYXNzKQpAQCAtMzIwLDggKzMxOSw2IEBAIGNs YXNzIENsYXNzTGF5b3V0KENsYXNzTGF5b3V0QmFzZSk6CiAKICAgICAgICAgICAgICAgICAgICAg c2VsZi5kYXRhX21lbWJlcnMuaW5zZXJ0KGksIHBhZGRpbmdfbWVtYmVyKQogICAgICAgICAgICAg ICAgICAgICBwYWRkaW5nX2J5dGVzICs9IHBhZGRpbmdfc2l6ZQotICAgICAgICAgICAgICAgICAg ICBpZiBkZXB0aCA9PSAwIGFuZCBwYWRkaW5nX3NpemUgPCA4OgotICAgICAgICAgICAgICAgICAg ICAgICAgc2VsZi50b3BfbGV2ZWxfcGFkX2J5dGVzICs9IHBhZGRpbmdfc2l6ZQogICAgICAgICAg ICAgICAgICAgICBpICs9IDEKIAogICAgICAgICAgICAgICAgIGlmIHNlbGYuTUVNQkVSX0lTX0JJ VEZJRUxEIGluIGRhdGFfbWVtYmVyOgpAQCAtMzY3LDcgKzM2NCw2IEBAIGNsYXNzIENsYXNzTGF5 b3V0KENsYXNzTGF5b3V0QmFzZSk6CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAg IHNlbGYuZGF0YV9tZW1iZXJzLmFwcGVuZChwYWRkaW5nX21lbWJlcikKICAgICAgICAgICAgICAg ICBwYWRkaW5nX2J5dGVzICs9IHBhZGRpbmdfc2l6ZQotICAgICAgICAgICAgICAgIHNlbGYudG9w X2xldmVsX3BhZF9ieXRlcyArPSBwYWRkaW5nX3NpemUKIAogICAgICAgICByZXR1cm4gW3BhZGRp bmdfYnl0ZXMsIGN1cnJlbnRfb2Zmc2V0XQogCkBAIC00MTUsMjIgKzQxMSwxMSBAQCBjbGFzcyBM TERCRGVidWdnZXJJbnN0YW5jZToKIAogICAgICAgICByZXR1cm4gbGxkYi5MTERCX0FSQ0hfREVG QVVMVAogCi0gICAgZGVmIGR1bXBfbGF5b3V0X2Zvcl9jbGFzc25hbWUoc2VsZiwgY2xhc3NuYW1l KToKKyAgICBkZWYgbGF5b3V0X2Zvcl9jbGFzc25hbWUoc2VsZiwgY2xhc3NuYW1lKToKICAgICAg ICAgdHlwZXMgPSBzZWxmLm1vZHVsZS5GaW5kVHlwZXMoY2xhc3NuYW1lKQotICAgICAgICBpZiBu b3QgdHlwZXMuR2V0U2l6ZSgpOgotICAgICAgICAgICAgcHJpbnQgJ2Vycm9yOiBubyB0eXBlIG1h dGNoZXMgIiVzIiBpbiAiJXMiJyAlIChjbGFzc25hbWUsIHNlbGYubW9kdWxlLmZpbGUpCi0gICAg ICAgICAgICByZXR1cm4gTm9uZQotICAgICAgICBmb3IgdCBpbiB0eXBlczoKLSAgICAgICAgICAg IENsYXNzTGF5b3V0KHNlbGYudGFyZ2V0LCB0KS5kdW1wKCkKLQotICAgIGRlZiBkdW1wX2FsbF93 YXN0ZWZ1bF9sYXlvdXRzKHNlbGYpOgotICAgICAgICB0eXBlcyA9IHNlbGYubW9kdWxlLkdldFR5 cGVzKGxsZGIuZVR5cGVDbGFzc0NsYXNzIHwgbGxkYi5lVHlwZUNsYXNzU3RydWN0KQotICAgICAg ICBzZWVuVHlwZXMgPSBzZXQoKQotICAgICAgICBmb3IgdCBpbiB0eXBlczoKLSAgICAgICAgICAg IGlmIHQuR2V0TmFtZSgpIGluIHNlZW5UeXBlczoKLSAgICAgICAgICAgICAgICBjb250aW51ZQot ICAgICAgICAgICAgc2VlblR5cGVzLmFkZCh0LkdldE5hbWUoKSkKLSAgICAgICAgICAgIGNsYXNz TGF5b3V0ID0gQ2xhc3NMYXlvdXQoc2VsZi50YXJnZXQsIHQpCi0gICAgICAgICAgICBpZiBjbGFz c0xheW91dC50b3BfbGV2ZWxfcGFkX2J5dGVzID49IDg6Ci0gICAgICAgICAgICAgICAgY2xhc3NM YXlvdXQuZHVtcCgpCi0gICAgICAgICAgICAgICAgcHJpbnQgIiIKKyAgICAgICAgaWYgdHlwZXMu R2V0U2l6ZSgpOgorICAgICAgICAgICAgIyBUaGVyZSBjYW4gYmUgbW9yZSB0aGF0IG9uZSB0eXBl IHdpdGggYSBnaXZlbiBuYW1lLCBidXQgZm9yIG5vdyBqdXN0IHJldHVybiB0aGUgZmlyc3Qgb25l LgorICAgICAgICAgICAgcmV0dXJuIENsYXNzTGF5b3V0KHNlbGYudGFyZ2V0LCB0eXBlcy5HZXRU eXBlQXRJbmRleCgwKSkKKworICAgICAgICBwcmludCAnZXJyb3I6IG5vIHR5cGUgbWF0Y2hlcyAi JXMiIGluICIlcyInICUgKGNsYXNzbmFtZSwgc2VsZi5tb2R1bGUuZmlsZSkKKyAgICAgICAgcmV0 dXJuIE5vbmUK