195633 2019-03-12 11:08:59 -0700 Web Inspector: Elements: provide node context menu items for event listeners sorted by node 2019-03-12 13:06:22 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 195368 1 hi hi commit-queue hi inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1515530 0 hi 2019-03-12 11:08:59 -0700 <https://webkit.org/b/195368> provides highlighting, but we should also be able to context menu and "Reveal in DOM tree". 1515536 1 364413 hi 2019-03-12 11:16:58 -0700 Created attachment 364413 Patch 1515584 2 364413 mattbaker 2019-03-12 12:08:51 -0700 Comment on attachment 364413 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364413&action=review r=me, but I think the bug title should be changed. Context menu items aren't added anywhere; this looks like refactoring. > Source/WebInspectorUI/ChangeLog:12 > + existing DOM without modifying it. This is confusing: "...so it can be used on existing DOM without modifying it." Aren't we just separating this out so it can be reused? 1515585 3 mattbaker 2019-03-12 12:10:04 -0700 (In reply to Matt Baker from comment #2) > Comment on attachment 364413 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364413&action=review > > r=me, but I think the bug title should be changed. Context menu items aren't > added anywhere; this looks like refactoring. > > > Source/WebInspectorUI/ChangeLog:12 > > + existing DOM without modifying it. > > This is confusing: "...so it can be used on existing DOM without modifying > it." Aren't we just separating this out so it can be reused? Sorry I misread part of the diff. Looks good! I'd clean up the wording in the change log though. 1515610 4 364413 hi 2019-03-12 12:39:20 -0700 Comment on attachment 364413 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364413&action=review >>> Source/WebInspectorUI/ChangeLog:12 >>> + existing DOM without modifying it. >> >> This is confusing: "...so it can be used on existing DOM without modifying it." Aren't we just separating this out so it can be reused? > > Sorry I misread part of the diff. Looks good! I'd clean up the wording in the change log though. Yes and no. Part of it is separating out the code, but the primary reason we have to separate out the code is because the existing function modifies the `element` passed in (as an example, it sets a `role` attribute). This new function allows us to have the same interaction logic without any other changes to the `element`. 1515627 5 364413 mattbaker 2019-03-12 13:04:28 -0700 Comment on attachment 364413 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364413&action=review >>>> Source/WebInspectorUI/ChangeLog:12 >>>> + existing DOM without modifying it. >>> >>> This is confusing: "...so it can be used on existing DOM without modifying it." Aren't we just separating this out so it can be reused? >> >> Sorry I misread part of the diff. Looks good! I'd clean up the wording in the change log though. > > Yes and no. Part of it is separating out the code, but the primary reason we have to separate out the code is because the existing function modifies the `element` passed in (as an example, it sets a `role` attribute). This new function allows us to have the same interaction logic without any other changes to the `element`. Ah okay! It wasn't obvious that this was because `WI.linkifyNodeReferenceElement` does more to the element than hooking up event listeners. 1515628 6 364413 commit-queue 2019-03-12 13:05:58 -0700 Comment on attachment 364413 Patch Clearing flags on attachment: 364413 Committed r242820: <https://trac.webkit.org/changeset/242820> 1515629 7 commit-queue 2019-03-12 13:05:59 -0700 All reviewed patches have been landed. Closing bug. 1515630 8 webkit-bug-importer 2019-03-12 13:06:22 -0700 <rdar://problem/48819815> 364413 2019-03-12 11:16:58 -0700 2019-03-12 13:05:58 -0700 Patch bug-195633-20190312111658.patch text/plain 4263 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQxM2UzYjlhNDY4M2Y0OGFlNWUxYzU0NGEyY2Zh Yjc0YjEyOWM1ZTMuLjY2M2YwNGYzNWIzODc2NjliMDk5NTcyNWNjNDM1NGNjMThmZDIzYzkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAzLTEyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBF bGVtZW50czogcHJvdmlkZSBub2RlIGNvbnRleHQgbWVudSBpdGVtcyBmb3IgZXZlbnQgbGlzdGVu ZXJzIHNvcnRlZCBieSBub2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTU2MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9ET01VdGlsaXRpZXMuanM6CisgICAgICAg IChXSS5saW5raWZ5Tm9kZVJlZmVyZW5jZUVsZW1lbnQpOgorICAgICAgICAoV0kuYmluZEludGVy YWN0aW9uc0Zvck5vZGVUb0VsZW1lbnQpOiBBZGRlZC4KKyAgICAgICAgU3BsaXQgbG9naWMgZm9y IGFkZGluZyBldmVudCBsaXN0ZW5lcnMgaW50byBhIHNlcGFyYXRlIGZ1bmN0aW9uIHNvIGl0IGNh biBiZSB1c2VkIG9uCisgICAgICAgIGV4aXN0aW5nIERPTSB3aXRob3V0IG1vZGlmeWluZyBpdC4K KworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRE9NTm9kZURldGFpbHNTaWRlYmFyUGFu ZWwuanM6CisgICAgICAgIChXSS5ET01Ob2RlRGV0YWlsc1NpZGViYXJQYW5lbC5wcm90b3R5cGUu X3JlZnJlc2hFdmVudExpc3RlbmVycy5nZW5lcmF0ZUdyb3Vwc0J5Tm9kZSk6CisKIDIwMTktMDMt MTIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBUaW1lbGluZXMgLSBJbXByb3ZlIGhhbmRsaW5nIG9mIHBhc3QgcmVjb3JkaW5n cyAocmVhZG9ubHkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9CYXNlL0RPTVV0aWxpdGllcy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0Jhc2UvRE9NVXRpbGl0aWVzLmpzCmluZGV4IDYxMjhkYjc3NDc5NmUxMTJkMDNjZDZi MWVkNDljM2NlYjE0YmI0MTEuLjI0OTMyMmUxN2VkYjI1YjBjOTkwYjM3MjVhM2YyYjk1NDc5MmU2 NGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2Uv RE9NVXRpbGl0aWVzLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvRE9NVXRpbGl0aWVzLmpzCkBAIC03NywxNSArNzcsMzAgQEAgV0kubGlua2lmeU5vZGVS ZWZlcmVuY2VFbGVtZW50ID0gZnVuY3Rpb24obm9kZSwgZWxlbWVudCwgb3B0aW9ucyA9IHt9KQog ICAgIGlmICgobm9kZVR5cGUgIT09IE5vZGUuRE9DVU1FTlRfTk9ERSB8fCBub2RlLnBhcmVudE5v ZGUpICYmIG5vZGVUeXBlICE9PSBOb2RlLlRFWFRfTk9ERSkKICAgICAgICAgZWxlbWVudC5jbGFz c0xpc3QuYWRkKCJub2RlLWxpbmsiKTsKIAotICAgIGVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigi Y2xpY2siLCBXSS5kb21NYW5hZ2VyLmluc3BlY3RFbGVtZW50LmJpbmQoV0kuZG9tTWFuYWdlciwg bm9kZS5pZCkpOwotICAgIGVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2VvdmVyIiwgV0ku ZG9tTWFuYWdlci5oaWdobGlnaHRET01Ob2RlLmJpbmQoV0kuZG9tTWFuYWdlciwgbm9kZS5pZCwg ImFsbCIpKTsKLSAgICBlbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNlb3V0IiwgV0kuZG9t TWFuYWdlci5oaWRlRE9NTm9kZUhpZ2hsaWdodC5iaW5kKFdJLmRvbU1hbmFnZXIpKTsKKyAgICBX SS5iaW5kSW50ZXJhY3Rpb25zRm9yTm9kZVRvRWxlbWVudChub2RlLCBlbGVtZW50LCBvcHRpb25z KTsKKworICAgIHJldHVybiBlbGVtZW50OworfTsKKworV0kuYmluZEludGVyYWN0aW9uc0Zvck5v ZGVUb0VsZW1lbnQgPSBmdW5jdGlvbihub2RlLCBlbGVtZW50LCBvcHRpb25zID0ge30pIHsKKyAg ICBpZiAoIW9wdGlvbnMuaWdub3JlQ2xpY2spIHsKKyAgICAgICAgZWxlbWVudC5hZGRFdmVudExp c3RlbmVyKCJjbGljayIsIChldmVudCkgPT4geworICAgICAgICAgICAgV0kuZG9tTWFuYWdlci5p bnNwZWN0RWxlbWVudChub2RlLmlkKTsKKyAgICAgICAgfSk7CisgICAgfQorCisgICAgZWxlbWVu dC5hZGRFdmVudExpc3RlbmVyKCJtb3VzZW92ZXIiLCAoZXZlbnQpID0+IHsKKyAgICAgICAgV0ku ZG9tTWFuYWdlci5oaWdobGlnaHRET01Ob2RlKG5vZGUuaWQsICJhbGwiKTsKKyAgICB9KTsKKwor ICAgIGVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2VvdXQiLCAoZXZlbnQpID0+IHsKKyAg ICAgICAgV0kuZG9tTWFuYWdlci5oaWRlRE9NTm9kZUhpZ2hsaWdodCgpOworICAgIH0pOworCiAg ICAgZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJjb250ZXh0bWVudSIsIChldmVudCkgPT4gewog ICAgICAgICBsZXQgY29udGV4dE1lbnUgPSBXSS5Db250ZXh0TWVudS5jcmVhdGVGcm9tRXZlbnQo ZXZlbnQpOwogICAgICAgICBXSS5hcHBlbmRDb250ZXh0TWVudUl0ZW1zRm9yRE9NTm9kZShjb250 ZXh0TWVudSwgbm9kZSwgb3B0aW9ucyk7CiAgICAgfSk7Ci0KLSAgICByZXR1cm4gZWxlbWVudDsK IH07CiAKIGZ1bmN0aW9uIGNyZWF0ZVNWR0VsZW1lbnQodGFnTmFtZSkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTU5vZGVEZXRhaWxzU2lk ZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv RE9NTm9kZURldGFpbHNTaWRlYmFyUGFuZWwuanMKaW5kZXggZTM1ZWQwMzk3YThhNzBlODQ5OGE5 N2IyMzAzMDE0YjBjNTYzMGY1Ni4uYjVlODU4YzdkNDExNGRmOWIxZTg5M2QzNTNkZGE3NmZlMmVh MzVlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvRE9NTm9kZURldGFpbHNTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NTm9kZURldGFpbHNTaWRlYmFyUGFuZWwuanMKQEAg LTM5MywxNyArMzkzLDEwIEBAIFdJLkRPTU5vZGVEZXRhaWxzU2lkZWJhclBhbmVsID0gY2xhc3Mg RE9NTm9kZURldGFpbHNTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXSS5ET01ECiAgICAgICAgICAgICAg ICAgaWYgKCFldmVudExpc3RlbmVyc0Zvck5vZGUpCiAgICAgICAgICAgICAgICAgICAgIGNvbnRp bnVlOwogCi0gICAgICAgICAgICAgICAgbGV0IG5vZGVJZCA9IGN1cnJlbnROb2RlLmlkOwotCiAg ICAgICAgICAgICAgICAgZXZlbnRMaXN0ZW5lcnNGb3JOb2RlLnNvcnQoKGEsIGIpID0+IGEudHlw ZS50b0xvd2VyQ2FzZSgpLmV4dGVuZGVkTG9jYWxlQ29tcGFyZShiLnR5cGUudG9Mb3dlckNhc2Uo KSkpOwogCiAgICAgICAgICAgICAgICAgbGV0IHNlY3Rpb24gPSBjcmVhdGVFdmVudExpc3RlbmVy U2VjdGlvbihjdXJyZW50Tm9kZS5kaXNwbGF5TmFtZSwgZXZlbnRMaXN0ZW5lcnNGb3JOb2RlLCB7 aGlkZU5vZGU6IHRydWV9KTsKLSAgICAgICAgICAgICAgICBzZWN0aW9uLnRpdGxlRWxlbWVudC5h ZGRFdmVudExpc3RlbmVyKCJtb3VzZW92ZXIiLCAoZXZlbnQpID0+IHsKLSAgICAgICAgICAgICAg ICAgICAgV0kuZG9tTWFuYWdlci5oaWdobGlnaHRET01Ob2RlKG5vZGVJZCwgImFsbCIpOwotICAg ICAgICAgICAgICAgIH0pOwotICAgICAgICAgICAgICAgIHNlY3Rpb24udGl0bGVFbGVtZW50LmFk ZEV2ZW50TGlzdGVuZXIoIm1vdXNlb3V0IiwgKGV2ZW50KSA9PiB7Ci0gICAgICAgICAgICAgICAg ICAgIFdJLmRvbU1hbmFnZXIuaGlkZURPTU5vZGVIaWdobGlnaHQoKTsKLSAgICAgICAgICAgICAg ICB9KTsKKyAgICAgICAgICAgICAgICBXSS5iaW5kSW50ZXJhY3Rpb25zRm9yTm9kZVRvRWxlbWVu dChjdXJyZW50Tm9kZSwgc2VjdGlvbi50aXRsZUVsZW1lbnQsIHtpZ25vcmVDbGljazogdHJ1ZX0p OwogICAgICAgICAgICAgICAgIHJvd3MucHVzaChzZWN0aW9uKTsKICAgICAgICAgICAgIH0gd2hp bGUgKGN1cnJlbnROb2RlID0gY3VycmVudE5vZGUucGFyZW50Tm9kZSk7CiAK