195607 2019-03-11 22:56:44 -0700 Remove OS X Server QuickTime plugin quirks 2019-03-12 00:01:35 -0700 1 1 1 Unclassified WebKit Plug-ins WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=61229 InRadar P2 Normal --- 1 rniwa rniwa aestes beidson bfulgham cdumez esprehn+autocc ews-watchlist ggaren gyuyoung.kim jer.noble simon.fraser webkit-bug-importer oldest_to_newest 1515303 0 rniwa 2019-03-11 22:56:44 -0700 https://trac.webkit.org/r87244 added a site specific quirk for Mac OS X Sever wiki pages. However, the issue has since been resolved as of OS X Mountain Lion. Apple has ended the support of this operating system in September 2015, and iTunes' support subsequently ended in August 2016. Furthermore, the latest versions of Safari no longer supports non-Flash plugins. So the only scenario in which this code will be triggered is with custom WKWebView / WebKitLegacy app which loads OS X Server pages running OS X Mountain Lion or earlier. Given these, I think we can remove this site specific quirk. 1515319 1 bfulgham 2019-03-11 23:28:18 -0700 Do it! 1515320 2 364355 rniwa 2019-03-11 23:28:25 -0700 Created attachment 364355 Cleanup 1515323 3 364355 bfulgham 2019-03-11 23:31:43 -0700 Comment on attachment 364355 Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=364355&action=review Nice! I find all of this code removal to be cathartic! > Source/WebCore/ChangeLog:9 > + However, the issue has since been resolved as of OS X Mountain Lion, Weird white spacing on this line. > Source/WebCore/ChangeLog:13 > + the only scenario in which this quirk come into play is when a third party app “comes into play” 1515325 4 ews-watchlist 2019-03-11 23:32:56 -0700 Attachment 364355 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1515335 5 rniwa 2019-03-11 23:49:32 -0700 (In reply to Brent Fulgham from comment #3) > Comment on attachment 364355 [details] > Cleanup > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364355&action=review > > Nice! I find all of this code removal to be cathartic! > > > Source/WebCore/ChangeLog:9 > > + However, the issue has since been resolved as of OS X Mountain Lion, > > Weird white spacing on this line. Fixed. > > Source/WebCore/ChangeLog:13 > > + the only scenario in which this quirk come into play is when a third party app > > “comes into play” Fixed. 1515337 6 rniwa 2019-03-11 23:55:47 -0700 For those at Apple, also see <rdar://problem/9489557>. 1515338 7 rniwa 2019-03-11 23:58:22 -0700 Committed r242784: <https://trac.webkit.org/changeset/242784> 1515339 8 webkit-bug-importer 2019-03-11 23:59:23 -0700 <rdar://problem/48799810> 364355 2019-03-11 23:28:25 -0700 2019-03-11 23:31:43 -0700 Cleanup bug-195607-20190311232824.patch text/plain 3980 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0Mjc4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDE5LTAzLTExICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSBPUyBYIFNlcnZlciBR dWlja1RpbWUgcGx1Z2luIHF1aXJrcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTk1NjA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgcjg3MjQ0IGFkZGVkIGEgc2l0ZSBzcGVjaWZpYyBxdWlyayBmb3IgTWFj IE9TIFggU2V2ZXIgd2lraSBwYWdlcy4KKwlIb3dldmVyLCB0aGUgaXNzdWUgaGFzIHNpbmNlIGJl ZW4gcmVzb2x2ZWQgYXMgb2YgT1MgWCBNb3VudGFpbiBMaW9uLAorICAgICAgICBvZiB3aGljaCBB cHBsZSBoYXMgZW5kZWQgdGhlIHN1cHBvcnQgaW4gU2VwdGVtYmVyIDIwMTUuCisKKyAgICAgICAg QmVjYXVzZSB0aGUgbGF0ZXN0IHZlcnNpb25zIG9mIFNhZmFyaSBubyBsb25nZXIgc3VwcG9ydHMg bm9uLUZsYXNoIHBsdWdpbnMsCisgICAgICAgIHRoZSBvbmx5IHNjZW5hcmlvIGluIHdoaWNoIHRo aXMgcXVpcmsgY29tZSBpbnRvIHBsYXkgaXMgd2hlbiBhIHRoaXJkIHBhcnR5IGFwcAorICAgICAg ICB3aGljaCBlbWJlZHMgV0tXZWJWaWV3IG9yIFdlYktpdExlZ2FjeSBsb2FkZWQgd2ViIHBhZ2Vz IG9uIGEgT1MgWCBTZXJ2ZXIKKyAgICAgICAgcnVubmluZyBPUyBYIE1vdW50YWluIExpb24gb3Ig ZWFybGllci4KKworICAgICAgICBHaXZlbiB0aGVzZSBvYnNlcnZhdGlvbnMsIGl0J3MgcHJvYmFi bHkgc2FmZSB0byByZW1vdmUgdGhpcyBxdWlyayBmcm9tIFdlYktpdC4KKworICAgICAgICAqIGh0 bWwvSFRNTE9iamVjdEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE9iamVjdEVs ZW1lbnQ6Omhhc0ZhbGxiYWNrQ29udGVudCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1M T2JqZWN0RWxlbWVudDo6aGFzVmFsaWRDbGFzc0lkKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxP YmplY3RFbGVtZW50OjpzaG91bGRBbGxvd1F1aWNrVGltZUNsYXNzSWRRdWlyayk6IERlbGV0ZWQu CisgICAgICAgICogaHRtbC9IVE1MT2JqZWN0RWxlbWVudC5oOgorCiAyMDE5LTAzLTEyICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSBNZWRpYVdpa2kg c2l0ZSBzcGVjaWZpYyBxdWlya3MKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE9iamVj dEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE9iamVj dEVsZW1lbnQuY3BwCShyZXZpc2lvbiAyNDI3NzgpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxPYmplY3RFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjI0LDM3ICsyMjQsMTEgQEAg Ym9vbCBIVE1MT2JqZWN0RWxlbWVudDo6aGFzRmFsbGJhY2tDb250ZQogICAgIH0KICAgICByZXR1 cm4gZmFsc2U7CiB9Ci0gICAgCi1ib29sIEhUTUxPYmplY3RFbGVtZW50OjpzaG91bGRBbGxvd1F1 aWNrVGltZUNsYXNzSWRRdWlyaygpCi17Ci0gICAgLy8gVGhpcyBzaXRlLXNwZWNpZmljIGhhY2sg bWFpbnRhaW5zIGNvbXBhdGliaWxpdHkgd2l0aCBNYWMgT1MgWCBXaWtpIFNlcnZlciwKLSAgICAv LyB3aGljaCBlbWJlZHMgUXVpY2tUaW1lIG1vdmllcyB1c2luZyBhbiBvYmplY3QgdGFnIGNvbnRh aW5pbmcgUXVpY2tUaW1lJ3MKLSAgICAvLyBBY3RpdmVYIGNsYXNzaWQuIFRyZWF0IHRoaXMgY2xh c3NpZCBhcyB2YWxpZCBvbmx5IGlmIE9TIFggU2VydmVyJ3MgdW5pcXVlCi0gICAgLy8gJ2dlbmVy YXRvcicgbWV0YSB0YWcgaXMgcHJlc2VudC4gT25seSBhcHBseSB0aGlzIHF1aXJrIGlmIHRoZXJl IGlzIG5vCi0gICAgLy8gZmFsbGJhY2sgY29udGVudCwgd2hpY2ggZW5zdXJlcyB0aGUgcXVpcmsg d2lsbCBkaXNhYmxlIGl0c2VsZiBpZiBXaWtpCi0gICAgLy8gU2VydmVyIGlzIHVwZGF0ZWQgdG8g Z2VuZXJhdGUgYW4gYWx0ZXJuYXRlIGVtYmVkIHRhZyBhcyBmYWxsYmFjayBjb250ZW50LgotCi0g ICAgaWYgKCFkb2N1bWVudCgpLnBhZ2UoKQotICAgICAgICB8fCAhZG9jdW1lbnQoKS5wYWdlKCkt PnNldHRpbmdzKCkubmVlZHNTaXRlU3BlY2lmaWNRdWlya3MoKQotICAgICAgICB8fCBoYXNGYWxs YmFja0NvbnRlbnQoKQotICAgICAgICB8fCAhZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2Uo YXR0cmlidXRlV2l0aG91dFN5bmNocm9uaXphdGlvbihjbGFzc2lkQXR0ciksICJjbHNpZDowMmJm MjVkNS04YzE3LTRiMjMtYmM4MC1kMzQ4OGFiZGRjNmIiKSkKLSAgICAgICAgcmV0dXJuIGZhbHNl OwotCi0gICAgZm9yIChhdXRvJiBtZXRhRWxlbWVudCA6IGRlc2NlbmRhbnRzT2ZUeXBlPEhUTUxN ZXRhRWxlbWVudD4oZG9jdW1lbnQoKSkpIHsKLSAgICAgICAgaWYgKGVxdWFsTGV0dGVyc0lnbm9y aW5nQVNDSUlDYXNlKG1ldGFFbGVtZW50Lm5hbWUoKSwgImdlbmVyYXRvciIpICYmIHN0YXJ0c1dp dGhMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UobWV0YUVsZW1lbnQuY29udGVudCgpLCAibWFjIG9z IHggc2VydmVyIHdlYiBzZXJ2aWNlcyBzZXJ2ZXIiKSkKLSAgICAgICAgICAgIHJldHVybiB0cnVl OwotICAgIH0KIAotICAgIHJldHVybiBmYWxzZTsKLX0KLSAgICAKIGJvb2wgSFRNTE9iamVjdEVs ZW1lbnQ6Omhhc1ZhbGlkQ2xhc3NJZCgpCiB7CiAgICAgaWYgKE1JTUVUeXBlUmVnaXN0cnk6Omlz SmF2YUFwcGxldE1JTUVUeXBlKHNlcnZpY2VUeXBlKCkpICYmIHByb3RvY29sSXMoYXR0cmlidXRl V2l0aG91dFN5bmNocm9uaXphdGlvbihjbGFzc2lkQXR0ciksICJqYXZhIikpCiAgICAgICAgIHJl dHVybiB0cnVlOwotICAgIAotICAgIGlmIChzaG91bGRBbGxvd1F1aWNrVGltZUNsYXNzSWRRdWly aygpKQotICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIC8vIEhUTUw1IHNheXMgdGhhdCBmYWxs YmFjayBjb250ZW50IHNob3VsZCBiZSByZW5kZXJlZCBpZiBhIG5vbi1lbXB0eQogICAgIC8vIGNs YXNzaWQgaXMgc3BlY2lmaWVkIGZvciB3aGljaCB0aGUgVUEgY2FuJ3QgZmluZCBhIHN1aXRhYmxl IHBsdWctaW4uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxPYmplY3RFbGVtZW50LmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MT2JqZWN0RWxlbWVudC5oCShy ZXZpc2lvbiAyNDI3NzgpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxPYmplY3RFbGVtZW50 LmgJKHdvcmtpbmcgY29weSkKQEAgLTg0LDggKzg0LDcgQEAgcHJpdmF0ZToKICAgICAvLyBGSVhN RTogVGhpcyBmdW5jdGlvbiBzaG91bGQgbm90IGRlYWwgd2l0aCB1cmwgb3Igc2VydmljZVR5cGUK ICAgICAvLyBzbyB0aGF0IHdlIGNhbiBiZXR0ZXIgc2hhcmUgY29kZSBiZXR3ZWVuIDxvYmplY3Q+ IGFuZCA8ZW1iZWQ+LgogICAgIHZvaWQgcGFyYW1ldGVyc0ZvclBsdWdpbihWZWN0b3I8U3RyaW5n PiYgcGFyYW1OYW1lcywgVmVjdG9yPFN0cmluZz4mIHBhcmFtVmFsdWVzLCBTdHJpbmcmIHVybCwg U3RyaW5nJiBzZXJ2aWNlVHlwZSk7Ci0gICAgCi0gICAgYm9vbCBzaG91bGRBbGxvd1F1aWNrVGlt ZUNsYXNzSWRRdWlyaygpOworCiAgICAgYm9vbCBoYXNWYWxpZENsYXNzSWQoKTsKIAogICAgIHZv aWQgcmVmRm9ybUFzc29jaWF0ZWRFbGVtZW50KCkgZmluYWwgeyByZWYoKTsgfQo=