195604 2019-03-11 21:27:28 -0700 WTF::Expected should use std::addressof instead of operator& 2019-03-12 09:34:25 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen benjamin cdumez cmarcelo commit-queue dbates ews-watchlist jfbastien mmaxfield webkit-bug-importer oldest_to_newest 1515261 0 achristensen 2019-03-11 21:27:28 -0700 WTF::Expected should use std::addressof instead of operator& 1515263 1 364350 achristensen 2019-03-11 21:30:13 -0700 Created attachment 364350 Patch 1515265 2 ews-watchlist 2019-03-11 21:34:32 -0700 Attachment 364350 did not pass style-queue: ERROR: Source/WTF/wtf/Expected.h:346: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Expected.h:348: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Expected.h:396: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Expected.h:465: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Expected.h:467: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Expected.h:472: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Expected.h:474: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Expected.h:543: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] Total errors found: 8 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1515279 3 364350 commit-queue 2019-03-11 22:16:07 -0700 Comment on attachment 364350 Patch Rejecting attachment 364350 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: o-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wno-float-conversion -Wnon-literal-null-conversion -Wobjc-literal-conversion -Wno-shorten-64-to-32 -Wno-newline-eof -Wno-c++11-extensions -DNDEBUG -DENABLE_3D_TRANSFORMS -DENABLE_APPLE_PAY -DENABLE_APPLE_PAY_SESSION_V3 -DENABLE_APPLICATION_MANIFEST -DENABLE_ATTACHMENT_ELEMENT -DENABLE_AVF_CAPTIONS -DENABLE_CACHE_PARTITIONING -DENABLE_CHANNEL_MESSAGING -DENABLE_CONTENT_FILTERING -DENABLE_CSS_BOX_DECORATION_BREAK -DENABLE_CSS_COMPOSITING -DENABLE_CSS_PAINTING_API -DENABLE_CSS_SCROLL_SNAP -DENABLE_CSS_SELECTORS_LEVEL4 -DENABLE_CSS_TRAILING_WORD -DENABLE_CSS_TYPED_OM -DENABLE_CURSOR_VISIBILITY -DENABLE_DARK_MODE_CSS -DENABLE_DASHBOARD_SUPPORT -DENABLE_DATACUE_VALUE -DENABLE_DATALIST_ELEMENT -DENABLE_EXPERIMENTAL_FEATURES -DENABLE_FILTERS_LEVEL_2 -DENABLE_FTL_JIT -DENABLE_FULLSCREEN_API -DENABLE_GAMEPAD -DENABLE_GEOLOCATION -DENABLE_ICONDATABASE -DENABLE_INDEXED_DATABASE -DENABLE_INDEXED_DATABASE_IN_WORKERS -DENABLE_INPUT_TYPE_COLOR -DENABLE_INTERSECTION_OBSERVER -DENABLE_INTL -DENABLE_KEYBOARD_CODE_ATTRIBUTE -DENABLE_KEYBOARD_KEY_ATTRIBUTE -DENABLE_LAYOUT_FORMATTING_CONTEXT -DENABLE_LEGACY_CSS_VENDOR_PREFIXES -DENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER -DENABLE_LEGACY_ENCRYPTED_MEDIA -DENABLE_MATHML -DENABLE_MEDIA_CONTROLS_SCRIPT -DENABLE_MEDIA_SOURCE -DENABLE_MEDIA_STREAM -DENABLE_METER_ELEMENT -DENABLE_MOUSE_CURSOR_SCALE -DENABLE_NOTIFICATIONS -DENABLE_PAYMENT_REQUEST -DENABLE_PDFKIT_PLUGIN -DENABLE_POINTER_EVENTS -DENABLE_POINTER_LOCK -DENABLE_PUBLIC_SUFFIX_LIST -DENABLE_REMOTE_INSPECTOR -DENABLE_RESOURCE_LOAD_STATISTICS -DENABLE_RESOURCE_USAGE -DENABLE_RUBBER_BANDING -DENABLE_SERVICE_CONTROLS -DENABLE_SERVICE_WORKER -DENABLE_SPEECH_SYNTHESIS -DENABLE_STREAMS_API -DENABLE_WEB_CRYPTO -DENABLE_SVG_FONTS -DENABLE_TELEPHONE_NUMBER_DETECTION -DENABLE_TEXT_AUTOSIZING -DENABLE_USER_MESSAGE_HANDLERS -DENABLE_USERSELECT_ALL -DENABLE_VARIATION_FONTS -DENABLE_VIDEO -DENABLE_VIDEO_PRESENTATION_MODE -DENABLE_VIDEO_TRACK -DENABLE_VIDEO_USES_ELEMENT_FULLSCREEN -DENABLE_WEB_AUDIO -DENABLE_WEB_AUTHN -DENABLE_WEB_RTC -DENABLE_WEBGL -DENABLE_WEBGL2 -DENABLE_WEBGPU -DENABLE_WEBMETAL -DENABLE_WIRELESS_PLAYBACK_TARGET -DENABLE_XSLT -DU_DISABLE_RENAMING=1 -DU_SHOW_CPLUSPLUS_API=0 -DENABLE_DASHBOARD_SUPPORT -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -fasm-blocks -fstrict-aliasing -Wno-deprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.13 -g -fvisibility=hidden -Wno-sign-conversion -Winfinite-recursion -Wmove -Wcomma -Wblock-capture-autoreleasing -Wstrict-prototypes -Wrange-loop-analysis -Wno-semicolon-before-method-body -I/Volumes/Data/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWTFLibrary.build/TestWTF.hmap -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/include -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/ForwardingHeaders -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCoreTestSupport -I/Volumes/Data/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWTFLibrary.build/DerivedSources/x86_64 -I/Volumes/Data/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWTFLibrary.build/DerivedSources -Wall -W -Wno-unused-parameter -F/Volumes/Data/EWS/WebKit/WebKitBuild/Release --system-header-prefix=WebKit/ -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/PrivateFrameworks -ftemplate-depth=256 -MMD -MT dependencies -MF /Volumes/Data/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWTFLibrary.build/Objects-normal/x86_64/Markable.d --serialize-diagnostics /Volumes/Data/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWTFLibrary.build/Objects-normal/x86_64/Markable.dia -c /Volumes/Data/EWS/WebKit/Tools/TestWebKitAPI/Tests/WTF/Markable.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWTFLibrary.build/Objects-normal/x86_64/Markable.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWTFLibrary.build/Objects-normal/x86_64/Expected.o Tests/WTF/Expected.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Failed to run "['Tools/Scripts/build-webkit', '--release']" exit_code: 65 x86_64/Markable.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWTFLibrary.build/Objects-normal/x86_64/Expected.o Tests/WTF/Expected.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: https://webkit-queues.webkit.org/results/11467762 1515283 4 364350 mmaxfield 2019-03-11 22:20:29 -0700 Comment on attachment 364350 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364350&action=review > Tools/TestWebKitAPI/Tests/WTF/Expected.cpp:483 > + std::NeedsStdAddress_ptr<int> m_ref; Shouldn't this be int*? > Tools/TestWebKitAPI/Tests/WTF/Expected.cpp:488 > + NeedsStdAddress a(*new int(3)); Doesn't this leak an int? 1515285 5 achristensen 2019-03-11 22:22:57 -0700 (In reply to Myles C. Maxfield from comment #4) > Comment on attachment 364350 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364350&action=review > > > Tools/TestWebKitAPI/Tests/WTF/Expected.cpp:483 > > + std::NeedsStdAddress_ptr<int> m_ref; > > Shouldn't this be int*? This should be std::unique_ptr<int>. This was me getting over eager with copying and pasting from an earlier version of the test. 1515289 6 364353 achristensen 2019-03-11 22:26:41 -0700 Created attachment 364353 Patch 1515307 7 364353 commit-queue 2019-03-11 23:04:28 -0700 Comment on attachment 364353 Patch Clearing flags on attachment: 364353 Committed r242778: <https://trac.webkit.org/changeset/242778> 1515308 8 commit-queue 2019-03-11 23:04:30 -0700 All reviewed patches have been landed. Closing bug. 1515324 9 webkit-bug-importer 2019-03-11 23:32:40 -0700 <rdar://problem/48799379> 1515461 10 jfbastien 2019-03-12 09:34:25 -0700 Thanks for fixing this, looks great. 364350 2019-03-11 21:30:13 -0700 2019-03-11 22:26:39 -0700 Patch bug-195604-20190311213012.patch text/plain 5627 achristensen SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNDI3MTApCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAzLTExICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgV1RGOjpFeHBlY3RlZCBzaG91bGQg dXNlIHN0ZDo6YWRkcmVzc29mIGluc3RlYWQgb2Ygb3BlcmF0b3ImCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU2MDQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbGF0dGVyIHdhcyBjYXVzaW5nIHBy b2JsZW1zIHdpdGggdHlwZXMgdGhhdCBkbyB0cmlja3kgdGhpbmdzIHdpdGggY29uc3RydWN0b3Jz IGFuZCBvcGVyYXRvciYsCisgICAgICAgIHNwZWNpZmljYWxseSBVbmlxdWVSZWYgYnV0IEkgbWFk ZSBhIHJlZHVjZWQgdGVzdCBjYXNlLiAgV2hlbiBpdCB1c2VkIG9wZXJhdG9yJiwgaXQgd291bGQg Z2V0IHRoZSBjb250YWluZWQKKyAgICAgICAgdHlwZSBhbmQgY2FsbCB0aGUgY29uc3RydWN0b3Ig dGhhdCB0YWtlcyBhIGNvbnRhaW5lZCB0eXBlIGluc3RlYWQgb2YgdGhlIG1vdmUgY29uc3RydWN0 b3IuCisKKyAgICAgICAgKiB3dGYvRXhwZWN0ZWQuaDoKKyAgICAgICAgKHN0ZDo6ZXhwZXJpbWVu dGFsOjpmdW5kYW1lbnRhbHNfdjM6Ol9fZXhwZWN0ZWRfZGV0YWlsOjpiYXNlOjpiYXNlKToKKyAg ICAgICAgKHN0ZDo6ZXhwZXJpbWVudGFsOjpmdW5kYW1lbnRhbHNfdjM6OmV4cGVjdGVkOjpzd2Fw KToKKwogMjAxOS0wMy0xMSAgVHJ1aXR0IFNhdmVsbCAgPHRzYXZlbGxAYXBwbGUuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNDI3MDIuCkluZGV4OiBTb3VyY2UvV1RG L3d0Zi9FeHBlY3RlZC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0V4cGVjdGVkLmgJ KHJldmlzaW9uIDI0MjcxMCkKKysrIFNvdXJjZS9XVEYvd3RmL0V4cGVjdGVkLmgJKHdvcmtpbmcg Y29weSkKQEAgLTMzNSwxNyArMzM1LDE3IEBAIHN0cnVjdCBiYXNlIHsKICAgICAgICAgOiBoYXMo by5oYXMpCiAgICAgewogICAgICAgICBpZiAoaGFzKQotICAgICAgICAgICAgOjpuZXcgKCZzLnZh bCkgdmFsdWVfdHlwZShvLnMudmFsKTsKKyAgICAgICAgICAgIDo6bmV3IChzdGQ6OmFkZHJlc3Nv ZihzLnZhbCkpIHZhbHVlX3R5cGUoby5zLnZhbCk7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAg IDo6bmV3ICgmcy5lcnIpIGVycm9yX3R5cGUoby5zLmVycik7CisgICAgICAgICAgICA6Om5ldyAo c3RkOjphZGRyZXNzb2Yocy5lcnIpKSBlcnJvcl90eXBlKG8ucy5lcnIpOwogICAgIH0KICAgICBi YXNlKGJhc2UmJiBvKQogICAgICAgICA6IGhhcyhvLmhhcykKICAgICB7CiAgICAgICAgIGlmICho YXMpCi0gICAgICAgICAgICA6Om5ldyAoJnMudmFsKSB2YWx1ZV90eXBlKHN0ZDo6bW92ZShvLnMu dmFsKSk7CisgICAgICAgICAgICA6Om5ldyAoc3RkOjphZGRyZXNzb2Yocy52YWwpKSB2YWx1ZV90 eXBlKHN0ZDo6bW92ZShvLnMudmFsKSk7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIDo6bmV3 ICgmcy5lcnIpIGVycm9yX3R5cGUoc3RkOjptb3ZlKG8ucy5lcnIpKTsKKyAgICAgICAgICAgIDo6 bmV3IChzdGQ6OmFkZHJlc3NvZihzLmVycikpIGVycm9yX3R5cGUoc3RkOjptb3ZlKG8ucy5lcnIp KTsKICAgICB9CiAgICAgfmJhc2UoKQogICAgIHsKQEAgLTM4NywxMyArMzg3LDEzIEBAIHN0cnVj dCBiYXNlPHZvaWQsIEU+IHsKICAgICAgICAgOiBoYXMoby5oYXMpCiAgICAgewogICAgICAgICBp ZiAoIWhhcykKLSAgICAgICAgICAgIDo6bmV3ICgmcy5lcnIpIGVycm9yX3R5cGUoby5zLmVycik7 CisgICAgICAgICAgICA6Om5ldyAoc3RkOjphZGRyZXNzb2Yocy5lcnIpKSBlcnJvcl90eXBlKG8u cy5lcnIpOwogICAgIH0KICAgICBiYXNlKGJhc2UmJiBvKQogICAgICAgICA6IGhhcyhvLmhhcykK ICAgICB7CiAgICAgICAgIGlmICghaGFzKQotICAgICAgICAgICAgOjpuZXcgKCZzLmVycikgZXJy b3JfdHlwZShzdGQ6Om1vdmUoby5zLmVycikpOworICAgICAgICAgICAgOjpuZXcgKHN0ZDo6YWRk cmVzc29mKHMuZXJyKSkgZXJyb3JfdHlwZShzdGQ6Om1vdmUoby5zLmVycikpOwogICAgIH0KICAg ICB+YmFzZSgpCiAgICAgewpAQCAtNDYyLDE2ICs0NjIsMTYgQEAgcHVibGljOgogICAgICAgICBl bHNlIGlmIChiYXNlOjpoYXMgJiYgIW8uaGFzKSB7CiAgICAgICAgICAgICBlcnJvcl90eXBlIGUo c3RkOjptb3ZlKG8ucy5lcnIpKTsKICAgICAgICAgICAgIF9fZXhwZWN0ZWRfZGV0YWlsOjpkZXN0 cm95KG8ucy5lcnIpOwotICAgICAgICAgICAgOjpuZXcgKCZvLnMudmFsKSB2YWx1ZV90eXBlKHN0 ZDo6bW92ZShiYXNlOjpzLnZhbCkpOworICAgICAgICAgICAgOjpuZXcgKHN0ZDo6YWRkcmVzc29m KG8ucy52YWwpKSB2YWx1ZV90eXBlKHN0ZDo6bW92ZShiYXNlOjpzLnZhbCkpOwogICAgICAgICAg ICAgX19leHBlY3RlZF9kZXRhaWw6OmRlc3Ryb3koYmFzZTo6cy52YWwpOwotICAgICAgICAgICAg OjpuZXcgKCZiYXNlOjpzLmVycikgZXJyb3JfdHlwZShzdGQ6Om1vdmUoZSkpOworICAgICAgICAg ICAgOjpuZXcgKHN0ZDo6YWRkcmVzc29mKGJhc2U6OnMuZXJyKSkgZXJyb3JfdHlwZShzdGQ6Om1v dmUoZSkpOwogICAgICAgICAgICAgc3dhcChiYXNlOjpoYXMsIG8uaGFzKTsKICAgICAgICAgfSBl bHNlIGlmICghYmFzZTo6aGFzICYmIG8uaGFzKSB7CiAgICAgICAgICAgICB2YWx1ZV90eXBlIHYo c3RkOjptb3ZlKG8ucy52YWwpKTsKICAgICAgICAgICAgIF9fZXhwZWN0ZWRfZGV0YWlsOjpkZXN0 cm95KG8ucy52YWwpOwotICAgICAgICAgICAgOjpuZXcgKCZvLnMuZXJyKSBlcnJvcl90eXBlKHN0 ZDo6bW92ZShiYXNlOjpzLmVycikpOworICAgICAgICAgICAgOjpuZXcgKHN0ZDo6YWRkcmVzc29m KG8ucy5lcnIpKSBlcnJvcl90eXBlKHN0ZDo6bW92ZShiYXNlOjpzLmVycikpOwogICAgICAgICAg ICAgX19leHBlY3RlZF9kZXRhaWw6OmRlc3Ryb3koYmFzZTo6cy5lcnIpOwotICAgICAgICAgICAg OjpuZXcgKCZiYXNlOjpzLnZhbCkgdmFsdWVfdHlwZShzdGQ6Om1vdmUodikpOworICAgICAgICAg ICAgOjpuZXcgKHN0ZDo6YWRkcmVzc29mKGJhc2U6OnMudmFsKSkgdmFsdWVfdHlwZShzdGQ6Om1v dmUodikpOwogICAgICAgICAgICAgc3dhcChiYXNlOjpoYXMsIG8uaGFzKTsKICAgICAgICAgfSBl bHNlCiAgICAgICAgICAgICBzd2FwKGJhc2U6OnMuZXJyLCBvLnMuZXJyKTsKQEAgLTUzNywxMCAr NTM3LDEwIEBAIHB1YmxpYzoKICAgICAgICAgICAgIC8vIERvIG5vdGhpbmcuCiAgICAgICAgIH0g ZWxzZSBpZiAoYmFzZTo6aGFzICYmICFvLmhhcykgewogICAgICAgICAgICAgZXJyb3JfdHlwZSBl KHN0ZDo6bW92ZShvLnMuZXJyKSk7Ci0gICAgICAgICAgICA6Om5ldyAoJmJhc2U6OnMuZXJyKSBl cnJvcl90eXBlKGUpOworICAgICAgICAgICAgOjpuZXcgKHN0ZDo6YWRkcmVzc29mKGJhc2U6OnMu ZXJyKSkgZXJyb3JfdHlwZShlKTsKICAgICAgICAgICAgIHN3YXAoYmFzZTo6aGFzLCBvLmhhcyk7 CiAgICAgICAgIH0gZWxzZSBpZiAoIWJhc2U6OmhhcyAmJiBvLmhhcykgewotICAgICAgICAgICAg OjpuZXcgKCZvLnMuZXJyKSBlcnJvcl90eXBlKHN0ZDo6bW92ZShiYXNlOjpzLmVycikpOworICAg ICAgICAgICAgOjpuZXcgKHN0ZDo6YWRkcmVzc29mKG8ucy5lcnIpKSBlcnJvcl90eXBlKHN0ZDo6 bW92ZShiYXNlOjpzLmVycikpOwogICAgICAgICAgICAgc3dhcChiYXNlOjpoYXMsIG8uaGFzKTsK ICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICBzd2FwKGJhc2U6OnMuZXJyLCBvLnMuZXJyKTsK SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Mjc3MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTAzLTExICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CisKKyAgICAgICAgV1RGOjpFeHBlY3RlZCBzaG91bGQgdXNlIHN0ZDo6YWRkcmVz c29mIGluc3RlYWQgb2Ygb3BlcmF0b3ImCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTU2MDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0V4cGVjdGVkLmNwcDoK KyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlVuaXF1ZTo6VW5pcXVlKToKKyAgICAgICAgKFRlc3RX ZWJLaXRBUEk6OlVuaXF1ZTo6b3BlcmF0b3ImKToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRF U1QpOgorCiAyMDE5LTAzLTExICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgogCiAgICAgICAgIEFQSSB0ZXN0IFdlYktpdC5SZXF1ZXN0VGV4dElucHV0Q29udGV4dCBmYWls cyBvbiBpT1MKSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0V4cGVjdGVkLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9FeHBlY3RlZC5j cHAJKHJldmlzaW9uIDI0MjcxMCkKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0V4 cGVjdGVkLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDcyLDQgKzQ3MiwyMyBAQCBURVNUKFdURl9F eHBlY3RlZCwgUmVmKQogICAgIEFTU0VSVF9TVFJFUSgicmVmKGEpIGRlcmVmKGEpICIsIHRha2VM b2dTdHIoKS5jX3N0cigpKTsKIH0KIAorY2xhc3MgTmVlZHNTdGRBZGRyZXNzIHsKK3B1YmxpYzoK KyAgICBOZWVkc1N0ZEFkZHJlc3MoTmVlZHNTdGRBZGRyZXNzJiYgb3RoZXIpCisgICAgICAgIDog bV9yZWYoV1RGTW92ZShvdGhlci5tX3JlZikpIHsgfQorICAgIE5lZWRzU3RkQWRkcmVzcyhpbnQm IG90aGVyKQorICAgICAgICA6IG1fcmVmKCZvdGhlcikgeyB9CisgICAgaW50KiBvcGVyYXRvciYo KSB7IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOyByZXR1cm4gbnVsbHB0cjsgfQorcHJpdmF0ZToKKyAg ICBzdGQ6Ok5lZWRzU3RkQWRkcmVzc19wdHI8aW50PiBtX3JlZjsKK307CisKK1RFU1QoV1RGX0V4 cGVjdGVkLCBBZGRyZXNzKQoreworICAgIE5lZWRzU3RkQWRkcmVzcyBhKCpuZXcgaW50KDMpKTsK KyAgICBFeHBlY3RlZDxOZWVkc1N0ZEFkZHJlc3MsIGZsb2F0PiBiKFdURk1vdmUoYSkpOworICAg IEV4cGVjdGVkPE5lZWRzU3RkQWRkcmVzcywgZmxvYXQ+IGMoV1RGTW92ZShiKSk7CisgICAgKHZv aWQpYzsKK30KKwogfSAvLyBuYW1lc3BhY2UgVGVzdFdlYmtpdEFQSQo= 364353 2019-03-11 22:26:41 -0700 2019-03-11 23:04:28 -0700 Patch bug-195604-20190311222639.patch text/plain 5618 achristensen SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNDI3MTApCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAzLTExICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgV1RGOjpFeHBlY3RlZCBzaG91bGQg dXNlIHN0ZDo6YWRkcmVzc29mIGluc3RlYWQgb2Ygb3BlcmF0b3ImCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU2MDQKKworICAgICAgICBSZXZpZXdl ZCBieSBNeWxlcyBNYXhmaWVsZC4KKworICAgICAgICBUaGUgbGF0dGVyIHdhcyBjYXVzaW5nIHBy b2JsZW1zIHdpdGggdHlwZXMgdGhhdCBkbyB0cmlja3kgdGhpbmdzIHdpdGggY29uc3RydWN0b3Jz IGFuZCBvcGVyYXRvciYsCisgICAgICAgIHNwZWNpZmljYWxseSBVbmlxdWVSZWYgYnV0IEkgbWFk ZSBhIHJlZHVjZWQgdGVzdCBjYXNlLiAgV2hlbiBpdCB1c2VkIG9wZXJhdG9yJiwgaXQgd291bGQg Z2V0IHRoZSBjb250YWluZWQKKyAgICAgICAgdHlwZSBhbmQgY2FsbCB0aGUgY29uc3RydWN0b3Ig dGhhdCB0YWtlcyBhIGNvbnRhaW5lZCB0eXBlIGluc3RlYWQgb2YgdGhlIG1vdmUgY29uc3RydWN0 b3IuCisKKyAgICAgICAgKiB3dGYvRXhwZWN0ZWQuaDoKKyAgICAgICAgKHN0ZDo6ZXhwZXJpbWVu dGFsOjpmdW5kYW1lbnRhbHNfdjM6Ol9fZXhwZWN0ZWRfZGV0YWlsOjpiYXNlOjpiYXNlKToKKyAg ICAgICAgKHN0ZDo6ZXhwZXJpbWVudGFsOjpmdW5kYW1lbnRhbHNfdjM6OmV4cGVjdGVkOjpzd2Fw KToKKwogMjAxOS0wMy0xMSAgVHJ1aXR0IFNhdmVsbCAgPHRzYXZlbGxAYXBwbGUuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNDI3MDIuCkluZGV4OiBTb3VyY2UvV1RG L3d0Zi9FeHBlY3RlZC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0V4cGVjdGVkLmgJ KHJldmlzaW9uIDI0MjcxMCkKKysrIFNvdXJjZS9XVEYvd3RmL0V4cGVjdGVkLmgJKHdvcmtpbmcg Y29weSkKQEAgLTMzNSwxNyArMzM1LDE3IEBAIHN0cnVjdCBiYXNlIHsKICAgICAgICAgOiBoYXMo by5oYXMpCiAgICAgewogICAgICAgICBpZiAoaGFzKQotICAgICAgICAgICAgOjpuZXcgKCZzLnZh bCkgdmFsdWVfdHlwZShvLnMudmFsKTsKKyAgICAgICAgICAgIDo6bmV3IChzdGQ6OmFkZHJlc3Nv ZihzLnZhbCkpIHZhbHVlX3R5cGUoby5zLnZhbCk7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAg IDo6bmV3ICgmcy5lcnIpIGVycm9yX3R5cGUoby5zLmVycik7CisgICAgICAgICAgICA6Om5ldyAo c3RkOjphZGRyZXNzb2Yocy5lcnIpKSBlcnJvcl90eXBlKG8ucy5lcnIpOwogICAgIH0KICAgICBi YXNlKGJhc2UmJiBvKQogICAgICAgICA6IGhhcyhvLmhhcykKICAgICB7CiAgICAgICAgIGlmICho YXMpCi0gICAgICAgICAgICA6Om5ldyAoJnMudmFsKSB2YWx1ZV90eXBlKHN0ZDo6bW92ZShvLnMu dmFsKSk7CisgICAgICAgICAgICA6Om5ldyAoc3RkOjphZGRyZXNzb2Yocy52YWwpKSB2YWx1ZV90 eXBlKHN0ZDo6bW92ZShvLnMudmFsKSk7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIDo6bmV3 ICgmcy5lcnIpIGVycm9yX3R5cGUoc3RkOjptb3ZlKG8ucy5lcnIpKTsKKyAgICAgICAgICAgIDo6 bmV3IChzdGQ6OmFkZHJlc3NvZihzLmVycikpIGVycm9yX3R5cGUoc3RkOjptb3ZlKG8ucy5lcnIp KTsKICAgICB9CiAgICAgfmJhc2UoKQogICAgIHsKQEAgLTM4NywxMyArMzg3LDEzIEBAIHN0cnVj dCBiYXNlPHZvaWQsIEU+IHsKICAgICAgICAgOiBoYXMoby5oYXMpCiAgICAgewogICAgICAgICBp ZiAoIWhhcykKLSAgICAgICAgICAgIDo6bmV3ICgmcy5lcnIpIGVycm9yX3R5cGUoby5zLmVycik7 CisgICAgICAgICAgICA6Om5ldyAoc3RkOjphZGRyZXNzb2Yocy5lcnIpKSBlcnJvcl90eXBlKG8u cy5lcnIpOwogICAgIH0KICAgICBiYXNlKGJhc2UmJiBvKQogICAgICAgICA6IGhhcyhvLmhhcykK ICAgICB7CiAgICAgICAgIGlmICghaGFzKQotICAgICAgICAgICAgOjpuZXcgKCZzLmVycikgZXJy b3JfdHlwZShzdGQ6Om1vdmUoby5zLmVycikpOworICAgICAgICAgICAgOjpuZXcgKHN0ZDo6YWRk cmVzc29mKHMuZXJyKSkgZXJyb3JfdHlwZShzdGQ6Om1vdmUoby5zLmVycikpOwogICAgIH0KICAg ICB+YmFzZSgpCiAgICAgewpAQCAtNDYyLDE2ICs0NjIsMTYgQEAgcHVibGljOgogICAgICAgICBl bHNlIGlmIChiYXNlOjpoYXMgJiYgIW8uaGFzKSB7CiAgICAgICAgICAgICBlcnJvcl90eXBlIGUo c3RkOjptb3ZlKG8ucy5lcnIpKTsKICAgICAgICAgICAgIF9fZXhwZWN0ZWRfZGV0YWlsOjpkZXN0 cm95KG8ucy5lcnIpOwotICAgICAgICAgICAgOjpuZXcgKCZvLnMudmFsKSB2YWx1ZV90eXBlKHN0 ZDo6bW92ZShiYXNlOjpzLnZhbCkpOworICAgICAgICAgICAgOjpuZXcgKHN0ZDo6YWRkcmVzc29m KG8ucy52YWwpKSB2YWx1ZV90eXBlKHN0ZDo6bW92ZShiYXNlOjpzLnZhbCkpOwogICAgICAgICAg ICAgX19leHBlY3RlZF9kZXRhaWw6OmRlc3Ryb3koYmFzZTo6cy52YWwpOwotICAgICAgICAgICAg OjpuZXcgKCZiYXNlOjpzLmVycikgZXJyb3JfdHlwZShzdGQ6Om1vdmUoZSkpOworICAgICAgICAg ICAgOjpuZXcgKHN0ZDo6YWRkcmVzc29mKGJhc2U6OnMuZXJyKSkgZXJyb3JfdHlwZShzdGQ6Om1v dmUoZSkpOwogICAgICAgICAgICAgc3dhcChiYXNlOjpoYXMsIG8uaGFzKTsKICAgICAgICAgfSBl bHNlIGlmICghYmFzZTo6aGFzICYmIG8uaGFzKSB7CiAgICAgICAgICAgICB2YWx1ZV90eXBlIHYo c3RkOjptb3ZlKG8ucy52YWwpKTsKICAgICAgICAgICAgIF9fZXhwZWN0ZWRfZGV0YWlsOjpkZXN0 cm95KG8ucy52YWwpOwotICAgICAgICAgICAgOjpuZXcgKCZvLnMuZXJyKSBlcnJvcl90eXBlKHN0 ZDo6bW92ZShiYXNlOjpzLmVycikpOworICAgICAgICAgICAgOjpuZXcgKHN0ZDo6YWRkcmVzc29m KG8ucy5lcnIpKSBlcnJvcl90eXBlKHN0ZDo6bW92ZShiYXNlOjpzLmVycikpOwogICAgICAgICAg ICAgX19leHBlY3RlZF9kZXRhaWw6OmRlc3Ryb3koYmFzZTo6cy5lcnIpOwotICAgICAgICAgICAg OjpuZXcgKCZiYXNlOjpzLnZhbCkgdmFsdWVfdHlwZShzdGQ6Om1vdmUodikpOworICAgICAgICAg ICAgOjpuZXcgKHN0ZDo6YWRkcmVzc29mKGJhc2U6OnMudmFsKSkgdmFsdWVfdHlwZShzdGQ6Om1v dmUodikpOwogICAgICAgICAgICAgc3dhcChiYXNlOjpoYXMsIG8uaGFzKTsKICAgICAgICAgfSBl bHNlCiAgICAgICAgICAgICBzd2FwKGJhc2U6OnMuZXJyLCBvLnMuZXJyKTsKQEAgLTUzNywxMCAr NTM3LDEwIEBAIHB1YmxpYzoKICAgICAgICAgICAgIC8vIERvIG5vdGhpbmcuCiAgICAgICAgIH0g ZWxzZSBpZiAoYmFzZTo6aGFzICYmICFvLmhhcykgewogICAgICAgICAgICAgZXJyb3JfdHlwZSBl KHN0ZDo6bW92ZShvLnMuZXJyKSk7Ci0gICAgICAgICAgICA6Om5ldyAoJmJhc2U6OnMuZXJyKSBl cnJvcl90eXBlKGUpOworICAgICAgICAgICAgOjpuZXcgKHN0ZDo6YWRkcmVzc29mKGJhc2U6OnMu ZXJyKSkgZXJyb3JfdHlwZShlKTsKICAgICAgICAgICAgIHN3YXAoYmFzZTo6aGFzLCBvLmhhcyk7 CiAgICAgICAgIH0gZWxzZSBpZiAoIWJhc2U6OmhhcyAmJiBvLmhhcykgewotICAgICAgICAgICAg OjpuZXcgKCZvLnMuZXJyKSBlcnJvcl90eXBlKHN0ZDo6bW92ZShiYXNlOjpzLmVycikpOworICAg ICAgICAgICAgOjpuZXcgKHN0ZDo6YWRkcmVzc29mKG8ucy5lcnIpKSBlcnJvcl90eXBlKHN0ZDo6 bW92ZShiYXNlOjpzLmVycikpOwogICAgICAgICAgICAgc3dhcChiYXNlOjpoYXMsIG8uaGFzKTsK ICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICBzd2FwKGJhc2U6OnMuZXJyLCBvLnMuZXJyKTsK SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Mjc3MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTAzLTExICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CisKKyAgICAgICAgV1RGOjpFeHBlY3RlZCBzaG91bGQgdXNlIHN0ZDo6YWRkcmVz c29mIGluc3RlYWQgb2Ygb3BlcmF0b3ImCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTU2MDQKKworICAgICAgICBSZXZpZXdlZCBieSBNeWxlcyBNYXhm aWVsZC4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0V4cGVjdGVkLmNwcDoK KyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlVuaXF1ZTo6VW5pcXVlKToKKyAgICAgICAgKFRlc3RX ZWJLaXRBUEk6OlVuaXF1ZTo6b3BlcmF0b3ImKToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRF U1QpOgorCiAyMDE5LTAzLTExICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgogCiAgICAgICAgIEFQSSB0ZXN0IFdlYktpdC5SZXF1ZXN0VGV4dElucHV0Q29udGV4dCBmYWls cyBvbiBpT1MKSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0V4cGVjdGVkLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9FeHBlY3RlZC5j cHAJKHJldmlzaW9uIDI0MjcxMCkKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0V4 cGVjdGVkLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDcyLDQgKzQ3MiwyMyBAQCBURVNUKFdURl9F eHBlY3RlZCwgUmVmKQogICAgIEFTU0VSVF9TVFJFUSgicmVmKGEpIGRlcmVmKGEpICIsIHRha2VM b2dTdHIoKS5jX3N0cigpKTsKIH0KIAorY2xhc3MgTmVlZHNTdGRBZGRyZXNzIHsKK3B1YmxpYzoK KyAgICBOZWVkc1N0ZEFkZHJlc3MoTmVlZHNTdGRBZGRyZXNzJiYgb3RoZXIpCisgICAgICAgIDog bV9wdHIoV1RGTW92ZShvdGhlci5tX3B0cikpIHsgfQorICAgIE5lZWRzU3RkQWRkcmVzcyhpbnQm IG90aGVyKQorICAgICAgICA6IG1fcHRyKCZvdGhlcikgeyB9CisgICAgaW50KiBvcGVyYXRvciYo KSB7IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOyByZXR1cm4gbnVsbHB0cjsgfQorcHJpdmF0ZToKKyAg ICBzdGQ6OnVuaXF1ZV9wdHI8aW50PiBtX3B0cjsKK307CisKK1RFU1QoV1RGX0V4cGVjdGVkLCBB ZGRyZXNzKQoreworICAgIE5lZWRzU3RkQWRkcmVzcyBhKCpuZXcgaW50KDMpKTsKKyAgICBFeHBl Y3RlZDxOZWVkc1N0ZEFkZHJlc3MsIGZsb2F0PiBiKFdURk1vdmUoYSkpOworICAgIEV4cGVjdGVk PE5lZWRzU3RkQWRkcmVzcywgZmxvYXQ+IGMoV1RGTW92ZShiKSk7CisgICAgKHZvaWQpYzsKK30K KwogfSAvLyBuYW1lc3BhY2UgVGVzdFdlYmtpdEFQSQo=