195600 2019-03-11 20:53:22 -0700 Remove OpenCube QuickMenu quirks from navigator.appVersion 2019-03-11 23:08:24 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa cdumez darin ggaren simon.fraser webkit-bug-importer wenson_hsieh zalan oldest_to_newest 1515244 0 rniwa 2019-03-11 20:53:22 -0700 https://trac.webkit.org/changeset/35050 added a site specific quirk for OpenCube QuickMenu, which was used by NWA.com at the time, and erroneously detected any browser which returns "4." in navigator.appVersion to be Netscape Navigator 4.x. It has been 11 years since then, and NWA.com simply redirects to delta.com now. 1515245 1 rniwa 2019-03-11 20:55:55 -0700 Blink "removed" this site specific quirks in https://chromium.googlesource.com/chromium/src/+/dfa9e59a223802c69955a01d4c5f8fd8277c7fb2 The patch added a new implementation of navigator.appVersion to NavigatorID and made Navigator supplemented by NavigatorID but without ever removing Navigator::appVersion, which had the site specific quirk. Arguably, this was unintentional behavioral change by Chris. The unused code in Navigator.cpp was subsequently removed in https://chromium.googlesource.com/chromium/src/+/70bb2b39ddf4d88ba048df2a67dd7de0780d7c28 1515249 2 rniwa 2019-03-11 21:05:22 -0700 The fact Blink/Chrome has been shopping a major browser engine for six years since the relevant code was removed is a good enough evidence that this workaround is no longer needed for Web compatibility. 1515260 3 364348 rniwa 2019-03-11 21:18:51 -0700 Created attachment 364348 Cleanup 1515309 4 rniwa 2019-03-11 23:07:16 -0700 Committed r242779: <https://trac.webkit.org/changeset/242779> 1515311 5 webkit-bug-importer 2019-03-11 23:08:24 -0700 <rdar://problem/48798868> 364348 2019-03-11 21:18:51 -0700 2019-03-11 22:26:16 -0700 Cleanup bug-195600-20190311211850.patch text/plain 2634 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0Mjc3MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAzLTExICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSBPcGVuQ3ViZSBRdWlj a01lbnUgcXVpcmtzIGZyb20gbmF2aWdhdG9yLmFwcFZlcnNpb24KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTYwMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB0aGUgc2l0ZSBzcGVjaWZpYyBx dWlyayBhZGRlZCBpbiByMzUwNTAgZm9yIE9wZW5DdWJlIFF1aWNrTWVudSBsaWJyYXJ5IGZvciBu d2EuY29tCisKKyAgICAgICAgQmxpbmsgcmVtb3ZlZCB0aGlzIGNvZGUgYmFjayBpbiAyMDEzLiBU aGUgZmFjdCBDaHJvbWUgaGFzIGJlZW4gc2hpcHBpbmcgc3VjY2Vzc2Z1bGx5IHdpdGhvdXQKKyAg ICAgICAgdGhpcyBxdWlyayBmb3Igc2l4IHllYXJzIGlzIGEgZ29vZCBldmlkZW5jZSB0aGF0IGl0 J3Mgbm8gbG9uZ2VyIG5lZWRlZCBmb3IgdGhlIFdlYiBjb21wYXRpYmlsaXR5LgorCisgICAgICAg ICogcGFnZS9OYXZpZ2F0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmF2aWdhdG9yOjphcHBW ZXJzaW9uIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OnNob3VsZEhpZGVGb3VyRG90KTogRGVs ZXRlZC4KKwogMjAxOS0wMy0xMSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAog ICAgICAgICBSRUdSRVNTSU9OKHIyMzYyODEpOiBZb3VUdWJlIE1vdmllcyBmYWlsIHdpdGggInZp ZGVvIGZvcm1hdCIgZXJyb3IKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdhdG9yLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL05hdmlnYXRvci5jcHAJKHJldmlz aW9uIDI0Mjc2NSkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdhdG9yLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNTYsMjAgKzU2LDYgQEAgTmF2aWdhdG9yOjpOYXZpZ2F0b3IoU2NyaXB0RXhl Y3V0aW9uQ29udAogCiBOYXZpZ2F0b3I6On5OYXZpZ2F0b3IoKSA9IGRlZmF1bHQ7CiAKLS8vIElm IHRoaXMgZnVuY3Rpb24gcmV0dXJucyB0cnVlLCB3ZSBuZWVkIHRvIGhpZGUgdGhlIHN1YnN0cmlu ZyAiNC4iIHRoYXQgd291bGQgb3RoZXJ3aXNlCi0vLyBhcHBlYXIgaW4gdGhlIGFwcFZlcnNpb24g c3RyaW5nLiBUaGlzIGlzIHRvIGF2b2lkIHByb2JsZW1zIHdpdGggb2xkIHZlcnNpb25zIG9mIGEK LS8vIGxpYnJhcnkgY2FsbGVkIE9wZW5DdWJlIFF1aWNrTWVudSwgd2hpY2ggYXMgb2YgdGhpcyB3 cml0aW5nIGlzIHN0aWxsIGJlaW5nIHVzZWQgb24KLS8vIHNpdGVzIHN1Y2ggYXMgbndhLmNvbSAt LSB0aGUgbGlicmFyeSB0aGlua3MgU2FmYXJpIGlzIE5ldHNjYXBlIDQgaWYgd2UgZG9uJ3QgZG8g dGhpcyEKLXN0YXRpYyBib29sIHNob3VsZEhpZGVGb3VyRG90KEZyYW1lJiBmcmFtZSkKLXsKLSAg ICBhdXRvKiBzb3VyY2VVUkwgPSBmcmFtZS5zY3JpcHQoKS5zb3VyY2VVUkwoKTsKLSAgICBpZiAo IXNvdXJjZVVSTCkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIGlmICghKHNvdXJjZVVSTC0+ ZW5kc1dpdGgoIi9kcW1fc2NyaXB0LmpzIikgfHwgc291cmNlVVJMLT5lbmRzV2l0aCgiL2RxbV9s b2FkZXIuanMiKSB8fCBzb3VyY2VVUkwtPmVuZHNXaXRoKCIvdGRxbV9sb2FkZXIuanMiKSkpCi0g ICAgICAgIHJldHVybiBmYWxzZTsKLSAgICByZXR1cm4gZnJhbWUuc2V0dGluZ3MoKS5uZWVkc1Np dGVTcGVjaWZpY1F1aXJrcygpOwotfQotCiBTdHJpbmcgTmF2aWdhdG9yOjphcHBWZXJzaW9uKCkg Y29uc3QKIHsKICAgICBhdXRvKiBmcmFtZSA9IHRoaXMtPmZyYW1lKCk7CkBAIC03NywxMCArNjMs NyBAQCBTdHJpbmcgTmF2aWdhdG9yOjphcHBWZXJzaW9uKCkgY29uc3QKICAgICAgICAgcmV0dXJu IFN0cmluZygpOwogICAgIGlmIChSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRGZWF0dXJl cygpLndlYkFQSVN0YXRpc3RpY3NFbmFibGVkKCkpCiAgICAgICAgIFJlc291cmNlTG9hZE9ic2Vy dmVyOjpzaGFyZWQoKS5sb2dOYXZpZ2F0b3JBUElBY2Nlc3NlZCgqZnJhbWUtPmRvY3VtZW50KCks IFJlc291cmNlTG9hZFN0YXRpc3RpY3M6Ok5hdmlnYXRvckFQSTo6QXBwVmVyc2lvbik7Ci0gICAg U3RyaW5nIGFwcFZlcnNpb24gPSBOYXZpZ2F0b3JCYXNlOjphcHBWZXJzaW9uKCk7Ci0gICAgaWYg KHNob3VsZEhpZGVGb3VyRG90KCpmcmFtZSkpCi0gICAgICAgIGFwcFZlcnNpb24ucmVwbGFjZSgi NC4iLCAiNF8iKTsKLSAgICByZXR1cm4gYXBwVmVyc2lvbjsKKyAgICByZXR1cm4gTmF2aWdhdG9y QmFzZTo6YXBwVmVyc2lvbigpOwogfQogCiBjb25zdCBTdHJpbmcmIE5hdmlnYXRvcjo6dXNlckFn ZW50KCkgY29uc3QK