195595 2019-03-11 18:39:14 -0700 blocksInPreOrder and blocksInPostOrder should reserve the right capacity for their result vector 2019-03-12 10:43:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Minor --- 1 rmorisset rmorisset commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1515172 0 rmorisset 2019-03-11 18:39:14 -0700 Since we know that the result vector will be exactly the size of m_blocks (it is just a permutation). We should also remove the inline capacity of that vector: even most small functions will have more than 5 BB. 1515174 1 364332 rmorisset 2019-03-11 18:46:06 -0700 Created attachment 364332 Patch 1515175 2 364332 saam 2019-03-11 18:50:29 -0700 Comment on attachment 364332 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364332&action=review > Source/JavaScriptCore/dfg/DFGBasicBlock.h:260 > +typedef Vector<BasicBlock*> BlockList; What’s the motivation here? 1515176 3 saam 2019-03-11 18:51:23 -0700 (In reply to Robin Morisset from comment #0) > We should also remove the inline capacity of that vector: even most small > functions will have more than 5 BB. Based on what data? This is actually a bit surprising to me 1515188 4 rmorisset 2019-03-11 19:07:32 -0700 (In reply to Saam Barati from comment #3) > (In reply to Robin Morisset from comment #0) > > We should also remove the inline capacity of that vector: even most small > > functions will have more than 5 BB. > > Based on what data? This is actually a bit surprising to me I had just observed that while debugging some small test cases. I just tested it on JetStream2. Out of 39158 calls to blocksIn{Pre/Post}Order, only 13676 had 5 or less BasicBlocks. So the current inline capacity is only used in 1/3 of cases, and it otherwise wastes space for no reason. Here are some more numbers in case we really want an inline capacity here for some reason: - 1 BB: 7806 - <= 4 BB: 12129 - <= 8 BB: 17974 - <= 16 BB: 25612 - <= 32 BB: 32558 - <= 34 BB: 37144 1515487 5 rmorisset 2019-03-12 10:14:39 -0700 > - <= 34 BB: 37144 This one should have been <= 64 BB of course. 1515501 6 364332 commit-queue 2019-03-12 10:42:49 -0700 Comment on attachment 364332 Patch Clearing flags on attachment: 364332 Committed r242802: <https://trac.webkit.org/changeset/242802> 1515502 7 commit-queue 2019-03-12 10:42:52 -0700 All reviewed patches have been landed. Closing bug. 1515504 8 webkit-bug-importer 2019-03-12 10:43:23 -0700 <rdar://problem/48813529> 364332 2019-03-11 18:46:06 -0700 2019-03-12 10:42:49 -0700 Patch patch195595 text/plain 2091 rmorisset SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQyNzYxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE5LTAzLTExICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CisKKyAg ICAgICAgYmxvY2tzSW5QcmVPcmRlciBhbmQgYmxvY2tzSW5Qb3N0T3JkZXIgc2hvdWxkIHJlc2Vy dmUgdGhlIHJpZ2h0IGNhcGFjaXR5IGZvciB0aGVpciByZXN1bHQgdmVjdG9yCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU1OTUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbHNvIGNoYW5nZSBCbG9ja0xp c3QgZnJvbSBiZWluZyBWZWN0b3I8QmFzaWNCbG9jayosIDU+IHRvIFZlY3RvcjxCYXNpY0Jsb2Nr Kj4KKworICAgICAgICAqIGRmZy9ERkdCYXNpY0Jsb2NrLmg6CisgICAgICAgICogZGZnL0RGR0dy YXBoLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpHcmFwaDo6YmxvY2tzSW5QcmVPcmRlcik6Cisg ICAgICAgIChKU0M6OkRGRzo6R3JhcGg6OmJsb2Nrc0luUG9zdE9yZGVyKToKKwogMjAxOS0wMy0x MSAgSnVzdGluIEZhbiAgPGp1c3Rpbl9mYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWIgR1BV XSBVcGRhdGUgR1BVU3dhcENoYWluRGVzY3JpcHRvciwgR1BVU3dhcENoYWluIGFuZCBpbXBsZW1l bnQgR1BVQ2FudmFzQ29udGV4dApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdC YXNpY0Jsb2NrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdC YXNpY0Jsb2NrLmgJKHJldmlzaW9uIDI0Mjc2MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHQmFzaWNCbG9jay5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNTcsNyArMjU3LDcgQEAKICAg ICBCbG9ja05vZGVMaXN0IG1fbm9kZXM7CiB9OwogCi10eXBlZGVmIFZlY3RvcjxCYXNpY0Jsb2Nr KiwgNT4gQmxvY2tMaXN0OwordHlwZWRlZiBWZWN0b3I8QmFzaWNCbG9jayo+IEJsb2NrTGlzdDsK ICAgICAKIHN0YXRpYyBpbmxpbmUgdW5zaWduZWQgZ2V0Qnl0ZWNvZGVCZWdpbkZvckJsb2NrKEJh c2ljQmxvY2sqKiBiYXNpY0Jsb2NrKQogewpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdHcmFwaC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdHcmFwaC5jcHAJKHJldmlzaW9uIDI0Mjc2MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHR3JhcGguY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04ODgsNiArODg4LDcgQEAKIEJsb2Nr TGlzdCBHcmFwaDo6YmxvY2tzSW5QcmVPcmRlcigpCiB7CiAgICAgQmxvY2tMaXN0IHJlc3VsdDsK KyAgICByZXN1bHQucmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShtX2Jsb2Nrcy5zaXplKCkpOwogICAg IEJsb2NrV29ya2xpc3Qgd29ya2xpc3Q7CiAgICAgZm9yIChCYXNpY0Jsb2NrKiBlbnRyeXBvaW50 IDogbV9yb290cykKICAgICAgICAgd29ya2xpc3QucHVzaChlbnRyeXBvaW50KTsKQEAgLTkyNiw2 ICs5MjcsNyBAQAogQmxvY2tMaXN0IEdyYXBoOjpibG9ja3NJblBvc3RPcmRlcihib29sIGlzU2Fm ZVRvVmFsaWRhdGUpCiB7CiAgICAgQmxvY2tMaXN0IHJlc3VsdDsKKyAgICByZXN1bHQucmVzZXJ2 ZUluaXRpYWxDYXBhY2l0eShtX2Jsb2Nrcy5zaXplKCkpOwogICAgIFBvc3RPcmRlckJsb2NrV29y a2xpc3Qgd29ya2xpc3Q7CiAgICAgZm9yIChCYXNpY0Jsb2NrKiBlbnRyeXBvaW50IDogbV9yb290 cykKICAgICAgICAgd29ya2xpc3QucHVzaChlbnRyeXBvaW50KTsK