19558 2008-06-15 09:37:22 -0700 [GTK] WebKitWebHistoryItem needs properties 2008-06-17 15:55:03 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED Gtk P2 Normal --- 1 christian christian oldest_to_newest 83379 0 christian 2008-06-15 09:37:22 -0700 The WebKitWebHistoryItem is technically a GObject but doesn't implement properties matching the accessors in the C interface. 83380 1 21714 christian 2008-06-15 10:04:39 -0700 Created attachment 21714 Implement properties 83657 2 21714 christian 2008-06-17 15:54:42 -0700 Comment on attachment 21714 Implement properties Committed in revision 34636. 21714 2008-06-15 10:04:39 -0700 2008-06-17 15:54:42 -0700 Implement properties historyitemproperties.diff text/plain 6570 christian ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmhpc3RvcnlpdGVtLmNwcCBi L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmhpc3RvcnlpdGVtLmNwcAppbmRleCA4NmQ2ZDU1 Li5mMTczNGQzIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJoaXN0b3J5 aXRlbS5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViaGlzdG9yeWl0ZW0uY3Bw CkBAIC00NCw4ICs0NCwyMSBAQCBzdHJ1Y3QgX1dlYktpdFdlYkhpc3RvcnlJdGVtUHJpdmF0ZSB7 CiAKICNkZWZpbmUgV0VCS0lUX1dFQl9ISVNUT1JZX0lURU1fR0VUX1BSSVZBVEUob2JqKSAgICAo R19UWVBFX0lOU1RBTkNFX0dFVF9QUklWQVRFKChvYmopLCBXRUJLSVRfVFlQRV9XRUJfSElTVE9S WV9JVEVNLCBXZWJLaXRXZWJIaXN0b3J5SXRlbVByaXZhdGUpKQogCitlbnVtIHsKKyAgICBQUk9Q XzAsCisKKyAgICBQUk9QX1RJVExFLAorICAgIFBST1BfQUxURVJOQVRFX1RJVExFLAorICAgIFBS T1BfVVJJLAorICAgIFBST1BfT1JJR0lOQUxfVVJJLAorICAgIFBST1BfTEFTVF9WSVNJVEVEX1RJ TUUKK307CisKIEdfREVGSU5FX1RZUEUoV2ViS2l0V2ViSGlzdG9yeUl0ZW0sIHdlYmtpdF93ZWJf aGlzdG9yeV9pdGVtLCBHX1RZUEVfT0JKRUNUKTsKIAorc3RhdGljIHZvaWQgd2Via2l0X3dlYl9o aXN0b3J5X2l0ZW1fc2V0X3Byb3BlcnR5KEdPYmplY3QqIG9iamVjdCwgZ3VpbnQgcHJvcF9pZCwg Y29uc3QgR1ZhbHVlKiB2YWx1ZSwgR1BhcmFtU3BlYyogcHNwZWMpOworCitzdGF0aWMgdm9pZCB3 ZWJraXRfd2ViX2hpc3RvcnlfaXRlbV9nZXRfcHJvcGVydHkoR09iamVjdCogb2JqZWN0LCBndWlu dCBwcm9wX2lkLCBHVmFsdWUqIHZhbHVlLCBHUGFyYW1TcGVjKiBwc3BlYyk7CiAKIHN0YXRpYyBH SGFzaFRhYmxlKiB3ZWJraXRfaGlzdG9yeV9pdGVtcygpCiB7CkBAIC0xMDYsNiArMTE5LDkwIEBA IHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfaGlzdG9yeV9pdGVtX2NsYXNzX2luaXQoV2ViS2l0V2Vi SGlzdG9yeUl0ZW1DbGFzcyoga2xhc3MpCiAKICAgICBnb2JqZWN0X2NsYXNzLT5kaXNwb3NlID0g d2Via2l0X3dlYl9oaXN0b3J5X2l0ZW1fZGlzcG9zZTsKICAgICBnb2JqZWN0X2NsYXNzLT5maW5h bGl6ZSA9IHdlYmtpdF93ZWJfaGlzdG9yeV9pdGVtX2ZpbmFsaXplOworICAgIGdvYmplY3RfY2xh c3MtPnNldF9wcm9wZXJ0eSA9IHdlYmtpdF93ZWJfaGlzdG9yeV9pdGVtX3NldF9wcm9wZXJ0eTsK KyAgICBnb2JqZWN0X2NsYXNzLT5nZXRfcHJvcGVydHkgPSB3ZWJraXRfd2ViX2hpc3RvcnlfaXRl bV9nZXRfcHJvcGVydHk7CisKKyAgICBHUGFyYW1GbGFncyBmbGFncyA9IChHUGFyYW1GbGFncyko V0VCS0lUX1BBUkFNX1JFQURXUklURSB8IEdfUEFSQU1fQ09OU1RSVUNUKTsKKworICAgIC8qKgor ICAgICogV2ViS2l0V2ViSGlzdG9yeUl0ZW06dGl0bGU6CisgICAgKgorICAgICogVGhlIHRpdGxl IG9mIHRoZSBoaXN0b3J5IGl0ZW0uCisgICAgKgorICAgICogU2luY2U6IDEuMC4yCisgICAgKi8K KyAgICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5KGdvYmplY3RfY2xhc3MsCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQUk9QX1RJVExFLAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgZ19wYXJhbV9zcGVjX3N0cmluZygKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICJ0aXRsZSIsCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAiVGl0bGUiLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIlRoZSB0aXRsZSBvZiB0aGUgaGlzdG9yeSBpdGVtIiwKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIE5VTEwsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBHX1BBUkFNX1JFQURBQkxFKSk7CisKKyAgICAvKioKKyAgICAqIFdlYktpdFdlYkhpc3RvcnlJ dGVtOmFsdGVybmF0ZS10aXRsZToKKyAgICAqCisgICAgKiBUaGUgYWx0ZXJuYXRlIHRpdGxlIG9m IHRoZSBoaXN0b3J5IGl0ZW0uCisgICAgKgorICAgICogU2luY2U6IDEuMC4yCisgICAgKi8KKyAg ICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5KGdvYmplY3RfY2xhc3MsCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQUk9QX0FMVEVSTkFURV9USVRMRSwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdfcGFyYW1fc3BlY19zdHJpbmcoCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiYWx0ZXJuYXRlLXRpdGxlIiwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJBbHRlcm5hdGUgVGl0bGUiLAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIlRoZSBhbHRlcm5hdGUgdGl0bGUgb2YgdGhl IGhpc3RvcnkgaXRlbSIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOVUxM LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmxhZ3MpKTsKKworICAgIC8q KgorICAgICogV2ViS2l0V2ViSGlzdG9yeUl0ZW06dXJpOgorICAgICoKKyAgICAqIFRoZSBVUkkg b2YgdGhlIGhpc3RvcnkgaXRlbS4KKyAgICAqCisgICAgKiBTaW5jZTogMS4wLjIKKyAgICAqLwor ICAgIGdfb2JqZWN0X2NsYXNzX2luc3RhbGxfcHJvcGVydHkoZ29iamVjdF9jbGFzcywKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBST1BfVVJJLAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZ19wYXJhbV9zcGVjX3N0cmluZygKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICJ1cmkiLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIlVSSSIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiVGhl IFVSSSBvZiB0aGUgaGlzdG9yeSBpdGVtIiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIE5VTEwsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHX1BBUkFN X1JFQURBQkxFKSk7CisKKyAgICAvKioKKyAgICAqIFdlYktpdFdlYkhpc3RvcnlJdGVtOm9yaWdp bmFsLXVyaToKKyAgICAqCisgICAgKiBUaGUgb3JpZ2luYWwgVVJJIG9mIHRoZSBoaXN0b3J5IGl0 ZW0uCisgICAgKgorICAgICogU2luY2U6IDEuMC4yCisgICAgKi8KKyAgICBnX29iamVjdF9jbGFz c19pbnN0YWxsX3Byb3BlcnR5KGdvYmplY3RfY2xhc3MsCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBQUk9QX09SSUdJTkFMX1VSSSwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGdfcGFyYW1fc3BlY19zdHJpbmcoCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAib3JpZ2luYWwtdXJpIiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICJPcmlnaW5hbCBVUkkiLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIlRoZSBvcmlnaW5hbCBVUkkgb2YgdGhlIGhpc3RvcnkgaXRlbSIsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBOVUxMLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgR19QQVJBTV9SRUFEQUJMRSkpOworCisgICAvKioKKyAgICAqIFdlYktpdFdl Ykhpc3RvcnlJdGVtOmxhc3QtdmlzaXRlZC10aW1lOgorICAgICoKKyAgICAqIFRoZSB0aW1lIGF0 IHdoaWNoIHRoZSBoaXN0b3J5IGl0ZW0gd2FzIGxhc3QgdmlzaXRlZC4KKyAgICAqCisgICAgKiBT aW5jZTogMS4wLjIKKyAgICAqLworICAgIGdfb2JqZWN0X2NsYXNzX2luc3RhbGxfcHJvcGVydHko Z29iamVjdF9jbGFzcywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBST1Bf TEFTVF9WSVNJVEVEX1RJTUUsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBn X3BhcmFtX3NwZWNfZG91YmxlKAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Imxhc3QtdmlzaXRlZC10aW1lIiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICJMYXN0IHZpc2l0ZWQgVGltZSIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAiVGhlIHRpbWUgYXQgd2hpY2ggdGhlIGhpc3RvcnkgaXRlbSB3YXMgbGFzdCB2aXNpdGVkIiwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDAsIEdfTUFYRE9VQkxFLCAwLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR19QQVJBTV9SRUFEQUJMRSkpOwog CiAgICAgZ190eXBlX2NsYXNzX2FkZF9wcml2YXRlKGdvYmplY3RfY2xhc3MsIHNpemVvZihXZWJL aXRXZWJIaXN0b3J5SXRlbVByaXZhdGUpKTsKIH0KQEAgLTExNSw2ICsyMTIsNDYgQEAgc3RhdGlj IHZvaWQgd2Via2l0X3dlYl9oaXN0b3J5X2l0ZW1faW5pdChXZWJLaXRXZWJIaXN0b3J5SXRlbSog d2ViSGlzdG9yeUl0ZW0pCiAgICAgd2ViSGlzdG9yeUl0ZW0tPnByaXYgPSBXRUJLSVRfV0VCX0hJ U1RPUllfSVRFTV9HRVRfUFJJVkFURSh3ZWJIaXN0b3J5SXRlbSk7CiB9CiAKK3N0YXRpYyB2b2lk IHdlYmtpdF93ZWJfaGlzdG9yeV9pdGVtX3NldF9wcm9wZXJ0eShHT2JqZWN0KiBvYmplY3QsIGd1 aW50IHByb3BfaWQsIGNvbnN0IEdWYWx1ZSogdmFsdWUsIEdQYXJhbVNwZWMqIHBzcGVjKQorewor ICAgIFdlYktpdFdlYkhpc3RvcnlJdGVtKiB3ZWJIaXN0b3J5SXRlbSA9IFdFQktJVF9XRUJfSElT VE9SWV9JVEVNKG9iamVjdCk7CisKKyAgICBzd2l0Y2gocHJvcF9pZCkgeworICAgIGNhc2UgUFJP UF9BTFRFUk5BVEVfVElUTEU6CisgICAgICAgIHdlYmtpdF93ZWJfaGlzdG9yeV9pdGVtX3NldF9h bHRlcm5hdGVfdGl0bGUod2ViSGlzdG9yeUl0ZW0sIGdfdmFsdWVfZ2V0X3N0cmluZyh2YWx1ZSkp OworICAgICAgICBicmVhazsKKyAgICBkZWZhdWx0OgorICAgICAgICBHX09CSkVDVF9XQVJOX0lO VkFMSURfUFJPUEVSVFlfSUQob2JqZWN0LCBwcm9wX2lkLCBwc3BlYyk7CisgICAgICAgIGJyZWFr OworICAgIH0KK30KKworc3RhdGljIHZvaWQgd2Via2l0X3dlYl9oaXN0b3J5X2l0ZW1fZ2V0X3By b3BlcnR5KEdPYmplY3QqIG9iamVjdCwgZ3VpbnQgcHJvcF9pZCwgR1ZhbHVlKiB2YWx1ZSwgR1Bh cmFtU3BlYyogcHNwZWMpCit7CisgICAgV2ViS2l0V2ViSGlzdG9yeUl0ZW0qIHdlYkhpc3RvcnlJ dGVtID0gV0VCS0lUX1dFQl9ISVNUT1JZX0lURU0ob2JqZWN0KTsKKworICAgIHN3aXRjaCAocHJv cF9pZCkgeworICAgIGNhc2UgUFJPUF9USVRMRToKKyAgICAgICAgZ192YWx1ZV9zZXRfc3RyaW5n KHZhbHVlLCB3ZWJraXRfd2ViX2hpc3RvcnlfaXRlbV9nZXRfdGl0bGUod2ViSGlzdG9yeUl0ZW0p KTsKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBQUk9QX0FMVEVSTkFURV9USVRMRToKKyAgICAg ICAgZ192YWx1ZV9zZXRfc3RyaW5nKHZhbHVlLCB3ZWJraXRfd2ViX2hpc3RvcnlfaXRlbV9nZXRf YWx0ZXJuYXRlX3RpdGxlKHdlYkhpc3RvcnlJdGVtKSk7CisgICAgICAgIGJyZWFrOworICAgIGNh c2UgUFJPUF9VUkk6CisgICAgICAgIGdfdmFsdWVfc2V0X3N0cmluZyh2YWx1ZSwgd2Via2l0X3dl Yl9oaXN0b3J5X2l0ZW1fZ2V0X3VyaSh3ZWJIaXN0b3J5SXRlbSkpOworICAgICAgICBicmVhazsK KyAgICBjYXNlIFBST1BfT1JJR0lOQUxfVVJJOgorICAgICAgICBnX3ZhbHVlX3NldF9zdHJpbmco dmFsdWUsIHdlYmtpdF93ZWJfaGlzdG9yeV9pdGVtX2dldF9vcmlnaW5hbF91cmkod2ViSGlzdG9y eUl0ZW0pKTsKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBQUk9QX0xBU1RfVklTSVRFRF9USU1F OgorICAgICAgICBnX3ZhbHVlX3NldF9kb3VibGUodmFsdWUsIHdlYmtpdF93ZWJfaGlzdG9yeV9p dGVtX2dldF9sYXN0X3Zpc2l0ZWRfdGltZSh3ZWJIaXN0b3J5SXRlbSkpOworICAgICAgICBicmVh azsKKyAgICBkZWZhdWx0OgorICAgICAgICBHX09CSkVDVF9XQVJOX0lOVkFMSURfUFJPUEVSVFlf SUQob2JqZWN0LCBwcm9wX2lkLCBwc3BlYyk7CisgICAgICAgIGJyZWFrOworICAgIH0KK30KKwog LyogSGVscGVyIGZ1bmN0aW9uIHRvIGNyZWF0ZSBhIG5ldyBXZWJIaXN0b3J5SXRlbSBpbnN0YW5j ZSB3aGVuIG5lZWRlZCAqLwogV2ViS2l0V2ViSGlzdG9yeUl0ZW0qIHdlYmtpdF93ZWJfaGlzdG9y eV9pdGVtX25ld193aXRoX2NvcmVfaXRlbShXZWJDb3JlOjpIaXN0b3J5SXRlbSogaXRlbSkKIHsK QEAgLTIzMCw2ICszNjcsNyBAQCB2b2lkIHdlYmtpdF93ZWJfaGlzdG9yeV9pdGVtX3NldF9hbHRl cm5hdGVfdGl0bGUoV2ViS2l0V2ViSGlzdG9yeUl0ZW0qIHdlYkhpc3RvcgogICAgIFdlYkNvcmU6 Okhpc3RvcnlJdGVtKiBpdGVtID0gY29yZSh3ZWJIaXN0b3J5SXRlbSk7CiAKICAgICBpdGVtLT5z ZXRBbHRlcm5hdGVUaXRsZShXZWJDb3JlOjpTdHJpbmc6OmZyb21VVEY4KHRpdGxlKSk7CisgICAg Z19vYmplY3Rfbm90aWZ5KEdfT0JKRUNUKHdlYkhpc3RvcnlJdGVtKSwgImFsdGVybmF0ZS10aXRs ZSIpOwogfQogCiAvKioK