195570 2019-03-11 13:36:23 -0700 Layout Test imported/w3c/web-platform-tests/IndexedDB/transaction-abort-request-error.html is failing 2019-03-12 12:29:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu achristensen alecflett beidson commit-queue ews-watchlist jsbell webkit-bug-importer oldest_to_newest 1514971 0 sihui_liu 2019-03-11 13:36:23 -0700 Request result should be undefined if it's never set. 1514972 1 364282 sihui_liu 2019-03-11 13:39:14 -0700 Created attachment 364282 Patch 1515065 2 364282 achristensen 2019-03-11 15:47:26 -0700 Comment on attachment 364282 Patch Could we instead have this in the header? Then we could remove all of these. Result m_result { NullResultType::Undefined }; 1515169 3 sihui_liu 2019-03-11 18:30:20 -0700 (In reply to Alex Christensen from comment #2) > Comment on attachment 364282 [details] > Patch > > Could we instead have this in the header? Then we could remove all of these. > > Result m_result { NullResultType::Undefined }; Tried this and it caused problem to forward declarations in IDBRequest.h, so I guess this doesn't work.. 1515546 4 364282 beidson 2019-03-12 11:33:56 -0700 Comment on attachment 364282 Patch Hah. 1515595 5 364282 commit-queue 2019-03-12 12:28:46 -0700 Comment on attachment 364282 Patch Clearing flags on attachment: 364282 Committed r242815: <https://trac.webkit.org/changeset/242815> 1515596 6 commit-queue 2019-03-12 12:28:47 -0700 All reviewed patches have been landed. Closing bug. 1515598 7 webkit-bug-importer 2019-03-12 12:29:21 -0700 <rdar://problem/48818543> 364282 2019-03-11 13:39:14 -0700 2019-03-12 12:28:46 -0700 Patch bug-195570-20190311133914.patch text/plain 4604 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyNzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2RlYmNlNTE1NjJmZjdi NmU0M2IyMmE1ZWQwMDZhZDc5ZDQ5MDA5ZC4uOGMxOGFiOWQwMGVhYmJiMGUxNjFjNzM0ZTVhMzJh MWZkZjFjZjMyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAzLTExICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIExheW91dCBUZXN0IGltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvSW5kZXhlZERCL3RyYW5zYWN0aW9uLWFib3J0LXJl cXVlc3QtZXJyb3IuaHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU1NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJREJSZXF1ZXN0IHJlc3VsdCBzaG91bGQgYmUgdW5kZWZpbmVk IGlmIGl0IGlzIG5ldmVyIHNldC4KKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRiL0lEQlJl cXVlc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCUmVxdWVzdDo6SURCUmVxdWVzdCk6CisK IDIwMTktMDMtMTEgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQuIE1hbnVhbGx5IHJvbGxpbmcgb3V0IHIyNDI3MDEgYW5kIHIyNDI3MDMg c2luY2UgdGhlIGNoYW5nZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5k ZXhlZGRiL0lEQlJlcXVlc3QuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIv SURCUmVxdWVzdC5jcHAKaW5kZXggY2VjN2M5YTRmODk4NjI4ZWZmMTY4YmM3ZmE1NGIwNzk5YzE4 YzAxMy4uZGY4NmQ4YmI3ZGJjNThjZGU2Zjg4NmQwODQ0ODc3MjE0MWNiNGJlNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCUmVxdWVzdC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCUmVxdWVzdC5jcHAKQEAgLTg1LDcg Kzg1LDcgQEAgSURCUmVxdWVzdDo6SURCUmVxdWVzdChTY3JpcHRFeGVjdXRpb25Db250ZXh0JiBj b250ZXh0LCBJREJDbGllbnQ6OklEQkNvbm5lY3Rpb24KICAgICAsIG1fcmVzb3VyY2VJZGVudGlm aWVyKGNvbm5lY3Rpb25Qcm94eSkKICAgICAsIG1fY29ubmVjdGlvblByb3h5KGNvbm5lY3Rpb25Q cm94eSkKIHsKLSAgICBtX3Jlc3VsdCA9IE51bGxSZXN1bHRUeXBlOjpFbXB0eTsKKyAgICBtX3Jl c3VsdCA9IE51bGxSZXN1bHRUeXBlOjpVbmRlZmluZWQ7CiAgICAgc3VzcGVuZElmTmVlZGVkKCk7 CiB9CiAKQEAgLTk2LDcgKzk2LDcgQEAgSURCUmVxdWVzdDo6SURCUmVxdWVzdChTY3JpcHRFeGVj dXRpb25Db250ZXh0JiBjb250ZXh0LCBJREJPYmplY3RTdG9yZSYgb2JqZWN0U3QKICAgICAsIG1f c291cmNlKCZvYmplY3RTdG9yZSkKICAgICAsIG1fY29ubmVjdGlvblByb3h5KHRyYW5zYWN0aW9u LmRhdGFiYXNlKCkuY29ubmVjdGlvblByb3h5KCkpCiB7Ci0gICAgbV9yZXN1bHQgPSBOdWxsUmVz dWx0VHlwZTo6RW1wdHk7CisgICAgbV9yZXN1bHQgPSBOdWxsUmVzdWx0VHlwZTo6VW5kZWZpbmVk OwogICAgIHN1c3BlbmRJZk5lZWRlZCgpOwogfQogCkBAIC0xMTMsNyArMTEzLDcgQEAgSURCUmVx dWVzdDo6SURCUmVxdWVzdChTY3JpcHRFeGVjdXRpb25Db250ZXh0JiBjb250ZXh0LCBJREJDdXJz b3ImIGN1cnNvciwgSURCVHIKICAgICAgICAgW3RoaXNdIChjb25zdCBhdXRvJiB2YWx1ZSkgeyB0 aGlzLT5tX3NvdXJjZSA9IElEQlJlcXVlc3Q6OlNvdXJjZSB7IHZhbHVlIH07IH0KICAgICApOwog Ci0gICAgbV9yZXN1bHQgPSBOdWxsUmVzdWx0VHlwZTo6RW1wdHk7CisgICAgbV9yZXN1bHQgPSBO dWxsUmVzdWx0VHlwZTo6VW5kZWZpbmVkOwogICAgIGN1cnNvci5zZXRSZXF1ZXN0KCp0aGlzKTsK IH0KIApAQCAtMTI0LDcgKzEyNCw3IEBAIElEQlJlcXVlc3Q6OklEQlJlcXVlc3QoU2NyaXB0RXhl Y3V0aW9uQ29udGV4dCYgY29udGV4dCwgSURCSW5kZXgmIGluZGV4LCBJREJUcmFuCiAgICAgLCBt X3NvdXJjZSgmaW5kZXgpCiAgICAgLCBtX2Nvbm5lY3Rpb25Qcm94eSh0cmFuc2FjdGlvbi5kYXRh YmFzZSgpLmNvbm5lY3Rpb25Qcm94eSgpKQogewotICAgIG1fcmVzdWx0ID0gTnVsbFJlc3VsdFR5 cGU6OkVtcHR5OworICAgIG1fcmVzdWx0ID0gTnVsbFJlc3VsdFR5cGU6OlVuZGVmaW5lZDsKICAg ICBzdXNwZW5kSWZOZWVkZWQoKTsKIH0KIApAQCAtMTM2LDE0ICsxMzYsMTQgQEAgSURCUmVxdWVz dDo6SURCUmVxdWVzdChTY3JpcHRFeGVjdXRpb25Db250ZXh0JiBjb250ZXh0LCBJREJPYmplY3RT dG9yZSYgb2JqZWN0U3QKICAgICAsIG1fcmVxdWVzdGVkT2JqZWN0U3RvcmVSZWNvcmRUeXBlKHR5 cGUpCiAgICAgLCBtX2Nvbm5lY3Rpb25Qcm94eSh0cmFuc2FjdGlvbi5kYXRhYmFzZSgpLmNvbm5l Y3Rpb25Qcm94eSgpKQogewotICAgIG1fcmVzdWx0ID0gTnVsbFJlc3VsdFR5cGU6OkVtcHR5Owor ICAgIG1fcmVzdWx0ID0gTnVsbFJlc3VsdFR5cGU6OlVuZGVmaW5lZDsKICAgICBzdXNwZW5kSWZO ZWVkZWQoKTsKIH0KIAogSURCUmVxdWVzdDo6SURCUmVxdWVzdChTY3JpcHRFeGVjdXRpb25Db250 ZXh0JiBjb250ZXh0LCBJREJJbmRleCYgaW5kZXgsIEluZGV4ZWREQjo6SW5kZXhSZWNvcmRUeXBl IHJlcXVlc3RlZFJlY29yZFR5cGUsIElEQlRyYW5zYWN0aW9uJiB0cmFuc2FjdGlvbikKICAgICA6 IElEQlJlcXVlc3QoY29udGV4dCwgaW5kZXgsIHRyYW5zYWN0aW9uKQogewotICAgIG1fcmVzdWx0 ID0gTnVsbFJlc3VsdFR5cGU6OkVtcHR5OworICAgIG1fcmVzdWx0ID0gTnVsbFJlc3VsdFR5cGU6 OlVuZGVmaW5lZDsKICAgICBtX3JlcXVlc3RlZEluZGV4UmVjb3JkVHlwZSA9IHJlcXVlc3RlZFJl Y29yZFR5cGU7CiB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IGI4NDU2NjIx MGI4YmIxNGM5YTg4ZmM2NjdkNzBkMzg5NDZjODUxYzQuLjBiM2I3ZThkMmEwMDlkY2I0NzhmMzAx NjUyMWM5MTczMTMyOWEzNDIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9D aGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTAzLTExICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgor CisgICAgICAgIExheW91dCBUZXN0IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvSW5k ZXhlZERCL3RyYW5zYWN0aW9uLWFib3J0LXJlcXVlc3QtZXJyb3IuaHRtbCBpcyBmYWlsaW5nCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU1NzAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGVkIHRl c3QgZXhwZWN0YXRpb24gdG8gUEFTUy4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9J bmRleGVkREIvdHJhbnNhY3Rpb24tYWJvcnQtcmVxdWVzdC1lcnJvci1leHBlY3RlZC50eHQ6CisK IDIwMTktMDMtMDcgIEZyZWRlcmljIFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgogCiAgICAgICAg IFVwZGF0ZSBXUFQgdGVzdHMgZm9yIGVtYmVkZGVkIGNvbnRlbnQKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvSW5kZXhlZERCL3RyYW5zYWN0 aW9uLWFib3J0LXJlcXVlc3QtZXJyb3ItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9JbmRleGVkREIvdHJhbnNhY3Rpb24tYWJvcnQtcmVx dWVzdC1lcnJvci1leHBlY3RlZC50eHQKaW5kZXggMWNlNjliNDViNGZhNmE4MzliZDViYTc5NzZl NGQwOGVmYzJmY2MzNS4uZWRiMzk5NTIxZWM2MjFhY2RiODU4M2Y1ZTA5OTkzNTdkMTk0MWI3OSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9J bmRleGVkREIvdHJhbnNhY3Rpb24tYWJvcnQtcmVxdWVzdC1lcnJvci1leHBlY3RlZC50eHQKKysr IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9JbmRleGVkREIv dHJhbnNhY3Rpb24tYWJvcnQtcmVxdWVzdC1lcnJvci1leHBlY3RlZC50eHQKQEAgLTEsMyArMSwz IEBACiAKLUZBSUwgUHJvcGVydGllcyBvZiBlcnJvciBldmVudHMgZmlyZWQgYXQgcmVxdWVzdHMg d2hlbiBhYm9ydGluZyBhIHRyYW5zYWN0aW9uIGFzc2VydF9lcXVhbHM6IFJlcXVlc3QncyByZXN1 bHQgc2hvdWxkIGJlIHVuZGVmaW5lZCBleHBlY3RlZCAodW5kZWZpbmVkKSB1bmRlZmluZWQgYnV0 IGdvdCAob2JqZWN0KSBudWxsCitQQVNTIFByb3BlcnRpZXMgb2YgZXJyb3IgZXZlbnRzIGZpcmVk IGF0IHJlcXVlc3RzIHdoZW4gYWJvcnRpbmcgYSB0cmFuc2FjdGlvbiAKIAo=