195550 2019-03-11 03:32:20 -0700 [CoordinatedGraphics] ASSERTION FAILED: !m_state.isSuspended 2019-03-24 19:31:25 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196190 InRadar P2 Normal --- 1 fujii fujii cgarcia webkit-bug-importer zan oldest_to_newest 1514731 0 fujii 2019-03-11 03:32:20 -0700 [CoordinatedGraphics] ASSERTION FAILED: !m_state.isSuspended I'm working on enabling Coordinated Graphics for WinCairo port (Bug 186364). Some compositing LayoutTests are failing due to the following assertion failures randomly. > python ./Tools/Scripts/run-webkit-tests --debug --wincairo --no-new-test-results compositing > ASSERTION FAILED: !m_state.isSuspended > ..\..\Source\WebKit\Shared\CoordinatedGraphics\threadedcompositor\CompositingRunLoop.cpp(225) : updateTimerFired > 1 00007FF94B331429 WTFCrash > 2 00007FF90EE90680 WTFCrashWithInfo > 3 00007FF90EF69EAC WebKit::CompositingRunLoop::updateTimerFired > 4 00007FF90EF6C6E2 WTF::RunLoop::Timer<WebKit::CompositingRunLoop>::fired > 5 00007FF94B45A610 WTF::RunLoop::TimerBase::timerFired > 6 00007FF94B45A495 WTF::RunLoop::wndProc > 7 00007FF94B45A389 WTF::RunLoop::RunLoopWndProc > 8 00007FF976F06D41 CallWindowProcW > 9 00007FF976F06713 DispatchMessageW > 10 00007FF94B45A693 WTF::RunLoop::run > 11 00007FF90EF6AC24 WebKit::createRunLoop::<unnamed-tag>::operator() > 12 00007FF90EF6ABC7 WTF::Function<void ()>::CallableWrapper<`lambda at ..\..\Source\WebKit\Shared\CoordinatedGraphics\threadedcompositor\CompositingRunLoop.cpp:46:53'>::call > 13 00007FF94B345040 WTF::Function<void ()>::operator() > 14 00007FF94B3994A3 WTF::Thread::entryPoint > 15 00007FF94B45BBB3 WTF::wtfThreadEntryPoint > 16 00007FF97527C4CE o_ceil > 17 00007FF977DD3DC4 BaseThreadInitThunk > 18 00007FF9780E3691 RtlUserThreadStart > #CRASHED - WebProcess (pid 18052) 1514732 1 364244 fujii 2019-03-11 03:42:38 -0700 Created attachment 364244 Patch 1514735 2 cgarcia 2019-03-11 03:58:56 -0700 Could you show the bt of the other threads too, please? 1514737 3 fujii 2019-03-11 04:36:40 -0700 Here is the callstack of main thread. > [External Code] > WTF.dll!WTF::ThreadCondition::timedWait(WTF::Mutex & mutex, WTF::WallTime absoluteTime) Line 414 C++ > WTF.dll!WTF::ParkingLot::parkConditionallyImpl(const void * address, const WTF::ScopedLambda<bool ()> & validation, const WTF::ScopedLambda<void ()> & beforeSleep, const WTF::TimeWithDynamicClockType & timeout) Line 603 C++ > WebKit2.dll!WTF::ParkingLot::parkConditionally<`lambda at DerivedSources\ForwardingHeaders\wtf/Condition.h:77:17',`lambda at DerivedSources\ForwardingHeaders\wtf/Condition.h:83:17'>(const void * address, const WTF::Condition::waitUntil<WTF::Lock>::<unnamed-tag> & validation, const WTF::Condition::waitUntil<WTF::Lock>::<unnamed-tag> & beforeSleep, const WTF::TimeWithDynamicClockType & timeout) Line 80 C++ > WebKit2.dll!WTF::Condition::waitUntil<WTF::Lock>(WTF::Lock & lock, const WTF::TimeWithDynamicClockType & timeout) Line 75 C++ > WebKit2.dll!WTF::Condition::wait<WTF::Lock>(WTF::Lock & lock) Line 121 C++ > WebKit2.dll!WebKit::CompositingRunLoop::performTaskSync(WTF::Function<void ()> && function) Line 95 C++ > WebKit2.dll!WebKit::ThreadedCompositor::suspend() Line 125 C++ > WebKit2.dll!WebKit::LayerTreeHost::pauseRendering() Line 254 C++ > WebKit2.dll!WebKit::DrawingAreaCoordinatedGraphics::exitAcceleratedCompositingMode() Line 594 C++ > WebKit2.dll!WTF::RunLoop::Timer<WebKit::DrawingAreaCoordinatedGraphics>::fired() Line 152 C++ > WTF.dll!WTF::RunLoop::TimerBase::timerFired() Line 141 C++ > WTF.dll!WTF::RunLoop::wndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 60 C++ > WTF.dll!WTF::RunLoop::RunLoopWndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 39 C++ > [External Code] > WTF.dll!WTF::RunLoop::run() Line 69 C++ > WebKit2.dll!WebKit::AuxiliaryProcessMain<WebKit::WebProcess,WebKit::WebProcessMain>(int argc, char * * argv) Line 67 C++ > WebKit2.dll!WebKit::WebProcessMainWin(int argc, char * * argv) Line 46 C++ > WebKitWebProcess.exe!main(int argc, char * * argv) Line 33 C++ > [External Code] ThreadedCompositor::suspend is calling the next function. 1515253 4 364244 fujii 2019-03-11 21:12:57 -0700 Comment on attachment 364244 Patch Clearing flags on attachment: 364244 Committed r242771: <https://trac.webkit.org/changeset/242771> 1515254 5 fujii 2019-03-11 21:13:00 -0700 All reviewed patches have been landed. Closing bug. 1515259 6 webkit-bug-importer 2019-03-11 21:17:53 -0700 <rdar://problem/48796633> 364244 2019-03-11 03:42:38 -0700 2019-03-11 21:12:57 -0700 Patch bug-195550-20190311194237.patch text/plain 1835 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyNjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVhYmY1ODY5YTY4MTJjMzYy ODIzZWJhMGM1MzZlMDMxMTM2NTA5MTEuLjY5ZjZkNDQyM2ZkM2M1OWFhOWQ3NmI2NTIyN2VhY2Uz ODY5ZjRkOTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDMtMTEgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW0Nvb3JkaW5hdGVk R3JhcGhpY3NdIEFTU0VSVElPTiBGQUlMRUQ6ICFtX3N0YXRlLmlzU3VzcGVuZGVkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU1NTAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb21wb3NpdGluZ1J1bkxv b3A6OnN1c3BlbmQoKSBsb2NrcyBhIG11dGV4IGFuZCBzdG9wcyB0aGUgdXBkYXRlCisgICAgICAg IHRpbWVyLiBCdXQsIHRoZSB0aW1lciBjYW4gYmUgZmlyZWQgYWZ0ZXIgdGhlIGxvY2sgd2FzIGFj cXVpcmVkIGFuZAorICAgICAgICBiZWZvcmUgdGhlIHRpbWVyIGlzIHN0b3BwZWQuCisKKyAgICAg ICAgKiBTaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy90aHJlYWRlZGNvbXBvc2l0b3IvQ29tcG9z aXRpbmdSdW5Mb29wLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29tcG9zaXRpbmdSdW5Mb29wOjp1 cGRhdGVUaW1lckZpcmVkKTogUmVtb3ZlZCB0aGUKKyAgICAgICAgYXNzZXJ0aW9uLiBSZXR1cm4g ZWFybHkgaWYgbV9zdGF0ZS5pc1N1c3BlbmRlZC4KKwogMjAxOS0wMy0xMCAgSmlld2VuIFRhbiAg PGppZXdlbl90YW5AYXBwbGUuY29tPgogCiAgICAgICAgIE9wdGltaXppbmcgbG9hZHMgd2hlbiBj cmVhdGluZyBuZXcgcGFnZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0Nvb3Jk aW5hdGVkR3JhcGhpY3MvdGhyZWFkZWRjb21wb3NpdG9yL0NvbXBvc2l0aW5nUnVuTG9vcC5jcHAg Yi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL3RocmVhZGVkY29tcG9z aXRvci9Db21wb3NpdGluZ1J1bkxvb3AuY3BwCmluZGV4IDg3YzZlZTg2MjdkZDZhMjg1NGQ4OTA3 ZGYwMmZkN2I5ZTM0YzJhZDQuLmM4MDg0YmRhZGIyYThlMjcwY2I5OGIyODNkNDY4ZDU2Y2M4MjVl MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv dGhyZWFkZWRjb21wb3NpdG9yL0NvbXBvc2l0aW5nUnVuTG9vcC5jcHAKKysrIGIvU291cmNlL1dl YktpdC9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy90aHJlYWRlZGNvbXBvc2l0b3IvQ29tcG9z aXRpbmdSdW5Mb29wLmNwcApAQCAtMjIyLDcgKzIyMiw4IEBAIHZvaWQgQ29tcG9zaXRpbmdSdW5M b29wOjp1cGRhdGVUaW1lckZpcmVkKCkKICAgICB7CiAgICAgICAgIC8vIEJvdGggY29tcG9zaXRp b24gYW5kIHNjZW5lIHVwZGF0ZSBhcmUgbm93IGluIHByb2dyZXNzLgogICAgICAgICBMb2NrSG9s ZGVyIGxvY2tlcihtX3N0YXRlLmxvY2spOwotICAgICAgICBBU1NFUlQoIW1fc3RhdGUuaXNTdXNw ZW5kZWQpOworICAgICAgICBpZiAobV9zdGF0ZS5pc1N1c3BlbmRlZCkKKyAgICAgICAgICAgIHJl dHVybjsKICAgICAgICAgbV9zdGF0ZS5jb21wb3NpdGlvbiA9IENvbXBvc2l0aW9uU3RhdGU6Oklu UHJvZ3Jlc3M7CiAgICAgICAgIG1fc3RhdGUudXBkYXRlID0gVXBkYXRlU3RhdGU6OkluUHJvZ3Jl c3M7CiAgICAgfQo=