195522 2019-03-09 11:36:58 -0800 Web Inspector: DOM Debugger: remove left padding when the last DOM breakpoint is removed 2019-03-12 12:04:22 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1514401 0 hi 2019-03-09 11:36:58 -0800 . 1514402 1 364136 hi 2019-03-09 11:37:41 -0800 Created attachment 364136 Patch 1515556 2 364136 mattbaker 2019-03-12 11:50:25 -0700 Comment on attachment 364136 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364136&action=review r=me > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:782 > + this.breakpointGutterEnabled = this._domTreeOutline.children.some((child) => child.hasBreakpoint); Nice! I think keeping the early return makes it read better, and with your changes it's cleaner still: if (!breakpoints.length) { treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.None; return; } if (breakpoints.some((item) => item.disabled)) treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.DisabledBreakpoint; else treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.Breakpoint; this.breakpointGutterEnabled = this._domTreeOutline.children.some((child) => child.hasBreakpoint); 1515557 3 364136 mattbaker 2019-03-12 11:50:59 -0700 Comment on attachment 364136 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364136&action=review >> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:782 >> + this.breakpointGutterEnabled = this._domTreeOutline.children.some((child) => child.hasBreakpoint); > > Nice! I think keeping the early return makes it read better, and with your changes it's cleaner still: > > if (!breakpoints.length) { > treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.None; > return; > } > > if (breakpoints.some((item) => item.disabled)) > treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.DisabledBreakpoint; > else > treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.Breakpoint; > > this.breakpointGutterEnabled = this._domTreeOutline.children.some((child) => child.hasBreakpoint); Oh right, the early return. ;) 1515560 4 364136 mattbaker 2019-03-12 11:52:33 -0700 Comment on attachment 364136 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364136&action=review >>> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:782 >>> + this.breakpointGutterEnabled = this._domTreeOutline.children.some((child) => child.hasBreakpoint); >> >> Nice! I think keeping the early return makes it read better, and with your changes it's cleaner still: >> >> if (!breakpoints.length) { >> treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.None; >> return; >> } >> >> if (breakpoints.some((item) => item.disabled)) >> treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.DisabledBreakpoint; >> else >> treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.Breakpoint; >> >> this.breakpointGutterEnabled = this._domTreeOutline.children.some((child) => child.hasBreakpoint); > > Oh right, the early return. ;) I guess `this.breakpointGutterEnabled = ...` could be moved above an early return, and it would still work, but I think it's fine as is. 1515573 5 364136 commit-queue 2019-03-12 12:03:07 -0700 Comment on attachment 364136 Patch Clearing flags on attachment: 364136 Committed r242811: <https://trac.webkit.org/changeset/242811> 1515574 6 commit-queue 2019-03-12 12:03:08 -0700 All reviewed patches have been landed. Closing bug. 1515576 7 webkit-bug-importer 2019-03-12 12:04:22 -0700 <rdar://problem/48817670> 364136 2019-03-09 11:37:41 -0800 2019-03-12 12:03:07 -0700 Patch bug-195522-20190309113740.patch text/plain 3090 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDljMDI5MTQ4NjRlMTlhYThiMTg2ZTJlZGZkNDE5 ZjlkMGY0ODE5MzIuLmQ4ZTA3OGI4MGM0MGJhYzdhYzE0NDg5MTE3MjEzNzRlY2I0ZGUzZmEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAzLTA5ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBE T00gRGVidWdnZXI6IHJlbW92ZSBsZWZ0IHBhZGRpbmcgd2hlbiB0aGUgbGFzdCBET00gYnJlYWtw b2ludCBpcyByZW1vdmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTU1MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUNvbnRlbnRWaWV3LmpzOgorICAg ICAgICAoV0kuRE9NVHJlZUNvbnRlbnRWaWV3LnByb3RvdHlwZS5fdXBkYXRlQnJlYWtwb2ludFN0 YXR1cyk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlRWxlbWVudC5qczoK KyAgICAgICAgKFdJLkRPTVRyZWVFbGVtZW50LnByb3RvdHlwZS5nZXQgaGFzQnJlYWtwb2ludCk6 IEFkZGVkLgorCiAyMDE5LTAzLTA3ICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUu Y29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFN0eWxlczogb3ZlcnJpZGRlbiBDU1MgcHJv cGVydHkgc2hvdWxkIGhhdmUgZ28tdG8gYnV0dG9uIHRvIGp1bXAgdG8gZWZmZWN0aXZlIHByb3Bl cnR5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9ET01UcmVlQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9ET01UcmVlQ29udGVudFZpZXcuanMKaW5kZXggYjgzOTA1MTRmY2RhZWRhYTUx ODBhNGZhMzJlMGRiOWI5Y2RkYjRiNS4uMWM0MTc4MzE3MmM5ZTFhZjU3YzE2ZWUxMTMyMmQ4ZGI1 ZTFiNTk0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvRE9NVHJlZUNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVDb250ZW50Vmlldy5qcwpAQCAtNzcxLDE1ICs3NzEs MTUgQEAgV0kuRE9NVHJlZUNvbnRlbnRWaWV3ID0gY2xhc3MgRE9NVHJlZUNvbnRlbnRWaWV3IGV4 dGVuZHMgV0kuQ29udGVudFZpZXcKICAgICAgICAgfQogCiAgICAgICAgIGxldCBicmVha3BvaW50 cyA9IFdJLmRvbURlYnVnZ2VyTWFuYWdlci5kb21CcmVha3BvaW50c0Zvck5vZGUoZG9tTm9kZSk7 Ci0gICAgICAgIGlmICghYnJlYWtwb2ludHMubGVuZ3RoKSB7CisgICAgICAgIGlmIChicmVha3Bv aW50cy5sZW5ndGgpIHsKKyAgICAgICAgICAgIGlmIChicmVha3BvaW50cy5zb21lKChpdGVtKSA9 PiBpdGVtLmRpc2FibGVkKSkKKyAgICAgICAgICAgICAgICB0cmVlRWxlbWVudC5icmVha3BvaW50 U3RhdHVzID0gV0kuRE9NVHJlZUVsZW1lbnQuQnJlYWtwb2ludFN0YXR1cy5EaXNhYmxlZEJyZWFr cG9pbnQ7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgdHJlZUVsZW1lbnQuYnJl YWtwb2ludFN0YXR1cyA9IFdJLkRPTVRyZWVFbGVtZW50LkJyZWFrcG9pbnRTdGF0dXMuQnJlYWtw b2ludDsKKyAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICB0cmVlRWxlbWVudC5icmVha3BvaW50 U3RhdHVzID0gV0kuRE9NVHJlZUVsZW1lbnQuQnJlYWtwb2ludFN0YXR1cy5Ob25lOwotICAgICAg ICAgICAgcmV0dXJuOwotICAgICAgICB9CiAKLSAgICAgICAgdGhpcy5icmVha3BvaW50R3V0dGVy RW5hYmxlZCA9IHRydWU7Ci0KLSAgICAgICAgbGV0IGRpc2FibGVkID0gYnJlYWtwb2ludHMuc29t ZSgoaXRlbSkgPT4gaXRlbS5kaXNhYmxlZCk7Ci0gICAgICAgIHRyZWVFbGVtZW50LmJyZWFrcG9p bnRTdGF0dXMgPSBkaXNhYmxlZCA/IFdJLkRPTVRyZWVFbGVtZW50LkJyZWFrcG9pbnRTdGF0dXMu RGlzYWJsZWRCcmVha3BvaW50IDogV0kuRE9NVHJlZUVsZW1lbnQuQnJlYWtwb2ludFN0YXR1cy5C cmVha3BvaW50OworICAgICAgICB0aGlzLmJyZWFrcG9pbnRHdXR0ZXJFbmFibGVkID0gdGhpcy5f ZG9tVHJlZU91dGxpbmUuY2hpbGRyZW4uc29tZSgoY2hpbGQpID0+IGNoaWxkLmhhc0JyZWFrcG9p bnQpOwogICAgIH0KIAogICAgIF9yZXN0b3JlQnJlYWtwb2ludHNBZnRlclVwZGF0ZSgpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVl RWxlbWVudC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RP TVRyZWVFbGVtZW50LmpzCmluZGV4IDM5NDdkYzljZDg3MmYyYjVkODU2MTZmZTdjMzZiZjRjZGMw YWVlNTcuLjY1OTg1MDIyNzBjYTBiZWIwZTdiZjQ4YWYzNzg4Njc1MWFlYmY4MzAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVt ZW50LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RP TVRyZWVFbGVtZW50LmpzCkBAIC03Miw2ICs3MiwxMSBAQCBXSS5ET01UcmVlRWxlbWVudCA9IGNs YXNzIERPTVRyZWVFbGVtZW50IGV4dGVuZHMgV0kuVHJlZUVsZW1lbnQKIAogICAgIC8vIFB1Ymxp YwogCisgICAgZ2V0IGhhc0JyZWFrcG9pbnQoKQorICAgIHsKKyAgICAgICAgcmV0dXJuIHRoaXMu X2JyZWFrcG9pbnRTdGF0dXMgIT09IFdJLkRPTVRyZWVFbGVtZW50LkJyZWFrcG9pbnRTdGF0dXMu Tm9uZSB8fCB0aGlzLl9zdWJ0cmVlQnJlYWtwb2ludENvdW50ID4gMDsKKyAgICB9CisKICAgICBn ZXQgYnJlYWtwb2ludFN0YXR1cygpCiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5fYnJlYWtw b2ludFN0YXR1czsK