195515 2019-03-08 23:45:34 -0800 REGRESSION(r242622): Web Inspector: Fix asserts "Overridden property is missing overridingProperty" 2019-03-11 13:05:14 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1514340 0 nvasilyev 2019-03-08 23:45:34 -0800 This has no user impact. An assert triggers on every overridden property when Show Jump to Effective Property Button is disabled. 1514341 1 webkit-bug-importer 2019-03-08 23:45:49 -0800 <rdar://problem/48737315> 1514342 2 364119 nvasilyev 2019-03-08 23:49:32 -0800 Created attachment 364119 Patch 1514939 3 364119 mattbaker 2019-03-11 12:46:09 -0700 Comment on attachment 364119 Patch rs=me. Maybe we should adopt a new pattern in the constructor of classes taking an optional delegate: constructor(delegate) { - this._delegate = delegate || null; + this._delegate = delegate || {}; } Then we could simplify tests throughout the class: - if (this._delegate && this._delegate.someMethod) { ... } + if (this._delegate.someMethod) { ... } 1514950 4 364119 commit-queue 2019-03-11 13:05:12 -0700 Comment on attachment 364119 Patch Clearing flags on attachment: 364119 Committed r242731: <https://trac.webkit.org/changeset/242731> 1514951 5 commit-queue 2019-03-11 13:05:14 -0700 All reviewed patches have been landed. Closing bug. 364119 2019-03-08 23:49:32 -0800 2019-03-11 13:05:12 -0700 Patch patch.txt text/plain 1943 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDljMDI5MTQ4NjRlLi4yYjgwNmY1MTIyMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDMtMDggIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjQyNjIyKTogV2ViIEluc3BlY3RvcjogRml4IGFzc2VydHMgIk92ZXJyaWRkZW4gcHJvcGVydHkg aXMgbWlzc2luZyBvdmVycmlkaW5nUHJvcGVydHkiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU1MTUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ4 NzM3MzE1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldFN0eWxlUHJvcGVydHkuanM6CisgICAg ICAgIChXSS5TcHJlYWRzaGVldFN0eWxlUHJvcGVydHkucHJvdG90eXBlLnVwZGF0ZVN0YXR1cyk6 CisKIDIwMTktMDMtMDcgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogU3R5bGVzOiBvdmVycmlkZGVuIENTUyBwcm9wZXJ0eSBz aG91bGQgaGF2ZSBnby10byBidXR0b24gdG8ganVtcCB0byBlZmZlY3RpdmUgcHJvcGVydHkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NwcmVh ZHNoZWV0U3R5bGVQcm9wZXJ0eS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1NwcmVhZHNoZWV0U3R5bGVQcm9wZXJ0eS5qcwppbmRleCBlYzQ2YzM1YmY1YS4u OTNkNGQxNmIyOTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1NwcmVhZHNoZWV0U3R5bGVQcm9wZXJ0eS5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldFN0eWxlUHJvcGVydHkuanMK QEAgLTI2Miw3ICsyNjIsNyBAQCBXSS5TcHJlYWRzaGVldFN0eWxlUHJvcGVydHkgPSBjbGFzcyBT cHJlYWRzaGVldFN0eWxlUHJvcGVydHkgZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgbGV0IGVs ZW1lbnRUaXRsZSA9ICIiOwogCiAgICAgICAgIGlmICh0aGlzLl9wcm9wZXJ0eS5vdmVycmlkZGVu KSB7Ci0gICAgICAgICAgICBpZiAoIXRoaXMuX2p1bXBUb0VmZmVjdGl2ZVByb3BlcnR5QnV0dG9u ICYmIHRoaXMuX2RlbGVnYXRlICYmIHRoaXMuX2RlbGVnYXRlLnNwcmVhZHNoZWV0U3R5bGVQcm9w ZXJ0eVNlbGVjdEJ5UHJvcGVydHkpIHsKKyAgICAgICAgICAgIGlmICghdGhpcy5fanVtcFRvRWZm ZWN0aXZlUHJvcGVydHlCdXR0b24gJiYgdGhpcy5fZGVsZWdhdGUgJiYgdGhpcy5fZGVsZWdhdGUu c3ByZWFkc2hlZXRTdHlsZVByb3BlcnR5U2VsZWN0QnlQcm9wZXJ0eSAmJiBXSS5zZXR0aW5ncy5l eHBlcmltZW50YWxFbmFibGVTdHlsZXNKdW1wVG9FZmZlY3RpdmUudmFsdWUpIHsKICAgICAgICAg ICAgICAgICBjb25zb2xlLmFzc2VydCh0aGlzLl9wcm9wZXJ0eS5vdmVycmlkaW5nUHJvcGVydHks IGBPdmVycmlkZGVuIHByb3BlcnR5IGlzIG1pc3Npbmcgb3ZlcnJpZGluZ1Byb3BlcnR5OiAke3Ro aXMuX3Byb3BlcnR5LmZvcm1hdHRlZFRleHR9YCk7CiAgICAgICAgICAgICAgICAgaWYgKHRoaXMu X3Byb3BlcnR5Lm92ZXJyaWRpbmdQcm9wZXJ0eSkgewogICAgICAgICAgICAgICAgICAgICB0aGlz Ll9qdW1wVG9FZmZlY3RpdmVQcm9wZXJ0eUJ1dHRvbiA9IFdJLmNyZWF0ZUdvVG9BcnJvd0J1dHRv bigpOwo=