195488 2019-03-08 15:23:13 -0800 Add assertions to help debug crash under DOMWindowExtension::suspendForPageCache() 2019-03-09 19:27:19 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez beidson commit-queue ggaren rniwa webkit-bug-importer oldest_to_newest 1514227 0 cdumez 2019-03-08 15:23:13 -0800 Add assertions to help debug crash under DOMWindowExtension::suspendForPageCache(). <rdar://problem/48612011> 1514231 1 364084 cdumez 2019-03-08 15:24:46 -0800 Created attachment 364084 Patch 1514450 2 364084 rniwa 2019-03-09 18:21:46 -0800 Comment on attachment 364084 Patch Looks like this is going to conflict with your other patch?? 1514457 3 364152 cdumez 2019-03-09 18:29:46 -0800 Created attachment 364152 Patch 1514474 4 364152 commit-queue 2019-03-09 19:26:15 -0800 Comment on attachment 364152 Patch Clearing flags on attachment: 364152 Committed r242677: <https://trac.webkit.org/changeset/242677> 1514475 5 commit-queue 2019-03-09 19:26:17 -0800 All reviewed patches have been landed. Closing bug. 1514476 6 webkit-bug-importer 2019-03-09 19:27:19 -0800 <rdar://problem/48746143> 364084 2019-03-08 15:24:46 -0800 2019-03-09 18:29:45 -0800 Patch bug-195488-20190308152445.patch text/plain 4183 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyNjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmY5N2VjOGJjZDYxMmY2 N2ZmZGUyYjFjNDU1ZmU4YmQxZTVjOTRiZi4uZWQ4YmYwZmM4YmVjYTkwZmI0ZTlkNjhkNjY3OWJl YTYxOTUzYTg5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAzLTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGFzc2VydGlvbnMgdG8g aGVscCBkZWJ1ZyBjcmFzaCB1bmRlciBET01XaW5kb3dFeHRlbnNpb246OnN1c3BlbmRGb3JQYWdl Q2FjaGUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTk1NDg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VHJ5IGFuZCBmaWd1cmUgb3V0IGhvdyB0aGUgZG9jdW1lbnQgY2FuIGJlIGRldGFjaGVkIGZyb20g aXRzIGZyYW1lIHdoaWxlIHdlJ3JlIHN1c3BlbmRpbmcKKyAgICAgICAgRE9NV2luZG93RXh0ZW5z aW9ucy4KKworICAgICAgICAqIHBhZ2UvRE9NV2luZG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkRPTVdpbmRvdzo6d2lsbERldGFjaERvY3VtZW50RnJvbUZyYW1lKToKKyAgICAgICAgKFdlYkNv cmU6OkRPTVdpbmRvdzo6c3VzcGVuZEZvclBhZ2VDYWNoZSk6CisgICAgICAgICogcGFnZS9ET01X aW5kb3cuaDoKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRvd0V4dGVuc2lvbi5oOgorCiAyMDE5LTAz LTA4ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0NvbnRlbnRD aGFuZ2VPYnNlcnZlcl0gQWRkIFN0YXJ0ZWRET01UaW1lckV4ZWN1dGlvbiBhbmQgU3RhcnRlZFN0 eWxlUmVjYWxjCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAKaW5kZXggZGZhMTEyNDg0YTNhNDc3 ZTNkYzAyMmEzNGNhMzRkZjNmZmE5M2UzMi4uOTg2NWFkYTgzMzMzMmE5ZGQ4OGZhMzc0MzQ2NjFi MWM5Yjc1ZjVmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcApAQCAtMTE5LDYgKzExOSw3 IEBACiAjaW5jbHVkZSA8d3RmL01hdGhFeHRyYXMuaD4KICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0 cm95ZWQuaD4KICNpbmNsdWRlIDx3dGYvUmVmLmg+CisjaW5jbHVkZSA8d3RmL1NldEZvclNjb3Bl Lmg+CiAjaW5jbHVkZSA8d3RmL1ZhcmlhbnQuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJp bmcuaD4KIApAQCAtNDczLDYgKzQ3NCw4IEBAIHZvaWQgRE9NV2luZG93Ojp3aWxsRGV0YWNoRG9j dW1lbnRGcm9tRnJhbWUoKQogICAgIGlmICghZnJhbWUoKSkKICAgICAgICAgcmV0dXJuOwogCisg ICAgUkVMRUFTRV9BU1NFUlQoIW1faXNTdXNwZW5kaW5nRE9NV2luZG93UHJvcGVydGllcyk7CisK ICAgICAvLyBJdCBpcyBuZWNlc3NhcnkgdG8gY29weSBtX3Byb3BlcnRpZXMgdG8gYSBzZXBhcmF0 ZSB2ZWN0b3IgYmVjYXVzZSB0aGUgRE9NV2luZG93UHJvcGVydGllcyBtYXkKICAgICAvLyB1bnJl Z2lzdGVyIHRoZW1zZWx2ZXMgZnJvbSB0aGUgRE9NV2luZG93IGFzIGEgcmVzdWx0IG9mIHRoZSBj YWxsIHRvIHdpbGxEZXRhY2hHbG9iYWxPYmplY3RGcm9tRnJhbWUuCiAgICAgZm9yIChhdXRvJiBw cm9wZXJ0eSA6IGNvcHlUb1ZlY3RvcihtX3Byb3BlcnRpZXMpKSB7CkBAIC01MjIsMTAgKzUyNSwx MyBAQCB2b2lkIERPTVdpbmRvdzo6cmVzZXRVbmxlc3NTdXNwZW5kZWRGb3JEb2N1bWVudFN1c3Bl bnNpb24oKQogCiB2b2lkIERPTVdpbmRvdzo6c3VzcGVuZEZvclBhZ2VDYWNoZSgpCiB7CisgICAg U2V0Rm9yU2NvcGU8Ym9vbD4gaXNTdXNwZW5kaW5nUHJvcGVydGllc1Njb3BlKG1faXNTdXNwZW5k aW5nRE9NV2luZG93UHJvcGVydGllcywgdHJ1ZSk7CisgICAgUkVMRUFTRV9BU1NFUlQoZnJhbWUo KSk7CiAgICAgZm9yIChhdXRvKiBwcm9wZXJ0eSA6IGNvcHlUb1ZlY3RvcihtX3Byb3BlcnRpZXMp KSB7CiAgICAgICAgIGlmIChtX3Byb3BlcnRpZXMuY29udGFpbnMocHJvcGVydHkpKQogICAgICAg ICAgICAgcHJvcGVydHktPnN1c3BlbmRGb3JQYWdlQ2FjaGUoKTsKICAgICB9CisgICAgUkVMRUFT RV9BU1NFUlQoZnJhbWUoKSk7CiAKICAgICBtX3N1c3BlbmRlZEZvckRvY3VtZW50U3VzcGVuc2lv biA9IHRydWU7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5o IGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaAppbmRleCBiYmJmYTk1ODcyZTRhMzNl NzM0MjUyODFlNGFjY2I0ZjcwNTliMWM0Li4yMDM3NTIyNTA1MGM5NTNhNjRkZjY5ZjJiOGUxYmFl MmVkOTgyNDc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmgKQEAgLTM2Niw2ICszNjYsNyBAQCBw cml2YXRlOgogCiAgICAgYm9vbCBtX3Nob3VsZFByaW50V2hlbkZpbmlzaGVkTG9hZGluZyB7IGZh bHNlIH07CiAgICAgYm9vbCBtX3N1c3BlbmRlZEZvckRvY3VtZW50U3VzcGVuc2lvbiB7IGZhbHNl IH07CisgICAgYm9vbCBtX2lzU3VzcGVuZGluZ0RPTVdpbmRvd1Byb3BlcnRpZXMgeyBmYWxzZSB9 OwogICAgIE9wdGlvbmFsPGJvb2w+IG1fY2FuU2hvd01vZGFsRGlhbG9nT3ZlcnJpZGU7CiAKICAg ICBIYXNoU2V0PERPTVdpbmRvd1Byb3BlcnR5Kj4gbV9wcm9wZXJ0aWVzOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3dFeHRlbnNpb24uaCBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRE9NV2luZG93RXh0ZW5zaW9uLmgKaW5kZXggMGY2MWYxZWYyZmNjNWVlOWI1NThiMWRm ZmI0MWU3ZmVhYjM5NjliOS4uNTQ1OWE2YzZkZGFkYTY2ODRjMmI1ZjM4NmJjZmRiNmZiMjg3YzU5 NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3dFeHRlbnNpb24uaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvd0V4dGVuc2lvbi5oCkBAIC0zNSwxOCAr MzUsMTggQEAgY2xhc3MgRE9NV2luZG93RXh0ZW5zaW9uOwogY2xhc3MgRE9NV3JhcHBlcldvcmxk OwogY2xhc3MgRnJhbWU7CiAKLWNsYXNzIERPTVdpbmRvd0V4dGVuc2lvbiA6IHB1YmxpYyBSZWZD b3VudGVkPERPTVdpbmRvd0V4dGVuc2lvbj4sIHB1YmxpYyBET01XaW5kb3dQcm9wZXJ0eSB7Citj bGFzcyBET01XaW5kb3dFeHRlbnNpb24gZmluYWwgOiBwdWJsaWMgUmVmQ291bnRlZDxET01XaW5k b3dFeHRlbnNpb24+LCBwdWJsaWMgRE9NV2luZG93UHJvcGVydHkgewogcHVibGljOgogICAgIHN0 YXRpYyBSZWY8RE9NV2luZG93RXh0ZW5zaW9uPiBjcmVhdGUoRE9NV2luZG93KiB3aW5kb3csIERP TVdyYXBwZXJXb3JsZCYgd29ybGQpCiAgICAgewogICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5l dyBET01XaW5kb3dFeHRlbnNpb24od2luZG93LCB3b3JsZCkpOwogICAgIH0KIAotICAgIHZvaWQg c3VzcGVuZEZvclBhZ2VDYWNoZSgpIG92ZXJyaWRlOwotICAgIHZvaWQgcmVzdW1lRnJvbVBhZ2VD YWNoZSgpIG92ZXJyaWRlOwotICAgIHZvaWQgd2lsbERlc3Ryb3lHbG9iYWxPYmplY3RJbkNhY2hl ZEZyYW1lKCkgb3ZlcnJpZGU7Ci0gICAgdm9pZCB3aWxsRGVzdHJveUdsb2JhbE9iamVjdEluRnJh bWUoKSBvdmVycmlkZTsKLSAgICB2b2lkIHdpbGxEZXRhY2hHbG9iYWxPYmplY3RGcm9tRnJhbWUo KSBvdmVycmlkZTsKKyAgICB2b2lkIHN1c3BlbmRGb3JQYWdlQ2FjaGUoKSBmaW5hbDsKKyAgICB2 b2lkIHJlc3VtZUZyb21QYWdlQ2FjaGUoKSBmaW5hbDsKKyAgICB2b2lkIHdpbGxEZXN0cm95R2xv YmFsT2JqZWN0SW5DYWNoZWRGcmFtZSgpIGZpbmFsOworICAgIHZvaWQgd2lsbERlc3Ryb3lHbG9i YWxPYmplY3RJbkZyYW1lKCkgZmluYWw7CisgICAgdm9pZCB3aWxsRGV0YWNoR2xvYmFsT2JqZWN0 RnJvbUZyYW1lKCkgZmluYWw7CiAKICAgICBET01XcmFwcGVyV29ybGQmIHdvcmxkKCkgY29uc3Qg eyByZXR1cm4gbV93b3JsZDsgfQogCg== 364152 2019-03-09 18:29:46 -0800 2019-03-09 19:26:15 -0800 Patch bug-195488-20190309182944.patch text/plain 2762 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyNjc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTA3Zjk2ZWJhMGJlYjY3 MzYzNzEyODMwNDdlNDljYjVkOTE2MWI3MS4uNzYyNzQzOGM4N2NkNGVhODlkODI3Y2NjYzViNDNl NjkwMmViOTZhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAzLTA5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGFzc2VydGlvbnMgdG8g aGVscCBkZWJ1ZyBjcmFzaCB1bmRlciBET01XaW5kb3dFeHRlbnNpb246OnN1c3BlbmRGb3JQYWdl Q2FjaGUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTk1NDg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgorCisgICAgICAgIFRy eSBhbmQgZmlndXJlIG91dCBob3cgdGhlIGRvY3VtZW50IGNhbiBiZSBkZXRhY2hlZCBmcm9tIGl0 cyBmcmFtZSB3aGlsZSB3ZSdyZSBzdXNwZW5kaW5nCisgICAgICAgIERPTVdpbmRvd0V4dGVuc2lv bnMuCisKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpE T01XaW5kb3c6OndpbGxEZXRhY2hEb2N1bWVudEZyb21GcmFtZSk6CisgICAgICAgIChXZWJDb3Jl OjpET01XaW5kb3c6OnN1c3BlbmRGb3JQYWdlQ2FjaGUpOgorICAgICAgICAqIHBhZ2UvRE9NV2lu ZG93Lmg6CisKIDIwMTktMDMtMDkgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAog ICAgICAgICBTaW1wbGlmeSBET01XaW5kb3dQcm9wZXJ0eSBjb2RlIC8gaGFuZGxpbmcKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRE9NV2luZG93LmNwcAppbmRleCBlZDQ3YzJmZmNhZmIyNDZkOGZkZGNjNTBlNWMwNjM1 ZTVhZDk0M2NmLi5lZmEwZTVlYzIzNzExZGE0MDY0NDc1NTZlZjQwOGQ1NzRlNDg3M2JmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCkBAIC0xMTksNiArMTE5LDcgQEAKICNpbmNsdWRlIDx3 dGYvTWF0aEV4dHJhcy5oPgogI2luY2x1ZGUgPHd0Zi9OZXZlckRlc3Ryb3llZC5oPgogI2luY2x1 ZGUgPHd0Zi9SZWYuaD4KKyNpbmNsdWRlIDx3dGYvU2V0Rm9yU2NvcGUuaD4KICNpbmNsdWRlIDx3 dGYvVmFyaWFudC5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCkBAIC00NzMs NiArNDc0LDggQEAgdm9pZCBET01XaW5kb3c6OndpbGxEZXRhY2hEb2N1bWVudEZyb21GcmFtZSgp CiAgICAgaWYgKCFmcmFtZSgpKQogICAgICAgICByZXR1cm47CiAKKyAgICBSRUxFQVNFX0FTU0VS VCghbV9pc1N1c3BlbmRpbmdPYnNlcnZlcnMpOworCiAgICAgLy8gSXQgaXMgbmVjZXNzYXJ5IHRv IGNvcHkgbV9vYnNlcnZlcnMgdG8gYSBzZXBhcmF0ZSB2ZWN0b3IgYmVjYXVzZSB0aGUgT2JzZXJ2 ZXIgbWF5CiAgICAgLy8gdW5yZWdpc3RlciB0aGVtc2VsdmVzIGZyb20gdGhlIERPTVdpbmRvdyBh cyBhIHJlc3VsdCBvZiB0aGUgY2FsbCB0byB3aWxsRGV0YWNoR2xvYmFsT2JqZWN0RnJvbUZyYW1l LgogICAgIGZvciAoYXV0byYgb2JzZXJ2ZXIgOiBjb3B5VG9WZWN0b3IobV9vYnNlcnZlcnMpKSB7 CkBAIC01MjEsMTAgKzUyNCwxNCBAQCB2b2lkIERPTVdpbmRvdzo6cmVzZXRVbmxlc3NTdXNwZW5k ZWRGb3JEb2N1bWVudFN1c3BlbnNpb24oKQogCiB2b2lkIERPTVdpbmRvdzo6c3VzcGVuZEZvclBh Z2VDYWNoZSgpCiB7CisgICAgU2V0Rm9yU2NvcGU8Ym9vbD4gaXNTdXNwZW5kaW5nT2JzZXJ2ZXJz KG1faXNTdXNwZW5kaW5nT2JzZXJ2ZXJzLCB0cnVlKTsKKyAgICBSRUxFQVNFX0FTU0VSVChmcmFt ZSgpKTsKKwogICAgIGZvciAoYXV0byogb2JzZXJ2ZXIgOiBjb3B5VG9WZWN0b3IobV9vYnNlcnZl cnMpKSB7CiAgICAgICAgIGlmIChtX29ic2VydmVycy5jb250YWlucyhvYnNlcnZlcikpCiAgICAg ICAgICAgICBvYnNlcnZlci0+c3VzcGVuZEZvclBhZ2VDYWNoZSgpOwogICAgIH0KKyAgICBSRUxF QVNFX0FTU0VSVChmcmFtZSgpKTsKIAogICAgIG1fc3VzcGVuZGVkRm9yRG9jdW1lbnRTdXNwZW5z aW9uID0gdHJ1ZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93 LmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5oCmluZGV4IDVlNzg4YzQxMmFkZTZm NDYyYWVmM2JiM2VkMTQ2MDM0NzI0YTcyNjEuLmU3ZjQ3NmU4OTBhMTAzZWYzY2U3ZmEwZGRjNmY4 NmM4ZTg3MjExYTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaApAQCAtMzkzLDYgKzM5Myw3IEBA IHByaXZhdGU6CiAKICAgICBib29sIG1fc2hvdWxkUHJpbnRXaGVuRmluaXNoZWRMb2FkaW5nIHsg ZmFsc2UgfTsKICAgICBib29sIG1fc3VzcGVuZGVkRm9yRG9jdW1lbnRTdXNwZW5zaW9uIHsgZmFs c2UgfTsKKyAgICBib29sIG1faXNTdXNwZW5kaW5nT2JzZXJ2ZXJzIHsgZmFsc2UgfTsKICAgICBP cHRpb25hbDxib29sPiBtX2NhblNob3dNb2RhbERpYWxvZ092ZXJyaWRlOwogCiAgICAgSGFzaFNl dDxPYnNlcnZlcio+IG1fb2JzZXJ2ZXJzOwo=