195480 2019-03-08 14:17:24 -0800 GetByIdStatus can be shrunk by 16 bytes 2019-03-08 15:31:29 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Trivial --- 1 rmorisset rmorisset commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1514176 0 rmorisset 2019-03-08 14:17:24 -0800 8 bytes from reordering fields 8 more bytes by making the enum State only use 1 byte. 1514177 1 364064 rmorisset 2019-03-08 14:19:51 -0800 Created attachment 364064 Patch 1514229 2 364064 commit-queue 2019-03-08 15:24:31 -0800 Comment on attachment 364064 Patch Clearing flags on attachment: 364064 Committed r242659: <https://trac.webkit.org/changeset/242659> 1514230 3 commit-queue 2019-03-08 15:24:32 -0800 All reviewed patches have been landed. Closing bug. 1514232 4 webkit-bug-importer 2019-03-08 15:31:29 -0800 <rdar://problem/48728439> 364064 2019-03-08 14:19:51 -0800 2019-03-08 15:24:31 -0800 Patch bug-195480-20190308141951.patch text/plain 2514 rmorisset SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQyNjU2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE5LTAzLTA4ICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CisKKyAg ICAgICAgR2V0QnlJZFN0YXR1cyBjYW4gYmUgc2hydW5rIGJ5IDE2IGJ5dGVzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU0ODAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA4IGJ5dGVzIGZyb20gcmVvcmRl cmluZyBmaWVsZHMKKyAgICAgICAgOCBtb3JlIGJ5dGVzIGJ5IG1ha2luZyB0aGUgZW51bSBTdGF0 ZSBvbmx5IHVzZSAxIGJ5dGUuCisKKyAgICAgICAgKiBieXRlY29kZS9HZXRCeUlkU3RhdHVzLmNw cDoKKyAgICAgICAgKEpTQzo6R2V0QnlJZFN0YXR1czo6R2V0QnlJZFN0YXR1cyk6CisgICAgICAg ICogYnl0ZWNvZGUvR2V0QnlJZFN0YXR1cy5oOgorCiAyMDE5LTAzLTA4ICBZdXN1a2UgU3V6dWtp ICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZm9sbG93LXVwIGFm dGVyIHIyNDI1NjgKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9HZXRCeUlk U3RhdHVzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUv R2V0QnlJZFN0YXR1cy5jcHAJKHJldmlzaW9uIDI0MjY0NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ieXRlY29kZS9HZXRCeUlkU3RhdHVzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQyLDEx ICsxNDIsMTEgQEAgR2V0QnlJZFN0YXR1cyBHZXRCeUlkU3RhdHVzOjpjb21wdXRlRm9yUwogCiAj aWYgRU5BQkxFKEpJVCkKIEdldEJ5SWRTdGF0dXM6OkdldEJ5SWRTdGF0dXMoY29uc3QgTW9kdWxl TmFtZXNwYWNlQWNjZXNzQ2FzZSYgYWNjZXNzQ2FzZSkKLSAgICA6IG1fc3RhdGUoTW9kdWxlTmFt ZXNwYWNlKQotICAgICwgbV93YXNTZWVuSW5KSVQodHJ1ZSkKLSAgICAsIG1fbW9kdWxlTmFtZXNw YWNlT2JqZWN0KGFjY2Vzc0Nhc2UubW9kdWxlTmFtZXNwYWNlT2JqZWN0KCkpCisgICAgOiBtX21v ZHVsZU5hbWVzcGFjZU9iamVjdChhY2Nlc3NDYXNlLm1vZHVsZU5hbWVzcGFjZU9iamVjdCgpKQog ICAgICwgbV9tb2R1bGVFbnZpcm9ubWVudChhY2Nlc3NDYXNlLm1vZHVsZUVudmlyb25tZW50KCkp CiAgICAgLCBtX3Njb3BlT2Zmc2V0KGFjY2Vzc0Nhc2Uuc2NvcGVPZmZzZXQoKSkKKyAgICAsIG1f c3RhdGUoTW9kdWxlTmFtZXNwYWNlKQorICAgICwgbV93YXNTZWVuSW5KSVQodHJ1ZSkKIHsKIH0K IApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0dldEJ5SWRTdGF0dXMuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvR2V0QnlJZFN0YXR1 cy5oCShyZXZpc2lvbiAyNDI2NDYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUv R2V0QnlJZFN0YXR1cy5oCSh3b3JraW5nIGNvcHkpCkBAIC00NSw3ICs0NSw3IEBAIGNsYXNzIFN0 cnVjdHVyZVN0dWJJbmZvOwogCiBjbGFzcyBHZXRCeUlkU3RhdHVzIHsKIHB1YmxpYzoKLSAgICBl bnVtIFN0YXRlIHsKKyAgICBlbnVtIFN0YXRlIDogdWludDhfdCB7CiAgICAgICAgIC8vIEl0J3Mg dW5jYWNoZWQgc28gd2UgaGF2ZSBubyBpbmZvcm1hdGlvbi4KICAgICAgICAgTm9JbmZvcm1hdGlv biwKICAgICAgICAgLy8gSXQncyBjYWNoZWQgZm9yIGEgc2ltcGxlIGFjY2VzcyB0byBhIGtub3du IG9iamVjdCBwcm9wZXJ0eSB3aXRoCkBAIC0xNTYsMTIgKzE1NiwxMyBAQCBwcml2YXRlOgogICAg IAogICAgIGJvb2wgYXBwZW5kVmFyaWFudChjb25zdCBHZXRCeUlkVmFyaWFudCYpOwogICAgIAot ICAgIFN0YXRlIG1fc3RhdGU7CisgICAgCiAgICAgVmVjdG9yPEdldEJ5SWRWYXJpYW50LCAxPiBt X3ZhcmlhbnRzOwotICAgIGJvb2wgbV93YXNTZWVuSW5KSVQgeyBmYWxzZSB9OwogICAgIEpTTW9k dWxlTmFtZXNwYWNlT2JqZWN0KiBtX21vZHVsZU5hbWVzcGFjZU9iamVjdCB7IG51bGxwdHIgfTsK ICAgICBKU01vZHVsZUVudmlyb25tZW50KiBtX21vZHVsZUVudmlyb25tZW50IHsgbnVsbHB0ciB9 OwogICAgIFNjb3BlT2Zmc2V0IG1fc2NvcGVPZmZzZXQgeyB9OworICAgIFN0YXRlIG1fc3RhdGU7 CisgICAgYm9vbCBtX3dhc1NlZW5JbkpJVCB7IGZhbHNlIH07CiB9OwogCiB9IC8vIG5hbWVzcGFj ZSBKU0MK