195477 2019-03-08 13:51:27 -0800 [ews-app] Add support for submit-to-ews url 2019-03-11 11:24:47 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dean_johnson dewei_zhu kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1514162 0 aakash_jain 2019-03-08 13:51:27 -0800 We should add submit-to-ews url support, so as to submit the patch ids manually to EWS. This would also be required to make the 'Submit for EWS analysis' button work. 1514179 1 364065 aakash_jain 2019-03-08 14:20:31 -0800 Created attachment 364065 Proposed patch 1514191 2 364065 dewei_zhu 2019-03-08 14:38:33 -0800 Comment on attachment 364065 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=364065&action=review > Tools/BuildSlaveSupport/ews-app/ews/fetcher.py:53 > + def fetch(self, patch_ids=None): > + if not patch_ids: > + patch_ids = Bugzilla.get_list_of_patches_needing_reviews() We may want to check the type of patch_ids here. BugzillaPatchFetcher().fetch(1) will cause exceptions in next line. > Tools/BuildSlaveSupport/ews-app/ews/views/submittoews.py:40 > +@method_decorator(csrf_exempt, name='dispatch') Do we have a security justification for not having csrf here? 1514868 3 364269 aakash_jain 2019-03-11 10:48:02 -0700 Created attachment 364269 Patch for landing > We may want to check the type of patch_ids here. Added the check. > Do we have a security justification for not having csrf here? Removed csrf_exempt decorator. Updated templates accordingly (by adding {% csrf_token %}) 1514882 4 364269 commit-queue 2019-03-11 11:22:07 -0700 Comment on attachment 364269 Patch for landing Clearing flags on attachment: 364269 Committed r242719: <https://trac.webkit.org/changeset/242719> 1514883 5 commit-queue 2019-03-11 11:22:09 -0700 All reviewed patches have been landed. Closing bug. 1514886 6 webkit-bug-importer 2019-03-11 11:24:47 -0700 <rdar://problem/48774381> 364065 2019-03-08 14:20:31 -0800 2019-03-11 10:48:02 -0700 Proposed patch submit-to-ews.patch text/plain 7572 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MjY1NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTAzLTA4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gQWRkIHN1cHBvcnQgZm9yIHN1Ym1pdC10by1ld3MgdXJs CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU0NzcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxk U2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2ZldGNoZXIucHk6CisgICAgICAgICogQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWFwcC9ld3MvdGVtcGxhdGVzL3N0YXR1c2J1YmJsZS5odG1sOgorICAgICAg ICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3RlbXBsYXRlcy9zdWJtaXR0b2V3cy5o dG1sOiBDb3BpZWQgZnJvbSBRdWV1ZVN0YXR1c1NlcnZlci90ZW1wbGF0ZXMvc3VibWl0dG9ld3Mu aHRtbC4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy91cmxzLnB5Ogor ICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3ZpZXdzL3N1Ym1pdHRvZXdz LnB5OiBBZGRlZC4KKwogMjAxOS0wMy0wOCAgU3RlcGhhbmllIExld2lzICA8c2xld2lzQGFwcGxl LmNvbT4KIAogICAgICAgICBFbnN1cmUgb2xkIHRhYiBzdGF0ZSBpcyBjbGVhcmVkIGJldHdlZW4g aXRlcmF0aW9ucyBvZiBydW4tYmVuY2htYXJrCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9y dC9ld3MtYXBwL2V3cy9mZXRjaGVyLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1hcHAvZXdzL2ZldGNoZXIucHkJKHJldmlzaW9uIDI0MjY1NikKKysrIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2ZldGNoZXIucHkJKHdvcmtpbmcgY29weSkK QEAgLTQ4LDggKzQ4LDkgQEAgY2xhc3MgRmV0Y2hMb29wKCk6CiAKIAogY2xhc3MgQnVnemlsbGFQ YXRjaEZldGNoZXIoKToKLSAgICBkZWYgZmV0Y2goc2VsZik6Ci0gICAgICAgIHBhdGNoX2lkcyA9 IEJ1Z3ppbGxhLmdldF9saXN0X29mX3BhdGNoZXNfbmVlZGluZ19yZXZpZXdzKCkKKyAgICBkZWYg ZmV0Y2goc2VsZiwgcGF0Y2hfaWRzPU5vbmUpOgorICAgICAgICBpZiBub3QgcGF0Y2hfaWRzOgor ICAgICAgICAgICAgcGF0Y2hfaWRzID0gQnVnemlsbGEuZ2V0X2xpc3Rfb2ZfcGF0Y2hlc19uZWVk aW5nX3Jldmlld3MoKQogICAgICAgICBwYXRjaF9pZHMgPSBCdWd6aWxsYVBhdGNoRmV0Y2hlci5m aWx0ZXJfdmFsaWRfcGF0Y2hlcyhwYXRjaF9pZHMpCiAgICAgICAgIF9sb2cuZGVidWcoJ3I/IHBh dGNoZXM6IHt9Jy5mb3JtYXQocGF0Y2hfaWRzKSkKICAgICAgICAgUGF0Y2guc2F2ZV9wYXRjaGVz KHBhdGNoX2lkcykKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3Vy bHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mv dXJscy5weQkocmV2aXNpb24gMjQyNjU2KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWFwcC9ld3MvdXJscy5weQkod29ya2luZyBjb3B5KQpAQCAtMjYsNiArMjYsNyBAQCBmcm9tIGV3 cy52aWV3cy5pbmRleCBpbXBvcnQgSW5kZXgKIGZyb20gZXdzLnZpZXdzLnBhdGNoIGltcG9ydCBQ YXRjaAogZnJvbSBld3Mudmlld3MucmVzdWx0cyBpbXBvcnQgUmVzdWx0cwogZnJvbSBld3Mudmll d3Muc3RhdHVzYnViYmxlIGltcG9ydCBTdGF0dXNCdWJibGUKK2Zyb20gZXdzLnZpZXdzLnN1Ym1p dHRvZXdzIGltcG9ydCBTdWJtaXRUb0VXUwogCiBhcHBfbmFtZSA9ICdld3MnCiB1cmxwYXR0ZXJu cyA9IFsKQEAgLTM3LDQgKzM4LDYgQEAgdXJscGF0dGVybnMgPSBbCiAgICAgdXJsKHInXnJlc3Vs dHMvJCcsIFJlc3VsdHMuYXNfdmlldygpLCBuYW1lPSdyZXN1bHRzJyksCiAgICAgIyBleDogL3N0 YXR1cy1idWJibGUvNQogICAgIHVybChyJ15zdGF0dXMtYnViYmxlLyg/UDxwYXRjaF9pZD5bMC05 XSspLyQnLCBTdGF0dXNCdWJibGUuYXNfdmlldygpLCBuYW1lPSdzdGF0dXNidWJibGUnKSwKKyAg ICAjIGV4OiAvc3VibWl0LXRvLWV3cy8KKyAgICB1cmwocidec3VibWl0LXRvLWV3cy8kJywgU3Vi bWl0VG9FV1MuYXNfdmlldygpLCBuYW1lPSdzdWJtaXR0b2V3cycpLAogXQpJbmRleDogVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvdGVtcGxhdGVzL3N0YXR1c2J1YmJsZS5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3RlbXBs YXRlcy9zdGF0dXNidWJibGUuaHRtbAkocmV2aXNpb24gMjQyNjU2KQorKysgVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvdGVtcGxhdGVzL3N0YXR1c2J1YmJsZS5odG1sCSh3b3Jr aW5nIGNvcHkpCkBAIC05MSw3ICs5MSw3IEBAIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJtZXNz YWdlIiwgZnVuY3QKICAgeyUgZW5kaWYgJX0KIAogeyUgaWYgc2hvd19zdWJtaXRfdG9fZXdzICV9 Ci0gIDxmb3JtIG5hbWU9InN1Ym1pdF90b19ld3MiIG1ldGhvZD0iUE9TVCIgYWN0aW9uPSIvc3Vi bWl0LXRvLWV3cyI+CisgIDxmb3JtIG5hbWU9InN1Ym1pdF90b19ld3MiIG1ldGhvZD0iUE9TVCIg YWN0aW9uPSIvc3VibWl0LXRvLWV3cy8iPgogICAgIDxpbnB1dCB0eXBlPSJoaWRkZW4iIG5hbWU9 InBhdGNoX2lkIiB2YWx1ZT0ie3sgcGF0Y2hfaWQgfX0iPgogICAgIDxpbnB1dCB0eXBlPSJoaWRk ZW4iIG5hbWU9Im5leHRfYWN0aW9uIiB2YWx1ZT0icmV0dXJuX3RvX2J1YmJsZXMiPgogICAgIDxp bnB1dCBjbGFzcz0ic3RhdHVzIiB0eXBlPSJzdWJtaXQiIHZhbHVlPSJTdWJtaXQgZm9yIEVXUyBh bmFseXNpcyI+CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy90ZW1w bGF0ZXMvc3VibWl0dG9ld3MuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYXBwL2V3cy90ZW1wbGF0ZXMvc3VibWl0dG9ld3MuaHRtbAkocmV2aXNpb24gMjQy NjU0KQkoZnJvbSBUb29scy9RdWV1ZVN0YXR1c1NlcnZlci90ZW1wbGF0ZXMvc3VibWl0dG9ld3Mu aHRtbDoyNDI2NTQpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy90ZW1w bGF0ZXMvc3VibWl0dG9ld3MuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDMgQEAKKzxm b3JtIG5hbWU9InN1Ym1pdF90b19ld3MiIG1ldGhvZD0iUE9TVCI+CitBdHRhY2htZW50IGlkIG9m IHBhdGNoIHRvIHN1Ym1pdDogPGlucHV0IG5hbWU9ImF0dGFjaG1lbnRfaWQiPjxpbnB1dCB0eXBl PSJzdWJtaXQiIHZhbHVlPSJTdWJtaXQgZm9yIEVXUyBQcm9jZXNzaW5nIj4KKzwvZm9ybT4KSW5k ZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3RlbXBsYXRlcy9zdWJtaXR0 b2V3cy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAv ZXdzL3RlbXBsYXRlcy9zdWJtaXR0b2V3cy5odG1sCShyZXZpc2lvbiAyNDI2NTQpCisrKyBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy90ZW1wbGF0ZXMvc3VibWl0dG9ld3MuaHRt bAkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMgQEAKIDxmb3JtIG5hbWU9InN1Ym1pdF90b19l d3MiIG1ldGhvZD0iUE9TVCI+Ci1BdHRhY2htZW50IGlkIG9mIHBhdGNoIHRvIHN1Ym1pdDogPGlu cHV0IG5hbWU9ImF0dGFjaG1lbnRfaWQiPjxpbnB1dCB0eXBlPSJzdWJtaXQiIHZhbHVlPSJTdWJt aXQgZm9yIEVXUyBQcm9jZXNzaW5nIj4KK0F0dGFjaG1lbnQgaWQgb2YgcGF0Y2ggdG8gc3VibWl0 OiA8aW5wdXQgbmFtZT0icGF0Y2hfaWQiPjxpbnB1dCB0eXBlPSJzdWJtaXQiIHZhbHVlPSJTdWJt aXQgZm9yIEVXUyBQcm9jZXNzaW5nIj4KIDwvZm9ybT4KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1hcHAvZXdzL3ZpZXdzL3N1Ym1pdHRvZXdzLnB5Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3ZpZXdzL3N1Ym1pdHRvZXdzLnB5CShu b25leGlzdGVudCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3ZpZXdz L3N1Ym1pdHRvZXdzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNjMgQEAKKyMgQ29weXJp Z2h0IChDKSAyMDE5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMKKyMgUmVkaXN0 cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRo b3V0CisjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xs b3dpbmcgY29uZGl0aW9ucworIyBhcmUgbWV0OgorIyAxLiAgUmVkaXN0cmlidXRpb25zIG9mIHNv dXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgICAgIG5vdGljZSwg dGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyMg Mi4gIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJv dmUgY29weXJpZ2h0CisjICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0 aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisjICAgICBkb2N1bWVudGF0aW9uIGFuZC9v ciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorIworIyBU SElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEFQUExFIElOQy4gQU5EIElUUyBDT05UUklCVVRP UlMgYGBBUyBJUycnIEFORAorIyBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElO Q0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRAorIyBXQVJSQU5USUVTIE9G IE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJF CisjIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIElOQy4gT1IgSVRTIENPTlRS SUJVVE9SUyBCRSBMSUFCTEUgRk9SCisjIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFM LCBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwKKyMgREFNQUdFUyAoSU5DTFVE SU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMg T1IKKyMgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVT UyBJTlRFUlJVUFRJT04pIEhPV0VWRVIKKyMgQ0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZIE9GIExJ QUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwKKyMgT1IgVE9S VCAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkg T1VUIE9GIFRIRSBVU0UKKyMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRI RSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKworZnJvbSBfX2Z1dHVyZV9fIGltcG9ydCB1 bmljb2RlX2xpdGVyYWxzCisKK2ltcG9ydCBqc29uCitpbXBvcnQgbG9nZ2luZworCitmcm9tIGRq YW5nby5odHRwIGltcG9ydCBIdHRwUmVzcG9uc2UKK2Zyb20gZGphbmdvLnNob3J0Y3V0cyBpbXBv cnQgcmVkaXJlY3QsIHJlbmRlcgorZnJvbSBkamFuZ28udmlld3MgaW1wb3J0IFZpZXcKK2Zyb20g ZGphbmdvLnZpZXdzLmRlY29yYXRvcnMuY3NyZiBpbXBvcnQgY3NyZl9leGVtcHQKK2Zyb20gZGph bmdvLnV0aWxzLmRlY29yYXRvcnMgaW1wb3J0IG1ldGhvZF9kZWNvcmF0b3IKKworZnJvbSBld3Mu ZmV0Y2hlciBpbXBvcnQgQnVnemlsbGFQYXRjaEZldGNoZXIKK2Zyb20gZXdzLm1vZGVscy5wYXRj aCBpbXBvcnQgUGF0Y2gKKworX2xvZyA9IGxvZ2dpbmcuZ2V0TG9nZ2VyKF9fbmFtZV9fKQorCisK K0BtZXRob2RfZGVjb3JhdG9yKGNzcmZfZXhlbXB0LCBuYW1lPSdkaXNwYXRjaCcpCitjbGFzcyBT dWJtaXRUb0VXUyhWaWV3KToKKyAgICBkZWYgZ2V0KHNlbGYsIHJlcXVlc3QpOgorICAgICAgICBy ZXR1cm4gcmVuZGVyKHJlcXVlc3QsICdzdWJtaXR0b2V3cy5odG1sJywge30pCisKKyAgICBkZWYg cG9zdChzZWxmLCByZXF1ZXN0KToKKyAgICAgICAgdHJ5OgorICAgICAgICAgICAgcGF0Y2hfaWQg PSByZXF1ZXN0LlBPU1QuZ2V0KCdwYXRjaF9pZCcpCisgICAgICAgICAgICBwYXRjaF9pZCA9IGlu dChwYXRjaF9pZCkKKyAgICAgICAgZXhjZXB0OgorICAgICAgICAgICAgcmV0dXJuIEh0dHBSZXNw b25zZSgiSW52YWxpZCBwYXRjaCBpZCB7fSIuZm9ybWF0KHJlcXVlc3QuUE9TVC5nZXQoJ3BhdGNo X2lkJykpKQorCisgICAgICAgIF9sb2cuZGVidWcoJ1N1Ym1pdFRvRVdTOjpwYXRjaDoge30nLmZv cm1hdChwYXRjaF9pZCkpCisgICAgICAgIGlmIFBhdGNoLmlzX3BhdGNoX3NlbnRfdG9fYnVpbGRi b3QocGF0Y2hfaWQpOgorICAgICAgICAgICAgX2xvZy5pbmZvKCdTdWJtaXRUb0VXUzo6cGF0Y2gg e30gYWxyZWFkeSBzdWJtaXR0ZWQnLmZvcm1hdChwYXRjaF9pZCkpCisgICAgICAgICAgICBpZiBy ZXF1ZXN0LlBPU1QuZ2V0KCduZXh0X2FjdGlvbicpID09ICdyZXR1cm5fdG9fYnViYmxlcyc6Cisg ICAgICAgICAgICAgICAgcmV0dXJuIHJlZGlyZWN0KCcvc3RhdHVzLWJ1YmJsZS97fScuZm9ybWF0 KHBhdGNoX2lkKSkKKyAgICAgICAgICAgIHJldHVybiBIdHRwUmVzcG9uc2UoIlBhdGNoIHt9IGFs cmVhZHkgc3VibWl0dGVkLiBQbGVhc2Ugd2FpdCBmb3Igc3RhdHVzLWJ1YmJsZXMuIi5mb3JtYXQo cGF0Y2hfaWQpKQorCisgICAgICAgIEJ1Z3ppbGxhUGF0Y2hGZXRjaGVyKCkuZmV0Y2goW3BhdGNo X2lkXSkKKworICAgICAgICBpZiByZXF1ZXN0LlBPU1QuZ2V0KCduZXh0X2FjdGlvbicpID09ICdy ZXR1cm5fdG9fYnViYmxlcyc6CisgICAgICAgICAgICByZXR1cm4gcmVkaXJlY3QoJy9zdGF0dXMt YnViYmxlL3t9Jy5mb3JtYXQocGF0Y2hfaWQpKQorICAgICAgICByZXR1cm4gSHR0cFJlc3BvbnNl KCJTdWJtaXR0ZWQgcGF0Y2gge30gdG8gRVdTLiIuZm9ybWF0KHBhdGNoX2lkKSkK 364269 2019-03-11 10:48:02 -0700 2019-03-11 11:22:07 -0700 Patch for landing submit-to-ews-v2.patch text/plain 7647 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MjcxNikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTAzLTExICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gQWRkIHN1cHBvcnQgZm9yIHN1Ym1pdC10by1ld3MgdXJs CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU0NzcK KworICAgICAgICBSZXZpZXdlZCBieSBMdWNhcyBGb3JzY2hsZXIuCisKKyAgICAgICAgKiBCdWls ZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9mZXRjaGVyLnB5OgorICAgICAgICAqIEJ1aWxkU2xh dmVTdXBwb3J0L2V3cy1hcHAvZXdzL3RlbXBsYXRlcy9zdGF0dXNidWJibGUuaHRtbDoKKyAgICAg ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy90ZW1wbGF0ZXMvc3VibWl0dG9ld3Mu aHRtbDogQ29waWVkIGZyb20gUXVldWVTdGF0dXNTZXJ2ZXIvdGVtcGxhdGVzL3N1Ym1pdHRvZXdz Lmh0bWwuCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvdXJscy5weToK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdWJtaXR0b2V3 cy5weTogQWRkZWQuCisKIDIwMTktMDMtMTEgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBs ZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjI0MjY4OCwgcjI0MjY0 MywgcjI0MjYyNC4KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2Zl dGNoZXIucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9l d3MvZmV0Y2hlci5weQkocmV2aXNpb24gMjQyNzE2KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvZXdzLWFwcC9ld3MvZmV0Y2hlci5weQkod29ya2luZyBjb3B5KQpAQCAtNDgsOCArNDgsMTMg QEAgY2xhc3MgRmV0Y2hMb29wKCk6CiAKIAogY2xhc3MgQnVnemlsbGFQYXRjaEZldGNoZXIoKToK LSAgICBkZWYgZmV0Y2goc2VsZik6Ci0gICAgICAgIHBhdGNoX2lkcyA9IEJ1Z3ppbGxhLmdldF9s aXN0X29mX3BhdGNoZXNfbmVlZGluZ19yZXZpZXdzKCkKKyAgICBkZWYgZmV0Y2goc2VsZiwgcGF0 Y2hfaWRzPU5vbmUpOgorICAgICAgICBpZiBwYXRjaF9pZHMgYW5kIHR5cGUocGF0Y2hfaWRzKSAh PSBsaXN0OgorICAgICAgICAgICAgX2xvZy5lcnJvcignRXJyb3I6IHBhdGNoX2lkcyBzaG91bGQg YmUgYSBsaXN0LCBmb3VuZDoge30nLmZvcm1hdCh0eXBlKHBhdGNoX2lkcykpKQorICAgICAgICAg ICAgcmV0dXJuIC0xCisKKyAgICAgICAgaWYgbm90IHBhdGNoX2lkczoKKyAgICAgICAgICAgIHBh dGNoX2lkcyA9IEJ1Z3ppbGxhLmdldF9saXN0X29mX3BhdGNoZXNfbmVlZGluZ19yZXZpZXdzKCkK ICAgICAgICAgcGF0Y2hfaWRzID0gQnVnemlsbGFQYXRjaEZldGNoZXIuZmlsdGVyX3ZhbGlkX3Bh dGNoZXMocGF0Y2hfaWRzKQogICAgICAgICBfbG9nLmRlYnVnKCdyPyBwYXRjaGVzOiB7fScuZm9y bWF0KHBhdGNoX2lkcykpCiAgICAgICAgIFBhdGNoLnNhdmVfcGF0Y2hlcyhwYXRjaF9pZHMpCklu ZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy91cmxzLnB5Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3VybHMucHkJKHJldmlz aW9uIDI0MjcxNikKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3VybHMu cHkJKHdvcmtpbmcgY29weSkKQEAgLTI2LDYgKzI2LDcgQEAgZnJvbSBld3Mudmlld3MuaW5kZXgg aW1wb3J0IEluZGV4CiBmcm9tIGV3cy52aWV3cy5wYXRjaCBpbXBvcnQgUGF0Y2gKIGZyb20gZXdz LnZpZXdzLnJlc3VsdHMgaW1wb3J0IFJlc3VsdHMKIGZyb20gZXdzLnZpZXdzLnN0YXR1c2J1YmJs ZSBpbXBvcnQgU3RhdHVzQnViYmxlCitmcm9tIGV3cy52aWV3cy5zdWJtaXR0b2V3cyBpbXBvcnQg U3VibWl0VG9FV1MKIAogYXBwX25hbWUgPSAnZXdzJwogdXJscGF0dGVybnMgPSBbCkBAIC0zNyw0 ICszOCw2IEBAIHVybHBhdHRlcm5zID0gWwogICAgIHVybChyJ15yZXN1bHRzLyQnLCBSZXN1bHRz LmFzX3ZpZXcoKSwgbmFtZT0ncmVzdWx0cycpLAogICAgICMgZXg6IC9zdGF0dXMtYnViYmxlLzUK ICAgICB1cmwocidec3RhdHVzLWJ1YmJsZS8oP1A8cGF0Y2hfaWQ+WzAtOV0rKS8kJywgU3RhdHVz QnViYmxlLmFzX3ZpZXcoKSwgbmFtZT0nc3RhdHVzYnViYmxlJyksCisgICAgIyBleDogL3N1Ym1p dC10by1ld3MvCisgICAgdXJsKHInXnN1Ym1pdC10by1ld3MvJCcsIFN1Ym1pdFRvRVdTLmFzX3Zp ZXcoKSwgbmFtZT0nc3VibWl0dG9ld3MnKSwKIF0KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2V3cy1hcHAvZXdzL3RlbXBsYXRlcy9zdGF0dXNidWJibGUuaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy90ZW1wbGF0ZXMvc3RhdHVzYnVi YmxlLmh0bWwJKHJldmlzaW9uIDI0MjcxNikKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3 cy1hcHAvZXdzL3RlbXBsYXRlcy9zdGF0dXNidWJibGUuaHRtbAkod29ya2luZyBjb3B5KQpAQCAt OTEsNyArOTEsNyBAQCB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigibWVzc2FnZSIsIGZ1bmN0CiAg IHslIGVuZGlmICV9CiAKIHslIGlmIHNob3dfc3VibWl0X3RvX2V3cyAlfQotICA8Zm9ybSBuYW1l PSJzdWJtaXRfdG9fZXdzIiBtZXRob2Q9IlBPU1QiIGFjdGlvbj0iL3N1Ym1pdC10by1ld3MiPgor ICA8Zm9ybSBuYW1lPSJzdWJtaXRfdG9fZXdzIiBtZXRob2Q9IlBPU1QiIGFjdGlvbj0iL3N1Ym1p dC10by1ld3MvIj57JSBjc3JmX3Rva2VuICV9CiAgICAgPGlucHV0IHR5cGU9ImhpZGRlbiIgbmFt ZT0icGF0Y2hfaWQiIHZhbHVlPSJ7eyBwYXRjaF9pZCB9fSI+CiAgICAgPGlucHV0IHR5cGU9Imhp ZGRlbiIgbmFtZT0ibmV4dF9hY3Rpb24iIHZhbHVlPSJyZXR1cm5fdG9fYnViYmxlcyI+CiAgICAg PGlucHV0IGNsYXNzPSJzdGF0dXMiIHR5cGU9InN1Ym1pdCIgdmFsdWU9IlN1Ym1pdCBmb3IgRVdT IGFuYWx5c2lzIj4KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3Rl bXBsYXRlcy9zdWJtaXR0b2V3cy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1hcHAvZXdzL3RlbXBsYXRlcy9zdWJtaXR0b2V3cy5odG1sCShyZXZpc2lvbiAy NDI2NTQpCShmcm9tIFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL3RlbXBsYXRlcy9zdWJtaXR0b2V3 cy5odG1sOjI0MjY1NCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3Rl bXBsYXRlcy9zdWJtaXR0b2V3cy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMyBAQAor PGZvcm0gbmFtZT0ic3VibWl0X3RvX2V3cyIgbWV0aG9kPSJQT1NUIj4KK0F0dGFjaG1lbnQgaWQg b2YgcGF0Y2ggdG8gc3VibWl0OiA8aW5wdXQgbmFtZT0iYXR0YWNobWVudF9pZCI+PGlucHV0IHR5 cGU9InN1Ym1pdCIgdmFsdWU9IlN1Ym1pdCBmb3IgRVdTIFByb2Nlc3NpbmciPgorPC9mb3JtPgpJ bmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvdGVtcGxhdGVzL3N1Ym1p dHRvZXdzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFw cC9ld3MvdGVtcGxhdGVzL3N1Ym1pdHRvZXdzLmh0bWwJKHJldmlzaW9uIDI0MjY1NCkKKysrIFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3RlbXBsYXRlcy9zdWJtaXR0b2V3cy5o dG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMyBAQAotPGZvcm0gbmFtZT0ic3VibWl0X3Rv X2V3cyIgbWV0aG9kPSJQT1NUIj4KLUF0dGFjaG1lbnQgaWQgb2YgcGF0Y2ggdG8gc3VibWl0OiA8 aW5wdXQgbmFtZT0iYXR0YWNobWVudF9pZCI+PGlucHV0IHR5cGU9InN1Ym1pdCIgdmFsdWU9IlN1 Ym1pdCBmb3IgRVdTIFByb2Nlc3NpbmciPgorPGZvcm0gbmFtZT0ic3VibWl0X3RvX2V3cyIgbWV0 aG9kPSJQT1NUIj57JSBjc3JmX3Rva2VuICV9CitBdHRhY2htZW50IGlkIG9mIHBhdGNoIHRvIHN1 Ym1pdDogPGlucHV0IG5hbWU9InBhdGNoX2lkIj48aW5wdXQgdHlwZT0ic3VibWl0IiB2YWx1ZT0i U3VibWl0IGZvciBFV1MgUHJvY2Vzc2luZyI+CiA8L2Zvcm0+CkluZGV4OiBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdWJtaXR0b2V3cy5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdWJtaXR0b2V3cy5w eQkobm9uZXhpc3RlbnQpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92 aWV3cy9zdWJtaXR0b2V3cy5weQkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDYwIEBACisjIENv cHlyaWdodCAoQykgMjAxOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjCisjIFJl ZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Ig d2l0aG91dAorIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUg Zm9sbG93aW5nIGNvbmRpdGlvbnMKKyMgYXJlIG1ldDoKKyMgMS4gIFJlZGlzdHJpYnV0aW9ucyBv ZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisjICAgICBub3Rp Y2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIu CisjIDIuICBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhl IGFib3ZlIGNvcHlyaWdodAorIyAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBh bmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQorIyAgICAgZG9jdW1lbnRhdGlvbiBh bmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KKyMK KyMgVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJ QlVUT1JTIGBgQVMgSVMnJyBBTkQKKyMgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVT LCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFIElNUExJRUQKKyMgV0FSUkFOVElF UyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NF IEFSRQorIyBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBD T05UUklCVVRPUlMgQkUgTElBQkxFIEZPUgorIyBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURF TlRBTCwgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMCisjIERBTUFHRVMgKElO Q0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdP T0RTIE9SCisjIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVT SU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSCisjIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWSBP RiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksCisjIE9S IFRPUlQgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkg V0FZIE9VVCBPRiBUSEUgVVNFCisjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBP RiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisKK2Zyb20gX19mdXR1cmVfXyBpbXBv cnQgdW5pY29kZV9saXRlcmFscworCitpbXBvcnQganNvbgoraW1wb3J0IGxvZ2dpbmcKKworZnJv bSBkamFuZ28uaHR0cCBpbXBvcnQgSHR0cFJlc3BvbnNlCitmcm9tIGRqYW5nby5zaG9ydGN1dHMg aW1wb3J0IHJlZGlyZWN0LCByZW5kZXIKK2Zyb20gZGphbmdvLnZpZXdzIGltcG9ydCBWaWV3CisK K2Zyb20gZXdzLmZldGNoZXIgaW1wb3J0IEJ1Z3ppbGxhUGF0Y2hGZXRjaGVyCitmcm9tIGV3cy5t b2RlbHMucGF0Y2ggaW1wb3J0IFBhdGNoCisKK19sb2cgPSBsb2dnaW5nLmdldExvZ2dlcihfX25h bWVfXykKKworCitjbGFzcyBTdWJtaXRUb0VXUyhWaWV3KToKKyAgICBkZWYgZ2V0KHNlbGYsIHJl cXVlc3QpOgorICAgICAgICByZXR1cm4gcmVuZGVyKHJlcXVlc3QsICdzdWJtaXR0b2V3cy5odG1s Jywge30pCisKKyAgICBkZWYgcG9zdChzZWxmLCByZXF1ZXN0KToKKyAgICAgICAgdHJ5OgorICAg ICAgICAgICAgcGF0Y2hfaWQgPSByZXF1ZXN0LlBPU1QuZ2V0KCdwYXRjaF9pZCcpCisgICAgICAg ICAgICBwYXRjaF9pZCA9IGludChwYXRjaF9pZCkKKyAgICAgICAgZXhjZXB0OgorICAgICAgICAg ICAgcmV0dXJuIEh0dHBSZXNwb25zZSgiSW52YWxpZCBwYXRjaCBpZCB7fSIuZm9ybWF0KHJlcXVl c3QuUE9TVC5nZXQoJ3BhdGNoX2lkJykpKQorCisgICAgICAgIF9sb2cuZGVidWcoJ1N1Ym1pdFRv RVdTOjpwYXRjaDoge30nLmZvcm1hdChwYXRjaF9pZCkpCisgICAgICAgIGlmIFBhdGNoLmlzX3Bh dGNoX3NlbnRfdG9fYnVpbGRib3QocGF0Y2hfaWQpOgorICAgICAgICAgICAgX2xvZy5pbmZvKCdT dWJtaXRUb0VXUzo6cGF0Y2gge30gYWxyZWFkeSBzdWJtaXR0ZWQnLmZvcm1hdChwYXRjaF9pZCkp CisgICAgICAgICAgICBpZiByZXF1ZXN0LlBPU1QuZ2V0KCduZXh0X2FjdGlvbicpID09ICdyZXR1 cm5fdG9fYnViYmxlcyc6CisgICAgICAgICAgICAgICAgcmV0dXJuIHJlZGlyZWN0KCcvc3RhdHVz LWJ1YmJsZS97fScuZm9ybWF0KHBhdGNoX2lkKSkKKyAgICAgICAgICAgIHJldHVybiBIdHRwUmVz cG9uc2UoIlBhdGNoIHt9IGFscmVhZHkgc3VibWl0dGVkLiBQbGVhc2Ugd2FpdCBmb3Igc3RhdHVz LWJ1YmJsZXMuIi5mb3JtYXQocGF0Y2hfaWQpKQorCisgICAgICAgIEJ1Z3ppbGxhUGF0Y2hGZXRj aGVyKCkuZmV0Y2goW3BhdGNoX2lkXSkKKworICAgICAgICBpZiByZXF1ZXN0LlBPU1QuZ2V0KCdu ZXh0X2FjdGlvbicpID09ICdyZXR1cm5fdG9fYnViYmxlcyc6CisgICAgICAgICAgICByZXR1cm4g cmVkaXJlY3QoJy9zdGF0dXMtYnViYmxlL3t9Jy5mb3JtYXQocGF0Y2hfaWQpKQorICAgICAgICBy ZXR1cm4gSHR0cFJlc3BvbnNlKCJTdWJtaXR0ZWQgcGF0Y2gge30gdG8gRVdTLiIuZm9ybWF0KHBh dGNoX2lkKSkK