195465 2019-03-08 09:59:43 -0800 Rename AssertionState::Download 2019-03-08 11:04:38 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson aestes commit-queue webkit-bug-importer oldest_to_newest 1514040 0 beidson 2019-03-08 09:59:43 -0800 Rename AssertionState::Download It's about Uploads also. 1514043 1 364025 beidson 2019-03-08 10:12:12 -0800 Created attachment 364025 Patch 1514044 2 364025 aestes 2019-03-08 10:13:15 -0800 Comment on attachment 364025 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364025&action=review > Source/WebKit/NetworkProcess/Downloads/DownloadMap.cpp:61 > - m_downloadAssertion = std::make_unique<ProcessAssertion>(getpid(), "WebKit downloads"_s, AssertionState::Download); > + m_downloadAssertion = std::make_unique<ProcessAssertion>(getpid(), "WebKit downloads"_s, AssertionState::UnboundedNetworking); "WebKit downloads" => "WebKit unbounded networking"? 1514048 3 beidson 2019-03-08 10:14:12 -0800 (In reply to Andy Estes from comment #2) > Comment on attachment 364025 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364025&action=review > > > Source/WebKit/NetworkProcess/Downloads/DownloadMap.cpp:61 > > - m_downloadAssertion = std::make_unique<ProcessAssertion>(getpid(), "WebKit downloads"_s, AssertionState::Download); > > + m_downloadAssertion = std::make_unique<ProcessAssertion>(getpid(), "WebKit downloads"_s, AssertionState::UnboundedNetworking); > > "WebKit downloads" => "WebKit unbounded networking"? In the case of the DownloadMap, we know it's "downloads" An UploadMap change coming very soon will name its "uploads" 1514085 4 364025 commit-queue 2019-03-08 11:01:37 -0800 Comment on attachment 364025 Patch Clearing flags on attachment: 364025 Committed r242646: <https://trac.webkit.org/changeset/242646> 1514086 5 commit-queue 2019-03-08 11:01:38 -0800 All reviewed patches have been landed. Closing bug. 1514090 6 webkit-bug-importer 2019-03-08 11:04:38 -0800 <rdar://problem/48718522> 364025 2019-03-08 10:12:12 -0800 2019-03-08 11:01:37 -0800 Patch bug-195465-20190308101212.patch text/plain 4133 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyNjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc0YjQzOGI1MWIyMTBjZTE0 YzQ1NTBlNzliNDA4MjdhNWNkOGFiNGMuLmY5YzNmMzVjZTA1MTc0N2E5ZDY4MjJhYTRkNTUzMmUy NjA1MTc4ODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTktMDMtMDggIEJyYWR5IEVp ZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJlbmFtZSBBc3NlcnRpb25TdGF0 ZTo6RG93bmxvYWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTU0NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJdCdzIChjdXJyZW50bHkpIGFib3V0IHVwbG9hZHMgYW5kIGRvd25sb2Fkcy4KKyAgICAg ICAgTGV0J3MgY2FsbCBpdCAiVW5ib3VuZGVkTmV0d29ya2luZyIKKworICAgICAgICAqIE5ldHdv cmtQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZE1hcC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRv d25sb2FkTWFwOjphZGQpOgorCisgICAgICAgICogVUlQcm9jZXNzL1Byb2Nlc3NBc3NlcnRpb24u aDoKKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJQcm9jZXNzUHJveHk6OmRpZFNldEFzc2VydGlvblN0YXRlKToKKworICAgICAg ICAqIFVJUHJvY2Vzcy9pb3MvUHJvY2Vzc0Fzc2VydGlvbklPUy5tbToKKyAgICAgICAgKFdlYktp dDo6ZmxhZ3NGb3JTdGF0ZSk6CisgICAgICAgIChXZWJLaXQ6OnJlYXNvbkZvclN0YXRlKToKKwog MjAxOS0wMy0wNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFJl Z3Jlc3Npb24ocjI0MjU4MCkgV2ViS2l0Lk5ldHdvcmtQcm9jZXNzQ3Jhc2hXaXRoUGVuZGluZ0Nv bm5lY3Rpb24gQVBJIGlzIGNyYXNoaW5nIG9uIGlPUyBkZWJ1ZwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRNYXAuY3BwIGIvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRNYXAuY3BwCmluZGV4IGM0 MDEyMDRkYzc4YjBiYzFkODRmMTRkMDk4MDc0MmQ0M2E3ZWVmYjUuLmNlNGViMjdlODllZmEyYmQ1 Yjc5ZjNjNTc1NGFjYTdkMjExYzA4NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkTWFwLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZE1hcC5jcHAKQEAgLTU4LDcgKzU4LDcgQEAg RG93bmxvYWRNYXA6OkRvd25sb2FkTWFwVHlwZTo6QWRkUmVzdWx0IERvd25sb2FkTWFwOjphZGQo RG93bmxvYWRJRCBkb3dubG9hZElELAogICAgIGF1dG8gcmVzdWx0ID0gbV9kb3dubG9hZHMuYWRk KGRvd25sb2FkSUQsIFdURk1vdmUoZG93bmxvYWQpKTsKICAgICBpZiAobV9kb3dubG9hZHMuc2l6 ZSgpID09IDEpIHsKICAgICAgICAgQVNTRVJUKCFtX2Rvd25sb2FkQXNzZXJ0aW9uKTsKLSAgICAg ICAgbV9kb3dubG9hZEFzc2VydGlvbiA9IHN0ZDo6bWFrZV91bmlxdWU8UHJvY2Vzc0Fzc2VydGlv bj4oZ2V0cGlkKCksICJXZWJLaXQgZG93bmxvYWRzIl9zLCBBc3NlcnRpb25TdGF0ZTo6RG93bmxv YWQpOworICAgICAgICBtX2Rvd25sb2FkQXNzZXJ0aW9uID0gc3RkOjptYWtlX3VuaXF1ZTxQcm9j ZXNzQXNzZXJ0aW9uPihnZXRwaWQoKSwgIldlYktpdCBkb3dubG9hZHMiX3MsIEFzc2VydGlvblN0 YXRlOjpVbmJvdW5kZWROZXR3b3JraW5nKTsKICAgICB9CiAKICAgICByZXR1cm4gcmVzdWx0Owpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUHJvY2Vzc0Fzc2VydGlvbi5oIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvUHJvY2Vzc0Fzc2VydGlvbi5oCmluZGV4IDE1NjcwZTA3 Njk4M2ZmZTg5ZWRjMWQzNzE5MGIwNzA5NjFiNjNjMGYuLjIxMGQ0MGE2NWE1NjhhYjMyOGZkNmE3 ZGFiYzAyNGE3MDQ2NDkxMmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1By b2Nlc3NBc3NlcnRpb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Qcm9jZXNzQXNz ZXJ0aW9uLmgKQEAgLTQ0LDcgKzQ0LDcgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiBlbnVtIGNsYXNz IEFzc2VydGlvblN0YXRlIHsKICAgICBTdXNwZW5kZWQsCiAgICAgQmFja2dyb3VuZCwKLSAgICBE b3dubG9hZCwKKyAgICBVbmJvdW5kZWROZXR3b3JraW5nLAogICAgIEZvcmVncm91bmQKIH07CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCmluZGV4IDg5Mjcx MWQ0NDExYTZlZDlkYjRmNWMxOWI3MTRiZTNkN2Q4ODQ0ODUuLmJlODU5ZjkzMWIzY2ZmZmY5ZTc5 ZGYwYmUzNDk3YjRlNWI4NDczZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYlByb2Nlc3NQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJv Y2Vzc1Byb3h5LmNwcApAQCAtMTE3Miw3ICsxMTcyLDcgQEAgdm9pZCBXZWJQcm9jZXNzUHJveHk6 OmRpZFNldEFzc2VydGlvblN0YXRlKEFzc2VydGlvblN0YXRlIHN0YXRlKQogICAgICAgICAgICAg cGFnZS0+cHJvY2Vzc1dpbGxCZWNvbWVGb3JlZ3JvdW5kKCk7CiAgICAgICAgIGJyZWFrOwogICAg IAotICAgIGNhc2UgQXNzZXJ0aW9uU3RhdGU6OkRvd25sb2FkOgorICAgIGNhc2UgQXNzZXJ0aW9u U3RhdGU6OlVuYm91bmRlZE5ldHdvcmtpbmc6CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgp OwogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1Byb2Nl c3NBc3NlcnRpb25JT1MubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvUHJvY2Vzc0Fz c2VydGlvbklPUy5tbQppbmRleCBhNzNjNzg5MzVlMjI1MDRkZTVkYjRiOGFjNzA3NjViYzVkZTRi ZmY0Li41YzMyMTgzYzVjNjAzOTExMDI1NjgwMmIxZTMzYTk0Y2IxZjgwZTQyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvUHJvY2Vzc0Fzc2VydGlvbklPUy5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvUHJvY2Vzc0Fzc2VydGlvbklPUy5tbQpAQCAt MTM5LDcgKzEzOSw3IEBAIHN0YXRpYyBCS1NQcm9jZXNzQXNzZXJ0aW9uRmxhZ3MgZmxhZ3NGb3JT dGF0ZShBc3NlcnRpb25TdGF0ZSBhc3NlcnRpb25TdGF0ZSkKICAgICBjYXNlIEFzc2VydGlvblN0 YXRlOjpTdXNwZW5kZWQ6CiAgICAgICAgIHJldHVybiBzdXNwZW5kZWRUYWJGbGFnczsKICAgICBj YXNlIEFzc2VydGlvblN0YXRlOjpCYWNrZ3JvdW5kOgotICAgIGNhc2UgQXNzZXJ0aW9uU3RhdGU6 OkRvd25sb2FkOgorICAgIGNhc2UgQXNzZXJ0aW9uU3RhdGU6OlVuYm91bmRlZE5ldHdvcmtpbmc6 CiAgICAgICAgIHJldHVybiBiYWNrZ3JvdW5kVGFiRmxhZ3M7CiAgICAgY2FzZSBBc3NlcnRpb25T dGF0ZTo6Rm9yZWdyb3VuZDoKICAgICAgICAgcmV0dXJuIGZvcmVncm91bmRUYWJGbGFnczsKQEAg LTE0OSw3ICsxNDksNyBAQCBzdGF0aWMgQktTUHJvY2Vzc0Fzc2VydGlvbkZsYWdzIGZsYWdzRm9y U3RhdGUoQXNzZXJ0aW9uU3RhdGUgYXNzZXJ0aW9uU3RhdGUpCiBzdGF0aWMgQktTUHJvY2Vzc0Fz c2VydGlvblJlYXNvbiByZWFzb25Gb3JTdGF0ZShBc3NlcnRpb25TdGF0ZSBhc3NlcnRpb25TdGF0 ZSkKIHsKICAgICBzd2l0Y2ggKGFzc2VydGlvblN0YXRlKSB7Ci0gICAgY2FzZSBBc3NlcnRpb25T dGF0ZTo6RG93bmxvYWQ6CisgICAgY2FzZSBBc3NlcnRpb25TdGF0ZTo6VW5ib3VuZGVkTmV0d29y a2luZzoKICAgICAgICAgcmV0dXJuIEJLU1Byb2Nlc3NBc3NlcnRpb25SZWFzb25GaW5pc2hUYXNr VW5ib3VuZGVkOwogICAgIGNhc2UgQXNzZXJ0aW9uU3RhdGU6OlN1c3BlbmRlZDoKICAgICBjYXNl IEFzc2VydGlvblN0YXRlOjpCYWNrZ3JvdW5kOgo=