195445 2019-03-07 18:17:16 -0800 [MSE] Adopt new AVSampleBufferDisplayLayer SPI 2019-03-07 20:28:55 -0800 1 1 1 Unclassified WebKit Media Other All All RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue jer.noble webkit-bug-importer oldest_to_newest 1513848 0 eric.carlson 2019-03-07 18:17:16 -0800 Adopt new AVSampleBufferDisplayLayer SPI to know when preroll completes. 1513849 1 eric.carlson 2019-03-07 18:17:37 -0800 <rdar://problem/48480516> 1513851 2 363967 eric.carlson 2019-03-07 18:23:52 -0800 Created attachment 363967 Patch 1513898 3 363967 commit-queue 2019-03-07 20:28:54 -0800 Comment on attachment 363967 Patch Clearing flags on attachment: 363967 Committed r242631: <https://trac.webkit.org/changeset/242631> 1513899 4 commit-queue 2019-03-07 20:28:55 -0800 All reviewed patches have been landed. Closing bug. 363967 2019-03-07 18:23:52 -0800 2019-03-07 20:28:54 -0800 Patch bug-195445-20190307182351.patch text/plain 6280 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMzYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDhhMWMyMjUwMzBjNmIx YWRhM2E4YTU5YzNhNDA2YTUyNWRlODg3MC4uMTdhZGY0ODIxYzhhNTJjNjhjNDg5ZmY5Y2VlZmEx YjMyMjljZmUwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTAzLTA3ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNU0VdIEFkb3B0 IG5ldyBBVlNhbXBsZUJ1ZmZlckRpc3BsYXlMYXllciBTUEkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTQ0NQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNDg0ODA1MTY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLCBubyBmdW5jdGlvbmFsIGNoYW5nZS4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL1NvdXJjZUJ1ZmZlclByaXZhdGVBVkZP YmpDLm1tOgorICAgICAgICAoV2ViQ29yZTo6U291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakM6OlNv dXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpDKTogT25seSByZWdpc3RlciBmb3IgCisgICAgICAgIGtD TVNhbXBsZUJ1ZmZlckNvbnN1bWVyTm90aWZpY2F0aW9uX0J1ZmZlckNvbnN1bWVkIG5vdGlpY2F0 aW9uIHdoZW4KKyAgICAgICAgLVtBVlNhbXBsZUJ1ZmZlckRpc3BsYXlMYXllciBwcmVyb2xsRGVj b2RlV2l0aENvbXBsZXRpb25IYW5kbGVyOl0gaXNuJ3QgYXZhaWxhYmxlLgorICAgICAgICAoV2Vi Q29yZTo6U291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakM6On5Tb3VyY2VCdWZmZXJQcml2YXRlQVZG T2JqQyk6IERpdHRvLCBmb3IgdW5yZWdpc3RlcmluZy4KKyAgICAgICAgKFdlYkNvcmU6OlNvdXJj ZUJ1ZmZlclByaXZhdGVBVkZPYmpDOjplbnF1ZXVlU2FtcGxlKTogVXNlIAorICAgICAgICAtW0FW U2FtcGxlQnVmZmVyRGlzcGxheUxheWVyIHByZXJvbGxEZWNvZGVXaXRoQ29tcGxldGlvbkhhbmRs ZXI6XSB3aGVuIHBvc3NpYmxlLgorCiAyMDE5LTAzLTA0ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFNoYXJlIG1vcmUgY29kZSBiZXR3ZWVuIG92ZXJm bG93IGFuZCBmcmFtZSBzY3JvbGxpbmcgbm9kZXMsIGZpeGluZyBvdmVyZmxvdyBzY3JvbGxiYXIg ZGlzcGxheQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZm b3VuZGF0aW9uL29iamMvU291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakMubW0gYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9Tb3VyY2VCdWZmZXJQcml2 YXRlQVZGT2JqQy5tbQppbmRleCBjYTcwNDJhZmQ3NTZjZWIyMTQ5ODk4OTdjOTExY2ExZTQwMjg3 OWZlLi5kMTY4MWJiNjdlMWVlNzJiNTJiNmNkMzY4ZjcyYjdlOTBhOWFmNzlkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9Tb3Vy Y2VCdWZmZXJQcml2YXRlQVZGT2JqQy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9Tb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQy5tbQpA QCAtODksNiArODksMTAgQEAgU09GVF9MSU5LX0NPTlNUQU5UKEFWRm91bmRhdGlvbiwgQVZTYW1w bGVCdWZmZXJEaXNwbGF5TGF5ZXJGYWlsZWRUb0RlY29kZU5vdGlmaWMKICNkZWZpbmUgQVZNZWRp YUNoYXJhY3RlcmlzdGljQXVkaWJsZSBnZXRBVk1lZGlhQ2hhcmFjdGVyaXN0aWNBdWRpYmxlKCkK ICNkZWZpbmUgQVZNZWRpYUNoYXJhY3RlcmlzdGljTGVnaWJsZSBnZXRBVk1lZGlhQ2hhcmFjdGVy aXN0aWNMZWdpYmxlKCkKIAorQGludGVyZmFjZSBBVlNhbXBsZUJ1ZmZlckRpc3BsYXlMYXllciAo V2ViQ29yZUFWU2FtcGxlQnVmZmVyRGlzcGxheUxheWVyUXVldWVNYW5hZ2VtZW50UHJpdmF0ZSkK Ky0gKHZvaWQpcHJlcm9sbERlY29kZVdpdGhDb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoQk9P TCBzdWNjZXNzKSlibG9jazsKK0BlbmQKKwogI3ByYWdtYSBtYXJrIC0KICNwcmFnbWEgbWFyayBB VlN0cmVhbVNlc3Npb24KIApAQCAtNDk0LDggKzQ5OCwxMCBAQCBTb3VyY2VCdWZmZXJQcml2YXRl QVZGT2JqQzo6U291cmNlQnVmZmVyUHJpdmF0ZUFWRk9iakMoTWVkaWFTb3VyY2VQcml2YXRlQVZG T2JqQwogI2VuZGlmCiB7CiAgICAgQUxXQVlTX0xPRyhMT0dJREVOVElGSUVSKTsKLQotICAgIENN Tm90aWZpY2F0aW9uQ2VudGVyQWRkTGlzdGVuZXIoQ01Ob3RpZmljYXRpb25DZW50ZXJHZXREZWZh dWx0TG9jYWxDZW50ZXIoKSwgcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4obV9tYXBJRCksIGJ1ZmZl cldhc0NvbnN1bWVkQ2FsbGJhY2ssIGtDTVNhbXBsZUJ1ZmZlckNvbnN1bWVyTm90aWZpY2F0aW9u X0J1ZmZlckNvbnN1bWVkLCBudWxscHRyLCAwKTsKKyAgICAKKyAgICBpZiAoIVtnZXRBVlNhbXBs ZUJ1ZmZlckRpc3BsYXlMYXllckNsYXNzKCkgaW5zdGFuY2VzUmVzcG9uZFRvU2VsZWN0b3I6QHNl bGVjdG9yKHByZXJvbGxEZWNvZGVXaXRoQ29tcGxldGlvbkhhbmRsZXI6KV0pCisgICAgICAgIENN Tm90aWZpY2F0aW9uQ2VudGVyQWRkTGlzdGVuZXIoQ01Ob3RpZmljYXRpb25DZW50ZXJHZXREZWZh dWx0TG9jYWxDZW50ZXIoKSwgcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4obV9tYXBJRCksIGJ1ZmZl cldhc0NvbnN1bWVkQ2FsbGJhY2ssIGtDTVNhbXBsZUJ1ZmZlckNvbnN1bWVyTm90aWZpY2F0aW9u X0J1ZmZlckNvbnN1bWVkLCBudWxscHRyLCAwKTsKKyAgICAKICAgICBtX2RlbGVnYXRlLmdldCgp LmFib3J0U2VtYXBob3JlID0gQm94PFNlbWFwaG9yZT46OmNyZWF0ZSgwKTsKIAogICAgIHNvdXJj ZUJ1ZmZlck1hcCgpLmFkZChtX21hcElELCBtYWtlV2Vha1B0cigqdGhpcykpOwpAQCAtNTEwLDcg KzUxNiw4IEBAIFNvdXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpDOjp+U291cmNlQnVmZmVyUHJpdmF0 ZUFWRk9iakMoKQogICAgIGRlc3Ryb3lQYXJzZXIoKTsKICAgICBkZXN0cm95UmVuZGVyZXJzKCk7 CiAKLSAgICBDTU5vdGlmaWNhdGlvbkNlbnRlclJlbW92ZUxpc3RlbmVyKENNTm90aWZpY2F0aW9u Q2VudGVyR2V0RGVmYXVsdExvY2FsQ2VudGVyKCksIHRoaXMsIGJ1ZmZlcldhc0NvbnN1bWVkQ2Fs bGJhY2ssIGtDTVNhbXBsZUJ1ZmZlckNvbnN1bWVyTm90aWZpY2F0aW9uX0J1ZmZlckNvbnN1bWVk LCBudWxscHRyKTsKKyAgICBpZiAoIVtnZXRBVlNhbXBsZUJ1ZmZlckRpc3BsYXlMYXllckNsYXNz KCkgaW5zdGFuY2VzUmVzcG9uZFRvU2VsZWN0b3I6QHNlbGVjdG9yKHByZXJvbGxEZWNvZGVXaXRo Q29tcGxldGlvbkhhbmRsZXI6KV0pCisgICAgICAgIENNTm90aWZpY2F0aW9uQ2VudGVyUmVtb3Zl TGlzdGVuZXIoQ01Ob3RpZmljYXRpb25DZW50ZXJHZXREZWZhdWx0TG9jYWxDZW50ZXIoKSwgdGhp cywgYnVmZmVyV2FzQ29uc3VtZWRDYWxsYmFjaywga0NNU2FtcGxlQnVmZmVyQ29uc3VtZXJOb3Rp ZmljYXRpb25fQnVmZmVyQ29uc3VtZWQsIG51bGxwdHIpOwogCiAgICAgaWYgKG1faGFzU2Vzc2lv blNlbWFwaG9yZSkKICAgICAgICAgbV9oYXNTZXNzaW9uU2VtYXBob3JlLT5zaWduYWwoKTsKQEAg LTExNDQsMTQgKzExNTEsMzEgQEAgdm9pZCBTb3VyY2VCdWZmZXJQcml2YXRlQVZGT2JqQzo6ZW5x dWV1ZVNhbXBsZShSZWY8TWVkaWFTYW1wbGU+JiYgc2FtcGxlLCBjb25zdAogICAgICAgICBpZiAo bV9tZWRpYVNvdXJjZSAmJiAhbV9tZWRpYVNvdXJjZS0+cGxheWVyKCktPmhhc0F2YWlsYWJsZVZp ZGVvRnJhbWUoKSAmJiAhc2FtcGxlLT5pc05vbkRpc3BsYXlpbmcoKSkgewogICAgICAgICAgICAg REVCVUdfTE9HKExPR0lERU5USUZJRVIsICJhZGRpbmcgYnVmZmVyIGF0dGFjaG1lbnQiKTsKIAot ICAgICAgICAgICAgQ01TYW1wbGVCdWZmZXJSZWYgcmF3U2FtcGxlQ29weTsKLSAgICAgICAgICAg IENNU2FtcGxlQnVmZmVyQ3JlYXRlQ29weShrQ0ZBbGxvY2F0b3JEZWZhdWx0LCBwbGF0Zm9ybVNh bXBsZS5zYW1wbGUuY21TYW1wbGVCdWZmZXIsICZyYXdTYW1wbGVDb3B5KTsKLSAgICAgICAgICAg IGF1dG8gc2FtcGxlQ29weSA9IGFkb3B0Q0YocmF3U2FtcGxlQ29weSk7Ci0gICAgICAgICAgICBD TVNldEF0dGFjaG1lbnQoc2FtcGxlQ29weS5nZXQoKSwga0NNU2FtcGxlQnVmZmVyQXR0YWNobWVu dEtleV9Qb3N0Tm90aWZpY2F0aW9uV2hlbkNvbnN1bWVkLCAoX19icmlkZ2UgQ0ZEaWN0aW9uYXJ5 UmVmKUB7IChfX2JyaWRnZSBOU1N0cmluZyAqKWtDTVNhbXBsZUJ1ZmZlckF0dGFjaG1lbnRLZXlf UG9zdE5vdGlmaWNhdGlvbldoZW5Db25zdW1lZCA6IEAoWUVTKSB9LCBrQ01BdHRhY2htZW50TW9k ZV9TaG91bGROb3RQcm9wYWdhdGUpOwotICAgICAgICAgICAgW21fZGlzcGxheUxheWVyIGVucXVl dWVTYW1wbGVCdWZmZXI6c2FtcGxlQ29weS5nZXQoKV07CisgICAgICAgICAgICBib29sIGhhdmVQ cmVyb2xsRGVjb2RlV2l0aENvbXBsZXRpb25IYW5kbGVyID0gW2dldEFWU2FtcGxlQnVmZmVyRGlz cGxheUxheWVyQ2xhc3MoKSBpbnN0YW5jZXNSZXNwb25kVG9TZWxlY3RvcjpAc2VsZWN0b3IocHJl cm9sbERlY29kZVdpdGhDb21wbGV0aW9uSGFuZGxlcjopXTsKKworICAgICAgICAgICAgaWYgKCFo YXZlUHJlcm9sbERlY29kZVdpdGhDb21wbGV0aW9uSGFuZGxlcikgeworICAgICAgICAgICAgICAg IENNU2FtcGxlQnVmZmVyUmVmIHJhd1NhbXBsZUNvcHk7CisgICAgICAgICAgICAgICAgQ01TYW1w bGVCdWZmZXJDcmVhdGVDb3B5KGtDRkFsbG9jYXRvckRlZmF1bHQsIHBsYXRmb3JtU2FtcGxlLnNh bXBsZS5jbVNhbXBsZUJ1ZmZlciwgJnJhd1NhbXBsZUNvcHkpOworICAgICAgICAgICAgICAgIGF1 dG8gc2FtcGxlQ29weSA9IGFkb3B0Q0YocmF3U2FtcGxlQ29weSk7CisgICAgICAgICAgICAgICAg Q01TZXRBdHRhY2htZW50KHNhbXBsZUNvcHkuZ2V0KCksIGtDTVNhbXBsZUJ1ZmZlckF0dGFjaG1l bnRLZXlfUG9zdE5vdGlmaWNhdGlvbldoZW5Db25zdW1lZCwgKF9fYnJpZGdlIENGRGljdGlvbmFy eVJlZilAeyAoX19icmlkZ2UgTlNTdHJpbmcgKilrQ01TYW1wbGVCdWZmZXJBdHRhY2htZW50S2V5 X1Bvc3ROb3RpZmljYXRpb25XaGVuQ29uc3VtZWQgOiBAKFlFUykgfSwga0NNQXR0YWNobWVudE1v ZGVfU2hvdWxkTm90UHJvcGFnYXRlKTsKKyAgICAgICAgICAgICAgICBbbV9kaXNwbGF5TGF5ZXIg ZW5xdWV1ZVNhbXBsZUJ1ZmZlcjpzYW1wbGVDb3B5LmdldCgpXTsKICNpZiBQTEFURk9STShJT1Nf RkFNSUxZKQotICAgICAgICAgICAgbV9tZWRpYVNvdXJjZS0+cGxheWVyKCktPnNldEhhc0F2YWls YWJsZVZpZGVvRnJhbWUodHJ1ZSk7CisgICAgICAgICAgICAgICAgbV9tZWRpYVNvdXJjZS0+cGxh eWVyKCktPnNldEhhc0F2YWlsYWJsZVZpZGVvRnJhbWUodHJ1ZSk7CiAjZW5kaWYKKyAgICAgICAg ICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAgW21fZGlzcGxheUxheWVyIGVucXVldWVTYW1w bGVCdWZmZXI6cGxhdGZvcm1TYW1wbGUuc2FtcGxlLmNtU2FtcGxlQnVmZmVyXTsKKyAgICAgICAg ICAgICAgICBbbV9kaXNwbGF5TGF5ZXIgcHJlcm9sbERlY29kZVdpdGhDb21wbGV0aW9uSGFuZGxl cjpbd2Vha1RoaXMgPSBjcmVhdGVXZWFrUHRyKCldIChCT09MIHN1Y2Nlc3MpIG11dGFibGUgewor ICAgICAgICAgICAgICAgICAgICBpZiAoIXN1Y2Nlc3MgfHwgIXdlYWtUaGlzKQorICAgICAgICAg ICAgICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgICAgICAgICAgICAgIGNhbGxPbk1haW5U aHJlYWQoW3dlYWtUaGlzID0gV1RGTW92ZSh3ZWFrVGhpcyldICgpIG11dGFibGUgeworICAgICAg ICAgICAgICAgICAgICAgICAgaWYgKCF3ZWFrVGhpcykKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICByZXR1cm47CisKKyAgICAgICAgICAgICAgICAgICAgICAgIHdlYWtUaGlzLT5idWZmZXJX YXNDb25zdW1lZCgpOworICAgICAgICAgICAgICAgICAgICB9KTsKKyAgICAgICAgICAgICAgICB9 XTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICBbbV9kaXNwbGF5 TGF5ZXIgZW5xdWV1ZVNhbXBsZUJ1ZmZlcjpwbGF0Zm9ybVNhbXBsZS5zYW1wbGUuY21TYW1wbGVC dWZmZXJdOwogCg==