195437 2019-03-07 14:53:51 -0800 [iOS] Pasting text into Microsoft Visio sometimes zooms and scrolls 2019-03-07 22:53:21 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build iPhone / iPad iOS 12 ASSIGNED InRadar, PlatformOnly P2 Normal --- 1 dbates dbates megan_gardner simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1513732 0 dbates 2019-03-07 14:53:51 -0800 It is annoying that sometimes when you paste content into Microsoft Visio that WebKit sometimes zooms and scrolls. Steps to reproduce: The following assume you have a hardware keyboard attached and you have some content on the clipboard. 1. Visit <http://portal.office.com> and sign in. 2. Open Visio and create a new document. 3. Drag and drop a shape to the document. 4. Press the Return key to edit the label for the shape. 5. Press Command + V to paste. Then WebKit will zoom and scroll the page such that the caret is aligned to the right edge of the page before the scrollbar. (Note if you have trouble reproducing then try changing Visio's zoom Control + + or Control + -. You can also try to do that in combination with moving the shape to be closer to the edge of the Visio document). The expected result is that no zooming or scrolling occur on paste. 1513733 1 363934 dbates 2019-03-07 14:55:29 -0800 Created attachment 363934 Work-in-progress 1513735 2 webkit-bug-importer 2019-03-07 14:55:49 -0800 <rdar://problem/48691509> 1513800 3 363934 wenson_hsieh 2019-03-07 16:33:53 -0800 Comment on attachment 363934 Work-in-progress View in context: https://bugs.webkit.org/attachment.cgi?id=363934&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:5321 > + isProgrammaticRefocus = !m_userIsInteracting && m_keyboardIsAttached; I haven't considered this approach thoroughly yet, but here's a quick comment... isProgrammaticRefocus seems like a strange name for this variable. The fact that it's always false on non-iOS platforms would imply that it's not possible to programmatically refocus an element there (which is not true!) It's also unclear to me why m_keyboardIsAttached would matter here — an element can always be programmatically focused after it already has focus, regardless of whether or not a hardware keyboard is attached. The difference seems to be whether or not programmatic focus is allowed to bring up the input view. Is this really about whether or not programmatic focus causes the input view to be shown by default? 1513846 4 dbates 2019-03-07 17:58:48 -0800 Don’t let the name get to you because I don’t like it too and need to think some more about this code to figure out a) whether this approach is correct b) where the code should live (originally the whole focus due to user interaction was in WebPageIOS and and c) what the name of the variable and existing variables should be called 1513930 5 dbates 2019-03-07 22:53:21 -0800 This bug also happens on Mac when you paste or paste with matching style. Need to try with Chrome/Firefox/Edge. 363934 2019-03-07 14:55:29 -0800 2019-03-07 14:55:35 -0800 Work-in-progress work-in-progress.diff text/plain 1062 dbates ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3Bw IGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKaW5kZXggMGY3 MGIzYmJmMDMuLmJiYTQ5NjlmZDRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmNwcApAQCAtNTMxNSw3ICs1MzE1LDEyIEBAIHZvaWQgV2ViUGFnZTo6ZWxl bWVudERpZFJlZm9jdXMoV2ViQ29yZTo6RWxlbWVudCYgZWxlbWVudCkKIAogdm9pZCBXZWJQYWdl OjplbGVtZW50RGlkRm9jdXMoV2ViQ29yZTo6RWxlbWVudCYgZWxlbWVudCkKIHsKLSAgICBpZiAo bV9mb2N1c2VkRWxlbWVudCA9PSAmZWxlbWVudCAmJiBtX2lzRm9jdXNpbmdFbGVtZW50RHVlVG9V c2VySW50ZXJhY3Rpb24pCisgICAgLy8gRklYTUU6IE5lZWQgdG8gcmUtY29tcHV0ZSBpZiBlZGl0 YWJpbGl0eSBjaGFuZ2VzIChub24tZWRpdGFibGUgdG8gZWRpdGFibGUgb3IgZWRpdGFibGUgdG8g bm9uLWVkaXRhYmxlKS4KKyAgICBib29sIGlzUHJvZ3JhbW1hdGljUmVmb2N1cyA9IGZhbHNlOwor I2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCisgICAgaXNQcm9ncmFtbWF0aWNSZWZvY3VzID0gIW1f dXNlcklzSW50ZXJhY3RpbmcgJiYgbV9rZXlib2FyZElzQXR0YWNoZWQ7CisjZW5kaWYKKyAgICBp ZiAobV9mb2N1c2VkRWxlbWVudCA9PSAmZWxlbWVudCAmJiAoaXNQcm9ncmFtbWF0aWNSZWZvY3Vz IHx8IG1faXNGb2N1c2luZ0VsZW1lbnREdWVUb1VzZXJJbnRlcmFjdGlvbikpCiAgICAgICAgIHJl dHVybjsKIAogICAgIGlmIChlbGVtZW50Lmhhc1RhZ05hbWUoV2ViQ29yZTo6SFRNTE5hbWVzOjpz ZWxlY3RUYWcpIHx8IGVsZW1lbnQuaGFzVGFnTmFtZShXZWJDb3JlOjpIVE1MTmFtZXM6OmlucHV0 VGFnKSB8fCBlbGVtZW50Lmhhc1RhZ05hbWUoV2ViQ29yZTo6SFRNTE5hbWVzOjp0ZXh0YXJlYVRh ZykgfHwgZWxlbWVudC5oYXNFZGl0YWJsZVN0eWxlKCkpIHsK