<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>195436</bug_id>
          
          <creation_ts>2019-03-07 14:43:10 -0800</creation_ts>
          <short_desc>WebRTC: don&apos;t use stack buffer</short_desc>
          <delta_ts>2022-02-28 03:29:23 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="JF Bastien">jfbastien</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>achristensen</cc>
    
    <cc>darin</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>jfbastien</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1513728</commentid>
    <comment_count>0</comment_count>
    <who name="JF Bastien">jfbastien</who>
    <bug_when>2019-03-07 14:43:10 -0800</bug_when>
    <thetext>WebRTC: don&apos;t use stack buffer</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1513730</commentid>
    <comment_count>1</comment_count>
      <attachid>363933</attachid>
    <who name="JF Bastien">jfbastien</who>
    <bug_when>2019-03-07 14:43:44 -0800</bug_when>
    <thetext>Created attachment 363933
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1513731</commentid>
    <comment_count>2</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2019-03-07 14:47:07 -0800</bug_when>
    <thetext>Attachment 363933 did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1513749</commentid>
    <comment_count>3</comment_count>
      <attachid>363941</attachid>
    <who name="JF Bastien">jfbastien</who>
    <bug_when>2019-03-07 15:27:41 -0800</bug_when>
    <thetext>Created attachment 363941
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1513750</commentid>
    <comment_count>4</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2019-03-07 15:30:35 -0800</bug_when>
    <thetext>Attachment 363941 did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1513777</commentid>
    <comment_count>5</comment_count>
      <attachid>363947</attachid>
    <who name="JF Bastien">jfbastien</who>
    <bug_when>2019-03-07 16:13:48 -0800</bug_when>
    <thetext>Created attachment 363947
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1513782</commentid>
    <comment_count>6</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2019-03-07 16:16:03 -0800</bug_when>
    <thetext>Attachment 363947 did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1513810</commentid>
    <comment_count>7</comment_count>
      <attachid>363957</attachid>
    <who name="JF Bastien">jfbastien</who>
    <bug_when>2019-03-07 16:40:44 -0800</bug_when>
    <thetext>Created attachment 363957
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1513811</commentid>
    <comment_count>8</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2019-03-07 16:43:13 -0800</bug_when>
    <thetext>Attachment 363957 did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1513814</commentid>
    <comment_count>9</comment_count>
      <attachid>363957</attachid>
    <who name="youenn fablet">youennf</who>
    <bug_when>2019-03-07 16:46:59 -0800</bug_when>
    <thetext>Comment on attachment 363957
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363957&amp;action=review

&gt; Source/WebCore/ChangeLog:3
&gt; +        WebRTC: don&apos;t create huge stack buffer in a loop

Probably missing https://bugs.webkit.org/show_bug.cgi?id=195436 here.

&gt; Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:99
&gt; +        m_data.reset(new char[bytesPerSample * channels * samplesPerFrame]);

Would better read with make_unique?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1513816</commentid>
    <comment_count>10</comment_count>
      <attachid>363958</attachid>
    <who name="JF Bastien">jfbastien</who>
    <bug_when>2019-03-07 16:51:36 -0800</bug_when>
    <thetext>Created attachment 363958
Patch

Address comments.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1513820</commentid>
    <comment_count>11</comment_count>
      <attachid>363958</attachid>
    <who name="youenn fablet">youennf</who>
    <bug_when>2019-03-07 16:59:20 -0800</bug_when>
    <thetext>Comment on attachment 363958
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363958&amp;action=review

&gt; Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:99
&gt; +        m_data.reset(std::make_unique&lt;char[]&gt;(bytesPerSample * channels * samplesPerFrame));

Would use m_data = std::make_unique.

If we go down that road, we could also allocate m_data in StartPlayoutOnAudioThread and delete it when exiting of StartPlayoutOnAudioThread.
That would remove the if check and deallocate it when no longer needed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1513823</commentid>
    <comment_count>12</comment_count>
      <attachid>363960</attachid>
    <who name="JF Bastien">jfbastien</who>
    <bug_when>2019-03-07 17:05:28 -0800</bug_when>
    <thetext>Created attachment 363960
Patch

(In reply to youenn fablet from comment #11)
&gt; Comment on attachment 363958 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=363958&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:99
&gt; &gt; +        m_data.reset(std::make_unique&lt;char[]&gt;(bytesPerSample * channels * samplesPerFrame));
&gt; 
&gt; Would use m_data = std::make_unique.

Oops yes. Fixed.


&gt; If we go down that road, we could also allocate m_data in
&gt; StartPlayoutOnAudioThread and delete it when exiting of
&gt; StartPlayoutOnAudioThread.
&gt; That would remove the if check and deallocate it when no longer needed.

I can do that if you want, I didn&apos;t dig through the code to convince myself that it was correct :-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1514594</commentid>
    <comment_count>13</comment_count>
      <attachid>363960</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-03-10 15:37:01 -0700</bug_when>
    <thetext>Comment on attachment 363960
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363960&amp;action=review

&gt; Source/WebCore/ChangeLog:7
&gt; +        The 1920 byte buffer is pretty big, and the loop is unrolled 5
&gt; +        times in a regular build.

If the unrolling is the issue, just putting the buffer outside the loop would solve the problem. Not sure allocating on the heap is the right thing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1514596</commentid>
    <comment_count>14</comment_count>
      <attachid>363960</attachid>
    <who name="JF Bastien">jfbastien</who>
    <bug_when>2019-03-10 15:45:07 -0700</bug_when>
    <thetext>Comment on attachment 363960
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363960&amp;action=review

&gt;&gt; Source/WebCore/ChangeLog:7
&gt;&gt; +        times in a regular build.
&gt; 
&gt; If the unrolling is the issue, just putting the buffer outside the loop would solve the problem. Not sure allocating on the heap is the right thing.

My ulterior motive is that, once we automatically initialize this stack buffer, it&apos;ll be expensive. Without LTO the compiler won&apos;t be able to prove anything about the buffer being initialized somewhere else, so it&apos;ll call memset. There&apos;s a few other places in WebCore where this happens for somewhat large buffers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1514599</commentid>
    <comment_count>15</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-03-10 15:58:19 -0700</bug_when>
    <thetext>(In reply to JF Bastien from comment #14)
&gt; My ulterior motive is that, once we automatically initialize this stack
&gt; buffer, it&apos;ll be expensive.

OK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1514617</commentid>
    <comment_count>16</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2019-03-10 16:28:52 -0700</bug_when>
    <thetext>(In reply to JF Bastien from comment #12)
&gt; Created attachment 363960 [details]
&gt; Patch
&gt; 
&gt; (In reply to youenn fablet from comment #11)
&gt; &gt; Comment on attachment 363958 [details]
&gt; &gt; Patch
&gt; &gt; 
&gt; &gt; View in context:
&gt; &gt; https://bugs.webkit.org/attachment.cgi?id=363958&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:99
&gt; &gt; &gt; +        m_data.reset(std::make_unique&lt;char[]&gt;(bytesPerSample * channels * samplesPerFrame));
&gt; &gt; 
&gt; &gt; Would use m_data = std::make_unique.
&gt; 
&gt; Oops yes. Fixed.
&gt; 
&gt; 
&gt; &gt; If we go down that road, we could also allocate m_data in
&gt; &gt; StartPlayoutOnAudioThread and delete it when exiting of
&gt; &gt; StartPlayoutOnAudioThread.
&gt; &gt; That would remove the if check and deallocate it when no longer needed.
&gt; 
&gt; I can do that if you want, I didn&apos;t dig through the code to convince myself
&gt; that it was correct :-)

I think it is correct and would improve the code a bit.
m_data could be replaced by a local var as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1514985</commentid>
    <comment_count>17</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-03-11 14:02:59 -0700</bug_when>
    <thetext>Your earlier version used operator new[] which I believe does not initialize the values to 0, and based on youenn&apos;s feedback you now use std::make_unique&lt;char[]&gt;, which I believe does initialize the values to 0.  Is this true?  Is this desired?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1515237</commentid>
    <comment_count>18</comment_count>
      <attachid>363960</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-03-11 20:30:35 -0700</bug_when>
    <thetext>Comment on attachment 363960
Patch

This also doesn&apos;t use fastMalloc/fastFree, but makeUniqueArray does.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>363933</attachid>
            <date>2019-03-07 14:43:44 -0800</date>
            <delta_ts>2019-03-07 15:27:41 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-195436-20190307144343.patch</filename>
            <type>text/plain</type>
            <size>2543</size>
            <attacher name="JF Bastien">jfbastien</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyNTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTAxMjExYzkxZWQ4ZmYw
OGNiNmQwYjYyODg3NGM2YWNkZjRlZjM1Mi4uOTQ0ZGMwNmY0NzAxZTAyNjQ4MmYyM2JjNmVhNzNm
OWYyMThiNzVhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTAzLTA3ICBKRiBC
YXN0aWVuICA8amZiYXN0aWVuQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJSVEM6IGRvbid0IGNy
ZWF0ZSBodWdlIHN0YWNrIGJ1ZmZlciBpbiBhIGxvb3AKKworICAgICAgICBUaGUgMTkyMCBieXRl
IGJ1ZmZlciBpcyBwcmV0dHkgYmlnLCBhbmQgdGhlIGxvb3AgaXMgdW5yb2xsZWQgNQorICAgICAg
ICB0aW1lcyBpbiBhIHJlZ3VsYXIgYnVpbGQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0
cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuY3BwOgorICAgICAgICAoV2ViQ29y
ZTo6TGliV2ViUlRDQXVkaW9Nb2R1bGU6OlBvbGxGcm9tU291cmNlKToKKyAgICAgICAgKiBwbGF0
Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuaDoKKwogMjAx
OS0wMy0wNiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAg
ICBNb3ZlIFJlbmRlck9iamVjdDo6aXNUcmFuc3BhcmVudE9yRnVsbHlDbGlwcGVkUmVzcGVjdGlu
Z1BhcmVudEZyYW1lcygpIHRvIFJlbmRlckxheWVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y
ZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuY3Bw
IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJU
Q0F1ZGlvTW9kdWxlLmNwcAppbmRleCBkODhjMzg5MzI0MDA3ZjI1MGUwZTJjOWMwZTc5Y2ZkMWM5
NDU5NDBlLi40OWQzNjJiZmUyOWRiZGFiYjk5NGU5MzA1ODZiYTY5NGM5MjY3YTk1IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2Vi
UlRDQXVkaW9Nb2R1bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry
ZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5jcHAKQEAgLTk1LDExICs5NSwxMyBA
QCB2b2lkIExpYldlYlJUQ0F1ZGlvTW9kdWxlOjpQb2xsRnJvbVNvdXJjZSgpCiAgICAgaWYgKCFt
X2F1ZGlvVHJhbnNwb3J0KQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAoIW1fZGF0YSkKKyAg
ICAgICAgbV9kYXRhID0gbmV3IGNoYXJbYnl0ZXNQZXJTYW1wbGUgKiBjaGFubmVscyAqIHNhbXBs
ZXNQZXJGcmFtZV07CisKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgcG9sbFNhbXBsZXM7
IGkrKykgewogICAgICAgICBpbnQ2NF90IGVsYXBzZWRUaW1lID0gLTE7CiAgICAgICAgIGludDY0
X3QgbnRwVGltZSA9IC0xOwotICAgICAgICBjaGFyIGRhdGFbKGJ5dGVzUGVyU2FtcGxlICogY2hh
bm5lbHMgKiBzYW1wbGVzUGVyRnJhbWUpXTsKLSAgICAgICAgbV9hdWRpb1RyYW5zcG9ydC0+UHVs
bFJlbmRlckRhdGEoYnl0ZXNQZXJTYW1wbGUgKiA4LCBzYW1wbGluZ1JhdGUsIGNoYW5uZWxzLCBz
YW1wbGVzUGVyRnJhbWUsIGRhdGEsICZlbGFwc2VkVGltZSwgJm50cFRpbWUpOworICAgICAgICBt
X2F1ZGlvVHJhbnNwb3J0LT5QdWxsUmVuZGVyRGF0YShieXRlc1BlclNhbXBsZSAqIDgsIHNhbXBs
aW5nUmF0ZSwgY2hhbm5lbHMsIHNhbXBsZXNQZXJGcmFtZSwgbV9kYXRhLCAmZWxhcHNlZFRpbWUs
ICZudHBUaW1lKTsKICAgICB9CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5oIGIvU291cmNl
L1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlvTW9k
dWxlLmgKaW5kZXggYTE1ZjQ4MzBkNjliY2NkMzNiMzUyMTUzNjcyODlkNjdhYTA2YTU4YS4uNDcz
YjBmYjY1YjA1ZmFlNDgwYmUxMzZhNjUzNjc5ZmJlMzBmYTZmMSAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlvTW9k
dWxlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRj
L0xpYldlYlJUQ0F1ZGlvTW9kdWxlLmgKQEAgLTEyOCw2ICsxMjgsNyBAQCBwcml2YXRlOgogICAg
IHZvaWQgUG9sbEZyb21Tb3VyY2UoKTsKIAogICAgIHN0ZDo6dW5pcXVlX3B0cjxydGM6OlRocmVh
ZD4gbV9hdWRpb1Rhc2tSdW5uZXI7CisgICAgc3RkOjp1bmlxdWVfcHRyPGRhdGFbXT4gbV9kYXRh
OwogCiAgICAgYm9vbCBtX2lzUGxheWluZyA9IGZhbHNlOwogICAgIHdlYnJ0Yzo6QXVkaW9UcmFu
c3BvcnQqIG1fYXVkaW9UcmFuc3BvcnQgPSBudWxscHRyOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>363941</attachid>
            <date>2019-03-07 15:27:41 -0800</date>
            <delta_ts>2020-01-31 03:50:35 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>0001-WebRTC-data-buffer.patch</filename>
            <type>text/plain</type>
            <size>2794</size>
            <attacher name="JF Bastien">jfbastien</attacher>
            
              <data encoding="base64">RnJvbSBhYjMwZmM3NjhiNDgxMDIwZTgxMzMwZWQwMDljYTY1M2Q2MWY2MjJmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl
OiBUaHUsIDcgTWFyIDIwMTkgMTQ6Mzk6MTAgLTA4MDAKU3ViamVjdDogW1BBVENIXSBXZWJSVEMg
ZGF0YSBidWZmZXIKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgfCAxMSArKysrKysrKysrKwogLi4uL21lZGlhc3RyZWFtL2xpYndlYnJ0
Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5jcHAgICAgfCAgNiArKysrLS0KIC4uLi9tZWRpYXN0cmVh
bS9saWJ3ZWJydGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuaCAgICAgIHwgIDEgKwogMyBmaWxlcyBj
aGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5
MDEyMTFjOTFlZC4uOTQ0ZGMwNmY0NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAx
OS0wMy0wNyAgSkYgQmFzdGllbiAgPGpmYmFzdGllbkBhcHBsZS5jb20+CisKKyAgICAgICAgV2Vi
UlRDOiBkb24ndCBjcmVhdGUgaHVnZSBzdGFjayBidWZmZXIgaW4gYSBsb29wCisKKyAgICAgICAg
VGhlIDE5MjAgYnl0ZSBidWZmZXIgaXMgcHJldHR5IGJpZywgYW5kIHRoZSBsb29wIGlzIHVucm9s
bGVkIDUKKyAgICAgICAgdGltZXMgaW4gYSByZWd1bGFyIGJ1aWxkLgorCisgICAgICAgICogcGxh
dGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlvTW9kdWxlLmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OkxpYldlYlJUQ0F1ZGlvTW9kdWxlOjpQb2xsRnJvbVNvdXJjZSk6Cisg
ICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlvTW9k
dWxlLmg6CisKIDIwMTktMDMtMDYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5j
b20+CiAKICAgICAgICAgTW92ZSBSZW5kZXJPYmplY3Q6OmlzVHJhbnNwYXJlbnRPckZ1bGx5Q2xp
cHBlZFJlc3BlY3RpbmdQYXJlbnRGcmFtZXMoKSB0byBSZW5kZXJMYXllcgpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1
ZGlvTW9kdWxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndl
YnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5jcHAKaW5kZXggZDg4YzM4OTMyNDAuLjQ5ZDM2MmJm
ZTI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3
ZWJydGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5jcHAKQEAgLTk1
LDExICs5NSwxMyBAQCB2b2lkIExpYldlYlJUQ0F1ZGlvTW9kdWxlOjpQb2xsRnJvbVNvdXJjZSgp
CiAgICAgaWYgKCFtX2F1ZGlvVHJhbnNwb3J0KQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAo
IW1fZGF0YSkKKyAgICAgICAgbV9kYXRhID0gbmV3IGNoYXJbYnl0ZXNQZXJTYW1wbGUgKiBjaGFu
bmVscyAqIHNhbXBsZXNQZXJGcmFtZV07CisKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwg
cG9sbFNhbXBsZXM7IGkrKykgewogICAgICAgICBpbnQ2NF90IGVsYXBzZWRUaW1lID0gLTE7CiAg
ICAgICAgIGludDY0X3QgbnRwVGltZSA9IC0xOwotICAgICAgICBjaGFyIGRhdGFbKGJ5dGVzUGVy
U2FtcGxlICogY2hhbm5lbHMgKiBzYW1wbGVzUGVyRnJhbWUpXTsKLSAgICAgICAgbV9hdWRpb1Ry
YW5zcG9ydC0+UHVsbFJlbmRlckRhdGEoYnl0ZXNQZXJTYW1wbGUgKiA4LCBzYW1wbGluZ1JhdGUs
IGNoYW5uZWxzLCBzYW1wbGVzUGVyRnJhbWUsIGRhdGEsICZlbGFwc2VkVGltZSwgJm50cFRpbWUp
OworICAgICAgICBtX2F1ZGlvVHJhbnNwb3J0LT5QdWxsUmVuZGVyRGF0YShieXRlc1BlclNhbXBs
ZSAqIDgsIHNhbXBsaW5nUmF0ZSwgY2hhbm5lbHMsIHNhbXBsZXNQZXJGcmFtZSwgbV9kYXRhLCAm
ZWxhcHNlZFRpbWUsICZudHBUaW1lKTsKICAgICB9CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVs
ZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldl
YlJUQ0F1ZGlvTW9kdWxlLmgKaW5kZXggYTE1ZjQ4MzBkNjkuLjYxNjgxMTA0ZWRkIDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2Vi
UlRDQXVkaW9Nb2R1bGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVh
bS9saWJ3ZWJydGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuaApAQCAtMTI4LDYgKzEyOCw3IEBAIHBy
aXZhdGU6CiAgICAgdm9pZCBQb2xsRnJvbVNvdXJjZSgpOwogCiAgICAgc3RkOjp1bmlxdWVfcHRy
PHJ0Yzo6VGhyZWFkPiBtX2F1ZGlvVGFza1J1bm5lcjsKKyAgICBzdGQ6OnVuaXF1ZV9wdHI8Y2hh
cltdPiBtX2RhdGE7CiAKICAgICBib29sIG1faXNQbGF5aW5nID0gZmFsc2U7CiAgICAgd2VicnRj
OjpBdWRpb1RyYW5zcG9ydCogbV9hdWRpb1RyYW5zcG9ydCA9IG51bGxwdHI7Ci0tIAoyLjE3LjAK
Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>363947</attachid>
            <date>2019-03-07 16:13:48 -0800</date>
            <delta_ts>2019-03-07 16:40:44 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>0001-WebRTC-data-buffer.patch</filename>
            <type>text/plain</type>
            <size>2799</size>
            <attacher name="JF Bastien">jfbastien</attacher>
            
              <data encoding="base64">RnJvbSAxYzZhZTMwMzJiNGYyMzRlOTkzMTU2ZTRlMjY1M2ViZTA1NGY4NjQwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl
OiBUaHUsIDcgTWFyIDIwMTkgMTQ6Mzk6MTAgLTA4MDAKU3ViamVjdDogW1BBVENIXSBXZWJSVEMg
ZGF0YSBidWZmZXIKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgfCAxMSArKysrKysrKysrKwogLi4uL21lZGlhc3RyZWFtL2xpYndlYnJ0
Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5jcHAgICAgfCAgNiArKysrLS0KIC4uLi9tZWRpYXN0cmVh
bS9saWJ3ZWJydGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuaCAgICAgIHwgIDEgKwogMyBmaWxlcyBj
aGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5
MDEyMTFjOTFlZC4uOTQ0ZGMwNmY0NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAx
OS0wMy0wNyAgSkYgQmFzdGllbiAgPGpmYmFzdGllbkBhcHBsZS5jb20+CisKKyAgICAgICAgV2Vi
UlRDOiBkb24ndCBjcmVhdGUgaHVnZSBzdGFjayBidWZmZXIgaW4gYSBsb29wCisKKyAgICAgICAg
VGhlIDE5MjAgYnl0ZSBidWZmZXIgaXMgcHJldHR5IGJpZywgYW5kIHRoZSBsb29wIGlzIHVucm9s
bGVkIDUKKyAgICAgICAgdGltZXMgaW4gYSByZWd1bGFyIGJ1aWxkLgorCisgICAgICAgICogcGxh
dGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlvTW9kdWxlLmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OkxpYldlYlJUQ0F1ZGlvTW9kdWxlOjpQb2xsRnJvbVNvdXJjZSk6Cisg
ICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlvTW9k
dWxlLmg6CisKIDIwMTktMDMtMDYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5j
b20+CiAKICAgICAgICAgTW92ZSBSZW5kZXJPYmplY3Q6OmlzVHJhbnNwYXJlbnRPckZ1bGx5Q2xp
cHBlZFJlc3BlY3RpbmdQYXJlbnRGcmFtZXMoKSB0byBSZW5kZXJMYXllcgpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1
ZGlvTW9kdWxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndl
YnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5jcHAKaW5kZXggZDg4YzM4OTMyNDAuLmU1OTA3ODNi
NTgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3
ZWJydGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5jcHAKQEAgLTk1
LDExICs5NSwxMyBAQCB2b2lkIExpYldlYlJUQ0F1ZGlvTW9kdWxlOjpQb2xsRnJvbVNvdXJjZSgp
CiAgICAgaWYgKCFtX2F1ZGlvVHJhbnNwb3J0KQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAo
IW1fZGF0YSkKKyAgICAgICAgbV9kYXRhLnJlc2V0KG5ldyBjaGFyW2J5dGVzUGVyU2FtcGxlICog
Y2hhbm5lbHMgKiBzYW1wbGVzUGVyRnJhbWVdKTsKKwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7
IGkgPCBwb2xsU2FtcGxlczsgaSsrKSB7CiAgICAgICAgIGludDY0X3QgZWxhcHNlZFRpbWUgPSAt
MTsKICAgICAgICAgaW50NjRfdCBudHBUaW1lID0gLTE7Ci0gICAgICAgIGNoYXIgZGF0YVsoYnl0
ZXNQZXJTYW1wbGUgKiBjaGFubmVscyAqIHNhbXBsZXNQZXJGcmFtZSldOwotICAgICAgICBtX2F1
ZGlvVHJhbnNwb3J0LT5QdWxsUmVuZGVyRGF0YShieXRlc1BlclNhbXBsZSAqIDgsIHNhbXBsaW5n
UmF0ZSwgY2hhbm5lbHMsIHNhbXBsZXNQZXJGcmFtZSwgZGF0YSwgJmVsYXBzZWRUaW1lLCAmbnRw
VGltZSk7CisgICAgICAgIG1fYXVkaW9UcmFuc3BvcnQtPlB1bGxSZW5kZXJEYXRhKGJ5dGVzUGVy
U2FtcGxlICogOCwgc2FtcGxpbmdSYXRlLCBjaGFubmVscywgc2FtcGxlc1BlckZyYW1lLCBtX2Rh
dGEsICZlbGFwc2VkVGltZSwgJm50cFRpbWUpOwogICAgIH0KIH0KIApkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlv
TW9kdWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMv
TGliV2ViUlRDQXVkaW9Nb2R1bGUuaAppbmRleCBhMTVmNDgzMGQ2OS4uNjE2ODExMDRlZGQgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9M
aWJXZWJSVENBdWRpb01vZHVsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlh
c3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5oCkBAIC0xMjgsNiArMTI4LDcg
QEAgcHJpdmF0ZToKICAgICB2b2lkIFBvbGxGcm9tU291cmNlKCk7CiAKICAgICBzdGQ6OnVuaXF1
ZV9wdHI8cnRjOjpUaHJlYWQ+IG1fYXVkaW9UYXNrUnVubmVyOworICAgIHN0ZDo6dW5pcXVlX3B0
cjxjaGFyW10+IG1fZGF0YTsKIAogICAgIGJvb2wgbV9pc1BsYXlpbmcgPSBmYWxzZTsKICAgICB3
ZWJydGM6OkF1ZGlvVHJhbnNwb3J0KiBtX2F1ZGlvVHJhbnNwb3J0ID0gbnVsbHB0cjsKLS0gCjIu
MTcuMAoK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>363957</attachid>
            <date>2019-03-07 16:40:44 -0800</date>
            <delta_ts>2019-03-07 16:51:36 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>0001-WebRTC-data-buffer.patch</filename>
            <type>text/plain</type>
            <size>2805</size>
            <attacher name="JF Bastien">jfbastien</attacher>
            
              <data encoding="base64">RnJvbSBkYzM1M2Y4ZWJkNmQ2NzMyMTU2ZTQ4M2U3MzFkNThkYjljYTViY2QwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl
OiBUaHUsIDcgTWFyIDIwMTkgMTQ6Mzk6MTAgLTA4MDAKU3ViamVjdDogW1BBVENIXSBXZWJSVEMg
ZGF0YSBidWZmZXIKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgfCAxMSArKysrKysrKysrKwogLi4uL21lZGlhc3RyZWFtL2xpYndlYnJ0
Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5jcHAgICAgfCAgNiArKysrLS0KIC4uLi9tZWRpYXN0cmVh
bS9saWJ3ZWJydGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuaCAgICAgIHwgIDEgKwogMyBmaWxlcyBj
aGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5
MDEyMTFjOTFlZC4uOTQ0ZGMwNmY0NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAx
OS0wMy0wNyAgSkYgQmFzdGllbiAgPGpmYmFzdGllbkBhcHBsZS5jb20+CisKKyAgICAgICAgV2Vi
UlRDOiBkb24ndCBjcmVhdGUgaHVnZSBzdGFjayBidWZmZXIgaW4gYSBsb29wCisKKyAgICAgICAg
VGhlIDE5MjAgYnl0ZSBidWZmZXIgaXMgcHJldHR5IGJpZywgYW5kIHRoZSBsb29wIGlzIHVucm9s
bGVkIDUKKyAgICAgICAgdGltZXMgaW4gYSByZWd1bGFyIGJ1aWxkLgorCisgICAgICAgICogcGxh
dGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlvTW9kdWxlLmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OkxpYldlYlJUQ0F1ZGlvTW9kdWxlOjpQb2xsRnJvbVNvdXJjZSk6Cisg
ICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlvTW9k
dWxlLmg6CisKIDIwMTktMDMtMDYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5j
b20+CiAKICAgICAgICAgTW92ZSBSZW5kZXJPYmplY3Q6OmlzVHJhbnNwYXJlbnRPckZ1bGx5Q2xp
cHBlZFJlc3BlY3RpbmdQYXJlbnRGcmFtZXMoKSB0byBSZW5kZXJMYXllcgpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1
ZGlvTW9kdWxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndl
YnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5jcHAKaW5kZXggZDg4YzM4OTMyNDAuLjZiNzU0MWI1
OGZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3
ZWJydGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5jcHAKQEAgLTk1
LDExICs5NSwxMyBAQCB2b2lkIExpYldlYlJUQ0F1ZGlvTW9kdWxlOjpQb2xsRnJvbVNvdXJjZSgp
CiAgICAgaWYgKCFtX2F1ZGlvVHJhbnNwb3J0KQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAo
IW1fZGF0YSkKKyAgICAgICAgbV9kYXRhLnJlc2V0KG5ldyBjaGFyW2J5dGVzUGVyU2FtcGxlICog
Y2hhbm5lbHMgKiBzYW1wbGVzUGVyRnJhbWVdKTsKKwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7
IGkgPCBwb2xsU2FtcGxlczsgaSsrKSB7CiAgICAgICAgIGludDY0X3QgZWxhcHNlZFRpbWUgPSAt
MTsKICAgICAgICAgaW50NjRfdCBudHBUaW1lID0gLTE7Ci0gICAgICAgIGNoYXIgZGF0YVsoYnl0
ZXNQZXJTYW1wbGUgKiBjaGFubmVscyAqIHNhbXBsZXNQZXJGcmFtZSldOwotICAgICAgICBtX2F1
ZGlvVHJhbnNwb3J0LT5QdWxsUmVuZGVyRGF0YShieXRlc1BlclNhbXBsZSAqIDgsIHNhbXBsaW5n
UmF0ZSwgY2hhbm5lbHMsIHNhbXBsZXNQZXJGcmFtZSwgZGF0YSwgJmVsYXBzZWRUaW1lLCAmbnRw
VGltZSk7CisgICAgICAgIG1fYXVkaW9UcmFuc3BvcnQtPlB1bGxSZW5kZXJEYXRhKGJ5dGVzUGVy
U2FtcGxlICogOCwgc2FtcGxpbmdSYXRlLCBjaGFubmVscywgc2FtcGxlc1BlckZyYW1lLCBtX2Rh
dGEuZ2V0KCksICZlbGFwc2VkVGltZSwgJm50cFRpbWUpOwogICAgIH0KIH0KIApkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJU
Q0F1ZGlvTW9kdWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3
ZWJydGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuaAppbmRleCBhMTVmNDgzMGQ2OS4uNjE2ODExMDRl
ZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndl
YnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5oCkBAIC0xMjgsNiAr
MTI4LDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIFBvbGxGcm9tU291cmNlKCk7CiAKICAgICBzdGQ6
OnVuaXF1ZV9wdHI8cnRjOjpUaHJlYWQ+IG1fYXVkaW9UYXNrUnVubmVyOworICAgIHN0ZDo6dW5p
cXVlX3B0cjxjaGFyW10+IG1fZGF0YTsKIAogICAgIGJvb2wgbV9pc1BsYXlpbmcgPSBmYWxzZTsK
ICAgICB3ZWJydGM6OkF1ZGlvVHJhbnNwb3J0KiBtX2F1ZGlvVHJhbnNwb3J0ID0gbnVsbHB0cjsK
LS0gCjIuMTcuMAoK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>363958</attachid>
            <date>2019-03-07 16:51:36 -0800</date>
            <delta_ts>2019-03-07 17:05:28 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>0001-WebRTC-data-buffer.patch</filename>
            <type>text/plain</type>
            <size>2875</size>
            <attacher name="JF Bastien">jfbastien</attacher>
            
              <data encoding="base64">RnJvbSA2NjUwNjYyMjIxNjhmNTFhY2UyYTQ1MWM3NzlmZTBkYTc4ZGE0NDEwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl
OiBUaHUsIDcgTWFyIDIwMTkgMTQ6Mzk6MTAgLTA4MDAKU3ViamVjdDogW1BBVENIXSBXZWJSVEMg
ZGF0YSBidWZmZXIKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICB8IDEyICsrKysrKysrKysrKwogLi4uL21lZGlhc3RyZWFtL2xpYndlYnJ0
Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5jcHAgICB8ICA2ICsrKystLQogLi4uL21lZGlhc3RyZWFt
L2xpYndlYnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5oICAgICB8ICAxICsKIDMgZmlsZXMgY2hh
bmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTAx
MjExYzkxZWQuLjQwN2Q1ZjkwM2U5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM
b2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTkt
MDMtMDcgIEpGIEJhc3RpZW4gIDxqZmJhc3RpZW5AYXBwbGUuY29tPgorCisgICAgICAgIFdlYlJU
QzogZG9uJ3QgY3JlYXRlIGh1Z2Ugc3RhY2sgYnVmZmVyIGluIGEgbG9vcAorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1NDM2CisKKyAgICAgICAgVGhl
IDE5MjAgYnl0ZSBidWZmZXIgaXMgcHJldHR5IGJpZywgYW5kIHRoZSBsb29wIGlzIHVucm9sbGVk
IDUKKyAgICAgICAgdGltZXMgaW4gYSByZWd1bGFyIGJ1aWxkLgorCisgICAgICAgICogcGxhdGZv
cm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlvTW9kdWxlLmNwcDoKKyAgICAg
ICAgKFdlYkNvcmU6OkxpYldlYlJUQ0F1ZGlvTW9kdWxlOjpQb2xsRnJvbVNvdXJjZSk6CisgICAg
ICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlvTW9kdWxl
Lmg6CisKIDIwMTktMDMtMDYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+
CiAKICAgICAgICAgTW92ZSBSZW5kZXJPYmplY3Q6OmlzVHJhbnNwYXJlbnRPckZ1bGx5Q2xpcHBl
ZFJlc3BlY3RpbmdQYXJlbnRGcmFtZXMoKSB0byBSZW5kZXJMYXllcgpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlv
TW9kdWxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0
Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5jcHAKaW5kZXggZDg4YzM4OTMyNDAuLjQ4MjczYjZkZTBh
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJy
dGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5jcHAKQEAgLTk1LDEx
ICs5NSwxMyBAQCB2b2lkIExpYldlYlJUQ0F1ZGlvTW9kdWxlOjpQb2xsRnJvbVNvdXJjZSgpCiAg
ICAgaWYgKCFtX2F1ZGlvVHJhbnNwb3J0KQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAoIW1f
ZGF0YSkKKyAgICAgICAgbV9kYXRhLnJlc2V0KHN0ZDo6bWFrZV91bmlxdWU8Y2hhcltdPihieXRl
c1BlclNhbXBsZSAqIGNoYW5uZWxzICogc2FtcGxlc1BlckZyYW1lKSk7CisKICAgICBmb3IgKHVu
c2lnbmVkIGkgPSAwOyBpIDwgcG9sbFNhbXBsZXM7IGkrKykgewogICAgICAgICBpbnQ2NF90IGVs
YXBzZWRUaW1lID0gLTE7CiAgICAgICAgIGludDY0X3QgbnRwVGltZSA9IC0xOwotICAgICAgICBj
aGFyIGRhdGFbKGJ5dGVzUGVyU2FtcGxlICogY2hhbm5lbHMgKiBzYW1wbGVzUGVyRnJhbWUpXTsK
LSAgICAgICAgbV9hdWRpb1RyYW5zcG9ydC0+UHVsbFJlbmRlckRhdGEoYnl0ZXNQZXJTYW1wbGUg
KiA4LCBzYW1wbGluZ1JhdGUsIGNoYW5uZWxzLCBzYW1wbGVzUGVyRnJhbWUsIGRhdGEsICZlbGFw
c2VkVGltZSwgJm50cFRpbWUpOworICAgICAgICBtX2F1ZGlvVHJhbnNwb3J0LT5QdWxsUmVuZGVy
RGF0YShieXRlc1BlclNhbXBsZSAqIDgsIHNhbXBsaW5nUmF0ZSwgY2hhbm5lbHMsIHNhbXBsZXNQ
ZXJGcmFtZSwgbV9kYXRhLmdldCgpLCAmZWxhcHNlZFRpbWUsICZudHBUaW1lKTsKICAgICB9CiB9
CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndl
YnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVk
aWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlvTW9kdWxlLmgKaW5kZXggYTE1ZjQ4MzBk
NjkuLjYxNjgxMTA0ZWRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRp
YXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuaAorKysgYi9Tb3VyY2UvV2Vi
Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUu
aApAQCAtMTI4LDYgKzEyOCw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBQb2xsRnJvbVNvdXJjZSgp
OwogCiAgICAgc3RkOjp1bmlxdWVfcHRyPHJ0Yzo6VGhyZWFkPiBtX2F1ZGlvVGFza1J1bm5lcjsK
KyAgICBzdGQ6OnVuaXF1ZV9wdHI8Y2hhcltdPiBtX2RhdGE7CiAKICAgICBib29sIG1faXNQbGF5
aW5nID0gZmFsc2U7CiAgICAgd2VicnRjOjpBdWRpb1RyYW5zcG9ydCogbV9hdWRpb1RyYW5zcG9y
dCA9IG51bGxwdHI7Ci0tIAoyLjE3LjAKCg==
</data>
<flag name="review"
          id="380522"
          type_id="1"
          status="+"
          setter="youennf"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>363960</attachid>
            <date>2019-03-07 17:05:28 -0800</date>
            <delta_ts>2022-02-28 03:29:23 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>0001-WebRTC-data-buffer.patch</filename>
            <type>text/plain</type>
            <size>2870</size>
            <attacher name="JF Bastien">jfbastien</attacher>
            
              <data encoding="base64">RnJvbSAxNWM4ODY3YTZlNjMyYWQxMGE0MmFiMjYzNWVjZWEyMTVlM2FkMWU5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl
OiBUaHUsIDcgTWFyIDIwMTkgMTQ6Mzk6MTAgLTA4MDAKU3ViamVjdDogW1BBVENIXSBXZWJSVEMg
ZGF0YSBidWZmZXIKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICB8IDEyICsrKysrKysrKysrKwogLi4uL21lZGlhc3RyZWFtL2xpYndlYnJ0
Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5jcHAgICB8ICA2ICsrKystLQogLi4uL21lZGlhc3RyZWFt
L2xpYndlYnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5oICAgICB8ICAxICsKIDMgZmlsZXMgY2hh
bmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTAx
MjExYzkxZWQuLjQwN2Q1ZjkwM2U5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM
b2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTkt
MDMtMDcgIEpGIEJhc3RpZW4gIDxqZmJhc3RpZW5AYXBwbGUuY29tPgorCisgICAgICAgIFdlYlJU
QzogZG9uJ3QgY3JlYXRlIGh1Z2Ugc3RhY2sgYnVmZmVyIGluIGEgbG9vcAorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1NDM2CisKKyAgICAgICAgVGhl
IDE5MjAgYnl0ZSBidWZmZXIgaXMgcHJldHR5IGJpZywgYW5kIHRoZSBsb29wIGlzIHVucm9sbGVk
IDUKKyAgICAgICAgdGltZXMgaW4gYSByZWd1bGFyIGJ1aWxkLgorCisgICAgICAgICogcGxhdGZv
cm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlvTW9kdWxlLmNwcDoKKyAgICAg
ICAgKFdlYkNvcmU6OkxpYldlYlJUQ0F1ZGlvTW9kdWxlOjpQb2xsRnJvbVNvdXJjZSk6CisgICAg
ICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlvTW9kdWxl
Lmg6CisKIDIwMTktMDMtMDYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+
CiAKICAgICAgICAgTW92ZSBSZW5kZXJPYmplY3Q6OmlzVHJhbnNwYXJlbnRPckZ1bGx5Q2xpcHBl
ZFJlc3BlY3RpbmdQYXJlbnRGcmFtZXMoKSB0byBSZW5kZXJMYXllcgpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlv
TW9kdWxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0
Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5jcHAKaW5kZXggZDg4YzM4OTMyNDAuLmYxNDM1M2MzNzFk
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJy
dGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5jcHAKQEAgLTk1LDEx
ICs5NSwxMyBAQCB2b2lkIExpYldlYlJUQ0F1ZGlvTW9kdWxlOjpQb2xsRnJvbVNvdXJjZSgpCiAg
ICAgaWYgKCFtX2F1ZGlvVHJhbnNwb3J0KQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAoIW1f
ZGF0YSkKKyAgICAgICAgbV9kYXRhID0gc3RkOjptYWtlX3VuaXF1ZTxjaGFyW10+KGJ5dGVzUGVy
U2FtcGxlICogY2hhbm5lbHMgKiBzYW1wbGVzUGVyRnJhbWUpOworCiAgICAgZm9yICh1bnNpZ25l
ZCBpID0gMDsgaSA8IHBvbGxTYW1wbGVzOyBpKyspIHsKICAgICAgICAgaW50NjRfdCBlbGFwc2Vk
VGltZSA9IC0xOwogICAgICAgICBpbnQ2NF90IG50cFRpbWUgPSAtMTsKLSAgICAgICAgY2hhciBk
YXRhWyhieXRlc1BlclNhbXBsZSAqIGNoYW5uZWxzICogc2FtcGxlc1BlckZyYW1lKV07Ci0gICAg
ICAgIG1fYXVkaW9UcmFuc3BvcnQtPlB1bGxSZW5kZXJEYXRhKGJ5dGVzUGVyU2FtcGxlICogOCwg
c2FtcGxpbmdSYXRlLCBjaGFubmVscywgc2FtcGxlc1BlckZyYW1lLCBkYXRhLCAmZWxhcHNlZFRp
bWUsICZudHBUaW1lKTsKKyAgICAgICAgbV9hdWRpb1RyYW5zcG9ydC0+UHVsbFJlbmRlckRhdGEo
Ynl0ZXNQZXJTYW1wbGUgKiA4LCBzYW1wbGluZ1JhdGUsIGNoYW5uZWxzLCBzYW1wbGVzUGVyRnJh
bWUsIG1fZGF0YS5nZXQoKSwgJmVsYXBzZWRUaW1lLCAmbnRwVGltZSk7CiAgICAgfQogfQogCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMv
TGliV2ViUlRDQXVkaW9Nb2R1bGUuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry
ZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5oCmluZGV4IGExNWY0ODMwZDY5Li42
MTY4MTEwNGVkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJl
YW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlvTW9kdWxlLmgKKysrIGIvU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0F1ZGlvTW9kdWxlLmgKQEAg
LTEyOCw2ICsxMjgsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgUG9sbEZyb21Tb3VyY2UoKTsKIAog
ICAgIHN0ZDo6dW5pcXVlX3B0cjxydGM6OlRocmVhZD4gbV9hdWRpb1Rhc2tSdW5uZXI7CisgICAg
c3RkOjp1bmlxdWVfcHRyPGNoYXJbXT4gbV9kYXRhOwogCiAgICAgYm9vbCBtX2lzUGxheWluZyA9
IGZhbHNlOwogICAgIHdlYnJ0Yzo6QXVkaW9UcmFuc3BvcnQqIG1fYXVkaW9UcmFuc3BvcnQgPSBu
dWxscHRyOwotLSAKMi4xNy4wCgo=
</data>
<flag name="review"
          id="380524"
          type_id="1"
          status="-"
          setter="achristensen"
    />
          </attachment>
      

    </bug>

</bugzilla>