195410 2019-03-07 08:00:27 -0800 REGRESSION(r242364): [WPE] Do not stop the compositing run loop update timer on suspend 2019-03-07 09:18:19 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned commit-queue webkit-bug-importer zan oldest_to_newest 1513502 0 cgarcia 2019-03-07 08:00:27 -0800 Calling CompositingRunLoop::stopUpdates() on suspend is leaving the threaded compositor in an inconsistent state, failing to resume and stopping the updates forever. This is causing timeouts in WPE layout tests. 1513503 1 363874 cgarcia 2019-03-07 08:05:58 -0800 Created attachment 363874 Patch 1513532 2 363874 commit-queue 2019-03-07 09:17:22 -0800 Comment on attachment 363874 Patch Clearing flags on attachment: 363874 Committed r242597: <https://trac.webkit.org/changeset/242597> 1513533 3 commit-queue 2019-03-07 09:17:24 -0800 All reviewed patches have been landed. Closing bug. 1513534 4 webkit-bug-importer 2019-03-07 09:18:19 -0800 <rdar://problem/48677179> 363874 2019-03-07 08:05:58 -0800 2019-03-07 09:17:22 -0800 Patch wpe-compositing-loop-pause.diff text/plain 6436 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMTU2ODExNzZmYzIuLmY4YzM2MWNmMjRjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDI4IEBACisyMDE5LTAzLTA3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNDIzNjQpOiBbV1BFXSBEbyBub3Qgc3RvcCB0 aGUgY29tcG9zaXRpbmcgcnVuIGxvb3AgdXBkYXRlIHRpbWVyIG9uIHN1c3BlbmQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTQxMAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGxpbmcgQ29tcG9zaXRp bmdSdW5Mb29wOjpzdG9wVXBkYXRlcygpIG9uIHN1c3BlbmQgaXMgbGVhdmluZyB0aGUgdGhyZWFk ZWQgY29tcG9zaXRvciBpbiBhbiBpbmNvbnNpc3RlbnQKKyAgICAgICAgc3RhdGUsIGZhaWxpbmcg dG8gcmVzdW1lIGFuZCBzdG9wcGluZyB0aGUgdXBkYXRlcyBmb3JldmVyLiBUaGlzIGlzIGNhdXNp bmcgdGltZW91dHMgaW4gV1BFIGxheW91dCB0ZXN0cy4gSW5zdGVhZAorICAgICAgICBvZiBjYWxs aW5nIHN0b3BVcGRhdGVzKCksIGEgbmV3IHN1c3BlbmQoKSBpcyBjYWxsZWQsIHRoYXQgc3RvcHMg dGhlIHVwZGF0ZSB0aW1lciwgd2l0aG91dCBjaGFuZ2luZyB0aGUgY3VycmVudAorICAgICAgICB1 cGRhZSB0aGEgY29tcG9zaXRpbmcgc3RhdGUuIEEgbmV3IG1ldGhvZCByZXN1bWUoKSBpcyBhbHNv IGFkZGVkIHRvIHNjaGVkdWxlIGFuIHVwZGF0ZSBpZiBuZWVkZWQuCisKKyAgICAgICAgKiBTaGFy ZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy90aHJlYWRlZGNvbXBvc2l0b3IvQ29tcG9zaXRpbmdSdW5M b29wLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29tcG9zaXRpbmdSdW5Mb29wOjpzdXNwZW5kKTog U2V0IHN0YXRlIGFzIHN1c3BlbmRlZCBhbmQgc3RvcCB0aGUgdXBkYXRlIHRpbWVyLgorICAgICAg ICAoV2ViS2l0OjpDb21wb3NpdGluZ1J1bkxvb3A6OnJlc3VtZSk6IFNldCBzdGF0ZSBhcyBub3Qg c3VzcGVuZGVkIGFuZCBzdGFydCB0aGUgdXBkYXRlIHRpbWVyIGlmIGl0IHdhcyBzY2hlZHVsZWQK KyAgICAgICAgd2hpbGUgc3VzcGVuZGVkLgorICAgICAgICAoV2ViS2l0OjpDb21wb3NpdGluZ1J1 bkxvb3A6OnNjaGVkdWxlVXBkYXRlKTogRG8gbm90IHN0YXJ0IHRoZSB1cGRhdGUgdGltZXIgd2hl biBzdXNwZW5kZWQuCisgICAgICAgIChXZWJLaXQ6OkNvbXBvc2l0aW5nUnVuTG9vcDo6Y29tcG9z aXRpb25Db21wbGV0ZWQpOiBEaXR0by4KKyAgICAgICAgKFdlYktpdDo6Q29tcG9zaXRpbmdSdW5M b29wOjp1cGRhdGVDb21wbGV0ZWQpOiBEaXR0by4KKyAgICAgICAgKFdlYktpdDo6Q29tcG9zaXRp bmdSdW5Mb29wOjp1cGRhdGVUaW1lckZpcmVkKTogQWRkIGFuIGFzc2VydCB0byBlbnN1cmUgdGhl IHVwZGF0ZSB0aW1lciBpcyBub3QgZmlyZWQgd2hpbGUgc3VzcGVuZGVkLgorICAgICAgICAqIFNo YXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL3RocmVhZGVkY29tcG9zaXRvci9Db21wb3NpdGluZ1J1 bkxvb3AuaDoKKyAgICAgICAgKiBTaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy90aHJlYWRlZGNv bXBvc2l0b3IvVGhyZWFkZWRDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYktpdDo6VGhyZWFk ZWRDb21wb3NpdG9yOjpzdXNwZW5kKTogQ2FsbCBDb21wb3NpdGluZ1J1bkxvb3A6OnN1c3BlbmQo KSBpbnN0ZWFkIG9mIHN0b3BVcGRhdGVzKCkuCisgICAgICAgIChXZWJLaXQ6OlRocmVhZGVkQ29t cG9zaXRvcjo6cmVzdW1lKTogQ2FsbCBDb21wb3NpdGluZ1J1bkxvb3A6OnJlc3VtZSgpLgorCiAy MDE5LTAzLTA2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBFeGNl cHRpb24gaXMgYSBKU0NlbGwsIG5vdCBhIEpTT2JqZWN0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy90aHJlYWRlZGNvbXBvc2l0b3IvQ29tcG9z aXRpbmdSdW5Mb29wLmNwcCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhp Y3MvdGhyZWFkZWRjb21wb3NpdG9yL0NvbXBvc2l0aW5nUnVuTG9vcC5jcHAKaW5kZXggYjg4MmUw YjFkNjMuLjg3YzZlZTg2MjdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db29y ZGluYXRlZEdyYXBoaWNzL3RocmVhZGVkY29tcG9zaXRvci9Db21wb3NpdGluZ1J1bkxvb3AuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvdGhyZWFkZWRj b21wb3NpdG9yL0NvbXBvc2l0aW5nUnVuTG9vcC5jcHAKQEAgLTk0LDYgKzk0LDIxIEBAIHZvaWQg Q29tcG9zaXRpbmdSdW5Mb29wOjpwZXJmb3JtVGFza1N5bmMoRnVuY3Rpb248dm9pZCAoKT4mJiBm dW5jdGlvbikKICAgICBtX2Rpc3BhdGNoU3luY0NvbmRpdGlvbi53YWl0KG1fZGlzcGF0Y2hTeW5j Q29uZGl0aW9uTXV0ZXgpOwogfQogCit2b2lkIENvbXBvc2l0aW5nUnVuTG9vcDo6c3VzcGVuZCgp Cit7CisgICAgTG9ja0hvbGRlciBzdGF0ZUxvY2tlcihtX3N0YXRlLmxvY2spOworICAgIG1fc3Rh dGUuaXNTdXNwZW5kZWQgPSB0cnVlOworICAgIG1fdXBkYXRlVGltZXIuc3RvcCgpOworfQorCit2 b2lkIENvbXBvc2l0aW5nUnVuTG9vcDo6cmVzdW1lKCkKK3sKKyAgICBMb2NrSG9sZGVyIHN0YXRl TG9ja2VyKG1fc3RhdGUubG9jayk7CisgICAgbV9zdGF0ZS5pc1N1c3BlbmRlZCA9IGZhbHNlOwor ICAgIGlmIChtX3N0YXRlLnVwZGF0ZSA9PSBVcGRhdGVTdGF0ZTo6U2NoZWR1bGVkKQorICAgICAg ICBtX3VwZGF0ZVRpbWVyLnN0YXJ0T25lU2hvdCgwX3MpOworfQorCiB2b2lkIENvbXBvc2l0aW5n UnVuTG9vcDo6c2NoZWR1bGVVcGRhdGUoKQogewogICAgIExvY2tIb2xkZXIgc3RhdGVMb2NrZXIo bV9zdGF0ZS5sb2NrKTsKQEAgLTExMyw3ICsxMjgsOCBAQCB2b2lkIENvbXBvc2l0aW5nUnVuTG9v cDo6c2NoZWR1bGVVcGRhdGUoTG9ja0hvbGRlciYgc3RhdGVMb2NrZXIpCiAgICAgc3dpdGNoICht X3N0YXRlLnVwZGF0ZSkgewogICAgIGNhc2UgVXBkYXRlU3RhdGU6OklkbGU6CiAgICAgICAgIG1f c3RhdGUudXBkYXRlID0gVXBkYXRlU3RhdGU6OlNjaGVkdWxlZDsKLSAgICAgICAgbV91cGRhdGVU aW1lci5zdGFydE9uZVNob3QoMF9zKTsKKyAgICAgICAgaWYgKCFtX3N0YXRlLmlzU3VzcGVuZGVk KQorICAgICAgICAgICAgbV91cGRhdGVUaW1lci5zdGFydE9uZVNob3QoMF9zKTsKICAgICAgICAg cmV0dXJuOwogICAgIGNhc2UgVXBkYXRlU3RhdGU6OlNjaGVkdWxlZDoKICAgICAgICAgcmV0dXJu OwpAQCAtMTU2LDcgKzE3Miw4IEBAIHZvaWQgQ29tcG9zaXRpbmdSdW5Mb29wOjpjb21wb3NpdGlv bkNvbXBsZXRlZChMb2NrSG9sZGVyJiBzdGF0ZUxvY2tlcikKICAgICAgICAgaWYgKG1fc3RhdGUu cGVuZGluZ1VwZGF0ZSkgewogICAgICAgICAgICAgbV9zdGF0ZS5wZW5kaW5nVXBkYXRlID0gZmFs c2U7CiAgICAgICAgICAgICBtX3N0YXRlLnVwZGF0ZSA9IFVwZGF0ZVN0YXRlOjpTY2hlZHVsZWQ7 Ci0gICAgICAgICAgICBtX3VwZGF0ZVRpbWVyLnN0YXJ0T25lU2hvdCgwX3MpOworICAgICAgICAg ICAgaWYgKCFtX3N0YXRlLmlzU3VzcGVuZGVkKQorICAgICAgICAgICAgICAgIG1fdXBkYXRlVGlt ZXIuc3RhcnRPbmVTaG90KDBfcyk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIApA QCAtMTg4LDcgKzIwNSw4IEBAIHZvaWQgQ29tcG9zaXRpbmdSdW5Mb29wOjp1cGRhdGVDb21wbGV0 ZWQoTG9ja0hvbGRlciYgc3RhdGVMb2NrZXIpCiAgICAgICAgIGlmIChtX3N0YXRlLnBlbmRpbmdV cGRhdGUpIHsKICAgICAgICAgICAgIG1fc3RhdGUucGVuZGluZ1VwZGF0ZSA9IGZhbHNlOwogICAg ICAgICAgICAgbV9zdGF0ZS51cGRhdGUgPSBVcGRhdGVTdGF0ZTo6U2NoZWR1bGVkOwotICAgICAg ICAgICAgbV91cGRhdGVUaW1lci5zdGFydE9uZVNob3QoMF9zKTsKKyAgICAgICAgICAgIGlmICgh bV9zdGF0ZS5pc1N1c3BlbmRlZCkKKyAgICAgICAgICAgICAgICBtX3VwZGF0ZVRpbWVyLnN0YXJ0 T25lU2hvdCgwX3MpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKQEAgLTIwNCw2 ICsyMjIsNyBAQCB2b2lkIENvbXBvc2l0aW5nUnVuTG9vcDo6dXBkYXRlVGltZXJGaXJlZCgpCiAg ICAgewogICAgICAgICAvLyBCb3RoIGNvbXBvc2l0aW9uIGFuZCBzY2VuZSB1cGRhdGUgYXJlIG5v dyBpbiBwcm9ncmVzcy4KICAgICAgICAgTG9ja0hvbGRlciBsb2NrZXIobV9zdGF0ZS5sb2NrKTsK KyAgICAgICAgQVNTRVJUKCFtX3N0YXRlLmlzU3VzcGVuZGVkKTsKICAgICAgICAgbV9zdGF0ZS5j b21wb3NpdGlvbiA9IENvbXBvc2l0aW9uU3RhdGU6OkluUHJvZ3Jlc3M7CiAgICAgICAgIG1fc3Rh dGUudXBkYXRlID0gVXBkYXRlU3RhdGU6OkluUHJvZ3Jlc3M7CiAgICAgfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy90aHJlYWRlZGNvbXBvc2l0 b3IvQ29tcG9zaXRpbmdSdW5Mb29wLmggYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db29yZGluYXRl ZEdyYXBoaWNzL3RocmVhZGVkY29tcG9zaXRvci9Db21wb3NpdGluZ1J1bkxvb3AuaAppbmRleCA4 M2RjMDRkMTk4NS4uNDkxNjI4MjZkMWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVk L0Nvb3JkaW5hdGVkR3JhcGhpY3MvdGhyZWFkZWRjb21wb3NpdG9yL0NvbXBvc2l0aW5nUnVuTG9v cC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvdGhyZWFk ZWRjb21wb3NpdG9yL0NvbXBvc2l0aW5nUnVuTG9vcC5oCkBAIC00Nyw2ICs0Nyw5IEBAIHB1Ymxp YzoKICAgICB2b2lkIHBlcmZvcm1UYXNrKEZ1bmN0aW9uPHZvaWQgKCk+JiYpOwogICAgIHZvaWQg cGVyZm9ybVRhc2tTeW5jKEZ1bmN0aW9uPHZvaWQgKCk+JiYpOwogCisgICAgdm9pZCBzdXNwZW5k KCk7CisgICAgdm9pZCByZXN1bWUoKTsKKwogICAgIExvY2smIHN0YXRlTG9jaygpIHsgcmV0dXJu IG1fc3RhdGUubG9jazsgfQogCiAgICAgdm9pZCBzY2hlZHVsZVVwZGF0ZSgpOwpAQCAtODEsNiAr ODQsNyBAQCBwcml2YXRlOgogICAgICAgICBDb21wb3NpdGlvblN0YXRlIGNvbXBvc2l0aW9uIHsg Q29tcG9zaXRpb25TdGF0ZTo6SWRsZSB9OwogICAgICAgICBVcGRhdGVTdGF0ZSB1cGRhdGUgeyBV cGRhdGVTdGF0ZTo6SWRsZSB9OwogICAgICAgICBib29sIHBlbmRpbmdVcGRhdGUgeyBmYWxzZSB9 OworICAgICAgICBib29sIGlzU3VzcGVuZGVkIHsgZmFsc2UgfTsKICAgICB9IG1fc3RhdGU7CiB9 OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNz L3RocmVhZGVkY29tcG9zaXRvci9UaHJlYWRlZENvbXBvc2l0b3IuY3BwIGIvU291cmNlL1dlYktp dC9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy90aHJlYWRlZGNvbXBvc2l0b3IvVGhyZWFkZWRD b21wb3NpdG9yLmNwcAppbmRleCBmZDRhYWY1ZDE1My4uN2RkN2Y2ZDk0MDcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvdGhyZWFkZWRjb21wb3Np dG9yL1RocmVhZGVkQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvQ29v cmRpbmF0ZWRHcmFwaGljcy90aHJlYWRlZGNvbXBvc2l0b3IvVGhyZWFkZWRDb21wb3NpdG9yLmNw cApAQCAtMTIxLDcgKzEyMSw3IEBAIHZvaWQgVGhyZWFkZWRDb21wb3NpdG9yOjpzdXNwZW5kKCkK ICAgICBpZiAoKyttX3N1c3BlbmRlZENvdW50ID4gMSkKICAgICAgICAgcmV0dXJuOwogCi0gICAg bV9jb21wb3NpdGluZ1J1bkxvb3AtPnN0b3BVcGRhdGVzKCk7CisgICAgbV9jb21wb3NpdGluZ1J1 bkxvb3AtPnN1c3BlbmQoKTsKICAgICBtX2NvbXBvc2l0aW5nUnVuTG9vcC0+cGVyZm9ybVRhc2tT eW5jKFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyldIHsKICAgICAgICAgbV9z Y2VuZS0+c2V0QWN0aXZlKGZhbHNlKTsKICAgICB9KTsKQEAgLTEzNiw2ICsxMzYsNyBAQCB2b2lk IFRocmVhZGVkQ29tcG9zaXRvcjo6cmVzdW1lKCkKICAgICBtX2NvbXBvc2l0aW5nUnVuTG9vcC0+ cGVyZm9ybVRhc2tTeW5jKFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyldIHsK ICAgICAgICAgbV9zY2VuZS0+c2V0QWN0aXZlKHRydWUpOwogICAgIH0pOworICAgIG1fY29tcG9z aXRpbmdSdW5Mb29wLT5yZXN1bWUoKTsKIH0KIAogdm9pZCBUaHJlYWRlZENvbXBvc2l0b3I6OnNl dE5hdGl2ZVN1cmZhY2VIYW5kbGVGb3JDb21wb3NpdGluZyh1aW50NjRfdCBoYW5kbGUpCg==