19541 2008-06-13 17:38:50 -0700 Null pointer in showModalDialog() 2008-11-09 17:19:48 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://danceoffwithyourpantsoff.googlepages.com/empty-page.html InRadar P2 Normal --- 1 danceoffwithyourpantsoff zwarich zwarich oldest_to_newest 83281 0 danceoffwithyourpantsoff 2008-06-13 17:38:50 -0700 A frame can out live it's page, for example when a frame is detached (so pageDestroyed() is called). We could still have a reference to the window from javascript. The patch is simple to check !frame and !frame->page() 83294 1 mrowe 2008-06-13 23:21:05 -0700 <rdar://problem/6008014> 97990 2 zwarich 2008-11-07 17:40:23 -0800 This shouldn't be hard to fix. 98117 3 25010 zwarich 2008-11-09 17:03:02 -0800 Created attachment 25010 Proposed patch 98118 4 25010 darin 2008-11-09 17:05:16 -0800 Comment on attachment 25010 Proposed patch I prefer to do page && page->chrome()->canRunModal() instead of a separate if statement. r=me 98119 5 zwarich 2008-11-09 17:19:48 -0800 Landed in r38248. 25010 2008-11-09 17:03:02 -0800 2008-11-09 17:05:16 -0800 Proposed patch nullcheck.diff text/plain 4236 zwarich SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODI0NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDgtMTEtMDkgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBw bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEJ1ZyAxOTU0MTogTnVsbCBwb2ludGVyIGluIHNob3dNb2RhbERpYWxvZygpCisgICAgICAgIDxo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1NDE+CisKKyAgICAgICAg QWRkIG51bGwgZnJhbWUtPnBhZ2UoKSBjaGVja3MgdG8gSlNET01XaW5kb3dCYXNlOjpjYW5TaG93 TW9kYWxEaWFsb2coKQorICAgICAgICBhbmQgSlNET01XaW5kb3dCYXNlOjpjYW5TaG93TW9kYWxE aWFsb2dOb3coKS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRE9NV2luZG93QmFzZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpjYW5TaG93TW9kYWxEaWFsb2cpOgorICAgICAgICAoV2ViQ29y ZTo6Y2FuU2hvd01vZGFsRGlhbG9nTm93KToKKwogMjAwOC0xMS0wOSAgRGFyaW4gQWRsZXIgIDxk YXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgLSB0cnkgdG8gZml4IFdpbmRvd3MgYnVpbGQKSW5k ZXg6IFdlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dCYXNlLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93QmFzZS5jcHAJKHJldmlzaW9uIDM4MjQw KQorKysgV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0Jhc2UuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yOTcsMTQgKzI5NywyNCBAQCBzdGF0aWMgYm9vbCBjYW5TaG93TW9kYWxEaWFsb2co Y29uc3QgRnJhCiB7CiAgICAgaWYgKCFmcmFtZSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAg IHJldHVybiBmcmFtZS0+cGFnZSgpLT5jaHJvbWUoKS0+Y2FuUnVuTW9kYWwoKTsKKworICAgIFBh Z2UqIHBhZ2UgPSBmcmFtZS0+cGFnZSgpOworICAgIGlmICghcGFnZSkKKyAgICAgICAgcmV0dXJu IGZhbHNlOworCisgICAgcmV0dXJuIHBhZ2UtPmNocm9tZSgpLT5jYW5SdW5Nb2RhbCgpOwogfQog CiBzdGF0aWMgYm9vbCBjYW5TaG93TW9kYWxEaWFsb2dOb3coY29uc3QgRnJhbWUqIGZyYW1lKQog ewogICAgIGlmICghZnJhbWUpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICByZXR1cm4gZnJh bWUtPnBhZ2UoKS0+Y2hyb21lKCktPmNhblJ1bk1vZGFsTm93KCk7CisKKyAgICBQYWdlKiBwYWdl ID0gZnJhbWUtPnBhZ2UoKTsKKyAgICBpZiAoIXBhZ2UpCisgICAgICAgIHJldHVybiBmYWxzZTsK KworICAgIHJldHVybiBwYWdlLT5jaHJvbWUoKS0+Y2FuUnVuTW9kYWxOb3coKTsKIH0KIAogc3Rh dGljIEpTVmFsdWUqIHNob3dNb2RhbERpYWxvZyhFeGVjU3RhdGUqIGV4ZWMsIEZyYW1lKiBmcmFt ZSwgY29uc3QgU3RyaW5nJiB1cmwsIEpTVmFsdWUqIGRpYWxvZ0FyZ3MsIGNvbnN0IFN0cmluZyYg ZmVhdHVyZUFyZ3MpCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAzODI0NikKKysrIExheW91dFRlc3RzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDA4LTExLTA5ICBDYW1l cm9uIFp3YXJpY2ggIDx6d2FyaWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSB0ZXN0IGZvciBidWcgMTk1NDE6IE51bGwg cG9pbnRlciBpbiBzaG93TW9kYWxEaWFsb2coKQorICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTQxPgorCisgICAgICAgICogZmFzdC9kb20vbnVsbC1w YWdlLXNob3ctbW9kYWwtZGlhbG9nLWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAg ICogZmFzdC9kb20vbnVsbC1wYWdlLXNob3ctbW9kYWwtZGlhbG9nLWNyYXNoLmh0bWw6IEFkZGVk LgorCiAyMDA4LTExLTA5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qv ZG9tL251bGwtcGFnZS1zaG93LW1vZGFsLWRpYWxvZy1jcmFzaC1leHBlY3RlZC50eHQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vbnVsbC1wYWdlLXNob3ctbW9kYWwtZGlhbG9n LWNyYXNoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9t L251bGwtcGFnZS1zaG93LW1vZGFsLWRpYWxvZy1jcmFzaC1leHBlY3RlZC50eHQJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEgQEAKK1RoaXMgaXMgYSB0ZXN0IGZvciBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1NDEgUkJ1ZyAxOTU0MTogTnVsbCBwb2ludGVyIGluIHNo b3dNb2RhbERpYWxvZygpIFRoaXMgdGVzdHMgY2FsbGluZyB0aGUgc2hvd01vZGFsRGlhbG9nKCkg ZnVuY3Rpb24gb24gYSB3aW5kb3cgb2JqZWN0IGZyb20gYSBkZXRhY2hlZCBpZnJhbWUsIGJvdGgg Y2FsbGluZyB0aGUgc2F2ZWQgc2hvd01vZGFsRGlhbG9nKCkgZnVuY3Rpb24gYW5kIGdldHRpbmcg dGhlIHByb3BlcnR5IGFnYWluIGFmdGVyIHRoZSBpZnJhbWUgaGFzIGJlZW4gZGV0YWNoZWQuIElm IHRoZXJlIGlzIG5vIGNyYXNoIHRoaXMgdGVzdCBwYXNzZXMuCkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L2RvbS9udWxsLXBhZ2Utc2hvdy1tb2RhbC1kaWFsb2ctY3Jhc2guaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9udWxsLXBhZ2Utc2hvdy1tb2RhbC1kaWFsb2ctY3Jh c2guaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL251bGwtcGFnZS1z aG93LW1vZGFsLWRpYWxvZy1jcmFzaC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI1IEBA CitUaGlzIGlzIGEgdGVzdCBmb3IgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5NTQxIj5odHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk1NDE8L2E+IAorUkJ1ZyAxOTU0MTogTnVsbCBwb2ludGVyIGluIHNob3dNb2RhbERpYWxv ZygpCisKK1RoaXMgdGVzdHMgY2FsbGluZyB0aGUgc2hvd01vZGFsRGlhbG9nKCkgZnVuY3Rpb24g b24gYSB3aW5kb3cgb2JqZWN0IGZyb20gYSBkZXRhY2hlZCBpZnJhbWUsIGJvdGggY2FsbGluZyB0 aGUgc2F2ZWQgc2hvd01vZGFsRGlhbG9nKCkgZnVuY3Rpb24gYW5kIGdldHRpbmcgdGhlIHByb3Bl cnR5IGFnYWluIGFmdGVyIHRoZSBpZnJhbWUgaGFzIGJlZW4gZGV0YWNoZWQuCisKK0lmIHRoZXJl IGlzIG5vIGNyYXNoIHRoaXMgdGVzdCBwYXNzZXMuCis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNj cmlwdCI+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RD b250cm9sbGVyLmR1bXBBc1RleHQoKTsKKwordmFyIGlmcmFtZSA9IGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoImlmcmFtZSIpOworCitpZnJhbWUub25sb2FkID0gZnVuY3Rpb24oKSB7CisgICAgdmFy IGlmcmFtZVdpbmRvdyA9IGlmcmFtZS5jb250ZW50V2luZG93OworICAgIHZhciBmID0gaWZyYW1l V2luZG93LnNob3dNb2RhbERpYWxvZzsKKworICAgIGlmcmFtZS5wYXJlbnROb2RlLnJlbW92ZUNo aWxkKGlmcmFtZSk7CisgICAgaWYgKGlmcmFtZVdpbmRvdy5zaG93TW9kYWxEaWFsb2cpCisgICAg ICAgIGlmcmFtZVdpbmRvdy5zaG93TW9kYWxEaWFsb2coKTsKKyAgICBpZiAoZikKKyAgICAgICAg Zi5jYWxsKGlmcmFtZVdpbmRvdyk7Cit9OworCitkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGlm cmFtZSk7Cis8L3NjcmlwdD4K