195391 2019-03-06 17:38:32 -0800 Remove an unneeded assert that was added with r242113 2019-03-06 19:03:29 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad ryanhaddad ap commit-queue eric.carlson jer.noble simon.fraser webkit-bug-importer oldest_to_newest 1513320 0 ryanhaddad 2019-03-06 17:38:32 -0800 This assertion failure is seen with multiple layout tests after it was added in https://trac.webkit.org/changeset/242113/webkit ASSERTION FAILED: m_mediaBufferingIsSuspended ./page/Page.cpp(1784) : void WebCore::Page::resumeAllMediaBuffering() 1 0x493aeaee9 WTFCrash 2 0x497bb9c5b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x49a78750b WebCore::Page::resumeAllMediaBuffering() 4 0x102bea184 WebKit::WebPage::resumeAllMediaBuffering() 5 0x1028a83a6 WebKit::WebProcess::resumeAllMediaBuffering() 6 0x1028a8e2a WebKit::WebProcess::processDidResume() see: https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20(Tests)/r242569%20(2612)/results.html It doesn't seem necessary since m_mediaBufferingIsSuspended is protected by an 'if' statement right below the ASSERT: void Page::resumeAllMediaBuffering() { #if ENABLE(VIDEO) ASSERT(m_mediaBufferingIsSuspended); if (!m_mediaBufferingIsSuspended) return; ... 1513322 1 363827 ryanhaddad 2019-03-06 17:44:28 -0800 Created attachment 363827 Patch 1513326 2 ryanhaddad 2019-03-06 17:54:02 -0800 <rdar://48642781> 1513327 3 webkit-bug-importer 2019-03-06 17:54:17 -0800 <rdar://problem/48660996> 1513342 4 363827 commit-queue 2019-03-06 19:03:27 -0800 Comment on attachment 363827 Patch Clearing flags on attachment: 363827 Committed r242586: <https://trac.webkit.org/changeset/242586> 1513343 5 commit-queue 2019-03-06 19:03:29 -0800 All reviewed patches have been landed. Closing bug. 363827 2019-03-06 17:44:28 -0800 2019-03-06 19:03:27 -0800 Patch bug-195391-20190306174428.patch text/plain 1422 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyNTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTAxMjExYzkxZWQ4ZmYw OGNiNmQwYjYyODg3NGM2YWNkZjRlZjM1Mi4uMmQyZTA1NjM4MmJlY2YxOTc2ZGJlZjYwYWNkODJh MmYxODE3YjYxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAzLTA2ICBSeWFu IEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBhbiB1bm5l ZWRlZCBhc3NlcnQgdGhhdCB3YXMgYWRkZWQgd2l0aCByMjQyMTEzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTUzOTEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYW55IGxheW91dCB0ZXN0cyBhcmUgZmFp bGluZyBBU1NFUlQobV9tZWRpYUJ1ZmZlcmluZ0lzU3VzcGVuZGVkKS4gU2luY2UgbV9tZWRpYUJ1 ZmZlcmluZ0lzU3VzcGVuZGVkIGlzCisgICAgICAgIHByb3RlY3RlZCBieSBhbiAnaWYnIHN0YXRl bWVudCBkaXJlY3RseSBhZnRlcndhcmRzLCB0aGUgYXNzZXJ0aW9uIHNob3VsZCBiZSBzYWZlIHRv IHJlbW92ZS4KKworICAgICAgICAqIHBhZ2UvUGFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQ YWdlOjpyZXN1bWVBbGxNZWRpYUJ1ZmZlcmluZyk6CisKIDIwMTktMDMtMDYgIFdlbnNvbiBIc2ll aCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBSZW5kZXJPYmplY3Q6 OmlzVHJhbnNwYXJlbnRPckZ1bGx5Q2xpcHBlZFJlc3BlY3RpbmdQYXJlbnRGcmFtZXMoKSB0byBS ZW5kZXJMYXllcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKaW5kZXggYzdiMWIwMmQxMWNiZTc1NWFlNmZmN2Rh ZjkyODM0NGZjZjYxZTg2Ny4uM2ZiZGVmMjI0ZWQyMThiNjc5YWYzMTk5NGFjOTU0ODdhMjJlMDRi YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL1BhZ2UuY3BwCkBAIC0xNzgxLDcgKzE3ODEsNiBAQCB2b2lkIFBhZ2U6OnN1 c3BlbmRBbGxNZWRpYUJ1ZmZlcmluZygpCiB2b2lkIFBhZ2U6OnJlc3VtZUFsbE1lZGlhQnVmZmVy aW5nKCkKIHsKICNpZiBFTkFCTEUoVklERU8pCi0gICAgQVNTRVJUKG1fbWVkaWFCdWZmZXJpbmdJ c1N1c3BlbmRlZCk7CiAgICAgaWYgKCFtX21lZGlhQnVmZmVyaW5nSXNTdXNwZW5kZWQpCiAgICAg ICAgIHJldHVybjsKICAgICBtX21lZGlhQnVmZmVyaW5nSXNTdXNwZW5kZWQgPSBmYWxzZTsK