195385 2019-03-06 16:15:53 -0800 [ iOS Simulator ] REGRESSION (r237702) Layout Test http/tests/security/xss-DENIED-script-inject-into-inactive-window.html is a flaky failure 2019-03-27 12:56:09 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sroberts cdumez achristensen beidson cdumez commit-queue ggaren lforschler rniwa webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1513261 0 sroberts 2019-03-06 16:15:53 -0800 The following layout test is failing on iOS Simulator http/tests/security/xss-DENIED-script-inject-into-inactive-window.html Probable cause: Test has been a flaky failure since it was changed in r237702. Fails 100% of the time with any previous build. Reproduced with: run-webkit-tests http/tests/security/xss-DENIED-script-inject-into-inactive-window.html --iterations 100 -f --ios-simulator --child-processes 4 Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fxss-DENIED-script-inject-into-inactive-window.html Diff: --- /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/http/tests/security/xss-DENIED-script-inject-into-inactive-window-expected.txt +++ /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/http/tests/security/xss-DENIED-script-inject-into-inactive-window-actual.txt @@ -1,3 +1,4 @@ +ALERT: XSS Check the child window. The test FAILED if you see a JavaScript alert() dialog. Otherwise, it PASSED. 1513267 1 webkit-bug-importer 2019-03-06 16:18:42 -0800 <rdar://problem/48657425> 1514056 2 sroberts 2019-03-08 10:20:55 -0800 Additional repro information: Found test was a flaky failure on dashboard through its available history on iOS Simulator. Searched on Trac and found test was modified in r237702 and used this as a bisecting point. Re-tested without extra child processes using command : run-webkit-tests http/tests/security/xss-DENIED-script-inject-into-inactive-window.html --iterations 500 -f --ios-simulator --exit-after-n-failures=5 --no-retry-failures 242568 5 out of 234 failed unexpectedly (text diff) 237702 3 out of 500 failed unexpectedly (text diff) 237701 Changed test parameters to --exit-after-n-failures=25, 25 out of 25 Unexpected timeouts (1) [ Timeout ] 1521778 3 366090 cdumez 2019-03-27 12:15:50 -0700 Created attachment 366090 Patch 1521792 4 366090 commit-queue 2019-03-27 12:56:07 -0700 Comment on attachment 366090 Patch Clearing flags on attachment: 366090 Committed r243558: <https://trac.webkit.org/changeset/243558> 1521793 5 commit-queue 2019-03-27 12:56:09 -0700 All reviewed patches have been landed. Closing bug. 366090 2019-03-27 12:15:50 -0700 2019-03-27 12:56:07 -0700 Patch bug-195385-20190327121549.patch text/plain 2714 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNTU0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMmU4ZWZmZjY2Mzc2ODk4OGE1YWJk NzI1MjU5YjcwMGUxYTk2ZTkyYi4uOGYzMDExOTBlN2M1OTk3MGI0YWNkMzc1NDk0ODUxMzlhZjEw MGJmNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE5LTAzLTI3ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgWyBpT1MgU2ltdWxhdG9yIF0gUkVHUkVTU0lPTiAo cjIzNzcwMikgTGF5b3V0IFRlc3QgaHR0cC90ZXN0cy9zZWN1cml0eS94c3MtREVOSUVELXNjcmlw dC1pbmplY3QtaW50by1pbmFjdGl2ZS13aW5kb3cuaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTM4NQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNDg2NTc0MjU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQmVmb3JlIHIyMzc3MDIsIHRoZSB0ZXN0IHVzZWQgdG8g ZGV0ZWN0IHRoYXQgX29wZW5lZFdpbmRvd0RvY3VtZW50IGhhZCBiZWNvbWUgZnJhbWVsZXNzIChp LmUuIGxvc3QgaXRzIGJyb3dzaW5nIGNvbnRleHQpCisgICAgICAgIGJ5IGNoZWNraW5nIGlmIF9v cGVuZWRXaW5kb3dEb2N1bWVudC5sb2NhdGlvbi5ocmVmIGlzIHRoZSBlbXB0eSBTdHJpbmcuIEhv d2V2ZXIsIHIyMzc3MDIgdXBkYXRpbmcgTG9jYXRpb24gdG8gcmV0dXJuCisgICAgICAgICJhYm91 dDpibGFuayIgaW5zdGVhZCBvZiAiIiB3aGVuIGZyYW1lbGVzcywgdG8gbWF0Y2ggdGhlIGxhdGVz dCBzcGVjaWZpY2F0aW9uLiBBcyBhIHJlc3VsdCwgSSBoYWQgdXBkYXRlZCB0aGUgdGVzdCB0bwor ICAgICAgICBleHBlY3QgX29wZW5lZFdpbmRvd0RvY3VtZW50LmxvY2F0aW9uLmhyZWYgdG8gYmUg ImFib3V0OmJsYW5rIi4gSG93ZXZlciwgSSBoYWQgbm90IG5vdGljZWQgdGhhdCB0aGUgZG9jdW1l bnQncyBpbml0aWFsCisgICAgICAgIFVSTCAod2hpbGUgaXQgaGFkIGEgYnJvd3NpbmcgY29udGV4 dCkgd2FzIGFsc28gImFib3V0OmJsYW5rIi4gVGhlcmVmb3JlLCBjaGVja2luZyB0aGF0IGxvY2F0 aW9uLmhyZWYgaXMgImFib3V0OmJsYW5rIgorICAgICAgICB3b3VsZCBhY3R1YWxseSBub3QgZ3Vh cmFudGVlIHRoYXQgdGhlIGRvY3VtZW50IGhhcyBubyBicm93c2luZyBjb250ZXh0LgorCisgICAg ICAgIFRvIGFkZHJlc3MgdGhlIGlzc3VlLCBjaGVjayB0aGF0IF9vcGVuZWRXaW5kb3dEb2N1bWVu dC5kZWZhdWx0VmlldyBpcyBudWxsIGluc3RlYWQgc2luY2UgdGhpcyBpcyBndWFyYW50ZWVkIHRv IGJlIG51bGwKKyAgICAgICAgZm9yIERvY3VtZW50cyB0aGF0IGRvIG5vdCBoYXZlIGEgYnJvd3Np bmcgY29udGV4dCBhcyBwZXI6CisgICAgICAgIC0gaHR0cHM6Ly9odG1sLnNwZWMud2hhdHdnLm9y Zy9tdWx0aXBhZ2Uvd2luZG93LW9iamVjdC5odG1sI2RvbS1kb2N1bWVudC1kZWZhdWx0dmlldwor CisgICAgICAgICogaHR0cC90ZXN0cy9zZWN1cml0eS94c3MtREVOSUVELXNjcmlwdC1pbmplY3Qt aW50by1pbmFjdGl2ZS13aW5kb3cuaHRtbDoKKwogMjAxOS0wMy0yNyAgU2hhd24gUm9iZXJ0cyAg PHNyb2JlcnRzQGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwL3Rlc3RzL3Jlc291cmNlTG9hZFN0 YXRpc3RpY3Mvd2Vic2l0ZS1kYXRhLXJlbW92YWwtZm9yLXNpdGUtbmF2aWdhdGVkLXRvLXdpdGgt bGluay1kZWNvcmF0aW9uLmh0bWwgaXMgYSBmbGFreSBmYWlsdXJlCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3hzcy1ERU5JRUQtc2NyaXB0LWluamVjdC1pbnRv LWluYWN0aXZlLXdpbmRvdy5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS94 c3MtREVOSUVELXNjcmlwdC1pbmplY3QtaW50by1pbmFjdGl2ZS13aW5kb3cuaHRtbAppbmRleCA3 ODlmZGUzZDc5NjdmZDZlYWRlZTA3YjE4Njg1NGVkMjEzNWVmNGFjLi5lNGJlNGMxZDBiY2QwNDA2 YmFlNTVhMDM1MmZiNjc3NDA0MWMxMDRmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL3NlY3VyaXR5L3hzcy1ERU5JRUQtc2NyaXB0LWluamVjdC1pbnRvLWluYWN0aXZlLXdpbmRv dy5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkveHNzLURFTklFRC1z Y3JpcHQtaW5qZWN0LWludG8taW5hY3RpdmUtd2luZG93Lmh0bWwKQEAgLTE2LDcgKzE2LDggQEAg dmFyIGludGVydmFsSWQ7CiAKIGZ1bmN0aW9uIGNoZWNrRGlkTG9hZFZpY3RpbSgpCiB7Ci0gICAg aWYgKF9vcGVuZWRXaW5kb3dEb2N1bWVudC5sb2NhdGlvbi5ocmVmID09ICJhYm91dDpibGFuayIp IHsKKyAgICAvLyBEb2N1bWVudC5kZWZhdWx0VmlldyBiZWNvbWVzIG51bGwgd2hlbiBhIERvY3Vt ZW50IG5vIGxvbmdlciBoYXMgYSBicm93c2luZyBjb250ZXh0LgorICAgIGlmICghX29wZW5lZFdp bmRvd0RvY3VtZW50LmRlZmF1bHRWaWV3KSB7CiAgICAgICAgIC8vIFZpY3RpbSBsb2FkZWQ7IHxf b3BlbmVkV2luZG93RG9jdW1lbnR8IGlzIGFuIGluYWN0aXZlIGRvY3VtZW50LgogICAgICAgICB3 aW5kb3cuY2xlYXJJbnRlcnZhbChpbnRlcnZhbElkKTsKIAo=