195379 2019-03-06 14:29:26 -0800 [macOS] Sandbox call violation causes WebContent process to crash 2019-12-17 10:24:15 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue webkit-bug-importer ysuzuki oldest_to_newest 1513195 0 pvollan 2019-03-06 14:29:26 -0800 A new call needs to be added to the allow list in the WebContent process' sandbox. 1513196 1 pvollan 2019-03-06 14:29:50 -0800 rdar://problem/48647263 1513200 2 363794 pvollan 2019-03-06 14:31:34 -0800 Created attachment 363794 Patch 1513201 3 363794 bfulgham 2019-03-06 14:33:40 -0800 Comment on attachment 363794 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363794&action=review > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:972 > + (syscall-number SYS_memorystatus_control) I suggest you add a comment with the Radar#, or perhaps the reason we need to include this (e.g., list which Framework uses it.) I this case, I think it night be: "..._control) ;; Needed for memory measurement infrastructure" Or something like that. 1513206 4 363795 pvollan 2019-03-06 14:40:57 -0800 Created attachment 363795 Patch 1513207 5 pvollan 2019-03-06 14:42:13 -0800 (In reply to Brent Fulgham from comment #3) > Comment on attachment 363794 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=363794&action=review > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:972 > > + (syscall-number SYS_memorystatus_control) > > I suggest you add a comment with the Radar#, or perhaps the reason we need > to include this (e.g., list which Framework uses it.) > > I this case, I think it night be: > > "..._control) ;; Needed for memory measurement infrastructure" > > Or something like that. Thanks for reviewing! I have updated the patch. 1513218 6 363795 commit-queue 2019-03-06 15:08:37 -0800 Comment on attachment 363795 Patch Clearing flags on attachment: 363795 Committed r242570: <https://trac.webkit.org/changeset/242570> 363794 2019-03-06 14:31:34 -0800 2019-03-06 14:33:40 -0800 Patch bug-195379-20190306143134.patch text/plain 1233 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDI1NjcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAzLTA2ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIFNhbmRib3ggY2Fs bCB2aW9sYXRpb24gY2F1c2VzIFdlYkNvbnRlbnQgcHJvY2VzcyB0byBjcmFzaAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1Mzc5CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS80ODY0NzI2Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBIG5ldyBjYWxsIG5lZWRzIHRvIGJlIGFkZGVkIHRvIHRoZSBhbGxv dyBsaXN0IGluIHRoZSBXZWJDb250ZW50IHByb2Nlc3MnIHNhbmRib3guCisKKyAgICAgICAgKiBX ZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluOgorCiAyMDE5LTAzLTA2ICBBbnR0 aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBCYXNpYyBoaXQg dGVzdGluZyBmb3IgY29udGVudCBvdmVybGFwcGluZyBmYXN0LXNjcm9sbGFibGUgb3ZlcmZsb3cK SW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5p bgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlBy b2Nlc3Muc2IuaW4JKHJldmlzaW9uIDI0MjU2NCkKKysrIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgkod29ya2luZyBjb3B5KQpAQCAtOTY5LDYgKzk2 OSw3IEBACiAgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfdWxvY2tfd2FrZSkKICAgICAgICAg KHN5c2NhbGwtbnVtYmVyIFNZU193b3JrX2ludGVydmFsX2N0bCkKICAgICAgICAgKHN5c2NhbGwt bnVtYmVyIFNZU19rZGVidWdfdHlwZWZpbHRlcikKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZ U19tZW1vcnlzdGF0dXNfY29udHJvbCkKICAgICApCiApCiAK 363795 2019-03-06 14:40:57 -0800 2019-03-06 15:08:37 -0800 Patch bug-195379-20190306144056.patch text/plain 1311 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDI1NjgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAzLTA2ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIFNhbmRib3ggY2Fs bCB2aW9sYXRpb24gY2F1c2VzIFdlYkNvbnRlbnQgcHJvY2VzcyB0byBjcmFzaAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1Mzc5CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS80ODY0NzI2Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBCcmVudCBGdWxn aGFtLgorCisgICAgICAgIEEgbmV3IGNhbGwgbmVlZHMgdG8gYmUgYWRkZWQgdG8gdGhlIGFsbG93 IGxpc3QgaW4gdGhlIFdlYkNvbnRlbnQgcHJvY2Vzcycgc2FuZGJveC4KKworICAgICAgICAqIFdl YlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW46CisKIDIwMTktMDMtMDYgIEFudHRp IEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEJhc2ljIGhpdCB0 ZXN0aW5nIGZvciBjb250ZW50IG92ZXJsYXBwaW5nIGZhc3Qtc2Nyb2xsYWJsZSBvdmVyZmxvdwpJ bmRleDogU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmlu Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJv Y2Vzcy5zYi5pbgkocmV2aXNpb24gMjQyNTY4KQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCSh3b3JraW5nIGNvcHkpCkBAIC05NjksNiArOTY5 LDcgQEAKICAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU191bG9ja193YWtlKQogICAgICAgICAo c3lzY2FsbC1udW1iZXIgU1lTX3dvcmtfaW50ZXJ2YWxfY3RsKQogICAgICAgICAoc3lzY2FsbC1u dW1iZXIgU1lTX2tkZWJ1Z190eXBlZmlsdGVyKQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lT X21lbW9yeXN0YXR1c19jb250cm9sKSA7OyBOZWVkZWQgZm9yIG1lbW9yeSBtZWFzdXJlbWVudCBp bmZyYXN0cnVjdHVyZSwgc2VlIDxyZGFyOi8vcHJvYmxlbS80ODY0NzI2Mz4KICAgICApCiApCiAK