195348 2019-03-05 17:23:33 -0800 [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots 2019-03-22 10:02:26 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=194829 InRadar P2 Normal --- 1 sroberts cdumez achristensen ap cdumez commit-queue ggaren lforschler rniwa webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1512919 0 sroberts 2019-03-05 17:23:33 -0800 The following layout test is flaky on iOS Simulator platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html Probable cause: It appears changes made in r241821 are causing this test to fail, when it is run immediately after platform/ipad/fast/viewport/viewport-overriden-by-minimum-effective-width-if-ignore-meta-viewport.html It will fail immediately after, and then pass on the re-test. Dashboard shows 100% failure since this revision. Reproduced locally with : run-webkit-tests platform/ipad/fast/viewport/viewport-overriden-by-minimum-effective-width-if-ignore-meta-viewport.html platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html --ipad-simulator --child-processes 1 Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=platform%2Fipad%2Ffast%2Fviewport%2Fviewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html Diff: --- /Users/shawnroberts/Desktop/builds/ios241822/layout-test-results/platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport-expected.txt +++ /Users/shawnroberts/Desktop/builds/ios241822/layout-test-results/platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport-actual.txt @@ -1,17 +1,17 @@ setMinimumEffectiveWidth(640.00) -window size: [980, 1281] -square size: [98, 128] -zoom scale: 0.78 +window size: [768, 1004] +square size: [77, 100] +zoom scale: 1.00 setMinimumEffectiveWidth(768.00) -window size: [980, 1281] -square size: [98, 128] -zoom scale: 0.78 +window size: [768, 1004] +square size: [77, 100] +zoom scale: 1.00 setMinimumEffectiveWidth(834.00) -window size: [980, 1281] -square size: [98, 128] -zoom scale: 0.78 +window size: [834, 1090] +square size: [83, 109] +zoom scale: 0.92 setMinimumEffectiveWidth(980.00) window size: [980, 1281] @@ -19,23 +19,23 @@ zoom scale: 0.78 setMinimumEffectiveWidth(1024.00) -window size: [980, 1281] -square size: [98, 128] -zoom scale: 0.78 +window size: [1024, 1339] +square size: [102, 134] +zoom scale: 0.75 setMinimumEffectiveWidth(1112.00) -window size: [980, 1281] -square size: [98, 128] -zoom scale: 0.78 +window size: [1112, 1454] +square size: [111, 145] +zoom scale: 0.69 setMinimumEffectiveWidth(1280.00) -window size: [980, 1281] -square size: [98, 128] -zoom scale: 0.78 +window size: [1280, 1673] +square size: [128, 167] +zoom scale: 0.60 setMinimumEffectiveWidth(1336.00) -window size: [980, 1281] -square size: [98, 128] -zoom scale: 0.78 +window size: [1336, 1747] +square size: [134, 175] +zoom scale: 0.57 1512922 1 webkit-bug-importer 2019-03-05 17:25:13 -0800 <rdar://problem/48622090> 1514071 2 sroberts 2019-03-08 10:44:13 -0800 Additional repro steps: Found test was a constant failure on dashboard through its available history on iOS Simulator and Debug starting to appear around r241821 Test would not fail locally when running by itself. Using layout test results from build 2973 for Apple iOS 12 Simulator Release WK2 (Tests), I pulled the worker information and used this to start bisecting tests until I found it will fail when preceded by platform/ipad/fast/viewport/viewport-overriden-by-minimum-effective-width-if-ignore-meta-viewport.html Searched on Trac and found test was moved to a new iPad directory in r240150 and used this as a bisecting point. 242496 Failed 241913 failed 241837 Failed 241824 Failed 241822 Failed 241821 Failed 241820 Passed 241816 Passed 241790 Passed 241768 Passed 241617 Passed 241323 Passed 240150 Passed 1519930 3 365616 cdumez 2019-03-21 14:08:31 -0700 Created attachment 365616 Patch 1520373 4 365616 cdumez 2019-03-22 10:02:20 -0700 Comment on attachment 365616 Patch Clearing flags on attachment: 365616 Committed r243385: <https://trac.webkit.org/changeset/243385> 1520374 5 cdumez 2019-03-22 10:02:21 -0700 All reviewed patches have been landed. Closing bug. 365616 2019-03-21 14:08:31 -0700 2019-03-22 10:02:20 -0700 Patch bug-195348-20190321140831.patch text/plain 1818 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMzIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWQ5Njg1ODI0MTA0MDc5NjZhNWVmNTMwZjRiNDdmNzM2 YTA1N2Q1OS4uMWVjNWMwMjk1YjZkN2I1MGYwODFhZDRiYmFkYWE0YzYwMTAyZGMxOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTAzLTIxICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgWyBpT1MgU2ltdWxhdG9yXSBSRUdSRVNTSU9OIChyMjQxODIxKSBMYXlvdXQgVGVzdCBwbGF0 Zm9ybS9pcGFkL2Zhc3Qvdmlld3BvcnQvdmlld3BvcnQtdW5jaGFuZ2VkLWJ5LW1pbmltdW0tZWZm ZWN0aXZlLXdpZHRoLWlmLW5vdC1pZ25vcmUtbWV0YS12aWV3cG9ydC5odG1sIGlzIGEgZmxha3kg ZmFpbHVyZSBvbiBib3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTUzNDgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ4NjIyMDkwPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VyZSB3ZWJW aWV3LmNvbmZpZ3VyYXRpb24ucHJlZmVyZW5jZXMuX3Nob3VsZElnbm9yZU1ldGFWaWV3cG9ydCBn ZXRzIHJlc2V0CisgICAgICAgIHRvIE5PIHdoZW4gdGVzdC5vcHRpb25zKCkuc2hvdWxkSWdub3Jl TWV0YVZpZXdwb3J0IGlzIGZhbHNlLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9pb3Mv VGVzdENvbnRyb2xsZXJJT1MubW06CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjpwbGF0 Zm9ybUNvbmZpZ3VyZVZpZXdGb3JUZXN0KToKKwogMjAxOS0wMy0yMSAgSm9uYXRoYW4gQmVkYXJk ICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU1NJT04gKHIyNDMyOTcpOiB3 ZWJraXRweSB0ZXN0cyBicm9rZW4KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv aW9zL1Rlc3RDb250cm9sbGVySU9TLm1tIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9pb3MvVGVz dENvbnRyb2xsZXJJT1MubW0KaW5kZXggZDQwNThmMzBkYzBmNGFlMWUwOWY0NWJhZmRiOTM0MzY2 MDcxMWY5Zi4uZWFmMWY1YTJiZjZkN2VkMDlmYjM0YzYwNzIwOTQ4NzI3NWQ3YjNhYiAxMDA2NDQK LS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9pb3MvVGVzdENvbnRyb2xsZXJJT1MubW0KKysr IGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9pb3MvVGVzdENvbnRyb2xsZXJJT1MubW0KQEAgLTE3 OCw4ICsxNzgsNyBAQCB2b2lkIFRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybUNvbmZpZ3VyZVZpZXdG b3JUZXN0KGNvbnN0IFRlc3RJbnZvY2F0aW9uJiB0ZXN0KQogICAgICAgICAKICAgICBUZXN0UnVu bmVyV0tXZWJWaWV3ICp3ZWJWaWV3ID0gbWFpbldlYlZpZXcoKS0+cGxhdGZvcm1WaWV3KCk7CiAK LSAgICBpZiAodGVzdC5vcHRpb25zKCkuc2hvdWxkSWdub3JlTWV0YVZpZXdwb3J0KQotICAgICAg ICB3ZWJWaWV3LmNvbmZpZ3VyYXRpb24ucHJlZmVyZW5jZXMuX3Nob3VsZElnbm9yZU1ldGFWaWV3 cG9ydCA9IFlFUzsKKyAgICB3ZWJWaWV3LmNvbmZpZ3VyYXRpb24ucHJlZmVyZW5jZXMuX3Nob3Vs ZElnbm9yZU1ldGFWaWV3cG9ydCA9IHRlc3Qub3B0aW9ucygpLnNob3VsZElnbm9yZU1ldGFWaWV3 cG9ydDsKIAogICAgIENHUmVjdCBzY3JlZW5Cb3VuZHMgPSBbVUlTY3JlZW4gbWFpblNjcmVlbl0u Ym91bmRzOwogICAgIENHU2l6ZSBvbGRTaXplID0gd2ViVmlldy5ib3VuZHMuc2l6ZTsK