195344 2019-03-05 15:32:30 -0800 Fix WKPasswordView compilation on iOS 2019-03-06 10:14:28 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino aestes benjamin cdumez cmarcelo dbates ews-watchlist oldest_to_newest 1512868 0 dino 2019-03-05 15:32:30 -0800 Add a platform define for UIColor system colors 1512905 1 363708 dino 2019-03-05 16:42:14 -0800 Created attachment 363708 Patch 1512906 2 dino 2019-03-05 16:42:37 -0800 <rdar://problem/48620066> 1512913 3 363710 dino 2019-03-05 17:12:36 -0800 Created attachment 363710 Patch 1512948 4 363710 dbates 2019-03-05 19:09:15 -0800 Comment on attachment 363710 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363710&action=review > Source/WebKit/UIProcess/ios/WKPasswordView.mm:110 > [_scrollView setBackgroundColor:[UIColor groupTableViewBackgroundColor]]; Ok as is, but if you want to be a nice guy you could fix up this line up for all Apple Engineers (including me!). Search radars on Andy Estes whose title contains groupTableView.... or poke Andy with a stick (I tried but it wasn’t sharp enough ;)) 1512949 5 363710 dbates 2019-03-05 19:10:48 -0800 Comment on attachment 363710 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363710&action=review >> Source/WebKit/UIProcess/ios/WKPasswordView.mm:110 >> [_scrollView setBackgroundColor:[UIColor groupTableViewBackgroundColor]]; > > Ok as is, but if you want to be a nice guy you could fix up this line up for all Apple Engineers (including me!). Search radars on Andy Estes whose title contains groupTableView.... or poke Andy with a stick (I tried but it wasn’t sharp enough ;)) Actually, depending on when SYSTEM COLORS is enabled you may have worked around the issue I am referring too at least for this callsite.... still applicable To othe call sites. 1512951 6 dbates 2019-03-05 19:11:56 -0800 Digital poking (CC) Andy 1513067 7 dino 2019-03-06 10:14:28 -0800 Committed r242552: <https://trac.webkit.org/changeset/242552> 363708 2019-03-05 16:42:14 -0800 2019-03-05 17:12:32 -0800 Patch bug-195344-20190306114212.patch text/plain 2774 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDFhOWIxOWQ3MTE5NWVhNmI2YTA1Y2Zh Njg3MjEyMjQ1ZGY3Y2U5NDAuLmNlYjMyMjU1ZmMwYTQ0NGE3ZGZjNjVlYjQzYjA3ODZiYzlkZmE3 MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDMtMDUgIERlYW4gSmFja3NvbiAgPGRpbm9A YXBwbGUuY29tPgorCisgICAgICAgIEFkZCBhIHBsYXRmb3JtIGRlZmluZSBmb3IgVUlDb2xvciBz eXN0ZW0gY29sb3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTUzNDQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ4NjIwMDY2PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGZsYWcgZm9yIG1v cmUgYWNjdXJhdGUgc3lzdGVtIGNvbG9ycyBpZiB0aGV5IGFyZSBhdmFpbGFibGUuCisKKyAgICAg ICAgKiB3dGYvUGxhdGZvcm0uaDogQWRkIFVTRV9TWVNURU1fVUlDT0xPUlMuCisKIDIwMTktMDIt MjggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIFdlYWtI YXNoU2V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCmluZGV4IDQ1NDQ4MTQ1NmVlYzNiYzVjMDEwOWMzNjBkNTBkY2Q5YjVjMDgx M2UuLjgyNTM2ZDNhMzlmZWRhNzFlZTYyOWQ4MmJiM2Q1ZjMxZjI3ZmViZWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTktMDMtMDUgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29t PgorCisgICAgICAgIEFkZCBhIHBsYXRmb3JtIGRlZmluZSBmb3IgVUlDb2xvciBzeXN0ZW0gY29s b3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTUz NDQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ4NjIwMDY2PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBhIGRpZmZlcmVudCBBUEkgaWYgVVNF X1NZU1RFTV9VSUNPTE9SUyBpcyB0cnVlLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS1Bh c3N3b3JkVmlldy5tbToKKyAgICAgICAgKC1bV0tQYXNzd29yZFZpZXcgc2hvd0luU2Nyb2xsVmll dzpdKToKKwogMjAxOS0wMy0wNCAgVHJ1aXR0IFNhdmVsbCAgPHRzYXZlbGxAYXBwbGUuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNDIyMjIuCmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRl eCA5NDAzN2NlOGUyOTMwOGFiMmRiOTY3MmQ0MmUzYmQzNTlkNDY2MWQwLi44NDRlMTdlMDM2MGRk MDA0YzAzYjZjNmE2YTI5MjYxYzQ3MzhlYzYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Q bGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTE1MDUsNiArMTUw NSwxMCBAQAogI2RlZmluZSBIQVZFX0NTQ0hFQ0tGSVhESVNBQkxFIDEKICNlbmRpZgogCisjaWYg KFBMQVRGT1JNKElPU19GQU1JTFkpICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVE ID49IDEzMDAwMCkKKyNkZWZpbmUgVVNFX1NZU1RFTV9VSUNPTE9SUyAxCisjZW5kaWYKKwogI2lm IFBMQVRGT1JNKE1BQykKICNkZWZpbmUgRU5BQkxFX01PTk9TUEFDRV9GT05UX0VYQ0VQVElPTiAo X19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEwMTUwMCkKICNlbGlmIFBMQVRGT1JN KElPU19GQU1JTFkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tQ YXNzd29yZFZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tQYXNzd29yZFZp ZXcubW0KaW5kZXggYzdiOWEyMmZhOGE1ZGQxMDAyYzNlNDExMTJkY2Y4ZGMyNzc0ZmNmOS4uMTk5 M2MyZmJhOWM3M2Q1YzcxODVjYTI2MzUwMTA2Mjk1NDQ1MjEyZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLUGFzc3dvcmRWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9XS1Bhc3N3b3JkVmlldy5tbQpAQCAtMTAwLDcgKzEwMCwxMiBAQCBj b25zdCBDR0Zsb2F0IHBhc3N3b3JkRW50cnlGaWVsZFBhZGRpbmcgPSAxMDsKICAgICBbX3Njcm9s bFZpZXcgc2V0TWF4aW11bVpvb21TY2FsZToxXTsKICAgICBbX3Njcm9sbFZpZXcgc2V0Wm9vbVNj YWxlOjFdOwogICAgIFtfc2Nyb2xsVmlldyBzZXRDb250ZW50U2l6ZTpzZWxmLmZyYW1lLnNpemVd OworI2lmIFVTRShTWVNURU1fVUlDT0xPUlMpCisgICAgaWYgKFtVSUNvbG9yIHJlc3BvbmRzVG9T ZWxlY3RvcjpAc2VsZWN0b3Ioc3lzdGVtR3JvdXBlZEJhY2tncm91bmRDb2xvcildKQorICAgICAg ICBbX3Njcm9sbFZpZXcgc2V0QmFja2dyb3VuZENvbG9yOltVSUNvbG9yIHN5c3RlbUdyb3VwZWRC YWNrZ3JvdW5kQ29sb3JdXTsKKyNlbHNlCiAgICAgW19zY3JvbGxWaWV3IHNldEJhY2tncm91bmRD b2xvcjpbVUlDb2xvciBncm91cFRhYmxlVmlld0JhY2tncm91bmRDb2xvcl1dOworI2VuZGlmCiAK ICAgICBbc2Nyb2xsVmlldyBhZGRTdWJ2aWV3OnNlbGZdOwogfQo= 363710 2019-03-05 17:12:36 -0800 2019-03-05 19:10:48 -0800 Patch bug-195344-20190306121234.patch text/plain 1752 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ1NDQ4MTQ1NmVlYzNiYzVj MDEwOWMzNjBkNTBkY2Q5YjVjMDgxM2UuLmVlY2RiNTQ5YWMxOGNmMjRmNWNkY2IwZDVlNTQyM2Jh ZWMyMDg0MDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDMtMDUgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFVzZSBhIHBsYXRmb3JtIGRlZmluZSBm b3IgVUlDb2xvciBzeXN0ZW0gY29sb3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTUzNDQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ4NjIwMDY2 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBh IGRpZmZlcmVudCBBUEkgaWYgVVNFX1NZU1RFTV9VSUNPTE9SUyBpcyB0cnVlLgorCisgICAgICAg ICogVUlQcm9jZXNzL2lvcy9XS1Bhc3N3b3JkVmlldy5tbToKKyAgICAgICAgKC1bV0tQYXNzd29y ZFZpZXcgc2hvd0luU2Nyb2xsVmlldzpdKToKKwogMjAxOS0wMy0wNCAgVHJ1aXR0IFNhdmVsbCAg PHRzYXZlbGxAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIy NDIyMjIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tQYXNzd29y ZFZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tQYXNzd29yZFZpZXcubW0K aW5kZXggYzdiOWEyMmZhOGE1ZGQxMDAyYzNlNDExMTJkY2Y4ZGMyNzc0ZmNmOS4uY2JkYjU3MTBj ZGE4OTc2NGFkMDZhMDdhMTA0ZWQyZjc1YTFjYzlhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL1dLUGFzc3dvcmRWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2lvcy9XS1Bhc3N3b3JkVmlldy5tbQpAQCAtMzUsNiArMzUsMTAgQEAKICNpbXBvcnQg PHd0Zi9SZXRhaW5QdHIuaD4KICNpbXBvcnQgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCisjaWYg VVNFKFNZU1RFTV9VSUNPTE9SUykKKyNpbXBvcnQgPFdlYktpdEFkZGl0aW9ucy9VSUNvbG9yQWRk aXRpb25zLm1tPgorI2VuZGlmCisKIGNvbnN0IENHRmxvYXQgcGFzc3dvcmRFbnRyeUZpZWxkUGFk ZGluZyA9IDEwOwogCiBAaW50ZXJmYWNlIFdLUGFzc3dvcmRWaWV3ICgpIDxVSURvY3VtZW50UGFz c3dvcmRWaWV3RGVsZWdhdGU+CkBAIC0xMDAsNyArMTA0LDExIEBAIGNvbnN0IENHRmxvYXQgcGFz c3dvcmRFbnRyeUZpZWxkUGFkZGluZyA9IDEwOwogICAgIFtfc2Nyb2xsVmlldyBzZXRNYXhpbXVt Wm9vbVNjYWxlOjFdOwogICAgIFtfc2Nyb2xsVmlldyBzZXRab29tU2NhbGU6MV07CiAgICAgW19z Y3JvbGxWaWV3IHNldENvbnRlbnRTaXplOnNlbGYuZnJhbWUuc2l6ZV07CisjaWYgVVNFKFNZU1RF TV9VSUNPTE9SUykKKyAgICBbX3Njcm9sbFZpZXcgc2V0QmFja2dyb3VuZENvbG9yOnNjcm9sbFZp ZXdCYWNrZ3JvdW5kQ29sb3IoKV07CisjZWxzZQogICAgIFtfc2Nyb2xsVmlldyBzZXRCYWNrZ3Jv dW5kQ29sb3I6W1VJQ29sb3IgZ3JvdXBUYWJsZVZpZXdCYWNrZ3JvdW5kQ29sb3JdXTsKKyNlbmRp ZgogCiAgICAgW3Njcm9sbFZpZXcgYWRkU3VidmlldzpzZWxmXTsKIH0K