195306 2019-03-04 19:41:02 -0800 Web Inspector: Reload actions from second level inspector should properly reload the inspected inspector 2019-03-07 12:45:21 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker nvasilyev webkit-bug-importer oldest_to_newest 1512462 0 joepeck 2019-03-04 19:41:02 -0800 Reload actions from second level inspector should properly reload the inspected inspector Can't use PageAgent.reload, need to InspectorFrontendHost.reopen. 1512463 1 363583 joepeck 2019-03-04 19:42:03 -0800 Created attachment 363583 [PATCH] Proposed Fix 1512475 2 363583 mattbaker 2019-03-04 20:02:16 -0800 Comment on attachment 363583 [PATCH] Proposed Fix r=me 1512485 3 363583 commit-queue 2019-03-04 20:28:05 -0800 Comment on attachment 363583 [PATCH] Proposed Fix Clearing flags on attachment: 363583 Committed r242410: <https://trac.webkit.org/changeset/242410> 1512486 4 commit-queue 2019-03-04 20:28:06 -0800 All reviewed patches have been landed. Closing bug. 1512488 5 webkit-bug-importer 2019-03-04 20:29:18 -0800 <rdar://problem/48588528> 1513245 6 nvasilyev 2019-03-06 15:59:39 -0800 Now there's no way to reload Web Inspector so it picks up changes from the filesystem. With this patch, pressing Command-R in 2nd level inspector doesn't pick up changes from the FS. "Reload Inspector" context menu stopped doing it a few months ago. 😭 1513387 7 joepeck 2019-03-06 21:02:12 -0800 (In reply to Nikita Vasilyev from comment #6) > Now there's no way to reload Web Inspector so it picks up changes from the > filesystem. > > With this patch, pressing Command-R in 2nd level inspector doesn't pick up > changes from the FS. > > "Reload Inspector" context menu stopped doing it a few months ago. > > 😭 Reloading from the file system never actually worked properly =(. It may have been a quick hack usable for development but it never re-initialized things properly. If we want to add something like that back we should make sure it works properly. 1513649 8 nvasilyev 2019-03-07 12:45:21 -0800 (In reply to Joseph Pecoraro from comment #7) > (In reply to Nikita Vasilyev from comment #6) > > Now there's no way to reload Web Inspector so it picks up changes from the > > filesystem. > > > > With this patch, pressing Command-R in 2nd level inspector doesn't pick up > > changes from the FS. > > > > "Reload Inspector" context menu stopped doing it a few months ago. > > > > 😭 > > Reloading from the file system never actually worked properly =(. It may > have been a quick hack usable for development but it never re-initialized > things properly. If we want to add something like that back we should make > sure it works properly. What do you mean by properly? I used it for development hundreds of times a day and now I can't. How often do you need to reload 1st level Inspector from the 2nd level Inspector but not load the latest files from the filesystem? This actually reads changes from the FS: WI._reloadInspectedInspector = function() { PageAgent.reload.invoke({ignoreCache: true}, function() { const options = {}; WI.runtimeManager.evaluateInInspectedWindow(`InspectorFrontendHost.reopen()`, options, function(){}); }); }; It reloads Inspector twice, essentially, but it actually works. 363583 2019-03-04 19:42:03 -0800 2019-03-04 20:28:05 -0800 [PATCH] Proposed Fix i2.patch text/plain 3504 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRkNjYyYmI1ZDY4Li5iODA5ODNhYjNjNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDMtMDQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBSZWxvYWQgYWN0aW9ucyBmcm9tIHNlY29uZCBsZXZlbCBpbnNwZWN0b3Igc2hvdWxkIHByb3Bl cmx5IHJlbG9hZCB0aGUgaW5zcGVjdGVkIGluc3BlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1MzA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qczoK KyAgICAgICAgUHJvdmlkZSBhIGJldHRlciByZWxvYWQgZm9yIGEgTnRoIGxldmVsIGluc3BlY3Rv ci4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvRGVidWcvQm9vdHN0cmFwLmpzOgorICAgICAg ICAoV0kucnVuQm9vdHN0cmFwT3BlcmF0aW9ucyk6CisgICAgICAgIFNpbXBsaWZ5LCBzaG91bGQg bm90IG5lZWQgdG8gY2hlY2sgZm9yIEluc3BlY3RvckZyb250ZW5kSG9zdC4KKwogMjAxOS0wMy0w MSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IENQVSBVc2FnZSBUaW1lbGluZSAtIFN0YXRpc3RpY3MgYW5kIFNvdXJjZXMgc2Vj dGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jh c2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFp bi5qcwppbmRleCBiN2JjOWVkZWM0OS4uNWNmYzM2NzQwMmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKQEAgLTIyNjAsMzAgKzIyNjAs NTMgQEAgV0kuX2Rvd25sb2FkV2ViQXJjaGl2ZSA9IGZ1bmN0aW9uKGV2ZW50KQogICAgIHRoaXMu YXJjaGl2ZU1haW5GcmFtZSgpOwogfTsKIAorV0kuX3JlbG9hZEluc3BlY3RlZEluc3BlY3RvciA9 IGZ1bmN0aW9uKCkKK3sKKyAgICBjb25zdCBvcHRpb25zID0ge307CisgICAgV0kucnVudGltZU1h bmFnZXIuZXZhbHVhdGVJbkluc3BlY3RlZFdpbmRvdyhgSW5zcGVjdG9yRnJvbnRlbmRIb3N0LnJl b3BlbigpYCwgb3B0aW9ucywgZnVuY3Rpb24oKXt9KTsKK307CisKIFdJLl9yZWxvYWRQYWdlID0g ZnVuY3Rpb24oZXZlbnQpCiB7CiAgICAgaWYgKCF3aW5kb3cuUGFnZUFnZW50KQogICAgICAgICBy ZXR1cm47CiAKKyAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOworCisgICAgaWYgKEluc3BlY3Rv ckZyb250ZW5kSG9zdC5pbnNwZWN0aW9uTGV2ZWwoKSA+IDEpIHsKKyAgICAgICAgV0kuX3JlbG9h ZEluc3BlY3RlZEluc3BlY3RvcigpOworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgUGFn ZUFnZW50LnJlbG9hZCgpOworfTsKKworV0kuX3JlbG9hZFBhZ2VGcm9tT3JpZ2luID0gZnVuY3Rp b24oZXZlbnQpCit7CisgICAgaWYgKCF3aW5kb3cuUGFnZUFnZW50KQorICAgICAgICByZXR1cm47 CisKICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOworCisgICAgaWYgKEluc3BlY3RvckZyb250 ZW5kSG9zdC5pbnNwZWN0aW9uTGV2ZWwoKSA+IDEpIHsKKyAgICAgICAgV0kuX3JlbG9hZEluc3Bl Y3RlZEluc3BlY3RvcigpOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgUGFnZUFnZW50 LnJlbG9hZC5pbnZva2Uoe2lnbm9yZUNhY2hlOiB0cnVlfSk7CiB9OwogCiBXSS5fcmVsb2FkVG9v bGJhckJ1dHRvbkNsaWNrZWQgPSBmdW5jdGlvbihldmVudCkKIHsKKyAgICBpZiAoSW5zcGVjdG9y RnJvbnRlbmRIb3N0Lmluc3BlY3Rpb25MZXZlbCgpID4gMSkgeworICAgICAgICBXSS5fcmVsb2Fk SW5zcGVjdGVkSW5zcGVjdG9yKCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICAvLyBS ZWxvYWQgcGFnZSBmcm9tIG9yaWdpbiBpZiB0aGUgYnV0dG9uIGlzIGNsaWNrZWQgd2hpbGUgdGhl IHNoaWZ0IGtleSBpcyBwcmVzc2VkIGRvd24uCiAgICAgUGFnZUFnZW50LnJlbG9hZC5pbnZva2Uo e2lnbm9yZUNhY2hlOiB0aGlzLm1vZGlmaWVyS2V5cy5zaGlmdEtleX0pOwogfTsKIAotV0kuX3Jl bG9hZFBhZ2VGcm9tT3JpZ2luID0gZnVuY3Rpb24oZXZlbnQpCi17Ci0gICAgaWYgKCF3aW5kb3cu UGFnZUFnZW50KQotICAgICAgICByZXR1cm47Ci0KLSAgICBQYWdlQWdlbnQucmVsb2FkLmludm9r ZSh7aWdub3JlQ2FjaGU6IHRydWV9KTsKLSAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOwotfTsK LQogV0kuX3VwZGF0ZVJlbG9hZFRvb2xiYXJCdXR0b24gPSBmdW5jdGlvbigpCiB7CiAgICAgaWYg KCF3aW5kb3cuUGFnZUFnZW50KSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9EZWJ1Zy9Cb290c3RyYXAuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9EZWJ1Zy9Cb290c3RyYXAuanMKaW5kZXggZmQxNjc4ODA0ZGMuLjBlYzM0 ZGYzNGI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9E ZWJ1Zy9Cb290c3RyYXAuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvRGVidWcvQm9vdHN0cmFwLmpzCkBAIC0xMDMsNyArMTAzLDcgQEAgV0kucnVuQm9vdHN0cmFw T3BlcmF0aW9ucyA9IGZ1bmN0aW9uKCkgewogICAgIGFwcGx5RHVtcE1lc3NhZ2VzU3RhdGUoZHVt cE1lc3NhZ2VzQ3VycmVudFN0YXRlKCkpOwogCiAgICAgLy8gTmV4dCBMZXZlbCBJbnNwZWN0b3Iu Ci0gICAgbGV0IGluc3BlY3Rpb25MZXZlbCA9IEluc3BlY3RvckZyb250ZW5kSG9zdCA/IEluc3Bl Y3RvckZyb250ZW5kSG9zdC5pbnNwZWN0aW9uTGV2ZWwoKSA6IDE7CisgICAgbGV0IGluc3BlY3Rp b25MZXZlbCA9IEluc3BlY3RvckZyb250ZW5kSG9zdC5pbnNwZWN0aW9uTGV2ZWwoKTsKICAgICBj b25zdCBpbnNwZWN0SW5zcGVjdG9yVG9vbFRpcCA9IFdJLnVubG9jYWxpemVkU3RyaW5nKCJPcGVu IFdlYiBJbnNwZWN0b3IgWyVkXSIpLmZvcm1hdChpbnNwZWN0aW9uTGV2ZWwgKyAxKTsKICAgICBs ZXQgaW5zcGVjdEluc3BlY3RvclRvb2xiYXJJdGVtID0gbmV3IFdJLkJ1dHRvblRvb2xiYXJJdGVt KCJpbnNwZWN0LWluc3BlY3RvciIsIGluc3BlY3RJbnNwZWN0b3JUb29sVGlwKTsKICAgICBXSS50 b29sYmFyLmFkZFRvb2xiYXJJdGVtKGluc3BlY3RJbnNwZWN0b3JUb29sYmFySXRlbSwgV0kuVG9v bGJhci5TZWN0aW9uLkNlbnRlclJpZ2h0KTsK